Re: [PATCH] xfree86: loader: Remove redundant debug command in loader.c.

2010-10-01 Thread ja...@minilop.net
Another place where I don't know the code, but the patch sure looks like a good idea. Reviewed-by: Jamey Sharp On Fri, Oct 1, 2010 at 7:06 PM, Jesse Adkins wrote: > Signed-off-by: Jesse Adkins > --- >  hw/xfree86/loader/loader.c |    4 >  1 files changed, 0 insertions(+), 4 deletions(-) >

[PATCH] xfree86: loader: Remove redundant debug command in loader.c.

2010-10-01 Thread Jesse Adkins
Signed-off-by: Jesse Adkins --- hw/xfree86/loader/loader.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/hw/xfree86/loader/loader.c b/hw/xfree86/loader/loader.c index 8921831..39e0e75 100644 --- a/hw/xfree86/loader/loader.c +++ b/hw/xfree86/loader/loader.c @@ -143,10

[PATCH modular] Catch bad command-line arguments.

2010-10-01 Thread Trevor Woerner
From: Trevor Woerner If the user specifies unknown, misspelled, or too many cmdline arguments make sure to catch them and generate an error. Signed-off-by: Trevor Woerner --- NOTE: this patch to be applied after the 10 I sent yesterday! build.sh |9 + 1 files changed, 9 insertion

Re: [PATCH v3 1/2] dix: Add facilities for client ID tracking.

2010-10-01 Thread Jesse Adkins
> +AC_ARG_ENABLE(clientids,      AS_HELP_STRING([--disable-clientids], [Build > Xorg with client ID tracking (default: enabled)]), [CLIENTIDS=$enableval], > [CLIENTIDS=yes]) Shouldn't that be --enable-clientids instead of --disable-clientids? ___ xorg-

[PATCH] test: Fix make distcheck when not building unit tests

2010-10-01 Thread Jeremy Huddleston
Signed-off-by: Jeremy Huddleston --- test/Makefile.am |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/test/Makefile.am b/test/Makefile.am index 7c44671..456221e 100644 --- a/test/Makefile.am +++ b/test/Makefile.am @@ -33,10 +33,9 @@ libxservertest_la_LIBADD = \

xserver make distdir fails without doxygen because of hw/dmx/doc

2010-10-01 Thread Jeremy Huddleston
make[3]: *** No rule to make target `dmx.txt', needed by `distdir'. Stop. make[2]: *** [distdir] Error 1 make[1]: *** [distdir] Error 1 make: *** [distdir] Error 1 Do we really want to ship all of the generated documentation in hw/dmx/doc? Is this the case in other modules, or is this an except

Re: [PATCH modular 05/10] Add preconditions.

2010-10-01 Thread Gaetan Nadon
On Thu, 2010-09-30 at 17:27 -0400, Trevor Woerner wrote: > From: Trevor Woerner > > Provide preconditions for some of the functions in build.sh script. > > Signed-off-by: Trevor Woerner > --- > build.sh | 12 > 1 files changed, 12 insertions(+), 0 deletions(-) > For the rema

Re: [PATCH modular 04/10] Document functions in build.sh.

2010-10-01 Thread Gaetan Nadon
On Thu, 2010-09-30 at 17:27 -0400, Trevor Woerner wrote: > From: Trevor Woerner > > Provide explanations of functioning and behaviour for some of the > functions > in build.sh script. > > Signed-off-by: Trevor Woerner > --- > build.sh | 31 +++ > 1 files changed,

Re: [PATCH modular 03b/10] Centralize NOQUIT build mode.

2010-10-01 Thread Gaetan Nadon
On Thu, 2010-09-30 at 22:45 -0400, Trevor Woerner wrote: > From: Trevor Woerner > > Put all the logic to handle the NOQUIT (-n) mode into one location. > > Signed-off-by: Trevor Woerner > --- > build.sh | 97 > + > 1 files changed,

Re: [PATCH modular 03a/10] Centralize build mode logic.

2010-10-01 Thread Gaetan Nadon
On Thu, 2010-09-30 at 22:44 -0400, Trevor Woerner wrote: > From: Trevor Woerner > > Place into one location the logic to decide what to do with regards to > the following build modes: LISTONLY, RESUME, and BUILD_ONE. > > Signed-off-by: Trevor Woerner > --- > build.sh | 66 >

Re: [PATCH ati] Remove reference to pixmapPrivate.

2010-10-01 Thread Keith Packard
On Fri, 01 Oct 2010 12:11:49 -0400, Gaetan Nadon wrote: > Just a reminder for those reading this thread. > > Should that information (the oldest server a driver wishes to support) > become available, > it should be coded in configure.ac: > > PKG_CHECK_MODULES(XORG, [xorg-server >= 1.0.9

Re: [PATCH ati] Remove reference to pixmapPrivate.

2010-10-01 Thread Michel Dänzer
On Fre, 2010-10-01 at 18:57 +0200, Julien Cristau wrote: > On Fri, Oct 1, 2010 at 18:29:54 +0200, Michel Dänzer wrote: > > > On Fre, 2010-10-01 at 18:27 +0200, Julien Cristau wrote: > > > #if ABI_VIDEODRV_VERSION < SET_ABI_VERSION(9, 0) > > > old code > > > #else > > > new code > > > #endif > >

Re: [PATCH ati] Remove reference to pixmapPrivate.

2010-10-01 Thread Julien Cristau
On Fri, Oct 1, 2010 at 13:14:51 -0400, Trevor Woerner wrote: > Irregardless of which solution is chosen, if someone wanted to compile > a driver for an older server, they'd still have to checkout an older > version of the server code to compile against. Wouldn't they? What are > the chances a new

Re: [PATCH ati] Remove reference to pixmapPrivate.

2010-10-01 Thread Trevor Woerner
2010/10/1 Julien Cristau : > On Fri, Oct  1, 2010 at 18:29:54 +0200, Michel Dänzer wrote: > >> On Fre, 2010-10-01 at 18:27 +0200, Julien Cristau wrote: >> > #if ABI_VIDEODRV_VERSION < SET_ABI_VERSION(9, 0) >> > old code >> > #else >> > new code >> > #endif >> >> That would work perfectly, if the AB

Re: [PATCH ati] Remove reference to pixmapPrivate.

2010-10-01 Thread Julien Cristau
On Fri, Oct 1, 2010 at 18:29:54 +0200, Michel Dänzer wrote: > On Fre, 2010-10-01 at 18:27 +0200, Julien Cristau wrote: > > #if ABI_VIDEODRV_VERSION < SET_ABI_VERSION(9, 0) > > old code > > #else > > new code > > #endif > > That would work perfectly, if the ABI was bumped by every change which >

Re: [PATCH ati] Remove reference to pixmapPrivate.

2010-10-01 Thread Michel Dänzer
On Fre, 2010-10-01 at 18:27 +0200, Julien Cristau wrote: > On Fri, Oct 1, 2010 at 12:16:55 -0400, Trevor Woerner wrote: > > > On Fri, Oct 1, 2010 at 11:37 AM, Mark Kettenis > > wrote: > > > Also, drivers are supposed to work with some older servers as well, at > > > least some of them. So eve

Re: [PATCH ati] Remove reference to pixmapPrivate.

2010-10-01 Thread Julien Cristau
On Fri, Oct 1, 2010 at 12:16:55 -0400, Trevor Woerner wrote: > On Fri, Oct 1, 2010 at 11:37 AM, Mark Kettenis > wrote: > > Also, drivers are supposed to work with some older servers as well, at > > least some of them.  So even if removing that line for the current > > server is OK, it probably

Re: [PATCH ati] Remove reference to pixmapPrivate.

2010-10-01 Thread Michel Dänzer
On Fre, 2010-10-01 at 12:11 -0400, Gaetan Nadon wrote: > > On Fri, 2010-10-01 at 17:37 +0200, Mark Kettenis wrote: > > > Also, drivers are supposed to work with some older servers as well, > at > > least some of them. So even if removing that line for the current > > server is OK, it probably i

Re: [PATCH ati] Remove reference to pixmapPrivate.

2010-10-01 Thread Trevor Woerner
On Fri, Oct 1, 2010 at 11:37 AM, Mark Kettenis wrote: > Also, drivers are supposed to work with some older servers as well, at > least some of them.  So even if removing that line for the current > server is OK, it probably isn't for older servers. What's the trick for compiling future drivers fo

Re: [PATCH ati] Remove reference to pixmapPrivate.

2010-10-01 Thread Gaetan Nadon
On Fri, 2010-10-01 at 17:37 +0200, Mark Kettenis wrote: > Also, drivers are supposed to work with some older servers as well, at > least some of them. So even if removing that line for the current > server is OK, it probably isn't for older servers. Just a reminder for those reading this thread

Re: [PATCH ati] Remove reference to pixmapPrivate.

2010-10-01 Thread Mark Kettenis
> From: Michel =?ISO-8859-1?Q?D=E4nzer?= > Date: Fri, 01 Oct 2010 17:18:05 +0200 > > On Fre, 2010-10-01 at 08:07 -0400, Trevor Woerner wrote: > > From: Trevor Woerner > > > > Signed-off-by: Trevor Woerner > > --- > > src/drmmode_display.c |1 - > > 1 files changed, 0 insertions(+), 1 del

Re: [PATCH ati] Remove reference to pixmapPrivate.

2010-10-01 Thread Michel Dänzer
On Fre, 2010-10-01 at 08:07 -0400, Trevor Woerner wrote: > From: Trevor Woerner > > Signed-off-by: Trevor Woerner > --- > src/drmmode_display.c |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/src/drmmode_display.c b/src/drmmode_display.c > index a6038b2..57a8ec6

[PATCH v3 0/2] xserver: Client ID tracking

2010-10-01 Thread Rami Ylimäki
Fixes based on comments of various reviewers. v2 -- Mark Kettenis: move /proc specific code into os treat pid -1 as error instead of 0 Tiago Vignatti: preserve copyrights amend authorship add description of the framework use doxygen style rename cmd -> cmdline in Client

[PATCH v3 2/2] Xext: Use general OS functions to determine client command string in SELinux.

2010-10-01 Thread Rami Ylimäki
SELinux could be also modified to take advantage of client ID tracking but we don't introduce that dependency here. People interested in SELinux are free to add that dependency later. Signed-off-by: Rami Ylimäki --- Xext/xselinux_hooks.c | 22 +- 1 files changed, 5 insertio

[PATCH v3 1/2] dix: Add facilities for client ID tracking.

2010-10-01 Thread Rami Ylimäki
An interface is provided for figuring out the PID and process name of a client. Make some existing functionality from SELinux and IA extensions available for general use. Signed-off-by: Rami Ylimäki --- configure.ac | 15 ++- dix/Makefile.am |1 + dix/client.c

Re: [DOC] Re: java OutOfMemory building documentation

2010-10-01 Thread Alan Coopersmith
Dan Nicholson wrote: > On Thu, Sep 30, 2010 at 6:56 PM, Jeremy Huddleston wrote: >> Also of note... My G5 took an hour and a half just to 'make install' with >> these changes. It looks like it's redoing some things in 'make install' >> that it already did in 'make': >> >> http://tinderbox.x.org/b

patch:libXt-1.0.8 fix possible NULL access

2010-10-01 Thread walter harms
Hi List, while testing a static checker, i got warnings about a possible NULL access. looking into the code i found that GetClassActions() may return NULL causing table->signature to ask for trouble. re, wh Honor that GetClassActions() may return NULL. Signed-off-by: Walter --- libXt-1.0.8

Re: [DOC] Re: java OutOfMemory building documentation

2010-10-01 Thread Dan Nicholson
On Thu, Sep 30, 2010 at 6:56 PM, Jeremy Huddleston wrote: > Also of note... My G5 took an hour and a half just to 'make install' with > these changes.  It looks like it's redoing some things in 'make install' > that it already did in 'make': > > http://tinderbox.x.org/builds/2010-09-30-0022/ One

[PATCH siliconmotion] Remove reference to pixmapPrivate.

2010-10-01 Thread Trevor Woerner
From: Trevor Woerner Signed-off-by: Trevor Woerner --- src/smi_crtc.c |5 - src/smi_driver.c |1 - 2 files changed, 0 insertions(+), 6 deletions(-) diff --git a/src/smi_crtc.c b/src/smi_crtc.c index bccf9b2..36bd085 100644 --- a/src/smi_crtc.c +++ b/src/smi_crtc.c @@ -210,11 +210

[PATCH mach64] Remove reference to pixmapPrivate.

2010-10-01 Thread Trevor Woerner
From: Trevor Woerner Signed-off-by: Trevor Woerner --- src/aticonsole.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/src/aticonsole.c b/src/aticonsole.c index 1be147e..902e260 100644 --- a/src/aticonsole.c +++ b/src/aticonsole.c @@ -715,8 +715,6 @@ ATIEnterVT

[PATCH ati] Remove reference to pixmapPrivate.

2010-10-01 Thread Trevor Woerner
From: Trevor Woerner Signed-off-by: Trevor Woerner --- src/drmmode_display.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/src/drmmode_display.c b/src/drmmode_display.c index a6038b2..57a8ec6 100644 --- a/src/drmmode_display.c +++ b/src/drmmode_display.c @@ -1145,7 +1

[PATCH geode] Remove reference to pixmapPrivate.

2010-10-01 Thread Trevor Woerner
From: Trevor Woerner Signed-off-by: Trevor Woerner --- src/gx_randr.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/gx_randr.c b/src/gx_randr.c index 1593c97..2deac14 100644 --- a/src/gx_randr.c +++ b/src/gx_randr.c @@ -218,8 +218,6 @@ GXRandRSetMode(ScreenPtr pS

Re: Build error: pixmapPrivate

2010-10-01 Thread Trevor Woerner
The information in bug report 30451 [https://bugs.freedesktop.org/show_bug.cgi?id=30451] seems to suggest simply removing any references to pixmapPrivate in the code is enough. Can anyone confirm that? I can provide patch attempts, but have no way of testing them. _

(RFC) siliconmotion: Offscreen Pixmaps not properly initialized?

2010-10-01 Thread Marc Scherer
We have a MPC5200 PowerPC @ 400 MHz with a SM501 (TQM5200 board). With XAA enabled, the xf86-video-siliconmotion works nicely except for screen-to-screen-copies (?). The symptom is that x11perf -copywinpix100 x11perf -copypixwin100 are 10x slower than with the following hack: smi_xaa.c, SMI_XAA