Re: [PATCH 2/2 xload] Fix old-style function definitions on Cygwin

2010-10-04 Thread Alan Coopersmith
Yaakov (Cygwin/X) wrote: > From: Yaakov Selkowitz > > get_load.c: In function ‘InitLoadPoint’: > get_load.c:74:6: warning: old-style function definition > get_load.c: In function ‘GetLoadPoint’: > get_load.c:92:6: warning: old-style function definition > > Signed-off-by: Yaakov Selkowitz > ---

Re: [PATCH] test: fix event conversion test after de8be07cc0a81

2010-10-04 Thread Robert Hooker
On Tue, Oct 5, 2010 at 12:18 AM, Peter Hutterer wrote: > commit de8be07cc0a8163b6ef04455706fd5ca2cebe587 > Author: Peter Hutterer > Date:   Tue Aug 17 12:08:52 2010 +1000 > >    dix: don't create core motion events for non-x/y valuators. > > introduces a change in the event generation. the x/y va

[PATCH 2/2 xload] Fix old-style function definitions on Cygwin

2010-10-04 Thread Yaakov (Cygwin/X)
From: Yaakov Selkowitz get_load.c: In function ‘InitLoadPoint’: get_load.c:74:6: warning: old-style function definition get_load.c: In function ‘GetLoadPoint’: get_load.c:92:6: warning: old-style function definition Signed-off-by: Yaakov Selkowitz --- get_load.c | 10 +- 1 files chan

[PATCH 1/2 xload] Avoid excess Win32 includes on Cygwin

2010-10-04 Thread Yaakov (Cygwin/X)
From: Yaakov Selkowitz Fixes compilation errors due to recent w32api , which is not needed to compile xload. Signed-off-by: Yaakov Selkowitz --- get_load.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/get_load.c b/get_load.c index 1439090..551a7a8 100644 --- a/get_l

[PATCH 0/2 xload] Cygwin compile fixes

2010-10-04 Thread Yaakov (Cygwin/X)
From: Yaakov Selkowitz Yaakov Selkowitz (2): Avoid excess Win32 includes on Cygwin Fix old-style function definitions on Cygwin get_load.c | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) ___ xorg-devel@lists.x.org: X.Org deve

Re: [PATCH synaptic 0/2] config: don't mess with hotplug device assignment

2010-10-04 Thread Peter Hutterer
On Sun, Sep 19, 2010 at 09:49:57AM +0200, Giuseppe Bilotta wrote: > The following two patches make sure that during hotplug the driver will > (try to) manage the device it's being assigned, and not what it gets to > guess from autoprobe. > > The second one in particular (which depends on the first

[PATCH] test: fix event conversion test after de8be07cc0a81

2010-10-04 Thread Peter Hutterer
commit de8be07cc0a8163b6ef04455706fd5ca2cebe587 Author: Peter Hutterer Date: Tue Aug 17 12:08:52 2010 +1000 dix: don't create core motion events for non-x/y valuators. introduces a change in the event generation. the x/y valuator mask bits must be set for a core event to be generated. This

Re: [PATCH modular 2/3] Fix spelling.

2010-10-04 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Trevor Woerner wrote: > On Mon, Oct 4, 2010 at 6:39 PM, Ian Romanick wrote: >>> From: Trevor Woerner >>> build_driver_input() { >>> -# Some drivers are only buildable on some OS'es >>> +# Some drivers can only be processed on some OS'es >> "

Re: [PATCH modular 2/3] Fix spelling.

2010-10-04 Thread Trevor Woerner
On Mon, Oct 4, 2010 at 6:39 PM, Ian Romanick wrote: >> From: Trevor Woerner >>  build_driver_input() { >> -    # Some drivers are only buildable on some OS'es >> +    # Some drivers can only be processed on some OS'es > > "can only be processed" is different from "are only buildable".  The > form

Re: [PATCH v3 1/2] dix: Add facilities for client ID tracking.

2010-10-04 Thread Alan Coopersmith
Jesse Adkins wrote: >> +AC_ARG_ENABLE(clientids, AS_HELP_STRING([--disable-clientids], [Build >> Xorg with client ID tracking (default: enabled)]), [CLIENTIDS=$enableval], >> [CLIENTIDS=yes]) > > Shouldn't that be --enable-clientids instead of --disable-clientids? I believe we normally lis

Re: [PATCH modular 2/3] Fix spelling.

2010-10-04 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Trevor Woerner wrote: > From: Trevor Woerner > > Signed-off-by: Trevor Woerner > --- > build.sh | 12 ++-- > 1 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/build.sh b/build.sh > index fb15cb1..33b416c 100755 > --- a/bu

Re: [PATCH modular 1/3] Sanity check required cmdline arguments.

2010-10-04 Thread Gaetan Nadon
On Mon, 2010-10-04 at 13:56 -0400, Trevor Woerner wrote: > From: Trevor Woerner > > If a command-line option has a required argument, verify such an > argument is supplied. Also, verify the argument doesn't look like > another option. > > Signed-off-by: Trevor Woerner > --- > build.sh | 38

Re: [PATCH 1/3] composite: Don't backfill non-bg-None windows

2010-10-04 Thread Adam Jackson
On Mon, 2010-10-04 at 13:13 -0700, Aaron Plattner wrote: > On Mon, Oct 04, 2010 at 12:33:40PM -0700, Adam Jackson wrote: > > @@ -487,7 +498,18 @@ compNewPixmap (WindowPtr pWin, int x, int y, int w, > > int h) > > > > pPixmap->screen_x = x; > > pPixmap->screen_y = y; > > - > > +

Re: [PATCH 1/3] composite: Don't backfill non-bg-None windows

2010-10-04 Thread Keith Packard
On Mon, 4 Oct 2010 15:33:40 -0400, Adam Jackson wrote: > If there's a defined background then backfilling is a waste of effort, > since exposure processing will paint that in for us. But note that we > have to backfill if any children are bg=None to preserve semantics with > non-composited serve

Re: [PATCH] modes: improve aspect ratio match for classic drivers

2010-10-04 Thread Alex Deucher
On Mon, Oct 4, 2010 at 3:59 PM, Adam Jackson wrote: > From: Olivier Fourdan > > After we infer the aspect ratio for the screen, we pick the largest > mode matching that aspect ratio from the best mode pool available. > We then clamp virtual size to that mode, and run the resulting mode > list thr

Re: [PATCH] ddc: Don't probe for DDC/CI or EEPROM

2010-10-04 Thread Alex Deucher
On Mon, Oct 4, 2010 at 3:43 PM, Adam Jackson wrote: > For whatever reason, some (broken) monitors will crash if you do this. > We're not actually using this information for anything, so let's just > not do it. > > Originally reported as http://bugzilla.redhat.com/620333 > > Signed-off-by: Adam Jac

Re: [PATCH 1/3] composite: Don't backfill non-bg-None windows

2010-10-04 Thread Aaron Plattner
On Mon, Oct 04, 2010 at 12:33:40PM -0700, Adam Jackson wrote: > If there's a defined background then backfilling is a waste of effort, > since exposure processing will paint that in for us. But note that we > have to backfill if any children are bg=None to preserve semantics with > non-composited

[PATCH] modes: improve aspect ratio match for classic drivers

2010-10-04 Thread Adam Jackson
From: Olivier Fourdan After we infer the aspect ratio for the screen, we pick the largest mode matching that aspect ratio from the best mode pool available. We then clamp virtual size to that mode, and run the resulting mode list through the driver's ValidMode hook. In doing so we might filter a

[PATCH] ddc: Don't probe for DDC/CI or EEPROM

2010-10-04 Thread Adam Jackson
For whatever reason, some (broken) monitors will crash if you do this. We're not actually using this information for anything, so let's just not do it. Originally reported as http://bugzilla.redhat.com/620333 Signed-off-by: Adam Jackson --- hw/xfree86/ddc/ddc.c |4 1 files changed, 0 i

[PATCH 3/3] composite: Move the backfill comment to a more appropriate indent level

2010-10-04 Thread Adam Jackson
Signed-off-by: Adam Jackson --- composite/compalloc.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/composite/compalloc.c b/composite/compalloc.c index 6bc3a54..144f6bc 100644 --- a/composite/compalloc.c +++ b/composite/compalloc.c @@ -514,14 +514,14 @@ compNewPi

[PATCH 0/3] composite backfill optimizations

2010-10-04 Thread Adam Jackson
Resend of a patch series from back in May. This version includes better comments, and accounts for the punch-through behaviour of bg=None windows when an entire stack is mapped at once. Lightly tested on Intel GM45 with gnome-shell. compalloc.c | 42 ++

[PATCH 2/3] composite: Don't backfill non-MapWindow allocations

2010-10-04 Thread Adam Jackson
Signed-off-by: Adam Jackson --- composite/compalloc.c | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/composite/compalloc.c b/composite/compalloc.c index 19f5896..6bc3a54 100644 --- a/composite/compalloc.c +++ b/composite/compalloc.c @@ -484,7 +484,7 @@ bgNoneVis

[PATCH 1/3] composite: Don't backfill non-bg-None windows

2010-10-04 Thread Adam Jackson
If there's a defined background then backfilling is a waste of effort, since exposure processing will paint that in for us. But note that we have to backfill if any children are bg=None to preserve semantics with non-composited servers. Signed-off-by: Adam Jackson --- composite/compalloc.c |

Re: [PATCH] xfree86: Do not call dlclose(NULL) [regression after ab7f057]

2010-10-04 Thread Keith Packard
On Sun, 3 Oct 2010 16:56:03 +0100, Chris Wilson wrote: > During unwind following an error when attempting to a load a module, we > attempt to call dlclose on a potentially NULL handle. This is a > side-effect of removing the abstraction layer in ab7f057. Applied. 533faf7..9a893fe master -

Re: [PATCH] xfree86: Do not call dlclose(NULL) [regression after ab7f057]

2010-10-04 Thread Adam Jackson
On Sun, 2010-10-03 at 16:56 +0100, Chris Wilson wrote: > During unwind following an error when attempting to a load a module, we > attempt to call dlclose on a potentially NULL handle. This is a > side-effect of removing the abstraction layer in ab7f057. > > Signed-off-by: Chris Wilson > Cc: Adam

Re: [PATCH modular 1/3] Sanity check required cmdline arguments.

2010-10-04 Thread Trevor Woerner
(this patch set is meant to be applied to the current master's HEAD, not on top of the 3 patches I just sent) ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-dev

Re: [PATCH ati] Remove reference to pixmapPrivate.

2010-10-04 Thread Keith Packard
On Sat, 2 Oct 2010 20:53:10 +0300, Adrian Bunk wrote: > So when there are 30 ABI-breaking commits between 1.9 and 1.10, > it should be required to bump the ABI 30 times? So far, the general plan has been to bump the ABI the first time a change occurs after a release and then not bump it again f

[PATCH modular 3/3] Better cmdline error parsing.

2010-10-04 Thread Trevor Woerner
From: Trevor Woerner If something appears to be wrong when parsing the command-line arguments provide better feedback to the user. Signed-off-by: Trevor Woerner --- build.sh |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/build.sh b/build.sh index 585ff9c..d9a2ae7

[PATCH modular 2/3] Add extra check for 'prefix'.

2010-10-04 Thread Trevor Woerner
From: Trevor Woerner Make sure not to mistake an unknown option for a missing 'prefix'. Signed-off-by: Trevor Woerner --- build.sh | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/build.sh b/build.sh index 93ad6e5..585ff9c 100755 --- a/build.sh +++ b/build.sh

[PATCH modular 1/3] Sanity check required cmdline arguments.

2010-10-04 Thread Trevor Woerner
From: Trevor Woerner If a command-line option has a required argument, verify such an argument is supplied. Also, verify the argument doesn't look like another option. Signed-off-by: Trevor Woerner --- build.sh | 38 ++ 1 files changed, 38 insertions(+), 0

Re: [PATCH modular 1/3] Process a user-supplied list of module/components.

2010-10-04 Thread Trevor Woerner
On Mon, Oct 4, 2010 at 12:17 PM, Gaetan Nadon wrote: > There may be some improvements to be done on the cmd line error > checking. Great idea. Patches to follow :-) ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg

Re: [PATCH modular 1/3] Process a user-supplied list of module/components.

2010-10-04 Thread Gaetan Nadon
On Mon, 2010-10-04 at 06:54 -0400, Trevor Woerner wrote: > From: Trevor Woerner > > New feature. Allow the user to supply, on the cmdline, a > space-separated list > of module/components to process, the script will process only those > listed > module/components. The list can be in any arbitrary

[PATCH modular 2/3] Fix spelling.

2010-10-04 Thread Trevor Woerner
From: Trevor Woerner Signed-off-by: Trevor Woerner --- build.sh | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/build.sh b/build.sh index fb15cb1..33b416c 100755 --- a/build.sh +++ b/build.sh @@ -67,7 +67,7 @@ failed_components="" nonexistent_components=""

[PATCH modular 1/3] Process a user-supplied list of module/components.

2010-10-04 Thread Trevor Woerner
From: Trevor Woerner New feature. Allow the user to supply, on the cmdline, a space-separated list of module/components to process, the script will process only those listed module/components. The list can be in any arbitrary order, the script takes care to process them in their correct, dependen

[PATCH modular 3/3] Enable progress on git clone.

2010-10-04 Thread Trevor Woerner
From: Trevor Woerner If redirecting output to a log file, "git clone" will be quiet. It's preferable to force it to not be quiet so the build doesn't look stuck. This introduces no change if not redirecting. Signed-off-by: Trevor Woerner --- build.sh |2 +- 1 files changed, 1 insertions(+

Re: [PATCH ati] Remove reference to pixmapPrivate.

2010-10-04 Thread Michel Dänzer
On Sam, 2010-10-02 at 20:53 +0300, Adrian Bunk wrote: > On Fri, Oct 01, 2010 at 07:23:05PM +0200, Michel Dänzer wrote: > > On Fre, 2010-10-01 at 18:57 +0200, Julien Cristau wrote: > > > On Fri, Oct 1, 2010 at 18:29:54 +0200, Michel Dänzer wrote: > > > > > > > On Fre, 2010-10-01 at 18:27 +0200,