[PATCH:libX11] Mark atom names argument to XInternAtoms as const

Updates code & docs for XInternAtoms. The single atom name argument to XInternAtom was already const char * in the code, but not the docs, so updated it in the docs too. Signed-off-by: Alan Coopersmith --- include/X11/Xlib.h|2 +- man/XInternAtom.man |8 specs/libX11/CH04

Where to free screen pixmap driver private?

Dear all, If I use driver pixmap, the screen pixmap also has an allocated driver private. However, when xorg terminates, the driver DestroyPixmap can not be executed. So, the screen pixmap driver private can not be freed. Is this a bug? Can anyone explain it? Thanks a lot! Best wishes,

Re: tiling support in EXA

Thanks a lot! This is very useful. Best wishes, Fancy 2010/10/20 Alex Deucher > On Tue, Oct 19, 2010 at 9:58 PM, fancy fang wrote: > > Hello, all > > CreatePixmap2 was added to ExaDriverRec for drivers with tiling > > support. I can not understand what the tiling means. Anyone can ex

Re: [PATCH:libfontenc] Fail configure if zlib.h & -lz not found

On Sun, Nov 21, 2010 at 6:28 PM, Alan Coopersmith wrote: > Dan Nicholson wrote: >> On Sun, Nov 21, 2010 at 2:59 PM, Rémi Cardona wrote: >>> Le 20/11/2010 07:04, Alan Coopersmith a écrit :  # zlib - -AC_CHECK_LIB(z, gzclose) +AC_CHECK_HEADER([zlib.h], [], +                

[PATCH RESEND app-xdm 0/9] Review xdm configuration - Part 4

This set reworks selinux, pam, arc4random and dev/random consistently using pre-searched system libs in $LIBS. Comment and relocate some config fragments. Gaetan Nadon (9): config: isolating -lselinux to a single target is not required config: upgrade the checking for PAM support config: upg

[PATCH app-xdm 1/9] config: isolating -lselinux to a single target is not required

Due to previous patches, -lselinux, if installed on the configured system, is included in $LIBS already. Signed-off-by: Gaetan Nadon --- configure.ac |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/configure.ac b/configure.ac index 80b936c..e2e15f6 100644 --- a/conf

[PATCH app-xdm 2/9] config: upgrade the checking for PAM support

Use AC_CHECK_FUNCS to get the consistent #define HAVE_xxx Use "auto" rather than "try" for consistency with other modules. Update help string to mention default value. Unchanged: if configured --with-pam and -lpam is misisng, abort the configuration. Signed-off-by: Gaetan Nadon --- configure.ac

[PATCH app-xdm 3/9] config: upgrade the checking for SELinux support

Use AC_CHECK_FUNCS to get the consistent #define HAVE_xxx Use "auto" rather than "try" for consistency with other modules. Update help string to mention default value. Unchanged: if configured --with-selinux and -lselinux is misisng, abort the configuration. Signed-off-by: Gaetan Nadon --- confi

[PATCH app-xdm 4/9] config: integrate check for arc4random in appropriate sections

The AC_SEARCH_LIBS is done in "Check for libraries" section. Move AC_SUBST and AM_CONDITIONAL over there as well. Move AC_CHECK_FUNCS for arc4random to "library functions" section No function change. Signed-off-by: Gaetan Nadon --- Makefile.am |4 ++-- configure.ac | 14 -- dm

[PATCH app-xdm 5/9] config: rework check for random number generator

Following a similar pattern to PAM and SELinux checks. Unchanged: if a user has requested the use of a random device and none can be found, the configuration aborts. Signed-off-by: Gaetan Nadon --- configure.ac | 36 +++- 1 files changed, 15 insertions(+), 21 de

[PATCH app-xdm 6/9] config: comment libxtrans macros as they are order sensitive

XTRANS_SECURE_RPC_FLAGS must be called after XTRANS_CONNECTION_FLAGS which finds libraries like -lsockect, -lnsl or -lws32_32. The found libraries are pre-pended to $LIBS which is not obvious. Signed-off-by: Gaetan Nadon --- configure.ac |4 +++- 1 files changed, 3 insertions(+), 1 deletion

[PATCH app-xdm 7/9] config: relocate AC_FUNC_FORK in section "Check for system library functions"

No configuration changes. Signed-off-by: Gaetan Nadon --- configure.ac | 10 ++ 1 files changed, 2 insertions(+), 8 deletions(-) diff --git a/configure.ac b/configure.ac index 70d5676..59bc5ee 100644 --- a/configure.ac +++ b/configure.ac @@ -88,16 +88,12 @@ AC_CHECK_HEADERS([grp.h sys

[PATCH app-xdm 8/9] config: relocate key_setnet in section "Check for header files"

No configuration changes Signed-off-by: Gaetan Nadon --- configure.ac | 16 +++- 1 files changed, 7 insertions(+), 9 deletions(-) diff --git a/configure.ac b/configure.ac index 59bc5ee..7781034 100644 --- a/configure.ac +++ b/configure.ac @@ -84,6 +84,13 @@ AC_SEARCH_LIBS(crypt, c

[PATCH app-xdm 9/9] config: use AM_V_GEN instead of customized macros for AM_SILENT_RULES

Signed-off-by: Gaetan Nadon --- config/Makefile.am |2 +- configure.ac |3 --- cpprules.in|9 + 3 files changed, 2 insertions(+), 12 deletions(-) diff --git a/config/Makefile.am b/config/Makefile.am index d13645f..30e22ea 100644 --- a/config/Makefile.am +++ b/co

[PATCH app-xdm 00/16] Review xdm configuration - Part 5

This series refactors common header files in an include directory and moves each target in its own directory. Gaetan Nadon (7): config: move man pages into their own directory config: move chooser into its own directory config: move xdmshell into its own directory config: move common heade

[PATCH app-xdm 1/5] config: move man pages into their own directory

Replace lowercase $(xdmlibdir) with $(XXDMLIBDIR) Signed-off-by: Gaetan Nadon --- Makefile.am | 37 ++- configure.ac |6 +++- man/Makefile.am | 55 ++ xdm.man.cpp =>

[PATCH app-xdm 2/5] config: move chooser into its own directory

Prevents the use of per target flags. Clearly shows which libraries and compiler options apply. Signed-off-by: Gaetan Nadon --- .gitignore |1 - Makefile.am| 23 +-- chooser/.gitignore |1 + chooser/Makefile.am

[PATCH app-xdm 3/5] config: move xdmshell into its own directory

Prevents the use of per target flags. Clearly shows which libraries and compiler options apply. Signed-off-by: Gaetan Nadon --- .gitignore|1 - Makefile.am | 21 ++--- configure.ac |3 ++- xdmshell/.giti

[PATCH app-xdm 4/5] config: move common headers into the include directory

They provide interfaces to multiple executables Signed-off-by: Gaetan Nadon --- Makefile.am| 10 +++--- chooser/Makefile.am|2 +- configure.ac |1 + greeter/Makefile.am|3 ++- include/Makefile.am

[PATCH app-xdm 5/5] config: mv xdm in its own directory

Prevents the use of per target flags. Clearly shows which libraries and compiler options apply. Signed-off-by: Gaetan Nadon --- .gitignore |5 +-- Makefile.am | 60 +-- configure.ac |1 + xdm/.gitignore

[PATCH app-xdm 6/7] config: move appdefault makefile to app-defaults dir.

For this package it is best not to break the pattern of each directory having its own makefile. Signed-off-by: Gaetan Nadon --- Makefile.am |8 +++- app-defaults/Makefile.am |1 + configure.ac |1 + 3 files changed, 5 insertions(+), 5 deletions(-) create

[PATCH app-xdm 7/7] config: AM_PROG_CC_C_O is no longer needed

All per-target flags have been removed now that each target sits in its own directory. Signed-off-by: Gaetan Nadon --- configure.ac |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 41220d1..8b90cb6 100644 --- a/configure.ac +++ b/configur

Re: [PATCH RESEND app-xdm 0/9] Review xdm configuration - Part 4

Twas brillig at 10:32:10 22.11.2010 UTC-05 when mems...@videotron.ca did gyre and gimble: GN> This set reworks selinux, pam, arc4random and dev/random GN> consistently using pre-searched system libs in $LIBS. Comment and GN> relocate some config fragments. For the series: Reviewed-by: Mikha

Re: [PATCH] test: compare byte padding macros against the expected bytes.

On Fri, Nov 19, 2010 at 11:26:13 +1000, Peter Hutterer wrote: > We calculate the expected bytes for each value, let's use it. > > Signed-off-by: Peter Hutterer > --- > test/input.c |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > Reviewed-by: Julien Cristau Cheers, Julien ___

Re: [PATCH] test: reduce range of byte-padding macro tests.

On Fri, Nov 19, 2010 at 11:38:03 +1000, Peter Hutterer wrote: > Byte padding and conversion is interesting for the rage of 0-8 bytes, and > then interesting towards the end of the valid range (INT_MAX - 7 and INT_MAX > - 3). > > Signed-off-by: Peter Hutterer > --- > This significantly speeds up

Re: [PATCH app-xdm 2/9] config: upgrade the checking for PAM support

Gaetan Nadon wrote: > + [Use PAM for authentication (default is autodected)]), s/autodected/autodetected/ > -# ifdef USE_PAM > +# ifdef HAVE_PAM_OPEN_SESSION USE_PAM really does seem more descriptive in this case than HAVE_PAM_OPEN_SESSION though, since it's the whole framework we care about

Re: [PATCH app-xdm 4/9] config: integrate check for arc4random in appropriate sections

Gaetan Nadon wrote: > The AC_SEARCH_LIBS is done in "Check for libraries" section. > Move AC_SUBST and AM_CONDITIONAL over there as well. > Move AC_CHECK_FUNCS for arc4random to "library functions" section > No function change. > > Signed-off-by: Gaetan Nadon Reviewed-by: Alan Coopersmith --

Re: [PATCH app-xdm 5/9] config: rework check for random number generator

Gaetan Nadon wrote: > Following a similar pattern to PAM and SELinux checks. > Unchanged: if a user has requested the use of a random device > and none can be found, the configuration aborts. > > Signed-off-by: Gaetan Nadon > --- > configure.ac | 36 +++- > 1 fi

Re: [PATCH app-xdm 7/9] config: relocate AC_FUNC_FORK in section "Check for system library functions"

Gaetan Nadon wrote: > No configuration changes. > > Signed-off-by: Gaetan Nadon > --- > configure.ac | 10 ++ > 1 files changed, 2 insertions(+), 8 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 70d5676..59bc5ee 100644 > --- a/configure.ac > +++ b/configure.ac > @@

Re: [PATCH app-xdm 6/9] config: comment libxtrans macros as they are order sensitive

Gaetan Nadon wrote: > XTRANS_SECURE_RPC_FLAGS must be called after XTRANS_CONNECTION_FLAGS > which finds libraries like -lsockect, -lnsl or -lws32_32. s/-lsockect/-lsocket/ > The found libraries are pre-pended to $LIBS which is not obvious. > > Signed-off-by: Gaetan Nadon > --- > configure.ac

Re: [PATCH app-xdm 9/9] config: use AM_V_GEN instead of customized macros for AM_SILENT_RULES

Gaetan Nadon wrote: > Signed-off-by: Gaetan Nadon > --- > config/Makefile.am |2 +- > configure.ac |3 --- > cpprules.in|9 + > 3 files changed, 2 insertions(+), 12 deletions(-) > > diff --git a/config/Makefile.am b/config/Makefile.am > index d13645f..30e22ea 10

Re: [PATCH app-xdm 2/5] config: move chooser into its own directory

Gaetan Nadon wrote: > Prevents the use of per target flags. > Clearly shows which libraries and compiler options apply. > > Signed-off-by: Gaetan Nadon > --- > .gitignore |1 - > Makefile.am| 23 +-- > chooser/.gitignore

Re: [PATCH app-xdm 3/5] config: move xdmshell into its own directory

Gaetan Nadon wrote: > Prevents the use of per target flags. > Clearly shows which libraries and compiler options apply. > > Signed-off-by: Gaetan Nadon Reviewed-by: Alan Coopersmith -- -Alan Coopersmith-alan.coopersm...@oracle.com Oracle Solaris Platform Engineering:

Re: [PATCH app-xdm 4/5] config: move common headers into the include directory

Gaetan Nadon wrote: > They provide interfaces to multiple executables > > Signed-off-by: Gaetan Nadon > --- > Makefile.am| 10 +++--- > chooser/Makefile.am|2 +- > configure.ac |1 + > greeter/Makefile.am

Re: [PATCH xserver (rev2) 1/9] Create/Destroy/Trigger/Reset Fence Sync objects

Reviewed-by: Adam Jackson for the series. - ajax signature.asc Description: This is a digitally signed message part ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listin

xinput/evdev switch events+state

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Some tablets (such as dell and hp) report hinge rotation as EV_SW events. Does it make sense to handle events and state in the X evdev driver and xinput? Rafi -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with

[PATCH xinit] Minor typo

From: Tom Doherty Date: Mon, 22 Nov 2010 21:27:13 +0100 Subject: [PATCH] Minor typo. Signed-off-by: Matthieu Herrb --- xinit.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/xinit.c b/xinit.c index dd4e0a2..1aafbd9 100644 --- a/xinit.c +++ b/xinit.c @@ -620,7 +620,7

Re: [PATCH xinit] Minor typo

Matthieu Herrb wrote: > From: Tom Doherty > Date: Mon, 22 Nov 2010 21:27:13 +0100 > Subject: [PATCH] Minor typo. > > Signed-off-by: Matthieu Herrb > --- > xinit.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/xinit.c b/xinit.c > index dd4e0a2..1aafbd9 100644 >

Re: [PATCH app-xdm 7/7] config: AM_PROG_CC_C_O is no longer needed

Gaetan Nadon wrote: > All per-target flags have been removed now that each target > sits in its own directory. > > Signed-off-by: Gaetan Nadon > --- > configure.ac |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 41220d1..8b90cb6

Re: [PATCH app-xdm 6/7] config: move appdefault makefile to app-defaults dir.

Gaetan Nadon wrote: > For this package it is best not to break the pattern > of each directory having its own makefile. > > Signed-off-by: Gaetan Nadon > --- > Makefile.am |8 +++- > app-defaults/Makefile.am |1 + > configure.ac |1 + > 3 files changed, 5

Re: [PATCH app-xdm 5/5] config: mv xdm in its own directory

Gaetan Nadon wrote: > Prevents the use of per target flags. > Clearly shows which libraries and compiler options apply. > > Signed-off-by: Gaetan Nadon > --- > .gitignore |5 +-- > Makefile.am | 60 +-- > configure.ac

Re: [PATCH app-xdm 1/5] config: move man pages into their own directory

Gaetan Nadon wrote: > Replace lowercase $(xdmlibdir) with $(XXDMLIBDIR) s/XXDM/XDM/ Other than that, Reviewed-by: Alan Coopersmith -- -Alan Coopersmith-alan.coopersm...@oracle.com Oracle Solaris Platform Engineering: X Window System ___

[PATCH] xfree86: Remove the xf8_16bpp overlay module

Only one (marginal) driver was using it, and it's been fixed to just implement it directly. Signed-off-by: Adam Jackson --- configure.ac|1 - hw/xfree86/Makefile.am |4 +- hw/xfree86/xf8_16bpp/Makefile.am| 11 - hw/xfree86/xf8_16bpp/cfb8_16.

Re: [PATCH:libX11] Mark atom names argument to XInternAtoms as const

On Mon, Nov 22, 2010 at 12:04:04AM -0800, Alan Coopersmith wrote: > Updates code & docs for XInternAtoms. > > The single atom name argument to XInternAtom was already const char * > in the code, but not the docs, so updated it in the docs too. > > Signed-off-by: Alan Coopersmith Reviewed-by: Pe

Re: [PATCH] glx: Remove swap barrier and hyperpipe support

On 11/19/2010 07:52 PM, Adam Jackson wrote: Never implemented in any open source driver. The implementation assumed explicit DDX driver knowledge of how the client-side driver worked, since at the time the server's GL renderer was not a DRI driver. But now, it is, so any implementation of these

[PATCH libICE docs] Add top-level target for documentation.

From: Trevor Woerner Builds user and developer documentation/specifications. Signed-off-by: Trevor Woerner --- Makefile.am |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/Makefile.am b/Makefile.am index c2110ec..d0102e8 100644 --- a/Makefile.am +++ b/Makefile.am

Re: xinput/evdev switch events+state

On Mon, Nov 22, 2010 at 01:53:22PM -0500, Rafi Rubin wrote: > Some tablets (such as dell and hp) report hinge rotation as EV_SW events. > Does > it make sense to handle events and state in the X evdev driver and xinput? yes, but I don't think button events are the right method for this. in the X

Re: [PATCH] glx: Remove swap barrier and hyperpipe support

On Mon, 2010-11-22 at 23:16 +0100, Mario Kleiner wrote: > On 11/19/2010 07:52 PM, Adam Jackson wrote: > > Never implemented in any open source driver. The implementation > > assumed explicit DDX driver knowledge of how the client-side driver > > worked, since at the time the server's GL renderer w

Re: [PATCH libICE docs] Add top-level target for documentation.

On Mon, Nov 22, 2010 at 17:26:38 -0500, Trevor Woerner wrote: > From: Trevor Woerner > > Builds user and developer documentation/specifications. > > Signed-off-by: Trevor Woerner > --- > Makefile.am |7 ++- > 1 files changed, 6 insertions(+), 1 deletions(-) > > diff --git a/Makefile.

Re: [PATCH libICE docs] Add top-level target for documentation.

On Mon, 2010-11-22 at 17:26 -0500, Trevor Woerner wrote: > -.PHONY: ChangeLog INSTALL > +.PHONY: ChangeLog INSTALL documents I don't think it should be a PHONY target, "documents" is not a file. It's like the lint target. > > INSTALL: > $(INSTALL_CMD) > @@ -15,6 +15,11 @@ ChangeLog: >

Re: [PATCH libICE docs] Add top-level target for documentation.

On Tue, 2010-11-23 at 00:02 +0100, Julien Cristau wrote: > I don't think it's a good idea for a target named 'documents' to > install > stuff. Good point > Call it install-specs or something if it's needed, but I'm not > sure what this buys you over 'make -C specs install'. > Nothing, if you

Re: [PATCH libICE docs] Add top-level target for documentation.

On Mon, Nov 22, 2010 at 7:21 PM, Gaetan Nadon wrote: > On Mon, 2010-11-22 at 17:26 -0500, Trevor Woerner wrote: > -.PHONY: ChangeLog INSTALL > +.PHONY: ChangeLog INSTALL documents > > I don't think it should be a PHONY target, "documents" is not a file. > It's like the lint target. I thought this

[PATCH 1/6] dix: replace a manual valuator check with valuator_get_mode().

This check was missing the OutOfProximity mask and resulted in the wrong bits being set in InternalEvents. Signed-off-by: Peter Hutterer --- dix/getevents.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dix/getevents.c b/dix/getevents.c index 06a0da0..5f4fb66 100644 -

[PATCH 2/6] dix: when comparing axis modes, compare the bits, not the bytes.

The DeviceEvent's mode field is a set of bits for each valuator, not bytes. Signed-off-by: Peter Hutterer --- dix/eventconvert.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dix/eventconvert.c b/dix/eventconvert.c index 46eb4ff..b92169e 100644 --- a/dix/eventconvert.

[PATCH 3/6] dix: when converting to XI 1.x events, use the first_valuator's device mode

Don't stop processing events when a valuator's mode doesn't match the 0th valuator's mode. Instead, start with the first_valuator in the event and keep stacking them on until the first valuator with a different mode is hit. Signed-off-by: Peter Hutterer --- dix/eventconvert.c | 14

[PATCH 4/6] dix: GetProximityEvents needs to check up to the last valuator

valuator_mask_size() returns the highest valuator set as opposed to the number of set bits (which obviously changes as we unset valuators). Signed-off-by: Peter Hutterer --- dix/getevents.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dix/getevents.c b/dix/getevents.

[PATCH 5/6] dix: fix typo, set the second valuator with the y-axis data.

Signed-off-by: Peter Hutterer Tested-by: Jeremy Huddleston --- dix/getevents.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dix/getevents.c b/dix/getevents.c index f80e87c..f19c991 100644 --- a/dix/getevents.c +++ b/dix/getevents.c @@ -1186,7 +1186,7 @@ GetPointerEve

[PATCH 6/6] dix: add a fixme about a corner-case that should probably be fixed.

Signed-off-by: Peter Hutterer --- dix/getevents.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/dix/getevents.c b/dix/getevents.c index f19c991..0d59290 100644 --- a/dix/getevents.c +++ b/dix/getevents.c @@ -1255,6 +1255,10 @@ GetProximityEvents(EventList *events, De

Re: [PATCH] Build libxf86config with -fPIC.

On Mon, Nov 15, 2010 at 04:11:11PM -0800, Dan Nicholson wrote: > On Mon, Nov 15, 2010 at 10:38 AM, Julien Cristau wrote: > > On Mon, Nov 15, 2010 at 13:28:34 -0500, Gaetan Nadon wrote: > > > >> On Mon, 2010-11-15 at 15:35 +0100, Julien Cristau wrote: > >> > >> > If you want to install it as a shar

Re: [RFC XI 2.1 - inputproto] Various fixes in response to Peter Hutterer's review

On Fri, Nov 19, 2010 at 01:52:39PM -0500, Chase Douglas wrote: > --- > Normally I'd just squash this in and make a v2 patch, but this is the most > important part of the MT work and it's easier to review separately :). I'll > squash later. > > XI2.h|3 +++ > XI2proto.txt | 39 ++