Signed-off-by: Alan Coopersmith
---
src/bsd_mouse.c |4
src/hurd_mouse.c |2 ++
src/sun_mouse.c |2 ++
3 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/src/bsd_mouse.c b/src/bsd_mouse.c
index 8a57226..e9e2649 100644
--- a/src/bsd_mouse.c
+++ b/src/bsd_mouse.c
@@ -
Dan Nicholson wrote:
> In order to keep the katamari moduleset up to date with current tarball
> information, have release.sh update the file when new releases are made.
> This is enabled by passing a module file with --moduleset.
>
> Signed-off-by: Dan Nicholson
Thanks.
Reviewed-by: Alan Coope
Dan Nicholson wrote:
> Add a moduleset for the 7.6 katamari based on xorg.modules. This uses
> the module list from 7.6-rc1 with gzipped tarballs and sha1sums from
> announce emails (when available).
>
> Modules not included in the katamari have been removed. It might be a
> good idea to include t
Provides a portable implementation of this common allocating sprintf()
API found in many, but not yet all, of the platforms we support.
If the platform provides vasprintf() we simply wrap it, otherwise we
implement it - either way callers can use it regardless of platform.
Since not all platforms
No point calling the no-fail-alloc if you check for failure and your
only caller checks for failure.
No point calling calloc to zero fill memory you're about to memcpy over.
In the unlikely event of a loss of memory allocation, drop your previous
allocations before returning to others.
Signed-of
Requires linking xprintf.c into libxf86config for those who build it.
Signed-off-by: Alan Coopersmith
---
hw/xfree86/parser/Flags.c | 13 -
hw/xfree86/parser/Makefile.am |1 +
hw/xfree86/parser/Pointer.c | 16 ++--
3 files changed, 11 insertions(+), 19 delet
The meat of this series is sandwiched right in the middle - patch #6
replaces the nifty, but unique, Xprintf() API with a local implementation
of the asprintf() family that's becoming widely adopted (found in
recent versions of the GNU, FreeBSD, NetBSD, OpenBSD, & Solaris
libc's, but not yet in all
Signed-off-by: Alan Coopersmith
---
hw/xfree86/common/xf86Helper.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/xfree86/common/xf86Helper.c b/hw/xfree86/common/xf86Helper.c
index 78e6b20..ea0acbf 100644
--- a/hw/xfree86/common/xf86Helper.c
+++ b/hw/xfree86/common/x
Signed-off-by: Alan Coopersmith
---
config/hal.c |9 +++--
hw/xfree86/common/xf86Configure.c | 33 +++--
hw/xfree86/common/xf86Helper.c|5 +
hw/xfree86/common/xf86Init.c |3 +--
hw/xfree86/common/xf86ShowOpts.c |
15ac25627e7239629be59 removed the "/" from the sprintf strings,
but failed to remove the extra byte allocated for the '/'.
Signed-off-by: Alan Coopersmith
---
hw/xfree86/loader/loadmod.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/xfree86/loader/loadmod.c b/h
Signed-off-by: Alan Coopersmith
---
config/hal.c |4 +++-
config/udev.c | 14 --
dix/dixfonts.c |4 +++-
hw/xfree86/common/xf86AutoConfig.c |4 ++--
hw/xfree86/common/xf86Config.c |7 +++
hw/xfree
Signed-off-by: Alan Coopersmith
---
hw/xfree86/common/xf86Mode.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/hw/xfree86/common/xf86Mode.c b/hw/xfree86/common/xf86Mode.c
index d03310e..4d64bd4 100644
--- a/hw/xfree86/common/xf86Mode.c
+++ b/hw/xfree86/common/xf86M
Doesn't seem to be any reason to just not pass the error string
as another argument directly to LogVWrite()
Signed-off-by: Alan Coopersmith
---
include/os.h |2 +-
os/log.c | 19 ++-
2 files changed, 7 insertions(+), 14 deletions(-)
diff --git a/include/os.h b/include/
Requires linking xprintf.c into standalone cvt utility
Signed-off-by: Alan Coopersmith
---
hw/xfree86/modes/xf86cvt.c | 10 +-
hw/xfree86/utils/cvt/Makefile.am |5 -
hw/xfree86/utils/cvt/cvt.c | 18 ++
3 files changed, 23 insertions(+), 10 deletion
Signed-off-by: Alan Coopersmith
---
dix/devices.c | 15 +--
hw/xfree86/common/xf86Config.c |4 +---
hw/xfree86/common/xf86Option.c |5 +
hw/xfree86/common/xf86ShowOpts.c|7 ++-
hw/xfree86/dixmods/extmod/modinit.c |5 +
On Tue, Nov 30, 2010 at 4:22 AM, Alan Coopersmith
wrote:
> Signed-off-by: Alan Coopersmith
Reviewed-by: Matt Turner
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinf
Most importantly removes AC_PROG_CC call that resets compiler flags back
to C89 mode, breaking use of C99 isfinite() on Solaris in dix/devices.c.
Signed-off-by: Alan Coopersmith
---
configure.ac |3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/configure.ac b/configure.a
These resolve compiler warnings on Solaris, though the first two also
affect other platforms as well (undoing the reset of compiler flags
that loses the C99 option xorg-macros applies if the compiler supports
it, and moving code only called on Linux into #ifdef __linux__).
[PATCH 1/3] config: Rem
static function only called from the matchDriverFromFiles function
that's inside #ifdef __linux__ section
Signed-off-by: Alan Coopersmith
---
hw/xfree86/common/xf86pciBus.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/xfree86/common/xf86pciBus.c b/hw/xfree86/commo
sun_init.c: In function `xf86OpenConsole':
sun_init.c:99: warning: cast does not match function type
sun_init.c:74: warning: unused variable `FreeVTslot'
sun_init.c: In function `xf86UseMsg':
sun_init.c:417: warning: old-style parameter declaration
sun_vid.c: In function `solUnMapVidMem':
sun_vid.
On Mon, Nov 29, 2010 at 04:07:24PM -0500, Chase Douglas wrote:
> On 11/29/2010 02:08 AM, Peter Hutterer wrote:
> > On Tue, Nov 23, 2010 at 09:27:53AM -0500, Chase Douglas wrote:
> >> On 11/23/2010 01:07 AM, Peter Hutterer wrote:
> >>> On Fri, Nov 19, 2010 at 01:52:39PM -0500, Chase Douglas wrote:
>
On Sun, Nov 28, 2010 at 04:15:51PM -0500, Eoghan Sherry wrote:
> It is currently assumed that an event button delieved to a master device
> corresponds to the slave button states. However, the event button is a
> logical (mapped) slave button and slave button states correspond to
> physical (unmapp
Alan Coopersmith wrote:
> Following up on Matt's call for other sources of X documentation to
> consider collecting to improve our user and developer documentation,
> here's a few I use either directly or for sending to others:
A user on #xorg pointed out these today I'd forgotten about:
http://t
Does anyone else want to review this, or are Robert's (@nvidia.com)
Reviewed-by and Cyril's Tested-by sufficient?
On Tue, Nov 16, 2010 at 12:17:33PM -0800, Aaron Plattner wrote:
> When RandR 1.2's transformation code is enabled, it rotates the cursor
> image so that it appears upright on a rotated
On Mon, Nov 29, 2010 at 08:49:00PM -0500, Chase Douglas wrote:
> On 11/29/2010 08:31 PM, Peter Hutterer wrote:
> > On Mon, Nov 29, 2010 at 08:21:26PM -0500, Chase Douglas wrote:
> >> If I've got this right, then it sounds like XI 1.x mode and XI 2.x
> >> per-valuator modes are orthogonal. If so, th
On 11/25/2010 06:37 PM, Peter Hutterer wrote:
> XI 1.x events still contain absolute coordinates anyway. By the time we get
> to the InternalEvent to XI event conversion, the valuators are already
> absolute.
>
> Stopping because of a different mode on a valuator is not necessary.
The addition wa
On 11/29/2010 08:31 PM, Peter Hutterer wrote:
> On Mon, Nov 29, 2010 at 08:21:26PM -0500, Chase Douglas wrote:
>> If I've got this right, then it sounds like XI 1.x mode and XI 2.x
>> per-valuator modes are orthogonal. If so, then do we need any of this
>> type of check in CountValuators at all?
>
Matt Dew wrote:
> On Mon, 2010-11-29 at 14:51 -0800, Alan Coopersmith wrote:
>> Jeremy Huddleston wrote:
>>> Series:
>>> Reviewed-by: Jeremy Huddleston
>>>
>>> Does the documentation include reference for these from inputstr.h which I
>>> recall being added in the past year or two:
>>>
>>> #defin
On Mon, Nov 29, 2010 at 08:21:26PM -0500, Chase Douglas wrote:
> On 11/29/2010 07:14 PM, Peter Hutterer wrote:
> > On Mon, Nov 29, 2010 at 11:14:02AM -0500, Chase Douglas wrote:
> >> On 11/22/2010 10:35 PM, Peter Hutterer wrote:
> >>> Don't stop processing events when a valuator's mode doesn't matc
On 11/29/2010 07:14 PM, Peter Hutterer wrote:
> On Mon, Nov 29, 2010 at 11:14:02AM -0500, Chase Douglas wrote:
>> On 11/22/2010 10:35 PM, Peter Hutterer wrote:
>>> Don't stop processing events when a valuator's mode doesn't match the 0th
>>> valuator's mode. Instead, start with the first_valuator i
On Mon, Nov 29, 2010 at 11:14:02AM -0500, Chase Douglas wrote:
> On 11/22/2010 10:35 PM, Peter Hutterer wrote:
> > Don't stop processing events when a valuator's mode doesn't match the 0th
> > valuator's mode. Instead, start with the first_valuator in the event and
> > keep stacking them on until t
On Mon, 2010-11-29 at 14:51 -0800, Alan Coopersmith wrote:
> Jeremy Huddleston wrote:
> > Series:
> > Reviewed-by: Jeremy Huddleston
> >
> > Does the documentation include reference for these from inputstr.h which I
> > recall being added in the past year or two:
> >
> > #define BitIsOn(ptr, bi
Jeremy Huddleston wrote:
> Series:
> Reviewed-by: Jeremy Huddleston
>
> Does the documentation include reference for these from inputstr.h which I
> recall being added in the past year or two:
>
> #define BitIsOn(ptr, bit) (!!(((BYTE *) (ptr))[(bit)>>3] & (1 << ((bit) &
> 7
> #define SetBi
Matt Dew wrote:
> Alan,
> In the later xml files I started using for function
> callouts like that.
>
>
>
> Bool CreateCallbackList
> CallbackListPtr
> *CallbackFuncsPtr
> CallbackFuncsPtr cbfuncs
>
>
>
>
> which generates:
> Bool CreateCallbackList(pcbl, cbfuncs);
> CallbackList
On Mon, Nov 29, 2010 at 09:02:39PM +0500, Alexandr Shadchin wrote:
> Signed-off-by: Alexandr Shadchin
> ---
> src/bsd_kbd.c |9 -
> src/hurd_kbd.c |1 -
> src/lnx_kbd.c |6 --
> src/sun_kbd.c |1 -
> src/xf86OSKbd.h |1 -
> 5 files changed, 0 insertions(+),
On Mon, Nov 29, 2010 at 06:27:34PM +0100, Ferry Huberts wrote:
> On 11/29/2010 05:47 PM, Julien Cristau wrote:
> > On Mon, Nov 29, 2010 at 17:09:31 +0100, Ferry Huberts wrote:
> >
> >> From: Ferry Huberts
> >>
> >> Signed-off-by: Ferry Huberts
> >> ---
> >> dix/getevents.c | 12 ++--
>
Alan,
In the later xml files I started using for function
callouts like that.
Bool CreateCallbackList
CallbackListPtr *CallbackFuncsPtr
CallbackFuncsPtr cbfuncs
which generates:
Bool CreateCallbackList(pcbl, cbfuncs);
CallbackListPtr *pcbl;
CallbackFuncsPtr cbfuncs;
What do y
On 11/29/2010 02:08 AM, Peter Hutterer wrote:
> On Tue, Nov 23, 2010 at 09:27:53AM -0500, Chase Douglas wrote:
>> On 11/23/2010 01:07 AM, Peter Hutterer wrote:
>>> On Fri, Nov 19, 2010 at 01:52:39PM -0500, Chase Douglas wrote:
diff --git a/XI2proto.txt b/XI2proto.txt
index fd47643..697668
On Sun, 2010-11-28 at 20:17 -0800, Alan Coopersmith wrote:
> For those of us building behind firewalls, shaves approx. 3 minutes
> off
> document creation for each set of documents by not waiting for
> download
> of the draft.png watermark image from the docbook website to time out.
>
> Also gets
On 11/25/2010 06:37 PM, Peter Hutterer wrote:
> XI 1.x events still contain absolute coordinates anyway. By the time we get
> to the InternalEvent to XI event conversion, the valuators are already
> absolute.
>
> Stopping because of a different mode on a valuator is not necessary.
I believe this
Only one (marginal) driver was using it, and it's been fixed to just
implement it directly.
v2: Also fix sdksyms.sh (spotted by Jesse Adkins)
Signed-off-by: Adam Jackson
---
configure.ac|1 -
hw/xfree86/Makefile.am |4 +-
hw/xfree86/loader/sdksyms.sh
On Fri, 2010-11-26 at 09:37 +1000, Peter Hutterer wrote:
> XI 1.x events still contain absolute coordinates anyway. By the time we get
> to the InternalEvent to XI event conversion, the valuators are already
> absolute.
>
> Stopping because of a different mode on a valuator is not necessary.
>
>
On Thu, 2010-11-25 at 12:57 +1000, Peter Hutterer wrote:
> Signed-off-by: Peter Hutterer
For the series:
Reviewed-by: Adam Jackson
- ajax
signature.asc
Description: This is a digitally signed message part
___
xorg-devel@lists.x.org: X.Org developme
Looks like a leftover of the SpecialKey handling that should have
gone away with the rest of it in d12d2d2c789e8439ae6f2e63526c49c76c385c8e.
Reviewed-by: Alan Coopersmith
-alan-
Alexandr Shadchin wrote:
> Signed-off-by: Alexandr Shadchin
> ---
> src/bsd_kbd.c |9 -
> src
On Fri, 2010-11-26 at 23:33 -0500, Devin J. Pohly wrote:
> The override-redirect flag is important for a window manager to know
> about, but there's no notification made when a window changes it. It
> doesn't appear that the protocol specifies an action to take when a
> ChangeWindowAttributes r
On Mon, 29 Nov 2010 13:38:36 -0500, Adam Jackson wrote:
> On Mon, 2010-11-29 at 08:55 -0800, Keith Packard wrote:
> > On Mon, 29 Nov 2010 10:07:40 -0500, Adam Jackson wrote:
> >
> > > Now if it seems to you wrong that we're trying to overlay magic values
> > > on this logic to get the right defa
On Sun, 2010-11-28 at 20:17 -0800, Alan Coopersmith wrote:
> Force draft mode to "no" instead of default of "maybe" as discussed in
> various posts in http://sources.redhat.com/ml/docbook-apps archives.
>
> For those of us building behind firewalls, shaves approx. 3 minutes off
> document creation
On Mon, 29 Nov 2010 17:47:31 +0100, Julien Cristau wrote:
> On Mon, Nov 29, 2010 at 17:09:31 +0100, Ferry Huberts wrote:
>
> > From: Ferry Huberts
> >
> > Signed-off-by: Ferry Huberts
> > ---
> > dix/getevents.c | 12 ++--
> > 1 files changed, 6 insertions(+), 6 deletions(-)
> >
>
On Mon, 2010-11-29 at 08:55 -0800, Keith Packard wrote:
> On Mon, 29 Nov 2010 10:07:40 -0500, Adam Jackson wrote:
>
> > Now if it seems to you wrong that we're trying to overlay magic values
> > on this logic to get the right defaults picked... well, good, that means
> > you have taste.
>
> I wa
On Wed, 2010-11-24 at 11:25 +0100, Maarten Maathuis wrote:
> If Adam indeed did this, and did not undo it afterwards, then he is
> having at least some (mental) issues. He did the right thing by
> disabling his admin account, because he obviously has some things to
> sort out. While the action its
On 11/29/2010 05:47 PM, Julien Cristau wrote:
> On Mon, Nov 29, 2010 at 17:09:31 +0100, Ferry Huberts wrote:
>
>> From: Ferry Huberts
>>
>> Signed-off-by: Ferry Huberts
>> ---
>> dix/getevents.c | 12 ++--
>> 1 files changed, 6 insertions(+), 6 deletions(-)
>>
> I'm missing the "why" f
On Mon, 29 Nov 2010 10:07:40 -0500, Adam Jackson wrote:
> Now if it seems to you wrong that we're trying to overlay magic values
> on this logic to get the right defaults picked... well, good, that means
> you have taste.
I was actually asking how the maxpixclock value used to get picked, and
wh
On Mon, Nov 29, 2010 at 17:09:31 +0100, Ferry Huberts wrote:
> From: Ferry Huberts
>
> Signed-off-by: Ferry Huberts
> ---
> dix/getevents.c | 12 ++--
> 1 files changed, 6 insertions(+), 6 deletions(-)
>
I'm missing the "why" for this change. It looks like a no-op to me...
Cheers,
On 11/22/2010 10:35 PM, Peter Hutterer wrote:
> This check was missing the OutOfProximity mask and resulted in the wrong
> bits being set in InternalEvents.
>
> Signed-off-by: Peter Hutterer
Except for patch 3/6, all:
Reviewed-by: Chase Douglas
___
x
On 11/22/2010 10:35 PM, Peter Hutterer wrote:
> Don't stop processing events when a valuator's mode doesn't match the 0th
> valuator's mode. Instead, start with the first_valuator in the event and
> keep stacking them on until the first valuator with a different mode is hit.
In XI 1.x, a device ha
From: Ferry Huberts
Signed-off-by: Ferry Huberts
---
dix/getevents.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/dix/getevents.c b/dix/getevents.c
index f09d31c..25889de 100644
--- a/dix/getevents.c
+++ b/dix/getevents.c
@@ -112,12 +112,12 @@ set_button_u
Signed-off-by: Alexandr Shadchin
---
src/bsd_kbd.c |9 -
src/hurd_kbd.c |1 -
src/lnx_kbd.c |6 --
src/sun_kbd.c |1 -
src/xf86OSKbd.h |1 -
5 files changed, 0 insertions(+), 18 deletions(-)
diff --git a/src/bsd_kbd.c b/src/bsd_kbd.c
index 3653042..35d3649
On Wed, 2010-11-24 at 11:38 -0800, Keith Packard wrote:
> On Mon, 15 Nov 2010 11:25:13 +1000, Peter Hutterer
> wrote:
>
> > + if (!scrp->monitor->maxPixClock && !specified) {
> > +type = "default ";
> > +scrp->monitor->maxPixClock = 65000.0;
> > +}
>
> Can you
58 matches
Mail list logo