Re: [PATCH:xf86-input-keyboard] sun_kbd: Replace deprecated xfree/xcalloc with free & calloc

2010-12-23 Thread Alan Coopersmith
On 12/23/10 04:20 PM, Julien Cristau wrote: > can't this whole thing be replaced with > > kbdPath = xf86SetStrOption(pInfo->options, "Device", "/dev/kbd") > > ? > > AFAICT it should handle a NULL pInfo->options fine (returning the > default). Not tested though. Yes it appears so. Rev

Re: [PATCH:xf86-input-keyboard] sun_kbd: Replace deprecated xfree/xcalloc with free & calloc

2010-12-23 Thread Julien Cristau
On Thu, Dec 23, 2010 at 16:00:33 -0800, Alan Coopersmith wrote: > Reworked char * pointers to avoid introducing new warnings of: > sun_kbd.c:512: warning: passing arg 1 of `free' discards qualifiers from > pointer target type > > Signed-off-by: Alan Coopersmith > --- > src/sun_kbd.c | 14 +++

[PATCH:xf86-input-keyboard] sun_kbd: Replace deprecated xfree/xcalloc with free & calloc

2010-12-23 Thread Alan Coopersmith
Reworked char * pointers to avoid introducing new warnings of: sun_kbd.c:512: warning: passing arg 1 of `free' discards qualifiers from pointer target type Signed-off-by: Alan Coopersmith --- src/sun_kbd.c | 14 +- 1 files changed, 5 insertions(+), 9 deletions(-) diff --git a/src

Re: [PATCH] EXA: Fix crash with fill using 1x1 tile of depth < 8 (bug #24703).

2010-12-23 Thread Jeremy Huddleston
On Dec 23, 2010, at 03:26, Michel Dänzer wrote: > On Mit, 2010-12-22 at 11:38 -0800, Keith Packard wrote: >> On Wed, 22 Dec 2010 11:45:36 +0100, Michel Dänzer wrote: >>> From: Michel Dänzer >>> >>> Fixes http://bugs.freedesktop.org/show_bug.cgi?id=24703 . >>> >>> Signed-off-by: Michel Dänzer

Re: [Mesa-dev] TLS autodetection support in the X server

2010-12-23 Thread tom fogal
Dan Nicholson writes: > On Wed, Dec 22, 2010 at 3:18 PM, tom fogal wrote: > > Alan Coopersmith writes: > >> On 12/22/10 02:30 PM, tom fogal wrote: > >> > >> We generally don't copy macros from the autoconf-archive into > >> xorg-macros, [. . .] Is there any reason not to do that here? Why > >>

Re: [PATCH bitmap] Fix memory leak.

2010-12-23 Thread Julien Cristau
On Thu, Dec 23, 2010 at 12:01:03 -0500, Trevor Woerner wrote: > From: Trevor Woerner > > Signed-off-by: Trevor Woerner > --- > bmtoa.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > Reviewed-by: Julien Cristau Cheers, Julien ___ xo

[PATCH bitmap] Fix memory leak.

2010-12-23 Thread Trevor Woerner
From: Trevor Woerner Signed-off-by: Trevor Woerner --- bmtoa.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/bmtoa.c b/bmtoa.c index bdd2078..8cd96b1 100644 --- a/bmtoa.c +++ b/bmtoa.c @@ -208,6 +208,7 @@ print_scanline (unsigned int width, putchar ('\n');

Re: [PATCH modular 1/8] build.sh: expose the PREFIX variable for the user to set

2010-12-23 Thread Trevor Woerner
On Wed, Dec 22, 2010 at 9:34 AM, Gaetan Nadon wrote: > I was contemplating another patch where PREFIX would not be mandatory and > set /usr/local > by default. This is what the autoconf does. That would be much more > consistent with everything. > What do you think? Yes, I think that would be the

Re: [Mesa-dev] TLS autodetection support in the X server

2010-12-23 Thread Dan Nicholson
On Wed, Dec 22, 2010 at 3:18 PM, tom fogal wrote: > Alan Coopersmith writes: >> On 12/22/10 02:30 PM, tom fogal wrote: >> >> We generally don't copy macros from the autoconf-archive into >> xorg-macros, we just use them as is - adding *.m4 files to >> packages that need them (especially when it's

Re: [PATCH inputproto 2/2] Add touch classes and events, bump to 2.1

2010-12-23 Thread Daniel Stone
Hi, On Thu, Dec 23, 2010 at 02:28:51PM +0100, Denis Dzyubenko wrote: > On 23 December 2010 12:44, Daniel Stone wrote: > > It's not really cancelled though. > > > > The finger has been lifted, so the touch has _physically_ finished, but > > the point of the event is to let you know that, while thi

Re: [PATCH inputproto 2/2] Add touch classes and events, bump to 2.1

2010-12-23 Thread Denis Dzyubenko
Hi, On 23 December 2010 12:44, Daniel Stone wrote: > On Thu, Dec 23, 2010 at 12:33:42PM +0100, Denis Dzyubenko wrote: >> On 23 December 2010 01:04, Peter Hutterer wrote: >> >> The idea behind TouchEnd is that it's the final event clients receive, >> >> and that they can clean up all state for th

[PATCH v4 xserver 3/3] Xext: Use general OS functions to determine client command string in SELinux.

2010-12-23 Thread Rami Ylimäki
Signed-off-by: Rami Ylimäki Reviewed-by: Tiago Vignatti --- Xext/xselinux_hooks.c | 34 +- 1 files changed, 17 insertions(+), 17 deletions(-) diff --git a/Xext/xselinux_hooks.c b/Xext/xselinux_hooks.c index 560e1e9..f1d8e5d 100644 --- a/Xext/xselinux_hooks.c ++

[PATCH v4 xserver 2/3] os: Add facilities for client ID tracking.

2010-12-23 Thread Rami Ylimäki
An interface is provided for figuring out the PID and process name of a client. Make some existing functionality from SELinux and IA extensions available for general use. Signed-off-by: Rami Ylimäki Reviewed-by: Tiago Vignatti --- configure.ac | 13 ++ dix/dispatch.c

[PATCH v4 xserver 1/3] config: Fix linking order of Xnest libraries.

2010-12-23 Thread Rami Ylimäki
MAIN depends on DIX and not vice versa. Signed-off-by: Rami Ylimäki --- configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index de172ce..cbbf5c3 100644 --- a/configure.ac +++ b/configure.ac @@ -1507,7 +1507,7 @@ if test "x$XNEST" =

[PATCH v4 xserver 0/3] Client ID tracking

2010-12-23 Thread Rami Ylimäki
Fixes based on comments of various reviewers. The changes are also available at clientids branch of ssh://g...@gitorious.org/rjy-fdo/xserver.git. v2 -- Mark Kettenis: move /proc specific code into os treat pid -1 as error instead of 0 Tiago Vignatti: preserve copyrights amend autho

Re: [PATCH] xkb/ddxLoad.c doesn't need any more

2010-12-23 Thread Julien Cristau
On Wed, Dec 22, 2010 at 18:03:36 -0800, Alan Coopersmith wrote: > Was previously used for _PATH_VARTMP, but that was removed in > 534fc5140b039a8c98ab715d0a6740d513b41209 > > Signed-off-by: Alan Coopersmith > --- > xkb/ddxLoad.c |4 > 1 files changed, 0 insertions(+), 4 deletions(-) >

Re: [PATCH inputproto 2/2] Add touch classes and events, bump to 2.1

2010-12-23 Thread Daniel Stone
Hi, On Thu, Dec 23, 2010 at 12:33:42PM +0100, Denis Dzyubenko wrote: > On 23 December 2010 01:04, Peter Hutterer wrote: > >> The idea behind TouchEnd is that it's the final event clients receive, > >> and that they can clean up all state for that touch as soon as they get > >> it.  So, TouchPendi

Re: [PATCH inputproto 2/2] Add touch classes and events, bump to 2.1

2010-12-23 Thread Denis Dzyubenko
Hi, On 23 December 2010 01:04, Peter Hutterer wrote: >> The idea behind TouchEnd is that it's the final event clients receive, >> and that they can clean up all state for that touch as soon as they get >> it.  So, TouchPendingFinish arrives in a TouchMotion event with zero >> valuators. > > ah, I

Re: [PATCH] EXA: Fix crash with fill using 1x1 tile of depth < 8 (bug #24703).

2010-12-23 Thread Michel Dänzer
On Mit, 2010-12-22 at 11:38 -0800, Keith Packard wrote: > On Wed, 22 Dec 2010 11:45:36 +0100, Michel Dänzer wrote: > > From: Michel Dänzer > > > > Fixes http://bugs.freedesktop.org/show_bug.cgi?id=24703 . > > > > Signed-off-by: Michel Dänzer > > Reviewed-by: Dave Airlie > > Merged. >56d

Re: [PATCH xserver 08/10] Input: Add initial multitouch support from Xi 2.1

2010-12-23 Thread Daniel Stone
On Thu, Dec 23, 2010 at 10:34:35AM +1000, Peter Hutterer wrote: > On Wed, Dec 22, 2010 at 11:56:30AM +, Daniel Stone wrote: > > On Wed, Dec 22, 2010 at 03:10:07PM +1000, Peter Hutterer wrote: > > > no. if the current hierarchy event processing isn't good enough, fix it > > > but > > > don't sh

Re: [PATCH inputproto 2/2] Add touch classes and events, bump to 2.1

2010-12-23 Thread Daniel Stone
On Thu, Dec 23, 2010 at 10:04:09AM +1000, Peter Hutterer wrote: > On Wed, Dec 22, 2010 at 11:39:34AM +, Daniel Stone wrote: > > Yeah, parallel seems like a bit of a minefield. OTOH, this is so > > terrifyingly complex that I think the best thing to do would be to make > > it implementation-def