Re: xserver distcheck broken with and without --disable-devel-docs

2011-01-03 Thread Keith Packard
On Mon, 03 Jan 2011 17:52:10 -0500, Gaetan Nadon wrote: > In the last path I did on master > http://cgit.freedesktop.org/xorg/xserver/commit/?id=03ea0b7726487b96df73936518da73d023e51334 > I had tested those various scenarios and worked correctly. It worked for me today. I recall discussing this

Re: [PATCH modular 14/14] build.sh: verify PREFIX is a directory and is writable

2011-01-03 Thread Peter Hutterer
On Mon, Jan 03, 2011 at 10:28:30PM -0500, Gaetan Nadon wrote: > On Tue, 2011-01-04 at 09:42 +1000, Peter Hutterer wrote: > > > > +check_writable_dir () { > > > +if [ X"$SUDO" = X ]; then > > > > skip this check, just because it's sudo doesn't mean you can write to > > the directory. > > On t

Re: [PATCH modular 14/14] build.sh: verify PREFIX is a directory and is writable

2011-01-03 Thread Gaetan Nadon
On Tue, 2011-01-04 at 09:42 +1000, Peter Hutterer wrote: > > +check_writable_dir () { > > +if [ X"$SUDO" = X ]; then > > skip this check, just because it's sudo doesn't mean you can write to > the directory. On the other hand, without this test, a user running build.sh with -s will always e

Re: xserver distcheck broken with and without --disable-devel-docs

2011-01-03 Thread Gaetan Nadon
On Mon, 2011-01-03 at 17:52 -0500, Gaetan Nadon wrote: > On Mon, 2011-01-03 at 14:06 +, Daniel Stone wrote: > > > Hi, > > So, the DMX doc stuff breaks distcheck quite badly. If I have > > --disable-devel-docs set in my ./configure run, I get: > > make[3]: Entering directory > > `/home/dani

Re: [PATCH v2 modular 3/3] build.sh: comment the supported systems and how they are detected

2011-01-03 Thread Gaetan Nadon
On Tue, 2011-01-04 at 00:31 +0100, Mark Kettenis wrote: > > Date: Mon, 03 Jan 2011 18:08:11 -0500 > > > > For many, build.sh is the first encounter to X.Org or even UNIX > code. > > This comment should help them understand why certain packages cannot > be > > built on thier system. > > Sorry, bu

[PATCH:xf86-input-keyboard] Make key codes for Sun Japanese keyboard match xkb-config mappings

2011-01-03 Thread Alan Coopersmith
From: Javier Acosta Solaris bug #7005752: http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=7005752 Signed-off-by: Javier Acosta Signed-off-by: Alan Coopersmith --- src/sun_kbdMap.c | 12 +++- 1 files changed, 3 insertions(+), 9 deletions(-) diff --git a/src/sun_kbdMap.c

[PATCH synaptics 5/5] Rename SHM functions from alloc/free_param_data to alloc/free_shm_data

2011-01-03 Thread Peter Hutterer
This naming is historical, we used to export the parameters through SHM. These days it's just confusing. Signed-off-by: Peter Hutterer --- src/synaptics.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/synaptics.c b/src/synaptics.c index ab24b79..88bd02

[PATCH synaptics 4/5] Don't report all options unconditionally.

2011-01-03 Thread Peter Hutterer
While this is useful to see all options provided, it also lists options that are not actually interpreted by the driver. Skip it, use xf86Set*Option() instead to just report the options handled by the driver. Signed-off-by: Peter Hutterer --- src/synaptics.c |2 -- 1 files changed, 0 inserti

[PATCH synaptics 3/5] Dont report the version explicitly, it's reported in the module blob anyway.

2011-01-03 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- src/synaptics.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/synaptics.c b/src/synaptics.c index 151d2a4..d336457 100644 --- a/src/synaptics.c +++ b/src/synaptics.c @@ -684,8 +684,6 @@ SynapticsPreInit(InputDriverPtr drv, InputInf

[PATCH synaptics 2/5] Use xf86SetStrOption instead of xf86FindOption for the Device

2011-01-03 Thread Peter Hutterer
xf86SetStrOption reports to the log if found. Signed-off-by: Peter Hutterer --- src/synaptics.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/synaptics.c b/src/synaptics.c index 872930c..151d2a4 100644 --- a/src/synaptics.c +++ b/src/synaptics.c @@ -238,9 +238,9

[PATCH synaptics 1/5] Remove the need for XI86_CONFIGURED on input-ABI 12

2011-01-03 Thread Peter Hutterer
Just move the assignment into an already if GET_ABI_MAJOR() block. Signed-off-by: Peter Hutterer --- src/synaptics.c |9 ++--- 1 files changed, 2 insertions(+), 7 deletions(-) diff --git a/src/synaptics.c b/src/synaptics.c index f64a081..872930c 100644 --- a/src/synaptics.c +++ b/src/sy

Re: xserver distcheck broken with and without --disable-devel-docs

2011-01-03 Thread Peter Hutterer
On Mon, 3 Jan 2011 14:06:37 +, Daniel Stone wrote: > Hi, > So, the DMX doc stuff breaks distcheck quite badly. If I have > --disable-devel-docs set in my ./configure run, I get: > make[3]: Entering directory > `/home/daniels/x/xorg/xserver/obj-amd64/hw/dmx/doc' > GENdmx.txt > GEN

Re: [PATCH 01/11] dix: Refactor block and wakup handlers

2011-01-03 Thread Keith Packard
On Fri, 31 Dec 2010 19:30:59 +0200, Pauli wrote: > From: Pauli Nieminen > > It is common use case in server that only block or wakeup handler is > used. To provide API for that case block handlers have to be split to > separate structures. This looks like the API we want. Acked-by: Keith Packa

Re: [PATCH modular 14/14] build.sh: verify PREFIX is a directory and is writable

2011-01-03 Thread Peter Hutterer
On Wed, 29 Dec 2010 11:30:03 -0500, Gaetan Nadon wrote: > This will catch the case where user forgets to set PREFIX > and does not have write permission in the /usr/local default location > > Signed-off-by: Gaetan Nadon > --- > build.sh | 23 ++- > 1 files changed, 22 inse

Re: [PATCH v2 modular 3/3] build.sh: comment the supported systems and how they are detected

2011-01-03 Thread Mark Kettenis
> From: Gaetan Nadon > Date: Mon, 03 Jan 2011 18:08:11 -0500 > > For many, build.sh is the first encounter to X.Org or even UNIX code. > This comment should help them understand why certain packages cannot be > built on thier system. Sorry, but I think this list is incomplete, and the descriptio

Re: What's an X.Org module? What license can it have? (was: [PATCH util/modular] build.sh: add xrestop)

2011-01-03 Thread Peter Hutterer
On Wed, 29 Dec 2010 14:32:10 -0800, Alan Coopersmith wrote: > On 12/29/10 09:47 AM, Daniel Stone wrote: > > On Wed, Dec 29, 2010 at 12:21:38PM -0500, Gaetan Nadon wrote: > >> I am still puzzled as to what "belongs" to X.Org or not. Or even if this > >> concept applies. > > > > Well, there's a bi

[PATCH v2 modular 3/3] build.sh: comment the supported systems and how they are detected

2011-01-03 Thread Gaetan Nadon
For many, build.sh is the first encounter to X.Org or even UNIX code. This comment should help them understand why certain packages cannot be built on thier system. Signed-off-by: Gaetan Nadon --- build.sh | 28 ++-- 1 files changed, 26 insertions(+), 2 deletions(-) di

[PATCH v2 modular 2/3] build.sh: use accurate values for HOST_CPU from config.guess

2011-01-03 Thread Gaetan Nadon
Using x86*64* rather than x86_64 is misleading to the user as it implies there are a large number of possibilities. Use the values from config.guess which are known to be accurate. Signed-off-by: Gaetan Nadon --- *** Use sparc | sparc64 which is equivalent to the origina

[PATCH v2 modular 1/3] build.sh: use accurate values for HOST_OS from config.guess

2011-01-03 Thread Gaetan Nadon
Using *Linux* rather than Linux is misleading to the user as it implies there are a large number of possibilities. In addition, FreeBSD | NetBSD | OpenBSD is more informative than *BSD* which is not used in config.guess. Use the values from config.guess which are known to be accurate. Signed-off

Re: [PATCH v4 xserver 1/3] config: Fix linking order of Xnest libraries.

2011-01-03 Thread Alan Coopersmith
On 12/23/10 04:11 AM, Rami Ylimäki wrote: > MAIN depends on DIX and not vice versa. > > Signed-off-by: Rami Ylimäki > --- > configure.ac |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/configure.ac b/configure.ac > index de172ce..cbbf5c3 100644 > --- a/configure.a

Re: xserver distcheck broken with and without --disable-devel-docs

2011-01-03 Thread Gaetan Nadon
On Mon, 2011-01-03 at 14:06 +, Daniel Stone wrote: > Hi, > So, the DMX doc stuff breaks distcheck quite badly. If I have > --disable-devel-docs set in my ./configure run, I get: > make[3]: Entering directory > `/home/daniels/x/xorg/xserver/obj-amd64/hw/dmx/doc' > GENdmx.txt > GEN

Re: [PATCH xrdb] Call C preprocessor with -P option (changed behaviour in GCC 4.5)

2011-01-03 Thread Ulrich Mueller
> On Mon, 03 Jan 2011, Adam Jackson wrote: > This looks like a safe change in that all the extant cpp's seem to > accept -P with the same semantics (checked gcc, mcpp, and Solaris). > But it leaks until exit, and it doesn't apply the -P if you do > xrdb -cpp foo, which seems wrong. Alternativ

Re: [PATCH 01/11] dix: Refactor block and wakup handlers

2011-01-03 Thread Alan Coopersmith
On 12/31/10 09:30 AM, Pauli wrote: > From: Pauli Nieminen > > It is common use case in server that only block or wakeup handler is > used. To provide API for that case block handlers have to be split to > separate structures. > > +extern _X_EXPORT Bool RegisterBlockHandler( > +BlockHandlerPr

Re: [PATCH 01/11] dix: Refactor block and wakup handlers

2011-01-03 Thread Daniel Stone
Hi, On Fri, Dec 31, 2010 at 07:30:59PM +0200, Pauli wrote: > -if (handlerDeleted) > +if (block.deleted) > { > - for (i = 0; i < numHandlers;) > - if (handlers[i].deleted) > - { > - for (j = i; j < numHandlers - 1; j++) > - handlers[j] =

Screen corrupted every 215th pixel

2011-01-03 Thread Oldřich Jedlička
Hi all, I have a really strange problem. I have every 215th column (in pixels) corrupted - when I draw two vertical lines with 214 pixels in between in Gimp and move the window on the desktop to the specific position, I don't see any line (the column is filled with the background color). I see

[PATCH 5/5] glx: validate numAttribs field before using it

2011-01-03 Thread Julien Cristau
Signed-off-by: Julien Cristau --- glx/glxcmds.c | 25 + glx/glxcmdsswap.c | 20 2 files changed, 45 insertions(+), 0 deletions(-) diff --git a/glx/glxcmds.c b/glx/glxcmds.c index 566dbbe..3ef567d 100644 --- a/glx/glxcmds.c +++ b/glx/glxcmds.c

[PATCH 4/5] glx: swap the request arrays entirely, not just half of them

2011-01-03 Thread Julien Cristau
Various glx request include a list of pairs of attributes. We were only swapping the first half. Signed-off-by: Julien Cristau --- glx/glxcmdsswap.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/glx/glxcmdsswap.c b/glx/glxcmdsswap.c index 9276e2f..87bf75b 100

[PATCH 3/5] glx: check request length before swapping

2011-01-03 Thread Julien Cristau
Signed-off-by: Julien Cristau --- glx/glxcmdsswap.c | 135 +++-- 1 files changed, 130 insertions(+), 5 deletions(-) diff --git a/glx/glxcmdsswap.c b/glx/glxcmdsswap.c index ce4d69a..9276e2f 100644 --- a/glx/glxcmdsswap.c +++ b/glx/glxcmdsswap.c @@

[PATCH 2/5] glx: validate request lengths

2011-01-03 Thread Julien Cristau
Reviewed-by: Adam Jackson Signed-off-by: Julien Cristau --- glx/glxcmds.c | 142 + glx/xfont.c |2 + 2 files changed, 135 insertions(+), 9 deletions(-) diff --git a/glx/glxcmds.c b/glx/glxcmds.c index 419cc46..566dbbe 100644 --- a/g

[PATCH 1/5] glx: make sure screen is non-negative in validGlxScreen

2011-01-03 Thread Julien Cristau
Reviewed-by: Adam Jackson Signed-off-by: Julien Cristau --- glx/glxcmds.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/glx/glxcmds.c b/glx/glxcmds.c index de9c3f0..419cc46 100644 --- a/glx/glxcmds.c +++ b/glx/glxcmds.c @@ -56,7 +56,7 @@ validGlxScreen(ClientPtr clien

[PATCH 0/5] glx input sanitizing

2011-01-03 Thread Julien Cristau
Most of this series has been sitting in bug#28823 for a while. It adds some missing checks for client-provided data in the glx code, and fixes a bug in the swapped-client path (patch 4/5). Cheers, Julien ___ xorg-devel@lists.x.org: X.Org development Ar

Re: [PATCH 00/11] Allow registering only wakeup or block handler

2011-01-03 Thread Pauli Nieminen
On 03/01/11 13:48 -0500, ext Adam Jackson wrote: > On Fri, 2010-12-31 at 19:30 +0200, Pauli wrote: > > > And I have to run combined x11perf -prop with this set and previous set: > > ync time adjustment is 0.1203 msecs. > > > > 6 reps @ 0.0896 msec ( 11200.0/sec): GetProperty > > 6 r

Re: [PATCH v2 5/6] composite: Support updating an arbitrary subtree

2011-01-03 Thread Keith Packard
On Mon, 3 Jan 2011 21:45:49 +0200, Ville Syrjälä wrote: > Indeed. compPaintWindowToParent + compPaintChildrenToWindow? > That would still leave compWindowUpdateAutomatic somewhat misnamed. > compPaintWindowToParentAutomatic would be quite a mouthful :) I suspect we could bikeshed this forever.

Re: [PATCH v2 5/6] composite: Support updating an arbitrary subtree

2011-01-03 Thread Ville Syrjälä
On Mon, Jan 03, 2011 at 09:21:40AM -0800, Keith Packard wrote: > On Mon, 3 Jan 2011 15:54:54 +0200, Ville Syrjälä > wrote: > > > How about this? Stills leaves the compChildrenUpdate name there > > though. > > Yeah, the structure looks good. I still don't like the names, as > compWindowUpdate pa

Re: [PATCH 00/11] Allow registering only wakeup or block handler

2011-01-03 Thread Adam Jackson
On Fri, 2010-12-31 at 19:30 +0200, Pauli wrote: > And I have to run combined x11perf -prop with this set and previous set: > ync time adjustment is 0.1203 msecs. > > 6 reps @ 0.0896 msec ( 11200.0/sec): GetProperty > 6 reps @ 0.0896 msec ( 11200.0/sec): GetProperty > 6 reps

Re: ebeam xinput driver : ask for review

2011-01-03 Thread Adam Jackson
On Wed, 2010-12-29 at 19:42 +0100, Yann Cantin wrote: > Hi, > > I've coded a xinput driver for ebeam device, and wanted to know if it's > possible to have it reviewed by someone. > > I'll provide more background info if it's of interest. Send a link to the source (or email it to the list if it'

Re: [PULL] Warning fixes, block handler cleanups, input misc

2011-01-03 Thread Keith Packard
On Mon, 3 Jan 2011 17:45:55 +, Daniel Stone wrote: > I'm happy to bear the brunt of his fury, and/or ply him with food and > drinks at LCA until he's sated; in any case, I'm not really sure when > he's back from holidays, so. As long as there's a promise of drinking, I'm good with it. Merged

Re: [PATCH xrdb] Call C preprocessor with -P option (changed behaviour in GCC 4.5)

2011-01-03 Thread Adam Jackson
On Tue, 2010-12-28 at 16:58 +0100, Ulrich Mueller wrote: > http://bugs.freedesktop.org/show_bug.cgi?id=32701 > http://bugs.gentoo.org/show_bug.cgi?id=347758 > > Signed-off-by: Ulrich Mueller This looks like a safe change in that all the extant cpp's seem to accept -P with the same semantics (che

Re: [PULL] Warning fixes, block handler cleanups, input misc

2011-01-03 Thread Daniel Stone
On Mon, Jan 03, 2011 at 09:03:42AM -0800, Keith Packard wrote: > On Mon, 3 Jan 2011 11:46:19 +, Daniel Stone wrote: > > Please pull the following set of warning fixes, the first round of > > Pauli's block handler changes, and a couple of reviewed input changes > > that were in Peter's for-keit

Re: [PATCH keyboard] Small fix include

2011-01-03 Thread Adam Jackson
On Tue, 2010-12-28 at 17:45 +0500, Alexandr Shadchin wrote: > Signed-off-by: Alexandr Shadchin Applied, thanks. - ajax signature.asc Description: This is a digitally signed message part ___ xorg-devel@lists.x.org: X.Org development Archives: http://l

Re: [PATCH keyboard] Removed unused code

2011-01-03 Thread Adam Jackson
On Tue, 2010-12-28 at 17:41 +0500, Alexandr Shadchin wrote: > Signed-off-by: Alexandr Shadchin Applied, thanks. - ajax signature.asc Description: This is a digitally signed message part ___ xorg-devel@lists.x.org: X.Org development Archives: http://l

Re: [PATCH] xlib: Initilize event type

2011-01-03 Thread Adam Jackson
On Thu, 2010-12-23 at 09:44 +1000, Peter Hutterer wrote: > On Wed, 22 Dec 2010 19:21:13 +0200, Pauli > wrote: > > Signed-off-by: Pauli Nieminen > > Reviewed-by: Peter Hutterer Applied, thanks. - ajax signature.asc Description: This is a digitally signed message part __

Re: [PATCH v2 5/6] composite: Support updating an arbitrary subtree

2011-01-03 Thread Keith Packard
On Mon, 3 Jan 2011 15:54:54 +0200, Ville Syrjälä wrote: > How about this? Stills leaves the compChildrenUpdate name there > though. Yeah, the structure looks good. I still don't like the names, as compWindowUpdate paints a window into its parent (updating the parent) and compChildrenUpdate upda

Re: [PULL] Warning fixes, block handler cleanups, input misc

2011-01-03 Thread Keith Packard
On Mon, 3 Jan 2011 11:46:19 +, Daniel Stone wrote: > Hi Keith, > Please pull the following set of warning fixes, the first round of > Pauli's block handler changes, and a couple of reviewed input changes > that were in Peter's for-keith branch. uhh. would peter prefer to have those coming fro

Re: [PATCH modular 3/4] build.sh: comment the supported systems and how they are detected

2011-01-03 Thread Alan Coopersmith
On 01/ 2/11 12:20 PM, Gaetan Nadon wrote: > On Solaris, uname -m would return x86_64 but never amd64, right? On Solaris, uname -m returns i386, since it's compatible with i386 ISA applications, even when running the 64-bit kernel. (Not changing uname output between 32-bit & 64-bit kernels was a

Re: [PATCH evdev] Don't update first_val and num_val if we don't have data (#32480)

2011-01-03 Thread Chase Douglas
On 12/22/2010 09:19 PM, Peter Hutterer wrote: > For touchpads, rel_queued may be on (due to abs to rel conversion) but the > delta for x/y is 0/0 on the first touch. Hence, we don't have any valuators > to post. The current results in a num_vals of -15 and a subsequent segfault > when the data is p

Re: [PATCH modular 4/4] build.sh: relocate the test for the AMD Geode 32 bit CPU

2011-01-03 Thread Dan Nicholson
On Sun, Jan 2, 2011 at 5:58 AM, Gaetan Nadon wrote: > Taking advantage of an exiting test for Linux. > The driver does not compile on 64 bit CPU as it contains > assembler code with 32 bit assumptions. > > Signed-off-by: Gaetan Nadon > --- >  build.sh |   17 - >  1 files changed,

[PULL] Warning fixes, block handler cleanups, input misc

2011-01-03 Thread Daniel Stone
Hi Keith, Please pull the following set of warning fixes, the first round of Pauli's block handler changes, and a couple of reviewed input changes that were in Peter's for-keith branch. The following changes since commit efcb63d0ce43f96d0ac02b6f4a480dfd2374fc84: Render: Fix 'comparing between d

xserver distcheck broken with and without --disable-devel-docs

2011-01-03 Thread Daniel Stone
Hi, So, the DMX doc stuff breaks distcheck quite badly. If I have --disable-devel-docs set in my ./configure run, I get: make[3]: Entering directory `/home/daniels/x/xorg/xserver/obj-amd64/hw/dmx/doc' GENdmx.txt GENscaled.txt make[3]: *** No rule to make target `html/annotated.html', n

Re: [RFC] [PATCH v2 10/12] [xserver] dix: Add facilities for client ID tracking.

2011-01-03 Thread Rami Ylimäki
On 12/31/2010 03:32 PM, Erkki Seppälä wrote: From: Rami Ylimäki An interface is provided for figuring out the PID and process name of a client. Make some existing functionality from SELinux and IA extensions available for general use. Signed-off-by: Rami Ylimäki Reviewed-by: Tiago Vignatti ---

Re: [PATCH v2 5/6] composite: Support updating an arbitrary subtree

2011-01-03 Thread Ville Syrjälä
On Fri, Dec 31, 2010 at 02:00:43PM -0800, ext Keith Packard wrote: > On Fri, 31 Dec 2010 16:49:38 +0200, ville.syrj...@nokia.com wrote: > > > WindowRec has a new member 'damagedDescendants' that is used to keep > > track of which subtrees need updating. When a window is damaged, > > 'damagedDescen

Re: [PATCH v2 4/6] composite: Add SourceValidate wrapper

2011-01-03 Thread Ville Syrjälä
On Fri, Dec 31, 2010 at 01:42:16PM -0800, ext Keith Packard wrote: > On Fri, 31 Dec 2010 16:49:37 +0200, ville.syrj...@nokia.com wrote: > > From: Ville Syrjälä > > > > When SourceValidate is performed on a window with IncludeInferiors > > sub-window mode, force an immediate update of all the auto

Re: [PATCH 1/3 (v3)] os: always check if client is local when connection is accepted

2011-01-03 Thread Daniel Stone
Hi, On Fri, Dec 31, 2010 at 12:52:25PM +0200, Pauli Nieminen wrote: > On Fri, Dec 31, 2010 at 11:55 AM, Daniel Stone wrote: > > LocalClient is used for all DRI2 requests that makes it frequently > > called function. Querying if connection is local or not takes 10-15us > > (on ARM) depending on ma

Re: [PATCH] Fix asprintf typo in commit d2c42b10

2011-01-03 Thread Daniel Stone
On Thu, Dec 30, 2010 at 04:08:48PM -0800, Alan Coopersmith wrote: > Reported-by: Jerome Carretero > Signed-off-by: Alan Coopersmith > Reviewed-by: Cyril Brulebois Reviewed-by: Daniel Stone I've merged this into my tree too. signature.asc Description: Digital signature __

Re: [PATCH v2 3/6] composite: Add GetImage wrapper

2011-01-03 Thread Daniel Stone
On Fri, Dec 31, 2010 at 04:49:36PM +0200, ville.syrj...@nokia.com wrote: > From: Ville Syrjälä > > When GetImage is performed on a window, force an immediate update of > all the automatically redirected windows, so that the current window > contents will be up to date. > > Signed-off-by: Ville S

Re: [RFC] [PATCH v2 1/12] [resourceproto] Added protocol description and records for XRes v1.2

2011-01-03 Thread Daniel Stone
Hi, Mainly nitpicks, I'm afraid ... On Fri, Dec 31, 2010 at 03:32:39PM +0200, Erkki Seppälä wrote: > +#define X_XResClientXidMask 0x01 > +#define X_XResLocalClientPidMask 0x02 Maybe make these XID and PID? > +typedef struct _XResClientIdSpec { > + CARD32 client B32; > + CARD32 mask B3

Re: [PATCH 5/9] dri1: warning fix

2011-01-03 Thread Daniel Stone
Hi, On Fri, Dec 31, 2010 at 12:28:30PM +0100, Mark Kettenis wrote: > > From: Adam Jackson > > > > dri.c: In function ‘DRIScreenInit’: > > dri.c:434: warning: cast from pointer to integer of different size > > Is just pacifying the compiler the right solution here? At least the > name of the va

Re: Trigger automatic redirection updates on GetImage and SourceValidate (v2)

2011-01-03 Thread Daniel Stone
On Fri, Dec 31, 2010 at 04:49:33PM +0200, ville.syrj...@nokia.com wrote: > Added the TraverseTree revert, and the src==dst SourceValidate patch > to the series. > > I also reoragnized the patchset so that patches 1-4 can be applied as a > quick fix. Patch 5 is then just an additional optimization

Re: [PATCH 6/9] xcmisc: warning fix

2011-01-03 Thread Daniel Stone
On Fri, Dec 31, 2010 at 12:29:57PM +0100, Mark Kettenis wrote: > > From: Daniel Stone > > Date: Fri, 31 Dec 2010 02:00:20 + > > > > From: Adam Jackson > > > > xcmisc.c:202: warning: no previous prototype for ‘XCMiscExtensionInit’ > > Sorry, but what's the point of the #if 1/#endif around t

Re: [PATCH v2 5/6] composite: Support updating an arbitrary subtree

2011-01-03 Thread Daniel Stone
On Fri, Dec 31, 2010 at 04:49:38PM +0200, ville.syrj...@nokia.com wrote: > From: Ville Syrjälä > > Rename compScreenUpdate to compChildrenUpdate, and pass a window as > the parameter. This allows an arbitrary subtree to be updated, instead > of having to update all the windows. This will be used

Re: [PATCH v2 4/6] composite: Add SourceValidate wrapper

2011-01-03 Thread Daniel Stone
On Fri, Dec 31, 2010 at 04:49:37PM +0200, ville.syrj...@nokia.com wrote: > From: Ville Syrjälä > > When SourceValidate is performed on a window with IncludeInferiors > sub-window mode, force an immediate update of all the automatically > redirected windows, so that the current window contents wil

Re: [PATCH v2 6/6] Call SourceValidate even if src == dst

2011-01-03 Thread Daniel Stone
On Fri, Dec 31, 2010 at 04:49:39PM +0200, ville.syrj...@nokia.com wrote: > From: Ville Syrjälä > > The extra SourceValidate calls from damageCopyArea and damageCopyPlane > can be removed. > > Signed-off-by: Ville Syrjälä Reviewed-by: Daniel Stone signature.asc Description: Digital signature

Re: [PATCH v2 1/6] Revert "composite: Convert compWindowUpdate to use TraverseTree"

2011-01-03 Thread Daniel Stone
On Fri, Dec 31, 2010 at 04:49:34PM +0200, ville.syrj...@nokia.com wrote: > From: Ville Syrjälä > > TraverseTree visits the parent before the children. When performing > the automatic redirection updates, the children must be visited before > the parent. > > If there are automatically redirected

Re: [PATCH v2 5/6] composite: Support updating an arbitrary subtree

2011-01-03 Thread Ville Syrjälä
On Fri, Dec 31, 2010 at 02:00:43PM -0800, ext Keith Packard wrote: > On Fri, 31 Dec 2010 16:49:38 +0200, ville.syrj...@nokia.com wrote: > > > WindowRec has a new member 'damagedDescendants' that is used to keep > > track of which subtrees need updating. When a window is damaged, > > 'damagedDescen

Re: Composite ClipNotify fix and expose event elimination (v2)

2011-01-03 Thread Ville Syrjälä
On Mon, Dec 27, 2010 at 03:24:09PM +0200, ville.syrj...@nokia.com wrote: > Patch 4/4 was modified to accomodate the review comments. The rest > remain unchanged. Were there still open issues with this set? -- Ville Syrjälä ___ xorg-devel@lists.x.org: X