Re: [PATCH 1.9.2.902 1/1] dix: GetPointerEvents: added valuator range checking

2011-01-24 Thread Jeremy Huddleston
Pushed: 089a510..188148e server-1.9-branch -> server-1.9-branch On Jan 24, 2011, at 16:34, Peter Hutterer wrote: > On Mon, Jan 24, 2011 at 10:03:30PM +0200, Oliver McFadden wrote: >> Button events may be sent with no valuators (e.g. to simply indicate >> ButtonPress or ButtonRelease without

Re: [PATCH] libtXt: add simple example for XtAppNextEvent() man page

2011-01-24 Thread Alan Coopersmith
On 01/24/11 05:16 AM, walter harms wrote: >> The bits in [] are to provide information to the e-mail readers, letting >> us know which module it's for, but are removed by git when applying the >> patch, leaving the rest of the subject line as the single line summary of >> the commit

Re: PendingBegin flag on XI_TouchMotionUnowned events?

2011-01-24 Thread Daniel Stone
On Tue, Jan 25, 2011 at 11:35:37AM +1000, Peter Hutterer wrote: > On Mon, Jan 24, 2011 at 12:25:25PM -0500, Chase Douglas wrote: > > We currently have a mechanism for clients selecting for unowned events > > to receive motion and finish events (through the PendingFinish flag). > > However, how does

Re: libX11.pdf not building -- soft-hyphens

2011-01-24 Thread Alan Coopersmith
On 01/24/11 05:19 PM, Matt Dew wrote: > Thanks Alan. I'd forgotten about that issue. > > I tracked down the problem, but I don't know how to fix it. > > In libX11/nls/Compose/el_GR.UTF-8.xml, on line 172: > action='seq'>Multi_keyminusminus"­ > " hyphen > > There's a character that looks l

Re: RawMotion events not delivered when a button is held down

2011-01-24 Thread Peter Hutterer
On Sun, Jan 23, 2011 at 03:27:31PM +0100, Philipp Reh wrote: > I have a client application that receives XI_RawMotion on its RootWindow. > This stops working if I hold a mouse button down and the mouse is > inside the client's window. > > Apparently, the server generates two RawMotion events per s

Re: PendingBegin flag on XI_TouchMotionUnowned events?

2011-01-24 Thread Peter Hutterer
On Mon, Jan 24, 2011 at 12:25:25PM -0500, Chase Douglas wrote: > We currently have a mechanism for clients selecting for unowned events > to receive motion and finish events (through the PendingFinish flag). > However, how does a non-owner know that a TouchBegin event isn't owned > yet? Should we m

Re: [PATCH xf86-input-evdev 3/3 v4] Add support for masked valuators

2011-01-24 Thread Peter Hutterer
On Mon, Jan 24, 2011 at 11:49:05AM -0500, Chase Douglas wrote: > With the X server now supporting masked valuators for XI2, enable > support in X evdev. > > Signed-off-by: Chase Douglas > --- > > Changes from v3: > - Fix a dumb copy/paste error preventing relative mode devices from working > (

Re: libX11.pdf not building -- soft-hyphens

2011-01-24 Thread Matt Dew
Thanks Alan. I'd forgotten about that issue. I tracked down the problem, but I don't know how to fix it. In libX11/nls/Compose/el_GR.UTF-8.xml, on line 172: action='seq'>Multi_keyminusminus"­ " hyphen There's a character that looks like a space between the literal tags. It's not actual

Re: [PATCH libXi] Fill in mods/group->effective in XIQueryPointer()

2011-01-24 Thread Peter Hutterer
On Mon, Jan 24, 2011 at 12:35:04PM +0100, carl...@gnome.org wrote: > From: Carlos Garnacho > > the other XIModifierState/XIGroupState fields are being set correctly, > but the "effective" field was being left as undefined memory. > --- > src/XIQueryPointer.c |3 +++ > 1 files changed, 3 inse

Re: [PATCH 1.9.2.902 1/1] dix: GetPointerEvents: added valuator range checking

2011-01-24 Thread Peter Hutterer
On Mon, Jan 24, 2011 at 10:03:30PM +0200, Oliver McFadden wrote: > Button events may be sent with no valuators (e.g. to simply indicate > ButtonPress or ButtonRelease without any coordinates); when this happens > the server would read uninitialized memory. > > ==== Conditional jump or move dep

Re: [PATCH 2/2] savage: Setup tiled surface registers in SavageEnterVT

2011-01-24 Thread Alex Deucher
On Mon, Jan 24, 2011 at 5:18 PM, Tormod Volden wrote: > On Sun, Jan 23, 2011 at 9:18 PM, Alex Deucher wrote: >> No, this is part of why UMS sucks.  During suspend the card is powered >> down, so on resume, the driver has to re-init everything.  All that >> has to happen in EnterVT.  All of your sa

Re: [PATCH 2/2] savage: Setup tiled surface registers in SavageEnterVT

2011-01-24 Thread Tormod Volden
On Sun, Jan 23, 2011 at 9:18 PM, Alex Deucher wrote: > No, this is part of why UMS sucks.  During suspend the card is powered > down, so on resume, the driver has to re-init everything.  All that > has to happen in EnterVT.  All of your savage patches look good to me: > > Reviewed-by: Alex Deucher

[PATCH 1.9.2.902 1/1] dix: GetPointerEvents: added valuator range checking

2011-01-24 Thread Oliver McFadden
Button events may be sent with no valuators (e.g. to simply indicate ButtonPress or ButtonRelease without any coordinates); when this happens the server would read uninitialized memory. ==== Conditional jump or move depends on uninitialised value(s) ====at 0x48E87E8: pixman_f_transform

PendingBegin flag on XI_TouchMotionUnowned events?

2011-01-24 Thread Chase Douglas
Hi Daniel, We currently have a mechanism for clients selecting for unowned events to receive motion and finish events (through the PendingFinish flag). However, how does a non-owner know that a TouchBegin event isn't owned yet? Should we mutate TouchBegin events to TouchMotionUnowned and set a Pen

[PATCH xserver xi2.1] Only check non-finished touches when finding indirect touch sprites

2011-01-24 Thread Chase Douglas
Should be squashed into big xi2.1 patch. Signed-off-by: Chase Douglas --- Xi/exevents.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/Xi/exevents.c b/Xi/exevents.c index fbe5912..96689e4 100644 --- a/Xi/exevents.c +++ b/Xi/exevents.c @@ -991,7 +991,8 @@ EnsureTouchSp

[PATCH xf86-input-evdev 3/3 v4] Add support for masked valuators

2011-01-24 Thread Chase Douglas
With the X server now supporting masked valuators for XI2, enable support in X evdev. Signed-off-by: Chase Douglas --- Changes from v3: - Fix a dumb copy/paste error preventing relative mode devices from working (See EvdevProcessValuators where one line change is delta[REL_X] -> delta[REL_Y

Re: [PATCH] libXt: add simple example for XtName man page

2011-01-24 Thread Alan Coopersmith
On 01/24/11 04:56 AM, walter harms wrote: > > > Am 23.01.2011 18:26, schrieb Alan Coopersmith: >>> @@ -134,7 +138,36 @@ Specifies the widget. >>> .SH DESCRIPTION >>> .ZN XtName >>> returns the widget's name. >>> + >>> +.SH EXAMPLE >>> + >>> +The example demonstrate the use. >> >> I'd just leav

Re: [PATCH] libtXt: add simple example for XtAppNextEvent() man page

2011-01-24 Thread walter harms
Am 24.01.2011 15:49, schrieb Gaetan Nadon: > On Mon, 2011-01-24 at 14:16 +0100, walter harms wrote: > >> >>> - The preferred subject line format would be: >>> [PATCH libXt] add simple example for XtAppNextEvent() man page >>> >> >> how can i get GIT to make a header like that ? >> > >

Re: supporting non-rectangular windows

2011-01-24 Thread Alan Coopersmith
On 01/24/11 03:34 AM, Prasanta Sadhukhan wrote: > Thanks for the information. Is there any link which shows an example of how to > use this APIs for example, if I want to create a rounded-rect window. See the oclock sources, which use the shape extension to draw a circular clock window: http://cg

Re: [PATCH] libtXt: add simple example for XtAppNextEvent() man page

2011-01-24 Thread Gaetan Nadon
On Mon, 2011-01-24 at 14:16 +0100, walter harms wrote: > > > - The preferred subject line format would be: > > [PATCH libXt] add simple example for XtAppNextEvent() man page > > > > how can i get GIT to make a header like that ? > The reviewers need to know for which component this p

Re: [PATCH] libXt add example for XtAppAddSignal man page

2011-01-24 Thread walter harms
Am 23.01.2011 18:38, schrieb Alan Coopersmith: > On 01/23/11 08:20 AM, walter harms wrote: >> @@ -181,13 +185,96 @@ and the flag is set to >> .ZN False >> just before the callback is invoked. >> .LP >> +the \fBXtSignalCallbackProc\fP is defined as follows: > > "The" should be capitalized and

Re: [PATCH] libtXt: add simple example for XtAppNextEvent() man page

2011-01-24 Thread walter harms
Am 23.01.2011 18:29, schrieb Alan Coopersmith: > Thanks for putting these together - I don't know enough about libXt to comment > on the code examples, but hopefully they'll help others. > > Some notes for all these patches: > > - please don't restore the old/obsolete CVS id tags that we have

Re: [PATCH] libXt: add simple example for XtName man page

2011-01-24 Thread walter harms
Am 23.01.2011 18:26, schrieb Alan Coopersmith: >> @@ -134,7 +138,36 @@ Specifies the widget. >> .SH DESCRIPTION >> .ZN XtName >> returns the widget's name. >> + >> +.SH EXAMPLE >> + >> +The example demonstrate the use. > > I'd just leave that line out, since it's obvious that's what the > exa

[PATCH libXi] Fill in mods/group->effective in XIQueryPointer()

2011-01-24 Thread carlosg
From: Carlos Garnacho the other XIModifierState/XIGroupState fields are being set correctly, but the "effective" field was being left as undefined memory. --- src/XIQueryPointer.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/XIQueryPointer.c b/src/XIQueryPointer

Re: supporting non-rectangular windows

2011-01-24 Thread Prasanta Sadhukhan
Thanks for the information. Is there any link which shows an example of how to use this APIs for example, if I want to create a rounded-rect window. I see we can only combine 2 regions [by XShapeCombineRegion] which is again a rectangle as the Region structure says typedef struct _XRegion { long

Re: [PATCH v3 4/6] xf86/xv: Fill color key on expose

2011-01-24 Thread Ville Syrjälä
On Thu, Jan 20, 2011 at 12:46:44AM +0200, ext Pauli wrote: > From: Pauli Nieminen > > If window gets exposed but clipboxes doesn't change drivers would avoid > color key fill. This makes XResizeWindo&co to lose colorkey if > background is painted. > > To help drivers to avoid filling colorkey fo

Re: [PATCH] VidMode: prevent crash with no modes

2011-01-24 Thread Chris Wilson
On Mon, 24 Jan 2011 11:20:12 +, Chris Wilson wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=14731 Having just hit this myself, I'd like to get this trivial patch reviewed and included in the rc. :) -Chris -- Chris Wilson, Intel Open Source Technology Centre __

[PATCH] VidMode: prevent crash with no modes

2011-01-24 Thread Chris Wilson
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=14731 Signed-off-by: Chris Wilson --- hw/xfree86/common/xf86VidMode.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/xfree86/common/xf86VidMode.c b/hw/xfree86/common/xf86VidMode.c index 1788fa1..c22243a 100644

Re: [PATCH 0/8] More warning fixes and build cleanups

2011-01-24 Thread Julien Cristau
On Sun, Jan 23, 2011 at 23:18:04 -0500, Adam Jackson wrote: > What it says on the box. > For the series, Reviewed-by: Julien Cristau Cheers, Julien ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: ht

supporting non-rectangular windows

2011-01-24 Thread Prasanta Sadhukhan
Hi I was wondering if X11 has any way of supporting/creating a non-rectangular window? Would this be really be only a call to a X API, or whether there are other issues to take into account, for example if X event delivery needs to be treated differently with non-rectangular windows? Thanks in ad

[PATCH] synaptics: detect corner tap using the initial touch position

2011-01-24 Thread Nicolas Cavalari
From: Nicolas Cavallari Currently, when detecting a tap release, the corner tap detection uses the current touch position to figure out which corner it corresponds. The problem is that, theoretically, there is no such position because there is no touch. It work in mosts cases because most touchpa

Re: supporting non-rectangular windows

2011-01-24 Thread Alan Coopersmith
On 01/23/11 11:13 PM, Prasanta Sadhukhan wrote: > Hi > > I was wondering if X11 has any way of supporting/creating a non-rectangular > window? http://www.x.org/releases/X11R7.6/doc/libXext/shapelib.html or http://www.x.org/releases/X11R7.6/doc/libXext/shapelib.pdf if you prefer PDF. --