Re: Spinning in _XReply

> 28 __XReply + 512 (in libX11.6.dylib) [0x6d50c0] > ... > 11 __XReply + 240 (in libX11.6.dylib) > [0x6d4fb0] I just took a quick look at xcb_io.c to see what _XReply is doing, and I doubt that it is reentrant.

[PATCH util-macros] XORG_WITH_XSLTPROC: add XSLT processor command line tool

The primary use will be for DocBook/XML cross links database generation. XSLT (Extensible Stylesheet Language Transformations) is a declarative, XML-based language used for the transformation of XML documents. The xsltproc command line tool is for applying XSLT stylesheets to XML documents. It is

[PATCH:xpr 2/3] Refactor invalid depth error reporting to allow printf format checking

Clears gcc warnings: x2jet.c: In function `validate_visual': x2jet.c:1053: warning: format not a string literal, argument types not checked x2jet.c:1055: warning: format not a string literal, argument types not checked x2jet.c:1057: warning: format not a string literal, argument types not checked x

[PATCH:xpr 3/3] Define pixel mask constant as unsigned long

Clears Sun Studio cc warning of: "x2jet.c", line 1681: warning: constant promoted to unsigned long Signed-off-by: Alan Coopersmith --- x2jet.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/x2jet.c b/x2jet.c index 2811f0f..e71441b 100644 --- a/x2jet.c +++ b/x2jet.c @@

[PATCH:xpr 1/3] Replace gcc noreturn & printf attributes with macros from

Adds dependency on x11proto 7.0.17 to get the definition of _X_NORETURN Signed-off-by: Alan Coopersmith --- configure.ac |2 +- x2jet.c |6 ++ 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index 5205339..d133052 100644 --- a/configure

Re: [PATCH libxkbcommon] Get rid of unneeded include.

On Sat, Jan 29, 2011 at 8:24 AM, Cyril Brulebois wrote: > There's no need for this xlib include: > |   YACC   xkbparse.c > |   CC     xkbparse.lo > | xkbparse.y:98:22: error: X11/Xlib.h: No such file or directory > > Signed-off-by: Cyril Brulebois Yes, thanks, applied. Kristian >  src/xkbcomp/

Re: [PATCH libX11] poll_for_response: Really handle xcb_poll_for_reply getting a reply.

On 01/18/11 02:02 PM, Pauli Nieminen wrote: > Cherry pick without conflicts from master to 1.3 branch. Pushed to libX11-1.3-branch If another release was to be cut from this branch, are there other fixes that should be cherry picked back? Perhaps: http://cgit.freedesktop.org/xorg/lib/libX11/co

Spinning in _XReply

I'm trying to figure out a spin that an XQuartz user reported seeing in emacs. The problem seems to boil down to two things: 1) XLoadQueryFont() is erroring for some reason (probably related to https://bugs.freedesktop.org/show_bug.cgi?id=28803) 2) emacs' error handler seems bugged. Is it leg

Re: [PATCH libxkbcommon] Get rid of unneeded include.

On Sat, 2011-01-29 at 14:24 +0100, Cyril Brulebois wrote: > There's no need for this xlib include: > | YACC xkbparse.c > | CC xkbparse.lo > | xkbparse.y:98:22: error: X11/Xlib.h: No such file or directory > > Signed-off-by: Cyril Brulebois > --- > src/xkbcomp/xkbparse.y |1 - > 1

[PATCH libxkbcommon] Get rid of unneeded include.

There's no need for this xlib include: | YACC xkbparse.c | CC xkbparse.lo | xkbparse.y:98:22: error: X11/Xlib.h: No such file or directory Signed-off-by: Cyril Brulebois --- src/xkbcomp/xkbparse.y |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/src/xkbcomp/xkbp

Re: [PATCH libxkbcommon] Check for x11 as well through pkg-config.

Gaetan Nadon (29/01/2011): > I recall some readings putting emphasis on the fact that the library > did not depend on libX11. > […] > Maybe this include is not necessary or there is an alternate > solution to not depend on X11. Ooh, thanks. This include indeed seems extraneous, removing it seems

Re: [PATCH libxkbcommon] Check for x11 as well through pkg-config.

On Sat, 2011-01-29 at 03:31 +0100, Cyril Brulebois wrote: > Otherwise, ./configure returns successfully while xkbparse.lo can fail > to build due to a missing include: > | YACC xkbparse.c > | CC xkbparse.lo > | xkbparse.y:98:22: error: X11/Xlib.h: No such file or directory > > Signed-of

Re: [PATCH:xprop 3/3] Use _X_NORETURN from xproto 7.0.17 instead of local check

On Fri, Jan 28, 2011 at 22:03:58 -0800, Alan Coopersmith wrote: > Signed-off-by: Alan Coopersmith > --- > configure.ac |2 +- > dsimple.h|9 - > 2 files changed, 5 insertions(+), 6 deletions(-) > Reviewed-by: Julien Cristau Cheers, Julien __

Re: [PATCH:xlsfonts 1/3] Remove unneeded Malloc function

On Fri, Jan 28, 2011 at 20:08:50 -0800, Alan Coopersmith wrote: > The only place it was called was in Realloc, if the initial pointer was > NULL, but ANSI C89 already guarantees realloc(NULL, size) will be handled > as malloc(size), so we don't need to handle that case ourselves. > > Signed-off-b

Re: [PATCH:xprop 2/3] Replace Copy_String() with strdup + error check

On Fri, Jan 28, 2011 at 22:03:57 -0800, Alan Coopersmith wrote: > Signed-off-by: Alan Coopersmith > --- > xprop.c | 25 +++-- > 1 files changed, 7 insertions(+), 18 deletions(-) > Reviewed-by: Julien Cristau Cheers, Julien ___

Re: [PATCH:xlsfonts 2/3] inline Realloc() at the one place it's called

On Fri, Jan 28, 2011 at 20:08:51 -0800, Alan Coopersmith wrote: > Signed-off-by: Alan Coopersmith > --- > dsimple.c | 15 --- > dsimple.h |1 - > xlsfonts.c |5 +++-- > 3 files changed, 3 insertions(+), 18 deletions(-) > Reviewed-by: Julien Cristau Cheers, Julien _

Re: [PATCH:xprop 1/3] inline Malloc & Realloc functions

On Fri, Jan 28, 2011 at 22:03:56 -0800, Alan Coopersmith wrote: > Since stdlib.h versions return void *, remove unneeded casts that > the wrappers needed. > > Signed-off-by: Alan Coopersmith > --- > dsimple.c | 24 > dsimple.h |2 -- > xprop.c | 26 +++

Re: [PATCH:xlsfonts 3/3] Use _X_NORETURN from xproto 7.0.17 instead of local check

On Fri, Jan 28, 2011 at 20:08:52 -0800, Alan Coopersmith wrote: > Signed-off-by: Alan Coopersmith > --- > configure.ac |5 + > dsimple.h|8 +++- > 2 files changed, 4 insertions(+), 9 deletions(-) > Reviewed-by: Julien Cristau Cheers, Julien

Re: [PATCH:xman 4/4] Use snprintf to PATH_MAX sized buffers to construct filenames

On Fri, Jan 28, 2011 at 11:14:00PM -0800, Alan Coopersmith wrote: > Simpler than trying to calculate the size to malloc. > > Could have used XtAsprintf() but didn't seem worth the dependency > for two simple calls with a standard, well-known maximum size. > > Signed-off-by: Alan Coopersmith > --

Re: [PATCH:xman 3/4] Convert more sprintf calls to snprintf

On Fri, Jan 28, 2011 at 11:13:59PM -0800, Alan Coopersmith wrote: > Previous conversion seems to have missed many calls right next to ones > that were converted to snprintf already > > Signed-off-by: Alan Coopersmith > --- > buttons.c |7 --- > handler.c | 18 +- > misc

Re: [PATCH:xman 2/4] Don't need to copy static strings to a buffer before calling PopupWarning

On Fri, Jan 28, 2011 at 11:13:58PM -0800, Alan Coopersmith wrote: > Signed-off-by: Alan Coopersmith > --- > handler.c | 12 +--- > misc.c| 20 > 2 files changed, 13 insertions(+), 19 deletions(-) Reviewed-by: Dirk Wallenstein -- Greetings, Dirk ___

Re: [PATCH:xman 1/4] Mark string argument to PopupWarning as a const char *

On Fri, Jan 28, 2011 at 11:13:57PM -0800, Alan Coopersmith wrote: > PopupWarning just copies the string into the message it displays, > via snprintf, and never writes to it. > > Signed-off-by: Alan Coopersmith > --- > man.h |2 +- > misc.c |2 +- > 2 files changed, 2 insertions(+), 2 de

Re: [PATCH:xinit] Merge adjacent if (timeout) blocks

On Fri, Jan 28, 2011 at 06:53:53PM -0800, Alan Coopersmith wrote: > Signed-off-by: Alan Coopersmith > --- > xinit.c |3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/xinit.c b/xinit.c > index 2b3842e..42ff008 100644 > --- a/xinit.c > +++ b/xinit.c > @@ -380,9 +380,8

Re: [PATCH] Add prototype for CheckDefaultMap().

On Fri, Jan 28, 2011 at 11:33:09PM +0100, Cyril Brulebois wrote: > Those warnings disappear accordingly: > | CC parseutils.lo > | parseutils.c:742: warning: no previous prototype for ‘CheckDefaultMap’ > | CC xkbscan.lo > | xkbscan.l: In function ‘XKBParseString’: > | xkbscan.l:220: warn