[PATCH:libXt 3/3] Shell.c: TopLevelSetValues ignores iconic state if shell not yet realized

2011-02-04 Thread Alan Coopersmith
Fix originally created by Leo Binchy for Sun to fix Solaris bug 1243761 The XmNiconic resource doesn't work Signed-off-by: Alan Coopersmith --- src/Shell.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/src/Shell.c b/src/Shell.c index ef6dad2..8a44651 100644 --- a/sr

[PATCH:libXt 2/3] GetResources: protect against underflow when type conversion fails

2011-02-04 Thread Alan Coopersmith
Fix originally created by Leo Binchy for Sun to fix Solaris bug 1211553: XtVaCreateManagedWidget with list of resources XtVaTypedArg cause core dump Signed-off-by: Alan Coopersmith --- src/Resources.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/Resources.c b/sr

[PATCH:libXt 1/3] Remove unused #ifdef UNALIGNED version of Xt macros & functions

2011-02-04 Thread Alan Coopersmith
Trying to outsmart the compiler and libc is a losing battle, but since UNALIGNED was never defined, we weren't even trying. Signed-off-by: Alan Coopersmith --- include/X11/IntrinsicI.h | 33 - src/Resources.c | 87 -- 2 fil

Re: --disable-nls

2011-02-04 Thread Alan Coopersmith
On 02/ 4/11 01:56 PM, Jeremy Huddleston wrote: > > On Feb 4, 2011, at 13:02, Gaetan Nadon wrote: > >> On Fri, 2011-02-04 at 10:25 -0800, Jeremy Huddleston wrote: >> >>> It looks like libXpm ... does not honor --disable-nls. >> ... > >> Never heard of it, did a bit a surfing. It is related to get

Re: --disable-nls

2011-02-04 Thread Gaetan Nadon
On Fri, 2011-02-04 at 13:56 -0800, Jeremy Huddleston wrote: > > Ah, so the '--disable-nls' configure option is actually from glib's m4 > macros, and a lot of projects picked it up. I'll see what I can do > about making a similar macro for util-macros that we can use, but my > m4 wizardry is a bi

Re: --disable-nls

2011-02-04 Thread Dan Nicholson
On Fri, Feb 4, 2011 at 1:56 PM, Jeremy Huddleston wrote: > > On Feb 4, 2011, at 13:02, Gaetan Nadon wrote: > >> On Fri, 2011-02-04 at 10:25 -0800, Jeremy Huddleston wrote: >> >>> It looks like libXpm ... does not honor --disable-nls. >> ... > >> Never heard of it, did a bit a surfing. It is relate

Re: [PATCH v3 2/3] config: Move Xlib-xcb to its own subdirectory.

2011-02-04 Thread Rami Ylimäki
2011/2/4 Gaetan Nadon You will need to rebase, file has changed since. > Sure. > -SUBDIRS = util xcms xlibi18n $(XKB_SUBDIRS) > +SUBDIRS = util xcms xlibi18n $(XKB_SUBDIRS) . xcb > > Can you explain why libX11 must be built before xcb subdir? > The commit text says it does not use any symbols

Re: --disable-nls

2011-02-04 Thread Jeremy Huddleston
On Feb 4, 2011, at 13:02, Gaetan Nadon wrote: > On Fri, 2011-02-04 at 10:25 -0800, Jeremy Huddleston wrote: > >> It looks like libXpm ... does not honor --disable-nls. > ... > Never heard of it, did a bit a surfing. It is related to getttext and > intltool which is used in libXpm only and inxlo

[PATCH xev] Show RandR events.

2011-02-04 Thread Michael Thayer
Signed-off-by: Michael Thayer --- I think the subject line says it all. I was wanting to see what RandR events clients were getting and saw that this was on the X.Org todo list. configure.ac |2 +- xev.c| 214 ++ 2 files chang

Re: [PATCH v3 libX11 3/3] config: Add --enable-checked-locks to catch missing XInitThreads calls.

2011-02-04 Thread Gaetan Nadon
On Fri, 2011-02-04 at 16:42 +0200, Rami Ylimäki wrote: > This change makes it possible to detect missing XInitThreads calls in > X clients. If a client hasn't called XInitThreads and enters a > critical section in Xlib concurrently, the client will be aborted with > a message informing about the m

Re: [PATCH v3 2/3] config: Move Xlib-xcb to its own subdirectory.

2011-02-04 Thread Gaetan Nadon
On Fri, 2011-02-04 at 16:42 +0200, Rami Ylimäki wrote: > This change makes it easier to use different compiler and linker flags > for libX11 and libX11-xcb. Also libX11-xcb doesn't depend on libX11 > anymore, because it's not using any of its symbols. > > Signed-off-by: Rami Ylimäki > --- > con

Re: --disable-nls

2011-02-04 Thread Gaetan Nadon
On Fri, 2011-02-04 at 10:25 -0800, Jeremy Huddleston wrote: > It looks like libXpm (and probably others, I just noticed now because > of a toolchain change) does not honor --disable-nls. Do you know how > wide spread this is throughout the modules? This seems like something > we should move into

--disable-nls

2011-02-04 Thread Jeremy Huddleston
Hey Gaetan, It looks like libXpm (and probably others, I just noticed now because of a toolchain change) does not honor --disable-nls. Do you know how wide spread this is throughout the modules? This seems like something we should move into util-macros. --Jeremy ./configure --prefix=/opt/X

Re: [PATCH evdev] Export device node as property.

2011-02-04 Thread Dan Nicholson
On Fri, Feb 4, 2011 at 6:24 AM, Peter Korsgaard wrote: >> "Dan" == Dan Nicholson writes: > > Hi, > >  >> The question is perhaps what the use case for this property is? To >  >> easily figure out what xinput id corresponds to a config entry in >  >> xorg.conf? The reason I wanted the property

Re: [PATCH 7/9] dri2: Send events only to known clients

2011-02-04 Thread Michel Dänzer
On Fre, 2011-02-04 at 16:38 +0200, Pauli Nieminen wrote: > On 04/02/11 10:44 +0100, ext Michel Dänzer wrote: > > On Don, 2011-02-03 at 19:48 +0200, Pauli wrote: > > > From: Pauli Nieminen > > > > > > If client disconnects and new client gets same id DRI2 events may end to > > > wrong client. DR

[PATCH v3 libX11 3/3] config: Add --enable-checked-locks to catch missing XInitThreads calls.

2011-02-04 Thread Rami Ylimäki
This change makes it possible to detect missing XInitThreads calls in X clients. If a client hasn't called XInitThreads and enters a critical section in Xlib concurrently, the client will be aborted with a message informing about the missing call. Enabling thread safety by default causes a minor p

[PATCH v3 2/3] config: Move Xlib-xcb to its own subdirectory.

2011-02-04 Thread Rami Ylimäki
This change makes it easier to use different compiler and linker flags for libX11 and libX11-xcb. Also libX11-xcb doesn't depend on libX11 anymore, because it's not using any of its symbols. Signed-off-by: Rami Ylimäki --- configure.ac|1 + src/Makefile.am |9 +++-- src/X

[PATCH v3 x11proto-core 1/3] Add xthread_trylock for detecting unsafe multihreaded Xlib usage.

2011-02-04 Thread Rami Ylimäki
Xlib can be configured with --enable-checked-locks option to check if it's called from multiple threads even though XInitThreads hasn't been called first. This detection is currently implemented with phtread_trylock. Signed-off-by: Rami Ylimäki Signed-off-by: Erkki Seppälä --- Xthreads.h |4

[PATCH v3 0/3] Allow detection of missing XInitThreads calls.

2011-02-04 Thread Rami Ylimäki
v1: The change initialized threads by default. Such feature allows unsafe X clients to work when they shouldn't. v2: Fixes problems in v1 and makes multithreaded X clients abort with an error message if they enter a critical section concurrently before XInitThreads is called. After the first XInit

Re: [PATCH 7/9] dri2: Send events only to known clients

2011-02-04 Thread Pauli Nieminen
On 04/02/11 10:44 +0100, ext Michel Dänzer wrote: > On Don, 2011-02-03 at 19:48 +0200, Pauli wrote: > > From: Pauli Nieminen > > > > If client disconnects and new client gets same id DRI2 events may end to > > wrong client. DRI2 reference list can be checked to see if the client > > still owns t

Re: [PATCH evdev] Export device node as property.

2011-02-04 Thread Peter Korsgaard
> "Dan" == Dan Nicholson writes: Hi, >> The question is perhaps what the use case for this property is? To >> easily figure out what xinput id corresponds to a config entry in >> xorg.conf? The reason I wanted the property was slightly different. As >> the xinput ids are not stable, I wa

Re: [PATCH evdev] Export device node as property.

2011-02-04 Thread Dan Nicholson
On Fri, Feb 4, 2011 at 5:17 AM, Peter Korsgaard wrote: >> "Peter" == Peter Hutterer writes: > > Hi, > >  >> I obviously like the concept, but this assumption basically breaks >  >> remote X. What I think we really need is a unique identifier for XI >  >> devices (to be able to reapply propert

Re: [PATCH 7/9] dri2: Send events only to known clients

2011-02-04 Thread Pauli Nieminen
On 04/02/11 13:34 +1100, ext Christopher James Halse Rogers wrote: > On Thu, 2011-02-03 at 19:48 +0200, Pauli wrote: > > From: Pauli Nieminen > > > > If client disconnects and new client gets same id DRI2 events may end to > > wrong client. DRI2 reference list can be checked to see if the client

Re: [PATCH evdev v3] Add third button emulation.

2011-02-04 Thread Benjamin Tissoires
I Peter, I did not made an exhaustive review, but at least, you can add my 'tested-by'. Thanks a lot for the work. Cheers, Benjamin On 02/04/2011 12:45 AM, Peter Hutterer wrote: New properties: "Evdev Third Button Emulation" → switch on/off "Evdev Third Button Emulation Timeout" → timeout u

Re: [PATCH evdev] Export device node as property.

2011-02-04 Thread Peter Korsgaard
> "Peter" == Peter Hutterer writes: Hi, >> I obviously like the concept, but this assumption basically breaks >> remote X. What I think we really need is a unique identifier for XI >> devices (to be able to reapply properties at next login), and with >> hotplugging, the device node isn't

Re: [PATCH 3/9] dri2: Change driver interface to support DRI2Drawable

2011-02-04 Thread Pauli Nieminen
On 04/02/11 13:33 +1100, ext Christopher James Halse Rogers wrote: > On Thu, 2011-02-03 at 19:48 +0200, Pauli wrote: > > From: Pauli Nieminen > > > > To let DRI2Drawable exists longer than Drawable driver has to use > > DRI2DrawablePtr to complete swaps and MSC waits. This allows DRI2 to > > clea

Re: [PATCH 5/9] dri2: Keep DRI2Drawable resource allocated until creator frees it

2011-02-04 Thread Pauli Nieminen
On 04/02/11 13:33 +1100, ext Christopher James Halse Rogers wrote: > On Thu, 2011-02-03 at 19:48 +0200, Pauli wrote: > > From: Pauli Nieminen > > > > EGLImage requires that image siblings stay valid until all of them has > > been freed. Base EGLImage is only required for creating new siblings. >

Re: [PATCH 7/9] dri2: Send events only to known clients

2011-02-04 Thread Michel Dänzer
On Don, 2011-02-03 at 19:48 +0200, Pauli wrote: > From: Pauli Nieminen > > If client disconnects and new client gets same id DRI2 events may end to > wrong client. DRI2 reference list can be checked to see if the client > still owns the DRI2Drawable. In the radeon driver, this was solved by inv

[PATCH 2/2] [libX11] xcms/cmsProp: don't deal with uninitialized values, fail instead

2011-02-04 Thread Erkki Seppälä
Properly handle the return value of XGetWindowProperty by considering if after the loop as well. Using freed pointer "prop_ret" There were numerous things wrong in how this function interacted with XGetWindowProperty. None of the local variables were initialized and remained that way if the call

[PATCH 1/2] [libX11] xcms/LRGB: don't double-free property_return

2011-02-04 Thread Erkki Seppälä
From: Ander Conselvan de Oliveira property_return was free'd before and in the case the conditional is true, the call to XcmsGetProperty failed which means that property_return wasn't set so there is no need to free it again. Double free of pointer "property_return" in call to "free" Reviewed-b

[PATCH 0/2] Last two libx11 static analysis fixes

2011-02-04 Thread Erkki Seppälä
Here are the final (I hope..) two LibX11 static analysis fixes. Thanks for perseverance! ;) The cmsProp patch was amended compared to the one posted earlier while the other is as-is (except for commit message). Ander Conselvan de Oliveira (1): xcms/LRGB: don't double-free property_return Erkk