[PATCH:xdm 5/5] greeter: Rename valueMask for xpm window to avoid shadowing argument

2011-02-19 Thread Alan Coopersmith
The Realize function names one of its arguments valueMask, so rename the local variable to xpmValueMask to reduce confusion and clear the gcc -Wshadow warning: Login.c: In function `Realize': Login.c:1901: warning: declaration of 'valueMask' shadows a parameter Login.c:1871: warning: shadowed decl

[PATCH:xdm 4/5] greeter: Remove unused extern dpy that is shadowed by local variables

2011-02-19 Thread Alan Coopersmith
Resolves these warnings from gcc -Wshadow: greet.c: In function `InitGreet': greet.c:244: warning: declaration of 'dpy' shadows a global declaration greet.c:146: warning: shadowed declaration is here greet.c: In function `CloseGreet': greet.c:326: warning: declaration of 'dpy' shadows a global decl

[PATCH:xdm 3/5] Remove forced cursor move for no-echo entry when echoPasswd not set

2011-02-19 Thread Alan Coopersmith
If you want to have it, for feedback that's visible to the user but harder to shoulder-surf, enable echoPasswd and set the echoPasswdChar to empty/space. Signed-off-by: Alan Coopersmith --- greeter/Login.c |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/greeter/Logi

[PATCH:xdm 2/5] Add echoPasswdChar resource to set character to display

2011-02-19 Thread Alan Coopersmith
Stop hardcoding it to '*'. Allows setting a resource with no value to display " " to advance the cursor without drawing text. Signed-off-by: Alan Coopersmith --- greeter/Login.c | 11 --- greeter/Login.h |2 ++ greeter/LoginP.h |4 +++- man/xdm.man |6 -- 4 fil

[PATCH:xdm 1/5] Delete some unused variables

2011-02-19 Thread Alan Coopersmith
auth.c: In function `DefineSelf': auth.c:1045: warning: unused variable `n' error.c: In function `Debug': error.c:116: warning: unused variable `buf' Signed-off-by: Alan Coopersmith --- xdm/auth.c |1 - xdm/error.c |2 -- 2 files changed, 0 insertions(+), 3 deletions(-) diff --git a/xd

Re: [PATCH] XDM: Fix FTBFS with gold or recent gcc releases.

2011-02-19 Thread Dan Nicholson
On Sat, Feb 19, 2011 at 11:35 AM, Alan Coopersmith wrote: > On 02/19/11 11:30 AM, Fernando Lemos wrote: >> On Sat, Feb 19, 2011 at 6:47 PM, Alan Coopersmith >> wrote: >>> On 02/19/11 10:28 AM, Mark Kettenis wrote: > Date: Sat, 19 Feb 2011 18:03:04 + > From: Fernando Lemos > >

Re: [PATCH] XDM: Fix missing linking dependency on -ldl.

2011-02-19 Thread Alan Coopersmith
On 02/19/11 01:51 PM, Gaetan Nadon wrote: > Have you checked there is no issue with adding this to BSD/MAC/Solaris > systems? > I would guess it cannot hurt. Won't hurt Solaris, as it will find dlopen is already in $LIBS (libc actually) and do nothing. Even if it added -ldl, that's just an ELF

Re: [PATCH] XDM: Fix missing linking dependency on -ldl.

2011-02-19 Thread Gaetan Nadon
On Sat, 2011-02-19 at 17:53 -0200, Fernando Tarlá Cardoso Lemos wrote: > Recent versions of GCC ship with a linker that doesn't add the deps > of the DSOs to the linking process. This behavior is also found in > GNU gold. This change fixes building with those linkers. > > Some references: > > ht

[PATCH] XDM: Fix missing linking dependency on -ldl.

2011-02-19 Thread Fernando Tarlá Cardoso Lemos
Recent versions of GCC ship with a linker that doesn't add the deps of the DSOs to the linking process. This behavior is also found in GNU gold. This change fixes building with those linkers. Some references: http://wiki.debian.org/ToolChain/DSOLinking https://fedoraproject.org/wiki/Understanding

Re: [PATCH] XDM: Fix FTBFS with gold or recent gcc releases.

2011-02-19 Thread Alan Coopersmith
On 02/19/11 11:30 AM, Fernando Lemos wrote: > On Sat, Feb 19, 2011 at 6:47 PM, Alan Coopersmith > wrote: >> On 02/19/11 10:28 AM, Mark Kettenis wrote: Date: Sat, 19 Feb 2011 18:03:04 + From: Fernando Lemos /usr/bin/ld: session.o: undefined reference to symbol 'dlclos

Re: [PATCH] XDM: Fix FTBFS with gold or recent gcc releases.

2011-02-19 Thread Fernando Lemos
On Sat, Feb 19, 2011 at 6:47 PM, Alan Coopersmith wrote: > On 02/19/11 10:28 AM, Mark Kettenis wrote: >>> Date: Sat, 19 Feb 2011 18:03:04 + >>> From: Fernando Lemos >>> >>> /usr/bin/ld: session.o: undefined reference to symbol 'dlclose@@GLIBC_2.2.5' >>> /usr/bin/ld: note: 'dlclose@@GLIBC_2.2.

Re: [PATCH] XDM: Fix FTBFS with gold or recent gcc releases.

2011-02-19 Thread Alan Coopersmith
On 02/19/11 10:28 AM, Mark Kettenis wrote: >> Date: Sat, 19 Feb 2011 18:03:04 + >> From: Fernando Lemos >> >> /usr/bin/ld: session.o: undefined reference to symbol 'dlclose@@GLIBC_2.2.5' >> /usr/bin/ld: note: 'dlclose@@GLIBC_2.2.5' is defined in DSO >> /lib64/libdl.so.2 so try adding it to the

Re: [PATCH] XDM: Fix FTBFS with gold or recent gcc releases.

2011-02-19 Thread Mark Kettenis
> Date: Sat, 19 Feb 2011 18:03:04 + > From: Fernando Lemos > > /usr/bin/ld: session.o: undefined reference to symbol 'dlclose@@GLIBC_2.2.5' > /usr/bin/ld: note: 'dlclose@@GLIBC_2.2.5' is defined in DSO > /lib64/libdl.so.2 so try adding it to the linker command line > /lib64/libdl.so.2: could

Re: [PATCH] XDM: Fix FTBFS with gold or recent gcc releases.

2011-02-19 Thread Fernando Lemos
On Sat, Feb 19, 2011 at 5:36 PM, Alan Coopersmith wrote: [...] > On 02/19/11 09:21 AM, Mikhail Gusarov wrote: >> >> Twas brillig at 09:19:24 19.02.2011 UTC-08 when >> alan.coopersm...@oracle.com did gyre and gimble: >> >>  AC> Neither of those explain what "FTBFS" means. >> >> "fails to build from

Re: [PATCH] XDM: Fix FTBFS with gold or recent gcc releases.

2011-02-19 Thread Alan Coopersmith
On 02/19/11 09:21 AM, Mikhail Gusarov wrote: > > Twas brillig at 09:19:24 19.02.2011 UTC-08 when > alan.coopersm...@oracle.com did gyre and gimble: > > AC> Neither of those explain what "FTBFS" means. > > "fails to build from source". First result of google://FTBFS gives you > this answer, by t

Re: [PATCH] XDM: Fix FTBFS with gold or recent gcc releases.

2011-02-19 Thread Mikhail Gusarov
Twas brillig at 09:19:24 19.02.2011 UTC-08 when alan.coopersm...@oracle.com did gyre and gimble: AC> Neither of those explain what "FTBFS" means. "fails to build from source". First result of google://FTBFS gives you this answer, by the way. -- http://fossarchy.blogspot.com/ pgp9cZHbBy8yi

Re: [PATCH] XDM: Fix FTBFS with gold or recent gcc releases.

2011-02-19 Thread Alan Coopersmith
On 02/19/11 08:51 AM, Fernando Tarlá Cardoso Lemos wrote: > Some references: > > http://wiki.debian.org/ToolChain/DSOLinking > https://fedoraproject.org/wiki/UnderstandingDSOLinkChange Neither of those explain what "FTBFS" means. (They mostly seem to explain that Linux is catching up to the lin

[PATCH] XDM: Fix FTBFS with gold or recent gcc releases.

2011-02-19 Thread Fernando Tarlá Cardoso Lemos
Some references: http://wiki.debian.org/ToolChain/DSOLinking https://fedoraproject.org/wiki/UnderstandingDSOLinkChange --- configure.ac |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 39a3655..13a2a58 100644 --- a/configure.ac +++ b/c

Re: xserver distcheck broken with and without --disable-devel-docs

2011-02-19 Thread Gaetan Nadon
On Sat, 2011-02-19 at 17:08 +0100, Cyril Brulebois wrote: > Gaetan Nadon (19/02/2011): > > The scenario in question is running distcheck in a VPATH build when > > doc generation is disabled which conflicts with the requirement of > > mandating generated docs in the tarball. > > > > This scenario

Re: xserver distcheck broken with and without --disable-devel-docs

2011-02-19 Thread Cyril Brulebois
Gaetan Nadon (19/02/2011): > The scenario in question is running distcheck in a VPATH build when > doc generation is disabled which conflicts with the requirement of > mandating generated docs in the tarball. > > This scenario does not affect distro/OS builds as far as I can tell. Out-of-tree bu

Re: xserver distcheck broken with and without --disable-devel-docs

2011-02-19 Thread Gaetan Nadon
On Sat, 2011-02-19 at 16:13 +0100, Julien Cristau wrote: > Did this get resolved? If not, can we please fix it before 1.10? > The short story is no. See the thread for the long story. The scenario in question is running distcheck in a VPATH build when doc generation is disabled which conflicts

Re: [PATCH libFS] Silence gcc warning.

2011-02-19 Thread Mark Kettenis
> Date: Sat, 19 Feb 2011 15:04:24 +0100 > From: Julien Cristau > > > diff --git a/test/FSGetErrorText.c b/test/FSGetErrorText.c > > index 31523c6..f9a88d2 100644 > > --- a/test/FSGetErrorText.c > > +++ b/test/FSGetErrorText.c > > @@ -40,7 +40,7 @@ CheckErrorMessage(FSServer *srv, int code, const

Re: xserver distcheck broken with and without --disable-devel-docs

2011-02-19 Thread Julien Cristau
On Mon, Jan 3, 2011 at 14:06:37 +, Daniel Stone wrote: > Hi, > So, the DMX doc stuff breaks distcheck quite badly. If I have > --disable-devel-docs set in my ./configure run, I get: > make[3]: Entering directory > `/home/daniels/x/xorg/xserver/obj-amd64/hw/dmx/doc' > GENdmx.txt > GE

Input drivers (was [ANNOUNCE] xorg-server 1.9.99.902 (1.10 RC2))

2011-02-19 Thread Cyril Brulebois
Hi, Keith Packard (18/02/2011): > Other than that, I think we're pretty much ready for the 1.10 > release. Let me know if you've got pending fixes that you want to > see merged in 1.10. Peter, could we please get a (pre)release for -synaptics? Latest release doesn't build with input ABI 12. (I c

Re: [PATCH] Revert "exa/mixed: Exclude frontbuffer from deferred pixmap handling."

2011-02-19 Thread Michel Dänzer
On Sam, 2011-02-19 at 14:49 +0100, Maarten Maathuis wrote: > This reverts commit 541b25038a5de74411a094570b407c5ae018c2ba. > > - It turns out that the high latency was a driver problem. > - catting a large amount of text turns out to look prettier when the > throughput is lower, but it's not wo

Re: [PATCH libFS] Silence gcc warning.

2011-02-19 Thread Julien Cristau
On Fri, Feb 18, 2011 at 21:17:12 +0100, Cyril Brulebois wrote: > Fix the build with CFLAGS="-Wall -Werror": > | CC FSGetErrorText.o > | cc1: warnings being treated as errors > | FSGetErrorText.c: In function ‘CheckErrorMessage’: > | FSGetErrorText.c:43: error: format ‘%d’ expects type ‘int’,

[PATCH] Revert "exa/mixed: Exclude frontbuffer from deferred pixmap handling."

2011-02-19 Thread Maarten Maathuis
This reverts commit 541b25038a5de74411a094570b407c5ae018c2ba. - It turns out that the high latency was a driver problem. - catting a large amount of text turns out to look prettier when the throughput is lower, but it's not worth the loss for a minor improvement that may not even exist on some