[PATCH:xscope] Greatly reduce xscope's bss pages

xscope had several static arrays of StaticMaxFD structures, which ended up in .bss sections. StaticMaxFD was initialized to FD_SETSIZE. On 32-bit Solaris, the default value FD_SETSIZE is 1024. On 64-bit Solaris, the FD_SETSIZE is 64k, due to the SPARCv9 ABI. One of the structures allocated incl

Re: [PATCH] input: properly align doubles in InitValuatorClassDeviceStruct

On Sat, 26 Feb 2011 00:00:39 +0100, Julien Cristau wrote: > Some architectures (hi, sparc!) are unhappy with unaligned memory > accesses. So make sure the axisVal member of ValuatorClassRec has > sizeof(double) alignment to avoid crashes and test failures. The 'standard' way to do this is to us

New Linux VT Keyboard Mode "Off"

Currently the linux-next branch of the linux kernel contains a patch to add a new vt keyboard mode "off." In this new mode all special kernel keys are ignored, like how they are ignored in raw mode, but no key events are buffered to the vt input buffer. The patch adding the new mode has been inclu

Re: [PULL] Server build fixes

On Fri, 25 Feb 2011 06:43:58 -0800, Dan Nicholson wrote: > Dan Nicholson (2): > xfree86: Allow sdksyms.dep to be included portably > dmx: Construct paths in doxygen.conf to fix VPATH builds Merged. 780a77a..6b951de master -> master -- keith.pack...@intel.com pgpOEr02XLbPd.pgp

Re: [PATCH] hw/xwin: Look for gl spec files in $(srcdir) or .

On Sat, 26 Feb 2011 00:19:45 +, Jon TURNEY wrote: > Anyhow, I fully accept this is less than ideal as it stands, and I'll try to > come up with something better for the future, as time permits. Argh. My first patch didn't work in the o-o-t build from tarball case (sigh). I've actually got a

Re: [PATCH xserver] EXA/mixed: ModifyPixmapHeader pitch fixes. (bug #33929)

Merged: 0e253a9..7b3b7ef server-1.9-branch -> server-1.9-branch On Feb 24, 2011, at 19:52, Cyril Brulebois wrote: > Keith Packard (24/02/2011): >> On Thu, 24 Feb 2011 12:17:57 +0100, Michel Dänzer wrote: >> >>> On the other hand, the system memory copy doesn't need the pitch >>> to be ali

Re: [PATCH] hw/xwin: Look for gl spec files in $(srcdir) or .

On 25/02/2011 18:58, Keith Packard wrote: > Tarballs include the downloaded gl spec files, which will end up in > $(srcdir). But, git-based builds will not have them at all and will > need to download them from opengl.org. They'll land in in the build > directory instead of $(srcdir), and so we nee

[PATCH setxkbmap; 3rd try] Consistent handling of memory allocation errors.

Macro `OOM' ("Out of memory") introduced for checking and reporting memory allocation errors. The same macro is used in all the cases. One check was missed in original source; fixed. Changes after patch review: 1. `OOM' macro uses `do ... while (0)'. 2. `exit(-1)', not `abort()'. Signed

Re: [PATCH setxkbmap; 2nd try] Consistent handling of memory allocation errors.

Got it. See the next version. On Fri, 2011-02-25 at 14:50 -0800, Alan Coopersmith wrote: > On 02/25/11 11:43 AM, Van de Bugger wrote: > > Macro `OOM' ("Out of memory") introduced for checking and reporting > > memory allocation errors. The same macro is used in all the cases. > > > > One check wa

Re: [PATCH] UMS: Fix build against xserver 1.10-rc3

Pushed. thanks. ecfdb209afe2aafc378baab8c511f5df7b000270 On Fri, Feb 25, 2011 at 3:48 PM, Sedat Dilek wrote: > This issue was introduced due to last minute backout of RandR-1.4 > in xserver 1.10-rc3. > > Switch to "#ifdef RANDR_14_INTERFACE" as suggested by Keith Packard. > See also

Re: [PATCH setxkbmap] Few messages added for easier troubleshooting.

On 02/25/11 12:38 PM, Van de Bugger wrote: > If setxkbmap fails to load rules file, it is not possible to find > out where setxkbmap looks for it. Increasing verbosity level does > not help: > > $ ./setxkbmap -v 10 > Setting verbose level to 10 > locale is C > Couldn't find rules f

[PATCH] input: properly align doubles in InitValuatorClassDeviceStruct

Some architectures (hi, sparc!) are unhappy with unaligned memory accesses. So make sure the axisVal member of ValuatorClassRec has sizeof(double) alignment to avoid crashes and test failures. X.Org bug#34742 Signed-off-by: Julien Cristau ---

Re: [PATCH setxkbmap; 2nd try] Consistent handling of memory allocation errors.

On 02/25/11 11:43 AM, Van de Bugger wrote: > Macro `OOM' ("Out of memory") introduced for checking and reporting > memory allocation errors. The same macro is used in all the cases. > > One check was missed in original source; fixed. > > Signed-off-by: Van de Bugger > --- > setxkbmap.c | 27 +

Re: [PATCH] vbe: Fix malloc size bug

On 02/25/11 10:08 AM, Adam Jackson wrote: > v2: Slightly more obvious sizing math. > > ==14882== Invalid write of size 2 > ==14882==at 0x6750267: VBEGetVBEInfo (vbe.c:400) > ==14882==by 0x6142064: ??? (in > /usr/lib64/xorg/modules/drivers/vesa_drv.so) > ==14882==by 0x471895: InitOutpu

[PATCH setxkbmap] Minor style changes in help message.

1. `args' renamed to `options'. (xkbcomp and gcc name these entities `options'). 2. `Where legal args are:' replaced with `Options:'. (Short and correct. As I remember, GNU does not recommend to use word `legal' unless it related to law and lawyers). 3. Option descriptions shifted ri

[PATCH] UMS: Fix build against xserver 1.10-rc3

This issue was introduced due to last minute backout of RandR-1.4 in xserver 1.10-rc3. Switch to "#ifdef RANDR_14_INTERFACE" as suggested by Keith Packard. See also . Note: The ddx needs a rebuild as the X video driver ABI changed

[PATCH setxkbmap] Few messages added for easier troubleshooting.

If setxkbmap fails to load rules file, it is not possible to find out where setxkbmap looks for it. Increasing verbosity level does not help: $ ./setxkbmap -v 10 Setting verbose level to 10 locale is C Couldn't find rules file (evdev) The problem fixed by adding two messages: befo

[PATCH setxkbmap; 2nd try] Consistent handling of memory allocation errors.

Macro `OOM' ("Out of memory") introduced for checking and reporting memory allocation errors. The same macro is used in all the cases. One check was missed in original source; fixed. Signed-off-by: Van de Bugger --- setxkbmap.c | 27 +-- 1 files changed, 9 insertions(+

[PATCH synaptics] Fix build on BSD

local was renamed to pInfo in 81ad2e389d11691d5c2687d83150e8e9033cfe76, but a couple places were missed. Signed-off-by: Julien Cristau --- src/psmcomm.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Failed build log at https://buildd.debian.org/fetch.cgi?pkg=xserver-xorg-input-s

Re: [PULL] Server build fixes

On Fri, 2011-02-25 at 11:02 -0800, Keith Packard wrote: > Right, this fails only when building out-of-tree directly from git, > not > From a tarball. > The doxygen generated html files are stuffed in the tarball. Doxygen is not invoked when building from a tarball. signature.asc Description:

Re: [PULL] Server build fixes

On Fri, 25 Feb 2011 18:03:44 +, Daniel Stone wrote: > Try doing the initial ./configure from out-of-tree: it should fail > then. Right, this fails only when building out-of-tree directly from git, not From a tarball. The fix isn't perfect -- there's a missing dependency issue which can be s

[PATCH] hw/xwin: Look for gl spec files in $(srcdir) or .

Tarballs include the downloaded gl spec files, which will end up in $(srcdir). But, git-based builds will not have them at all and will need to download them from opengl.org. They'll land in in the build directory instead of $(srcdir), and so we need to allow them to be in either place. This chang

Re: [PULL] Server build fixes

On Fri, 2011-02-25 at 08:59 -0800, Keith Packard wrote: > So, I'm a bit confused here -- I do 'make distcheck' to build > releases, > and it works for me. I'd like to know how I can test this patch to > make > sure it does what you expect. > The failing scenario involves builds where srcdir != b

Re: [PATCH] vbe: Fix malloc size bug

> From: Adam Jackson > Date: Fri, 25 Feb 2011 13:08:59 -0500 > > v2: Slightly more obvious sizing math. > > ==14882== Invalid write of size 2 > ==14882==at 0x6750267: VBEGetVBEInfo (vbe.c:400) > ==14882==by 0x6142064: ??? (in > /usr/lib64/xorg/modules/drivers/vesa_drv.so) > ==14882==

Re: [PATCH:mkfontscale 2/2] makeList: free partially allocated list on failure

On Thu, Feb 24, 2011 at 23:38:45 -0800, Alan Coopersmith wrote: > Error: Memory leak (CWE 401) >Memory leak of pointer 'first' allocated with malloc(8) > at line 192 of list.c in function 'makeList'. > 'first' allocated at line 181 with malloc(8). > first leaks when

Re: [PATCH:mkfontscale 1/2] Leave room for null terminator in file & font name arrays

On Thu, Feb 24, 2011 at 23:38:44 -0800, Alan Coopersmith wrote: > fscanf %s arguments don't include the trailing \0 byte in their counts. > > Error: Buffer overrun >Buffer overflow (CWE 120): Use of fscanf(%1024[), with buffer 'font' > Array size is 1024 bytes > at line 707 of m

Re: [PATCH] vbe: Fix malloc size bug

On Fri, Feb 25, 2011 at 13:08:59 -0500, Adam Jackson wrote: > v2: Slightly more obvious sizing math. > > ==14882== Invalid write of size 2 > ==14882==at 0x6750267: VBEGetVBEInfo (vbe.c:400) > ==14882==by 0x6142064: ??? (in > /usr/lib64/xorg/modules/drivers/vesa_drv.so) > ==14882==by

[PATCH] vbe: Fix malloc size bug

v2: Slightly more obvious sizing math. ==14882== Invalid write of size 2 ==14882==at 0x6750267: VBEGetVBEInfo (vbe.c:400) ==14882==by 0x6142064: ??? (in /usr/lib64/xorg/modules/drivers/vesa_drv.so) ==14882==by 0x471895: InitOutput (xf86Init.c:519) ==14882==by 0x422778: main (main.c

Re: [PULL] Server build fixes

On Fri, Feb 25, 2011 at 09:53:00AM -0800, Keith Packard wrote: > On Fri, 25 Feb 2011 18:04:56 +0100, Cyril Brulebois wrote: > > Keith Packard (25/02/2011): > > > So, I'm a bit confused here -- I do 'make distcheck' to build > > > releases, and it works for me. I'd like to know how I can test this

Re: [PULL] Server build fixes

On Fri, 25 Feb 2011 18:04:56 +0100, Cyril Brulebois wrote: > Keith Packard (25/02/2011): > > So, I'm a bit confused here -- I do 'make distcheck' to build > > releases, and it works for me. I'd like to know how I can test this > > patch to make sure it does what you expect. > > Do you end up bui

Re: [PULL] Server build fixes

Keith Packard (25/02/2011): > So, I'm a bit confused here -- I do 'make distcheck' to build > releases, and it works for me. I'd like to know how I can test this > patch to make sure it does what you expect. Do you end up building with devel docs, so with doxygen support when you're running make

Re: [PULL] Server build fixes

On Fri, 25 Feb 2011 06:43:58 -0800, Dan Nicholson wrote: > dmx: Construct paths in doxygen.conf to fix VPATH builds > > The paths in doxygen.conf assumed that srcdir=builddir and broke > otherwise. Use autoconf to fill in the paths to the srcdir so that the > files can be found

Re: Spinning in _XReply

On 25 February 2011 14:39, Daniel Stone wrote: > On Fri, Feb 25, 2011 at 03:18:37PM +0200, Rami Ylimäki wrote: >> On 02/25/2011 02:48 PM, Daniel Stone wrote: >> >On Fri, Feb 25, 2011 at 02:08:38PM +0200, Rami Ylimäki wrote: >> >>Documentation of "C.2.1 XInitExtension" from Xlib manual says that >>

Re: Spinning in _XReply

On 02/25/2011 02:48 PM, Daniel Stone wrote: On Fri, Feb 25, 2011 at 02:08:38PM +0200, Rami Ylimäki wrote: On 02/23/2011 04:35 PM, Michal Suchanek wrote: X server seems to preserve the extension codes until the server is regenerated and therefore all connections should use the same codes. Is t

Re: Spinning in _XReply

On Fri, Feb 25, 2011 at 03:18:37PM +0200, Rami Ylimäki wrote: > On 02/25/2011 02:48 PM, Daniel Stone wrote: > >On Fri, Feb 25, 2011 at 02:08:38PM +0200, Rami Ylimäki wrote: > >>Documentation of "C.2.1 XInitExtension" from Xlib manual says that > >>the Xlib specific extension number in XExtCodes is

[PULL] Server build fixes

The following changes since commit 780a77acce1dd369549ece802b3e2c4006058dfe: Version bumped to 1.9.99.903 (1.10 RC3) (2011-02-24 20:45:46 -0800) are available in the git repository at: git://people.freedesktop.org/~dbn/xserver build-fixes Dan Nicholson (2): xfree86: Allow sdksyms.dep t

Re: Spinning in _XReply

On Fri, Feb 25, 2011 at 02:08:38PM +0200, Rami Ylimäki wrote: > On 02/23/2011 04:35 PM, Michal Suchanek wrote: > >>X server seems to preserve the extension codes until the server is > >>regenerated and therefore all connections should use the same codes. > >> > >Is that guaranteed by some protocol

Re: [PULL xserver] Composite ClipNotify fix and expose event elimination

On Thu, Feb 24, 2011 at 07:17:28PM -0800, ext Keith Packard wrote: > On Thu, 24 Feb 2011 17:38:53 +0200, Ville Syrjälä > wrote: > > > Ville Syrjälä (4): > > composite: Call ValidateGC after ChangeGC > > composite: Initialize borderClip with current values > > I'm good with merging t

Re: Spinning in _XReply

On 02/23/2011 04:35 PM, Michal Suchanek wrote: X server seems to preserve the extension codes until the server is regenerated and therefore all connections should use the same codes. Is that guaranteed by some protocol or does it just happen to work as the requests in error handler did? This