Re: RandR 1.4 restart

2011-03-09 Thread Pauli Nieminen
On Tue, Mar 8, 2011 at 4:13 PM, Soeren Sandmann sandm...@cs.au.dk wrote: James Jones jajo...@nvidia.com writes: Interesting.  I'm not really sold on the switch to InputOnly windows though. It sounds very elegant in theory, but I don't like the idea of apps needing to use a separate codepath

Re: [PATCH 2/3] dix: Shrink PropertyRec on LP64

2011-03-09 Thread Daniel Stone
On Tue, Mar 08, 2011 at 03:17:09PM -0500, Adam Jackson wrote: On Tue, 2011-03-08 at 19:37 +, Daniel Stone wrote: Being really pedantic again, can't these two be uint8_t or something? You've just grown format from 16 to 32 bytes. :P size pretty much needs to be uint32_t,

[PATCH xrandr] xrandr: dump configuration in parsable format

2011-03-09 Thread Stefan Tomanek
This patch adds the command line switch --dump to the xrandr program. When specified, xrandr outputs the current display configuration in an easily parsable format similar to the command line options accepted by xrandr itself. That way, an existing configuration can easily be saved and restored

[PATCH] [xorg/xserver] mi/misprite: release private record

2011-03-09 Thread Erkki Seppälä
The record allocated by miSpriteDeviceCursorInitialize was not being released. This patch adds a call to free and resetting the private record to miSpriteDeviceCursorCleanup. Reviewed-by: Rami Ylimäki rami.ylim...@vincit.fi Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi --- mi/misprite.c |

[PATCH xserver] xkb: Initialize pad bytes sent in replies of geometry requests.

2011-03-09 Thread Rami Ylimäki
Valgrind complains about uninitialized data being written to clients. Reviewed-by: Erkki Seppälä erkki.sepp...@vincit.fi Signed-off-by: Rami Ylimäki rami.ylim...@vincit.fi --- xkb/xkb.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/xkb/xkb.c b/xkb/xkb.c

Re: [PATCH xserver] xkb: Initialize pad bytes sent in replies of geometry requests.

2011-03-09 Thread Daniel Stone
On Wed, Mar 09, 2011 at 03:45:40PM +0200, Rami Ylimäki wrote: Valgrind complains about uninitialized data being written to clients. Reviewed-by: Erkki Seppälä erkki.sepp...@vincit.fi Signed-off-by: Rami Ylimäki rami.ylim...@vincit.fi Reviewed-by: Daniel Stone dan...@fooishbar.org

Re: [PATCH] [xorg/xserver] mi/misprite: release private record

2011-03-09 Thread Daniel Stone
Hi, On Wed, Mar 09, 2011 at 03:42:14PM +0200, Erkki Seppälä wrote: The record allocated by miSpriteDeviceCursorInitialize was not being released. This patch adds a call to free and resetting the private record to miSpriteDeviceCursorCleanup. Reviewed-by: Rami Ylimäki rami.ylim...@vincit.fi

[PATCH 1/1] randr: avoid rrGetScreenResources replying with uninitialized bytes.

2011-03-09 Thread Oliver McFadden
==== Syscall param writev(vector[...]) points to uninitialised byte(s) ====at 0x4AB7054: writev (writev.c:51) ====by 0x5E237: _XSERVTransWritev (Xtrans.c:912) ====by 0x6154B: FlushClient (io.c:937) ====by 0x61FFF: FlushAllOutput (io.c:681) ====by

Re: [PATCH 1/1] randr: avoid rrGetScreenResources replying with uninitialized bytes.

2011-03-09 Thread Daniel Stone
On Wed, Mar 09, 2011 at 04:02:11PM +0200, Oliver McFadden wrote: ==== Syscall param writev(vector[...]) points to uninitialised byte(s) ====at 0x4AB7054: writev (writev.c:51) ====by 0x5E237: _XSERVTransWritev (Xtrans.c:912) ====by 0x6154B: FlushClient (io.c:937)

Re: [PATCH] [xorg/xserver] mi/misprite: release private record

2011-03-09 Thread Erkki Seppala
On 09.03.2011 15:57, Daniel Stone wrote: You could get this automatically by having miSpriteDevPrivatesKey allocate sizeof(miCursorInfoRec), rather than doing the allocation and free separately. Thanks for the feedback! I considered this with Rami, but it appeared that it uses the NULLness

Re: [PATCH] [xorg/xserver] mi/misprite: release private record

2011-03-09 Thread Daniel Stone
Hi, On Wed, Mar 09, 2011 at 04:19:06PM +0200, Erkki Seppala wrote: On 09.03.2011 15:57, Daniel Stone wrote: You could get this automatically by having miSpriteDevPrivatesKey allocate sizeof(miCursorInfoRec), rather than doing the allocation and free separately. Thanks for the feedback!

[PATCH v2] [xorg/xserver] mi/misprite: use memory management provided by dixRegisterPrivateKey

2011-03-09 Thread Erkki Seppälä
The record allocated by miSpriteDeviceCursorInitialize was not being released. This patch makes misprite use dixRegisterPrivateKey with the record size argument, which handles the memory management issues. miSpriteDeviceCursorInitialize is restructured to initialize pCursorInfo only if

Re: [PATCH v2] [xorg/xserver] mi/misprite: use memory management provided by dixRegisterPrivateKey

2011-03-09 Thread Erkki Seppala
Oops, I intended to send this to you instead of just Keith and the list - too fast with command line history - I hope you notice it at least this way. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info:

Re: [PATCH v2] [xorg/xserver] mi/misprite: use memory management provided by dixRegisterPrivateKey

2011-03-09 Thread Daniel Stone
Hi, On Wed, Mar 09, 2011 at 05:29:14PM +0200, Erkki Seppälä wrote: The record allocated by miSpriteDeviceCursorInitialize was not being released. This patch makes misprite use dixRegisterPrivateKey with the record size argument, which handles the memory management issues.

[PATCH] Remove geometry arguments from miSourceValidate()

2011-03-09 Thread Søren Sandmann
From: Søren Sandmann Pedersen s...@redhat.com The only user of the geometry coordinates is the software sprite code, which uses them to remove the pointer whenever the window beneath is being used as a source. However, using Window pictures as a source is extremely rare (let alone *partial*

Re: [PATCH 2/5] panoramiX: convert 0-panoramiXNumScreens loops to macro

2011-03-09 Thread Alan Coopersmith
On 03/ 8/11 09:29 PM, Dave Airlie wrote: From: Dave Airlie airl...@redhat.com This just uses the FOR_NSCREENS macro instead. Looks like a couple of the 1-n loop conversions to FOR_NSCREENS_FORWARD_SKIP snuck in from patch 3 as well: @@ -740,7 +740,7 @@ PanoramiXMaybeAddDepth(DepthPtr

Re: [PATCH 4/5] panoramiX: use RESTYPE instead of unsigned long

2011-03-09 Thread Alan Coopersmith
On 03/ 8/11 09:29 PM, Dave Airlie wrote: From: Dave Airlie airl...@redhat.com unsigned long seems like the wrong type to use here, switch to using RESTYPE. Signed-off-by: Dave Airlie airl...@redhat.com Looks like a duplicate of ajax's patch a few days earlier:

Re: [PATCH 4/5] panoramiX: use RESTYPE instead of unsigned long

2011-03-09 Thread Dave Airlie
On Thu, Mar 10, 2011 at 4:59 AM, Alan Coopersmith alan.coopersm...@oracle.com wrote: On 03/ 8/11 09:29 PM, Dave Airlie wrote: From: Dave Airlie airl...@redhat.com unsigned long seems like the wrong type to use here, switch to using RESTYPE. Signed-off-by: Dave Airlie airl...@redhat.com

Re: [PATCH] panoramiX: macro checking if drawable is root (v2)

2011-03-09 Thread Peter Hutterer
On Wed, Mar 09, 2011 at 04:04:49PM +1000, Dave Airlie wrote: From: Dave Airlie airl...@redhat.com this code appears in quite a few places, consolidate it into a macro in a header. v2: align braces with macro just above it, and with lines removed Signed-off-by: Dave Airlie

Re: [PULL] xserver-next, 2011-03-08

2011-03-09 Thread Keith Packard
On Tue, 08 Mar 2011 13:52:45 -0500, Adam Jackson a...@nwnk.net wrote: Adam Jackson (14): vbe: Fix malloc size bug dix: Remove usage_hint from pixmaps, store it in -drawable.class dix: Remove deprecated.c dix: Remove PIXEL typedef xv: Use RESTYPE where

Re: [PATCH 5/8] xinerama: Use RESTYPE consistently

2011-03-09 Thread Dave Airlie
On Tue, Mar 8, 2011 at 2:28 AM, Adam Jackson a...@redhat.com wrote: No functional change Signed-off-by: Adam Jackson a...@redhat.com Reviewed-by: Dave Airlie airl...@redhat.com since I just posted nearly the exact same patch. Dave. ___

Re: [PULL] xserver-next, 2011-03-08

2011-03-09 Thread Adam Jackson
On 3/9/11 5:20 PM, Keith Packard wrote: On Tue, 08 Mar 2011 13:52:45 -0500, Adam Jacksona...@nwnk.net wrote: Adam Jackson (14): vbe: Fix malloc size bug dix: Remove usage_hint from pixmaps, store it in -drawable.class dix: Remove deprecated.c dix: Remove PIXEL

[PATCH 1/3] panoramiX: consolidate common id assignment code.

2011-03-09 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com This adds a new FOR_NSCREENS_FORWARD_SKIP, which skips the first element and is a common idiom throughout panoramiX code. It then adds a new inline function to hide id assignment to a panoramiX resource and cleans up lots of common repeated code.

[PATCH 2/3] panoramiX: convert 0-panoramiXNumScreens loops to macro (v2)

2011-03-09 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com This just uses the FOR_NSCREENS macro instead. also convert one num - 1 - 0 loop. v2: remove some of the 1-x loops. Signed-off-by: Dave Airlie airl...@redhat.com --- Xext/panoramiX.c | 10 +- Xext/panoramiXprocs.c |2 +- Xext/saver.c

[PATCH 3/3] panoramiX: convert 1-panoramiXNumScreens loops to use macro (v2)

2011-03-09 Thread Dave Airlie
From: Dave Airlie airl...@redhat.com This converts all the remaining 1-num loops to the macro, this removes nearly all the panoramiXNumScreens usage in loops, and is a step to replacing it. v2: move some from the other patch. Signed-off-by: Dave Airlie airl...@redhat.com --- Xext/panoramiX.c

Re: [PATCH xserver] xkb: Initialize pad bytes sent in replies of geometry requests.

2011-03-09 Thread Peter Hutterer
On Wed, Mar 09, 2011 at 03:45:40PM +0200, Rami Ylimäki wrote: Valgrind complains about uninitialized data being written to clients. Reviewed-by: Erkki Seppälä erkki.sepp...@vincit.fi Signed-off-by: Rami Ylimäki rami.ylim...@vincit.fi merged, thanks. Cheers, Peter --- xkb/xkb.c | 12

Re: panoramiX: repost 3 patches post-review

2011-03-09 Thread Alan Coopersmith
On 03/ 9/11 03:23 PM, Dave Airlie wrote: This is a repost of the 3 unreviewed patches post comments by Alan. I've dropped the patch I overlapped with ajax. For the series: Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com -- -Alan Coopersmith-

Re: [PATCH 2/3] panoramiX: convert 0-panoramiXNumScreens loops to macro (v2)

2011-03-09 Thread Daniel Stone
Hi, On Thu, Mar 10, 2011 at 09:23:34AM +1000, Dave Airlie wrote: diff --git a/Xext/saver.c b/Xext/saver.c index 1888603..492a54f 100644 --- a/Xext/saver.c +++ b/Xext/saver.c @@ -1288,7 +1288,7 @@ ProcScreenSaverUnsetAttributes (ClientPtr client) if (rc != Success)

Re: [libXt:PATCH] XtAsprintf: Fix memory corruption.

2011-03-09 Thread Alan Coopersmith
On 03/ 8/11 01:14 PM, Alan Coopersmith wrote: On 03/ 8/11 07:09 AM, Cyril Brulebois wrote: Don't write the null terminator to a random place, this can trigger some segfault in XtOpenDisplay() and other annoyances. -new_string[len] = '\0'; +(*new_string)[len] = '\0'; Oops! Sorry.

Re: [PULL] xserver-next, 2011-03-08

2011-03-09 Thread Jeremy Huddleston
/facepalm fix applied to both 1.9 and 1.10: 424..8ffaef2 server-1.9-branch - server-1.9-branch 3550396..0ab680f server-1.10-branch - server-1.10-branch On Mar 9, 2011, at 15:23, Adam Jackson wrote: On 3/9/11 5:20 PM, Keith Packard wrote: On Tue, 08 Mar 2011 13:52:45 -0500, Adam

Re: [PULL] xserver-next, 2011-03-08

2011-03-09 Thread Adam Jackson
On 3/9/11 6:58 PM, Jeremy Huddleston wrote: /facepalm fix applied to both 1.9 and 1.10: 424..8ffaef2 server-1.9-branch - server-1.9-branch 3550396..0ab680f server-1.10-branch - server-1.10-branch No worries, my fault for not getting it into master promptly. Thanks! - ajax

Re: [PATCH 2/3] panoramiX: convert 0-panoramiXNumScreens loops to macro (v2)

2011-03-09 Thread Dave Airlie
On Thu, Mar 10, 2011 at 9:48 AM, Daniel Stone dan...@fooishbar.org wrote: Hi, On Thu, Mar 10, 2011 at 09:23:34AM +1000, Dave Airlie wrote: diff --git a/Xext/saver.c b/Xext/saver.c index 1888603..492a54f 100644 --- a/Xext/saver.c +++ b/Xext/saver.c @@ -1288,7 +1288,7 @@

Re: [PATCH 2/3] panoramiX: convert 0-panoramiXNumScreens loops to macro (v2)

2011-03-09 Thread Alan Coopersmith
On 03/ 9/11 04:14 PM, Dave Airlie wrote: On Thu, Mar 10, 2011 at 9:48 AM, Daniel Stone dan...@fooishbar.org wrote: Hi, On Thu, Mar 10, 2011 at 09:23:34AM +1000, Dave Airlie wrote: diff --git a/Xext/saver.c b/Xext/saver.c index 1888603..492a54f 100644 --- a/Xext/saver.c +++ b/Xext/saver.c

Re: [PATCH 2/3] panoramiX: convert 0-panoramiXNumScreens loops to macro (v2)

2011-03-09 Thread Dave Airlie
On Thu, Mar 10, 2011 at 10:17 AM, Alan Coopersmith alan.coopersm...@oracle.com wrote: On 03/ 9/11 04:14 PM, Dave Airlie wrote: On Thu, Mar 10, 2011 at 9:48 AM, Daniel Stone dan...@fooishbar.org wrote: Hi, On Thu, Mar 10, 2011 at 09:23:34AM +1000, Dave Airlie wrote: diff --git a/Xext/saver.c

The following changes since commit 628d16a92a7fa556fbb70bf4a4adf57ec05c190b:

2011-03-09 Thread Dave Airlie
loader: Don't distribute sdksyms.c and make it depend on the config (2011-03-03 21:54:25 -0800) are available in the git repository at: git://people.freedesktop.org/~airlied/xserver xinerama-cleanup Dave Airlie (4): panoramiX: macro checking if drawable is root (v2) panoramiX:

[PATCH v2:libXt] Add test framework similar to xserver and use it to test XtAsprintf

2011-03-09 Thread Alan Coopersmith
Only two simple test cases to start with: - compares the results of snprintf of a short string to a static buffer with the new buffer returned by XtAsprintf. - compare the results of using XtAsprintf to replicate a portion of a very long string with the original string. Uses

Summer of code 2011

2011-03-09 Thread Stéphane Marchesin
Hi, This is this time of year again, as the weather gets better (or worse depending on your side of the planet) Summer of code is coming up. So we will need to update and fill this page with our best and brightest summer of code ideas: http://wiki.x.org/wiki/SummerOfCodeIdeas We have a couple