Re: [PATCH] man: list the drivers that are ignored when hotplugging (#35209)

On 2011-03-16 08:11:21 +1000, Peter Hutterer wrote: > evdev has duplication detection built-in so it doesn't add the same device > twice. going from the info in the bugreport it's hard to figure out what > exactly was wrong though. I thought it was just the usual bug that we've > seen before (but s

Re: [PATCH] man: list the drivers that are ignored when hotplugging (#35209)

On Wed, Mar 16, 2011 at 01:17:17AM +0100, Vincent Lefevre wrote: > On 2011-03-16 08:11:21 +1000, Peter Hutterer wrote: > > evdev has duplication detection built-in so it doesn't add the same device > > twice. going from the info in the bugreport it's hard to figure out what > > exactly was wrong th

Re: [PATCH xserver] xkb: Release XKB component names when compiling keymap.

On Fri, Mar 11, 2011 at 02:30:49PM +0200, Rami Ylimäki wrote: > Reviewed-by: Erkki Seppälä > Signed-off-by: Rami Ylimäki > --- > I tested this with X server 1.9. However, I did cherry pick enough > patches from master so that I could make the patch apply cleanly on > X server master also. Applie

Re: [PATCH inputproto 0/4] Reposting with all the glitches fixed

On Tue, Mar 15, 2011 at 09:42:44PM -0400, Gaetan Nadon wrote: > Passes distcheck > > Gaetan Nadon (3): > specs: convert XI2proto.txt to html using asciidoc > XI2proto.txt: fix whitespace issues > XIproto.txt: fix whitespace issues > > Peter Hutterer (1): > Add minimal asciidoc syntax > >

[PATCH inputproto 4/4] XIproto.txt: fix whitespace issues

Signed-off-by: Gaetan Nadon --- specs/XIproto.txt | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/specs/XIproto.txt b/specs/XIproto.txt index 83cf9dd..4b6b8f1 100644 --- a/specs/XIproto.txt +++ b/specs/XIproto.txt @@ -4,7 +4,7 @@ X Version 1

[PATCH inputproto 3/4] XI2proto.txt: fix whitespace issues

Signed-off-by: Gaetan Nadon --- specs/XI2proto.txt | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/specs/XI2proto.txt b/specs/XI2proto.txt index 5d1b275..1e3adbe 100644 --- a/specs/XI2proto.txt +++ b/specs/XI2proto.txt @@ -144,7 +144,7 @@ If an event is generated

[PATCH inputproto 2/4] specs: convert XI2proto.txt to html using asciidoc

Signed-off-by: Gaetan Nadon --- Makefile.am|6 +++--- configure.ac |9 ++--- specs/.gitignore |1 + specs/Makefile.am | 16 XI2proto.txt => specs/XI2proto.txt |0 XIproto.txt =>

[PATCH inputproto 0/4] Reposting with all the glitches fixed

Passes distcheck Gaetan Nadon (3): specs: convert XI2proto.txt to html using asciidoc XI2proto.txt: fix whitespace issues XIproto.txt: fix whitespace issues Peter Hutterer (1): Add minimal asciidoc syntax Makefile.am|6 +- configure.ac |

Re: Spinning in _XReply

Jamey Sharp writes: > So I don't see anything we can do except require that callers meet the > documented requirements for XSetErrorHandler. I did try to find a kludge > to let existing apps survive this bug, but anything I could think of > probably breaks multi-threaded clients. Thanks for the f

Re: [PATCH inputproto] Add minimal asciidoc syntax

On Wed, 2011-03-16 at 09:12 +1000, Peter Hutterer wrote: > asciidoc also converts to docbook. so while there would be some > inconsistency, it wouldn't be that bad. > I thought about that. The strategy would that before it matures, asciidoc provides a "rapid development process". At one point a

Re: [PATCH xserver] xkb: Initialize pad bytes sent in replies of geometry requests.

On Wed, Mar 09, 2011 at 03:45:40PM +0200, Rami Ylimäki wrote: > Valgrind complains about uninitialized data being written to clients. > > Reviewed-by: Erkki Seppälä > Signed-off-by: Rami Ylimäki > --- > xkb/xkb.c | 12 +--- > 1 files changed, 9 insertions(+), 3 deletions(-) > > diff

[PATCH] xkb: Document XkbWriteCountedString.

Signed-off-by: Peter Hutterer --- xkb/xkb.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/xkb/xkb.c b/xkb/xkb.c index bdd67a2..ae8a395 100644 --- a/xkb/xkb.c +++ b/xkb/xkb.c @@ -4307,6 +4307,17 @@ ProcXkbSetNames(ClientPtr client) #defineXkbSizeCou

Re: Spinning in _XReply

Short version: I can't maintain Xlib's correctness conditions and also allow error handlers to call _XReply. In various places, Xlib assumes that it processes all responses from the server in the order the server generated those responses. If the server has generated an error and then another respo

Re: [PATCH inputproto] Prototype asciidoc text to html converter - not for review yet

On Tue, Mar 15, 2011 at 03:51:54PM -0400, Gaetan Nadon wrote: > Signed-off-by: Gaetan Nadon > --- > Makefile.am|6 +++--- > configure.ac |9 ++--- > specs/.gitignore |1 + > specs/Makefile.am | 12 +

Re: [PATCH inputproto] Add minimal asciidoc syntax

On Tue, Mar 15, 2011 at 09:01:40AM -0400, Gaetan Nadon wrote: > On Tue, 2011-03-15 at 15:29 +1000, Peter Hutterer wrote: > > > Though this protocol description is mainly to be viewed as textfile, a > > few > > minor changes make it parsable for asciidoc to spit out reasonably > > nicely-formatted

Re: [PATCH inputproto] Add minimal asciidoc syntax

On Tue, Mar 15, 2011 at 03:45:57PM -0400, Gaetan Nadon wrote: > On Tue, 2011-03-15 at 15:29 +1000, Peter Hutterer wrote: > > > Though this protocol description is mainly to be viewed as textfile, a > > few > > minor changes make it parsable for asciidoc to spit out reasonably > > nicely-formatted

Re: [PATCH xserver 2/3] Add generalized unit test support using util-macros.

On Mon, Mar 14, 2011 at 08:54:23PM -0400, Gaetan Nadon wrote: > A handful of modules have begun adding unit test programs. > These macros will help providing a consistent interface which will > help package builders and developers to manage the functionality. > > XORG_ENABLE_UNIT_TESTS will turn o

Re: [PATCH] man: list the drivers that are ignored when hotplugging (#35209)

On Tue, Mar 15, 2011 at 02:49:29PM +0100, Vincent Lefevre wrote: > On 2011-03-15 13:21:16 +1000, Peter Hutterer wrote: > > X.Org Bug 35209 > > > > Signed-off-by: Peter Hutterer > > --- > > hw/xfree86/doc/man/xorg.conf.man | 13 ++--- >

Re: [PATCH 3/4] xfree86: warning fix

On Tue, Mar 15, 2011 at 8:37 AM, Keith Packard wrote: > On Tue, 15 Mar 2011 11:05:06 -0400, Adam Jackson wrote: > >> -                             if (asprintf(&s, "%ul %ul", val1, val.num) == >> -1) >> +                             if (asprintf(&s, "%lu %u", val1, val.num) == >> -1) > > Review

Re: [PATCH 0/2] minor xtrans cleanup

On Tue, Mar 15, 2011 at 15:50:30 -0400, Adam Jackson wrote: > Lets us get rid of Xalloc/Xfree/etc in xserver. > Reviewed-by: Julien Cristau for the series. Cheers, Julien ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archi

Re: [PATCH 4/4] xfree86: warning fix

On Tue, 15 Mar 2011 20:31:28 +0100, Simon Thum wrote: > * interleaved code and declarations: { foo = TRUE; int bar; > do_stuff(); } > > > So, what's up with that? We're trying to reduce the number of warnings generated by the compiler (ideally down to zero). -- keith.pack...@intel.com

[PATCH inputproto] Prototype asciidoc text to html converter - not for review yet

Signed-off-by: Gaetan Nadon --- Makefile.am|6 +++--- configure.ac |9 ++--- specs/.gitignore |1 + specs/Makefile.am | 12 XI2proto.txt => specs/XI2proto.txt |0 XIproto.txt => spe

[PATCH 2/2] Remove K&R token pasting macros

Signed-off-by: Adam Jackson --- Xtrans.h | 36 1 files changed, 0 insertions(+), 36 deletions(-) diff --git a/Xtrans.h b/Xtrans.h index cb83196..7670d48 100644 --- a/Xtrans.h +++ b/Xtrans.h @@ -63,22 +63,14 @@ from The Open Group. */ #ifdef X11_t -#if

[PATCH 0/2] minor xtrans cleanup

Lets us get rid of Xalloc/Xfree/etc in xserver. - ajax ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH 1/2] Don't special-case allocation for the X server

xserver uses malloc/free directly now, don't route through the Xalloc wrappers. Signed-off-by: Adam Jackson --- transport.c |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/transport.c b/transport.c index 5131d99..84a2915 100644 --- a/transport.c +++ b/transport.c @@

Re: [PATCH inputproto] Add minimal asciidoc syntax

On Tue, 2011-03-15 at 15:29 +1000, Peter Hutterer wrote: > Though this protocol description is mainly to be viewed as textfile, a > few > minor changes make it parsable for asciidoc to spit out reasonably > nicely-formatted html code. > > Changes include: > - underline section headers with the ma

Re: [PATCH 4/4] xfree86: warning fix

On Tue, 2011-03-15 at 20:31 +0100, Simon Thum wrote: > On 03/15/2011 04:43 PM, Keith Packard wrote: > > On Tue, 15 Mar 2011 11:05:07 -0400, Adam Jackson wrote: > > > >> xf86RandR12.c: In function 'xf86RandR12EnterVT': > >> xf86RandR12.c:1769:5: warning: ISO C90 forbids mixed declarations and > >>

Re: [PATCH 4/4] xfree86: warning fix

On 03/15/2011 04:43 PM, Keith Packard wrote: > On Tue, 15 Mar 2011 11:05:07 -0400, Adam Jackson wrote: > >> xf86RandR12.c: In function 'xf86RandR12EnterVT': >> xf86RandR12.c:1769:5: warning: ISO C90 forbids mixed declarations and >> code True, but I was using the construct as well, based on doc/c

Re: [PATCH 5/6] glx: Flatten -DXFree86Server

On Tue, 15 Mar 2011 06:05:39 +1000, Dave Airlie wrote: > On Tue, Mar 15, 2011 at 5:31 AM, Adam Jackson wrote: > > Always defined by the makefile, so, just get rid of it. > > > > Signed-off-by: Adam Jackson > > --- > >  glx/Makefile.am |    1 - > >  glx/glapi.c     |   43

Re: sessreg: Changes to 'master'

On Tue, 2011-03-15 at 12:32 +, Jon TURNEY wrote: > Yes, always reproduces for non-srcdir builds for me. > > $ autoconf --version > autoconf (GNU Autoconf) 2.68 > $ automake --version > automake (GNU automake) 1.11.1 > $ git clone git://anongit.freedesktop.org/xorg/app/sessreg > [...] > $ cd s

Re: [PATCH 1/4] dix: warning fix

On Tue, 2011-03-15 at 08:35 -0700, Keith Packard wrote: > On Tue, 15 Mar 2011 11:05:04 -0400, Adam Jackson wrote: > > > - ErrorF("[dix] AddResource(%lx, %lx, %lx), client=%d \n", > > - (unsigned long)id, type, (unsigned long)value, client); > > + ErrorF("[dix] AddResource(%x, %x, %l

Re: [PATCH 1/4] dix: warning fix

On Tue, Mar 15, 2011 at 08:35:12 -0700, Keith Packard wrote: > On Tue, 15 Mar 2011 11:05:04 -0400, Adam Jackson wrote: > > > - ErrorF("[dix] AddResource(%lx, %lx, %lx), client=%d \n", > > - (unsigned long)id, type, (unsigned long)value, client); > > + ErrorF("[dix] AddResource(%x,

Re: [PATCH 4/4] xfree86: warning fix

On Tue, 15 Mar 2011 11:05:07 -0400, Adam Jackson wrote: > xf86RandR12.c: In function 'xf86RandR12EnterVT': > xf86RandR12.c:1769:5: warning: ISO C90 forbids mixed declarations and > code Reviewed-by: Keith Packard -- keith.pack...@intel.com pgpkIvhwLMBGP.pgp Description: PGP signature __

Re: [PATCH 3/4] xfree86: warning fix

On Tue, 15 Mar 2011 11:05:06 -0400, Adam Jackson wrote: > - if (asprintf(&s, "%ul %ul", val1, val.num) == > -1) > + if (asprintf(&s, "%lu %u", val1, val.num) == -1) Reviewed-by: Keith Packard (as an aside, I was amused to find that 'val'

Re: [PATCH 2/4] render: warning fixes

On Tue, 15 Mar 2011 11:05:05 -0400, Adam Jackson wrote: > picture.c: In function 'CompositeTriStrip': > picture.c:1777:25: warning: unused variable 'ps' > picture.c: In function 'CompositeTriFan': > picture.c:1807:16: warning: unused variable 'pScreen' Reviewed-by: Keith Packard -- keith.pack

Re: [PATCH 1/4] dix: warning fix

On Tue, 15 Mar 2011 11:05:04 -0400, Adam Jackson wrote: > - ErrorF("[dix] AddResource(%lx, %lx, %lx), client=%d \n", > - (unsigned long)id, type, (unsigned long)value, client); > + ErrorF("[dix] AddResource(%x, %x, %lx), client=%d \n", > +id, type, (unsigned long)v

Re: sessreg: Changes to 'master'

On Tue, Mar 15, 2011 at 5:32 AM, Jon TURNEY wrote: > On 14/03/2011 17:53, Gaetan Nadon wrote: >> On Mon, 2011-03-14 at 08:18 -0700, Dan Nicholson wrote: >> >>> On Mon, Mar 14, 2011 at 7:31 AM, Jon TURNEY >>> wrote: On 19/01/2011 15:49, Gaetan Nadon wrote: >  Makefile.am         |   25 -

[PATCH 4/4] xfree86: warning fix

xf86RandR12.c: In function 'xf86RandR12EnterVT': xf86RandR12.c:1769:5: warning: ISO C90 forbids mixed declarations and code Signed-off-by: Adam Jackson --- hw/xfree86/modes/xf86RandR12.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/xfree86/modes/xf86RandR12.c b/hw

[PATCH 3/4] xfree86: warning fix

Pointer.c: In function 'xf86parsePointerSection': Pointer.c:192:5: warning: format '%u' expects type 'unsigned int', but argument 3 has type 'long unsigned int' Signed-off-by: Adam Jackson --- hw/xfree86/parser/Pointer.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/

[PATCH 2/4] render: warning fixes

picture.c: In function 'CompositeTriStrip': picture.c:1777:25: warning: unused variable 'ps' picture.c: In function 'CompositeTriFan': picture.c:1807:16: warning: unused variable 'pScreen' Signed-off-by: Adam Jackson --- render/picture.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(

[PATCH 1/4] dix: warning fix

resource.c: In function 'AddResource': resource.c:493:3: warning: format '%lx' expects type 'long unsigned int', but argument 3 has type 'RESTYPE' Signed-off-by: Adam Jackson --- dix/resource.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dix/resource.c b/dix/reso

Re: [PULL v2] XResource extension v1.2

On Tue, 15 Mar 2011 10:42:32 +0200, Erkki Seppala wrote: > I quite hope that there will be more standard data structures in X, > because not having them leads to having ad-hoc data structures that are > possibly suboptimal for the task at hand - not only performance-wise but > from code clarity

Re: auto generated glx code in X server

On Tue, 2011-03-15 at 13:52 +1000, Dave Airlie wrote: > On Fri, Mar 4, 2011 at 11:24 AM, Dave Airlie wrote: > > Hi guys, > > > > I know this used to work, but it seems to be well busted now. > > > > If you made glx changes in mesa you could just set XORG_BASE and run > > make and it would regenera

Re: [PATCH] man: list the drivers that are ignored when hotplugging (#35209)

On 2011-03-15 13:21:16 +1000, Peter Hutterer wrote: > X.Org Bug 35209 > > Signed-off-by: Peter Hutterer > --- > hw/xfree86/doc/man/xorg.conf.man | 13 ++--- > 1 files changed, 10 insertions(+), 3 deletions(-) > > diff --git a/hw/xfre

Re: [Mesa-dev] auto generated glx code in X server

On Tue, Mar 15, 2011 at 12:12 AM, Keith Packard wrote: > On Tue, 15 Mar 2011 13:52:40 +1000, Dave Airlie wrote: > >> a) undo ajax's cleanup, fix generator scripts to work again (not sure >> how possible that is >> since Olv's mapi changes), import latest GLX into server on a >> semi-regular basis

Re: [PATCH inputproto] Add minimal asciidoc syntax

On 03/15/2011 01:29 AM, Peter Hutterer wrote: > Though this protocol description is mainly to be viewed as textfile, a few > minor changes make it parsable for asciidoc to spit out reasonably > nicely-formatted html code. > > Changes include: > - underline section headers with the matching lines >

Re: [PATCH inputproto] Add minimal asciidoc syntax

On Tue, 2011-03-15 at 15:29 +1000, Peter Hutterer wrote: > Though this protocol description is mainly to be viewed as textfile, a > few > minor changes make it parsable for asciidoc to spit out reasonably > nicely-formatted html code. > > Changes include: > - underline section headers with the ma

Re: [PATCH] Xext: relax assert in SecurityAuthorizationExpired.

Cyril Brulebois (07/03/2011): > The following code path is considered valid: > SecurityAuthorizationExpired > TimerSet > SecurityStartAuthorizationTimer > > In other words, SecurityAuthorizationExpired can be called while > pAuth->timer is still NULL, so relax the assert() accordingly. > >

Re: [PATCH] man: list the drivers that are ignored when hotplugging (#35209)

Peter Hutterer (15/03/2011): > -sections in the xorg.conf if hotplugging is enabled. > +sections in the xorg.conf if hotplugging is in use. If hotplugging is > +enabled, > +.B InputDevice > +sections using the > +.B mouse, kbd To keep them sorted, maybe: kbd, mouse > +and > +.B vmmouse > +driver

Re: [PATCH:libXt 1/2 v3] Add test framework similar to xserver and use it to test XtAsprintf

On Mon, 2011-03-14 at 21:47 -0700, Alan Coopersmith wrote: > > They won't build for me when I configure --without-glib: > Same here, I must have forgotten to clean the test dir before running make check again. Everything is working now with the the bug fix. With the .gitignore and HAVE_GLIB, f

Re: [PATCH:libXt 1/2 v3] Add test framework similar to xserver and use it to test XtAsprintf

On Mon, 2011-03-14 at 21:47 -0700, Alan Coopersmith wrote: > I didn't think that was necessary since the macros reported error if > you had > unit tests enabled and glib was missing - did I miss something? > The util macros aren't a a copy of the server code. I extracted the requirements and gen

Re: sessreg: Changes to 'master'

On 14/03/2011 17:53, Gaetan Nadon wrote: > On Mon, 2011-03-14 at 08:18 -0700, Dan Nicholson wrote: > >> On Mon, Mar 14, 2011 at 7:31 AM, Jon TURNEY >> wrote: >>> On 19/01/2011 15:49, Gaetan Nadon wrote: Makefile.am | 25 - configure.ac|5 + filenames

Re: [PATCH] man: list the drivers that are ignored when hotplugging (#35209)

On Tue, Mar 15, 2011 at 13:21:16 +1000, Peter Hutterer wrote: > X.Org Bug 35209 > > Signed-off-by: Peter Hutterer > --- > hw/xfree86/doc/man/xorg.conf.man | 13 ++--- > 1 files changed, 10 insertions(+), 3 deletions(-) > Reviewed-by

Re: [PULL v2] XResource extension v1.2

Hello, On 14.03.2011 22:35, Keith Packard wrote: We've already got half a dozen hash table implementations in the X server, most of which are heavily tuned for a particular task. Yes, there are some hash implementations which are intertwined with the implementation of the code using it, such a