Re: [PATCH synaptics 08/17] eventcomm: streamline absinfo retrieval.

2011-03-26 Thread Chris Bagwell
Reviewed-by: Chris Bagwell On Sun, Mar 20, 2011 at 9:08 PM, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > --- >  src/eventcomm.c |  104 > --- >  1 files changed, 61 insertions(+), 43 deletions(-) > > diff --git a/src/eventcomm.c b/s

Re: [PATCH synaptics 10/17] eventcomm: untangle state setting from printing device info

2011-03-26 Thread Chris Bagwell
Reviewed-by: Chris Bagwell On Sun, Mar 20, 2011 at 9:08 PM, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > --- >  src/eventcomm.c |   97 -- >  1 files changed, 50 insertions(+), 47 deletions(-) > > diff --git a/src/eventcomm.c b/src/e

Re: [PATCH modular 2/3 (v3)] jhbuild: Support skipping packages on a per-architecture basis.

2011-03-26 Thread Jeremy Huddleston
Reviving this thread... I like this idea, but I think we need the logic to be the other way around. We need to have a mechanism to say that a given module only works on a set of architectures, and skip it if the build arch isn't in that set. ie (forgive my python as it's not my native tongue,

Re: [PATCH xserver] EXA: Use dixGetPrivate(Addr) instead of dixLookupPrivate.

2011-03-26 Thread Cyril Brulebois
(Mode I'm-discovering-the-code on) Michel Dänzer (26/03/2011): > From: Michel Dänzer > > The latter calls the former, let's cut the middle man and eliminate a branch > in a hot path. > > Signed-off-by: Michel Dänzer Since we have: dixRegisterPrivateKey(&exaScreenPrivateKeyRec, PRIVATE_SCRE

Re: [PATCH xorg-docs 2/2] Replace XMLTO with XSLTPROC, XMLLINT and W3M tools

2011-03-26 Thread Dan Nicholson
On Fri, Mar 25, 2011 at 10:21 AM, Gaetan Nadon wrote: > On Fri, 2011-03-25 at 09:28 -0600, Matt Dew wrote: > > Dan,  which justifications do you feel are incorrect?  Agreed that > accurate commit msgs are important so we'll try to clear them up. > > > I think the issue has been resolved with the n

Re: Alignment error in libXi

2011-03-26 Thread Julien Cristau
On Fri, Mar 25, 2011 at 06:31:38 +, Matt Turner wrote: > Oh, I didn't realize it had already been fixed. > > Odd that it was fixed, reviewed, and tested without another comment in > this thread. Guess I just missed the patch. > The followup with patch was only on -devel. Cheers, Julien

Re: [PATCH xserver] EXA: Use dixGetPrivate(Addr) instead of dixLookupPrivate.

2011-03-26 Thread Michel Dänzer
On Sam, 2011-03-26 at 11:50 +, Maarten Maathuis wrote: > 2011/3/26 Michel Dänzer : > > From: Michel Dänzer > > > > The latter calls the former, let's cut the middle man and eliminate a branch > > in a hot path. > > > > Signed-off-by: Michel Dänzer > > --- > > exa/exa_priv.h |7 +++ >

Re: [PATCH xserver] EXA: Use dixGetPrivate(Addr) instead of dixLookupPrivate.

2011-03-26 Thread Maarten Maathuis
2011/3/26 Michel Dänzer : > From: Michel Dänzer > > The latter calls the former, let's cut the middle man and eliminate a branch > in a hot path. > > Signed-off-by: Michel Dänzer > --- >  exa/exa_priv.h |    7 +++ >  1 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/exa/exa_pr

[PATCH xserver] EXA: Use dixGetPrivate(Addr) instead of dixLookupPrivate.

2011-03-26 Thread Michel Dänzer
From: Michel Dänzer The latter calls the former, let's cut the middle man and eliminate a branch in a hot path. Signed-off-by: Michel Dänzer --- exa/exa_priv.h |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/exa/exa_priv.h b/exa/exa_priv.h index e5d90d4..70de4bd

Re: [PATCH 01/11] xfree86: dri2: fix memory leak in DRI2AddDrawableRef

2011-03-26 Thread Michel Dänzer
On Fre, 2011-03-25 at 20:41 +0200, Tiago Vignatti wrote: > Signed-off-by: Tiago Vignatti > --- > hw/xfree86/dri2/dri2.c |8 ++-- > 1 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/hw/xfree86/dri2/dri2.c b/hw/xfree86/dri2/dri2.c > index 9ca378f..53f1e33 100644 > --- a/hw

Re: GSoC Proposal the second

2011-03-26 Thread janikjaskolski
Hello again, Thanks for your clarification. I did not mean any disrespect, that came out wrong, sorry. The problem here is that if your filter happens to return false when the user intended to trigger it a different event is generated. For such input to be useful the filter should be som

Re: GSoC Proposal the second

2011-03-26 Thread janikjaskolski
Hello Michal, first of all, thanks a lot for your feedback. I must admit though, that I get the feeling, that you did either not fully comprehend my intention, or else, have not read some of the latest research results on multi sensory input evaluation?! Maybe I just expressed myself not we