Re: [PATCH libXi] Allocate enough memory for raw events + extra data.

2011-05-02 Thread Jeremy Huddleston
On May 2, 2011, at 11:24 PM, Peter Hutterer wrote: > On Mon, May 02, 2011 at 11:11:26PM -0700, Jeremy Huddleston wrote: >> >> On May 2, 2011, at 11:00 PM, Jeremy Huddleston wrote: >>> On May 2, 2011, at 10:00 PM, Peter Hutterer wrote: re "Idempotent operation" I'm staring hard at

Re: [PATCH libXi] Allocate enough memory for raw events + extra data.

2011-05-02 Thread Peter Hutterer
On Mon, May 02, 2011 at 11:11:26PM -0700, Jeremy Huddleston wrote: > > On May 2, 2011, at 11:00 PM, Jeremy Huddleston wrote: > > On May 2, 2011, at 10:00 PM, Peter Hutterer wrote: > >> > >> re "Idempotent operation" > >> I'm staring hard at those but don't really see the issue. > >> SetReqLen(req

Re: [PATCH libXi] Allocate enough memory for raw events + extra data.

2011-05-02 Thread Jeremy Huddleston
On May 2, 2011, at 11:00 PM, Jeremy Huddleston wrote: > On May 2, 2011, at 10:00 PM, Peter Hutterer wrote: >> >> re "Idempotent operation" >> I'm staring hard at those but don't really see the issue. >> SetReqLen(req, foo, foo); is valid and for any foo that is non-zero >> shouldn't have the effe

Re: [PATCH 1/2] Use XORG_COMPILER_BRAND from util-macros 1.14 to check for SUNCC

2011-05-02 Thread Jeremy Huddleston
On May 2, 2011, at 10:25 PM, Peter Hutterer wrote: > Reviewed-by: Peter Hutterer > (I'd obviously prefer if this patch is held back until the macros are > released) Ditto on that. In fact, should we just move xorg-tls.m4 into util-macros? ___ xorg-

Re: [PATCH libXi] Allocate enough memory for raw events + extra data.

2011-05-02 Thread Jeremy Huddleston
On May 2, 2011, at 10:00 PM, Peter Hutterer wrote: > On Mon, May 02, 2011 at 09:05:21PM -0700, Jeremy Huddleston wrote: >> Woot. That takes care of: >> >> http://people.freedesktop.org/~jeremyhu/analyzer/yuffie/20110429-1617/libXi/report-kzyPla.html#EndPath >> >> It looks like there are others

Re: [PATCH] Move event filter initializer out of the structure itself

2011-05-02 Thread Peter Hutterer
On Sun, Apr 24, 2011 at 12:55:05PM -0700, Alan Coopersmith wrote: > On 04/22/11 11:10 PM, Jamey Sharp wrote: > > On Fri, Apr 22, 2011 at 10:19:39PM -0700, Alan Coopersmith wrote: > >> When kept in the structure, it causes the entire MAXDEVICES * 128 masks > >> to be stored in the data segment and l

Re: [PATCH libXi] XIChangeHierarchy: Return Success early if no actual changes are requested.

2011-05-02 Thread Jeremy Huddleston
Reviewed-by: Jeremy Huddleston On May 2, 2011, at 9:58 PM, Peter Hutterer wrote: > Do the same for negative num_changes. > > Signed-off-by: Peter Hutterer > --- > man/XIChangeHierarchy.txt |3 ++- > src/XIHierarchy.c |3 +++ > 2 files changed, 5 insertions(+), 1 deletions(-) > >

Re: [PATCH libXi] Remove a few unused assignments.

2011-05-02 Thread Jeremy Huddleston
Reviewed-by: Jeremy Huddleston On May 2, 2011, at 9:55 PM, Peter Hutterer wrote: > Found by static analyzer. > > Reported-by: Jeremy Huddleston > Signed-off-by: Peter Hutterer > --- > src/XExtInt.c |3 --- > 1 files changed, 0 insertions(+), 3 deletions(-) > > diff --git a/src/XExtInt.c b

Re: [PATCH 2/2] Use XORG_STRICT_OPTION from util-macros 1.14 to set -Werror flags

2011-05-02 Thread Jeremy Huddleston
Reviewed-by: Jeremy Huddleston Thanks. On May 2, 2011, at 8:54 PM, Alan Coopersmith wrote: > Signed-off-by: Alan Coopersmith > --- > > Assumes PATCH 1/2 has already established the baseline of macros 1.14 in > configure.ac (though it mostly works fine without it, just allows unknown > attribu

Re: [PATCH 1/2] Use XORG_COMPILER_BRAND from util-macros 1.14 to check for SUNCC

2011-05-02 Thread Jeremy Huddleston
Reviewed-by: Jeremy Huddleston On May 2, 2011, at 8:54 PM, Alan Coopersmith wrote: > Signed-off-by: Alan Coopersmith > --- > > To test with current util/macros git, bump the version in its configure.ac > to 1.14.0 and install first. > > configure.ac |8 +++- > 1 files changed, 3 insert

Re: [PATCH 1/2] Use XORG_COMPILER_BRAND from util-macros 1.14 to check for SUNCC

2011-05-02 Thread Peter Hutterer
On Mon, May 02, 2011 at 08:54:29PM -0700, Alan Coopersmith wrote: > Signed-off-by: Alan Coopersmith > --- > > To test with current util/macros git, bump the version in its configure.ac > to 1.14.0 and install first. > > configure.ac |8 +++- > 1 files changed, 3 insertions(+), 5 deletio

Re: [PATCH libXi] Allocate enough memory for raw events + extra data.

2011-05-02 Thread Peter Hutterer
On Mon, May 02, 2011 at 09:05:21PM -0700, Jeremy Huddleston wrote: > Woot. That takes care of: > > http://people.freedesktop.org/~jeremyhu/analyzer/yuffie/20110429-1617/libXi/report-kzyPla.html#EndPath > > It looks like there are others you might want to do at the same time: > http://people.free

[PATCH libXi] XIChangeHierarchy: Return Success early if no actual changes are requested.

2011-05-02 Thread Peter Hutterer
Do the same for negative num_changes. Signed-off-by: Peter Hutterer --- man/XIChangeHierarchy.txt |3 ++- src/XIHierarchy.c |3 +++ 2 files changed, 5 insertions(+), 1 deletions(-) diff --git a/man/XIChangeHierarchy.txt b/man/XIChangeHierarchy.txt index ac667bc..205f40f 100644 -

[PATCH libXi] Remove a few unused assignments.

2011-05-02 Thread Peter Hutterer
Found by static analyzer. Reported-by: Jeremy Huddleston Signed-off-by: Peter Hutterer --- src/XExtInt.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/src/XExtInt.c b/src/XExtInt.c index 134ccc6..55144c6 100644 --- a/src/XExtInt.c +++ b/src/XExtInt.c @@ -760,7 +760,

Re: [PATCH xlsclients] Depend on xcb >= 1.6 for XCB_ATOM_*.

2011-05-02 Thread Alan Coopersmith
On 05/ 1/11 07:49 PM, Arnaud Fontaine wrote: > Hello, > > XCB_ATOM_* requires xcb >= 1.6. Could you please consider applying this > patch? Done. Thanks for the patch. > Also, considering that xcb-util 0.3.8 has been released, could you > please release xlsclients as the last released v

Re: [PATCH libXi] Allocate enough memory for raw events + extra data.

2011-05-02 Thread Jeremy Huddleston
Oh yeah, and: Reviewed-by: Jeremy Huddleston On May 2, 2011, at 8:50 PM, Peter Hutterer wrote: > Necessary space was calculated, but not actually used to allocate memory. As > a result, valuator data would overwrite the allocated memory. > > ==4166== Invalid write of size 1 > ==4166==at 0x

Re: [PATCH libXi] Allocate enough memory for raw events + extra data.

2011-05-02 Thread Jeremy Huddleston
Woot. That takes care of: http://people.freedesktop.org/~jeremyhu/analyzer/yuffie/20110429-1617/libXi/report-kzyPla.html#EndPath It looks like there are others you might want to do at the same time: http://people.freedesktop.org/~jeremyhu/analyzer/yuffie/20110429-1617/libXi/ On May 2, 2011, at

[PATCH 2/2] Use XORG_STRICT_OPTION from util-macros 1.14 to set -Werror flags

2011-05-02 Thread Alan Coopersmith
Signed-off-by: Alan Coopersmith --- Assumes PATCH 1/2 has already established the baseline of macros 1.14 in configure.ac (though it mostly works fine without it, just allows unknown attribute warnings to appear on compilers that don't support them but don't make them fatal errors). m4/xorg-tls

[PATCH 1/2] Use XORG_COMPILER_BRAND from util-macros 1.14 to check for SUNCC

2011-05-02 Thread Alan Coopersmith
Signed-off-by: Alan Coopersmith --- To test with current util/macros git, bump the version in its configure.ac to 1.14.0 and install first. configure.ac |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index 61caaed..bd1bb0b 100644 ---

[PATCH libXi] Allocate enough memory for raw events + extra data.

2011-05-02 Thread Peter Hutterer
Necessary space was calculated, but not actually used to allocate memory. As a result, valuator data would overwrite the allocated memory. ==4166== Invalid write of size 1 ==4166==at 0x4C29F04: memcpy (mc_replace_strmem.c:497) ==4166==by 0x8F39180: ??? (in /usr/lib/libXi.so.6.1.0) ==4166==

[PULL: xserver master] misc minor fixes

2011-05-02 Thread Alan Coopersmith
The following changes since commit 5cb31cd0cbf83fff5f17a475e7b0e45246b19bf3: Merge remote-tracking branch 'jturney/remove-opengl-spec-download' (2011-04-29 09:59:49 -0700) are available in the git repository at: git://people.freedesktop.org/~alanc/xserver.git master Alan Coopersmith (4):

Re: [PATCH:macros] XORG_STRICT_OPTION: add -Werror=attributes to STRICT_CFLAGS for gcc

2011-05-02 Thread Jeremy Huddleston
Thanks. Reviewed-by: Jeremy Huddleston On May 2, 2011, at 7:13 PM, Alan Coopersmith wrote: > Flags unknown attributes as errors, if -Werror=attributes is supported. > (The -Werror=* option was first spotted in gcc 4.2.0 manuals.) > > Signed-off-by: Alan Coopersmith > --- > xorg-macros.m4.in |

1.10.2 RC1 scheduled for Friday

2011-05-02 Thread Jeremy Huddleston
Send nominations and pull requests if you've been sitting on them. Thanks, Jeremy ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH:macros] XORG_STRICT_OPTION: add -Werror=attributes to STRICT_CFLAGS for gcc

2011-05-02 Thread Alan Coopersmith
Flags unknown attributes as errors, if -Werror=attributes is supported. (The -Werror=* option was first spotted in gcc 4.2.0 manuals.) Signed-off-by: Alan Coopersmith --- xorg-macros.m4.in |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/xorg-macros.m4.in b/xorg-m

xclock/oclock endian mismatch in Xfbdev

2011-05-02 Thread dushara . jayasinghe
Hi all, I'm Working on an iMX.25 (ARM) based embedded platform with xserver_xorg-server-1.7.5. I had to make the following mods to servermd.h to reflect the hardware. #define FBNOPIXADDR #define IMAGE_BYTE_ORDERMSBFirst #define BITMAP_BIT_ORDERMSBFirst This setup works with xlog

Re: [PATCH 17/20] mi: check for MASTER_POINTER instead of manual checks.

2011-05-02 Thread Daniel Stone
On Fri, Feb 18, 2011 at 01:52:24PM +1000, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > --- > mi/mipointer.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/mi/mipointer.c b/mi/mipointer.c > index 5b82978..209ea06 100644 > --- a/mi/mipointer.c > +++ b/mi/

Re: [PATCH] dix: only transform valuators when we need them.

2011-05-02 Thread Peter Hutterer
On Mon, Apr 25, 2011 at 12:58:17PM -0400, Chase Douglas wrote: > On 04/21/2011 03:35 AM, Peter Hutterer wrote: > > Unconditionally drop the valuators back into the mask when they were there > > in the first place. Otherwise, sending identical coordinates from the driver > > on a translated device c

Re: [PATCH 04/20] mi: simplify a "check for keyboard" condition

2011-05-02 Thread Daniel Stone
On Fri, Feb 18, 2011 at 01:52:11PM +1000, Peter Hutterer wrote: > Signed-off-by: Peter Hutterer > --- > mi/mipointer.c |3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/mi/mipointer.c b/mi/mipointer.c > index 124f9de..aa0ca6d 100644 > --- a/mi/mipointer.c > +++ b/mi

Re: [PATCH 20/20] dix: reduce scope of tmp and mult.

2011-05-02 Thread Peter Hutterer
On Thu, Apr 21, 2011 at 11:58:03PM +0200, Simon Thum wrote: > On 04/20/2011 10:21 AM, Daniel Stone wrote: > > Hi, > > > > On Wed, Apr 20, 2011 at 04:28:29PM +1000, Peter Hutterer wrote: > >> index 0741604..4901d6a 100644 > >> --- a/dix/ptrveloc.c > >> +++ b/dix/ptrveloc.c > >> @@ -1122,7 +1122,6 @

Re: [PULL] Accumulated small input changes

2011-05-02 Thread Daniel Stone
Hi, On Fri, Apr 29, 2011 at 09:35:03AM -0400, Chase Douglas wrote: > On 04/29/2011 08:33 AM, Daniel Stone wrote: > > Ah yes, you're right; forgot about the root window always being present. > > I've updated my tree now, but that commit is still lacking any R-b tag. > > I've checked it out here: >

Re: [PATCH:macros v2] Make XORG_STRICT_OPTION always set STRICT_CFLAGS

2011-05-02 Thread Jeremy Huddleston
Sure, a second logical commit sounds good. Reviewed-by: Jeremy Huddleston On May 2, 2011, at 15:36, Alan Coopersmith wrote: > On 05/ 2/11 12:19 AM, Jeremy Huddleston wrote: >> Hey Alan, >> >> I think you missed my comment about adding -Werror=attributes for the $GCC >> case. Could you please

Re: [PATCH:macros v2] Make XORG_STRICT_OPTION always set STRICT_CFLAGS

2011-05-02 Thread Alan Coopersmith
On 05/ 2/11 12:19 AM, Jeremy Huddleston wrote: > Hey Alan, > > I think you missed my comment about adding -Werror=attributes for the $GCC > case. Could you please add that as well (gcc doesn't default to > -Werror=attributes with -Werror). I thought that was only needed in the xorg-tls.m4, but

Re: [RFC] swap event handling fixes

2011-05-02 Thread Jesse Barnes
On Sat, 30 Apr 2011 01:10:27 +0200 Mario Kleiner wrote: > > On Apr 29, 2011, at 11:37 PM, Jesse Barnes wrote: > > > On Thu, 28 Apr 2011 13:27:18 -0700 > > Jesse Barnes wrote: > > > >> I obviously failed to count the swap event structure size after > >> adding > >> and removing fields a few t

Re: Why no activity on this (nasty X segfault) bug?

2011-05-02 Thread Simon Thum
Hi Ian, you seem not to be used to mailing lists. You should cc all the people you want to read this mail, i.e. normally everyone already in to or cc [0]. People read their email, but not the list archive. I did that as I was interested in the progress on this issue. I'm just stepping in since I'

X Server 1.11 merge window closes on May 27th.

2011-05-02 Thread Keith Packard
If you've got changes that you'd like to get into 1.11, make sure they're reviewed and merged before the 27th to ensure that they make the release. After that date, only bug fixes will be merged. Your friendly release manager. -- keith.pack...@intel.com pgpcb7d3EQweI.pgp Description: PGP signa

Re: [PATCH: xcb util-image] Fix xcb_bitops.h include path

2011-05-02 Thread Arnaud Fontaine
Hi, > This patch fix the include path of the xcb_bitops.h file. Applied and pushed, thanks. Cheers, -- Arnaud Fontaine pgpJ0hMMYhlIk.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archive

[PATCH: xcb util-image] Fix xcb_bitops.h include path

2011-05-02 Thread Roberto Branciforti
This patch fix the include path of the xcb_bitops.h file. Signed-off-by: rbbrnc --- image/test_formats.c |2 +- image/xcb_image.c|2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/image/test_formats.c b/image/test_formats.c index 5078548..b03673b 100644 --- a/imag

Re: [PATCH] fb: Fix memcpy abuse

2011-05-02 Thread Adam Jackson
On 4/30/11 8:39 AM, Soeren Sandmann wrote: If I remember correctly, the main objection I had to the overlapped blt patch was that it inlined the C fallback into all the SIMD versions instead of just calling down through the delegate. Other than that, I agree that doing this in pixman would be b

Re: [PATCH:macros v2] Make XORG_STRICT_OPTION always set STRICT_CFLAGS

2011-05-02 Thread Gaetan Nadon
On Sun, 2011-05-01 at 10:36 -0700, Alan Coopersmith wrote: > Still only adds it to CWARNFLAGS if --enable-strict-compilation is > passed, but sets the variable with the right flags for the compiler > so it's available for other checks in configure scripts. > > Signed-off-by: Alan Coopersmith > -

Re: [PATCH] DRI2/GLX: fix swap event handling

2011-05-02 Thread Michel Dänzer
On Fre, 2011-04-29 at 08:21 -0700, Jesse Barnes wrote: > On Fri, 29 Apr 2011 09:23:27 +0200 > Michel Dänzer wrote: > > > On Fre, 2011-04-29 at 08:52 +0200, Michel Dänzer wrote: > > > On Don, 2011-04-28 at 13:27 -0700, Jesse Barnes wrote: > > > > @@ -1114,7 +1169,7 @@ DRI2ScreenInit(ScreenPtr p

RE: Question about the modesetting on X server

2011-05-02 Thread Huang, FrankR
Thanks, Alan. I got it. That is to say, a simple X API application can make the xserver running without reset. Frank > -Original Message- > From: xorg-devel-bounces+frankr.huang=amd@lists.x.org [mailto:xorg- > devel-bounces+frankr.huang=amd@lists.x.org] On Behalf Of Alan > Cooper

Re: [PATCH:macros v2] Make XORG_STRICT_OPTION always set STRICT_CFLAGS

2011-05-02 Thread Jeremy Huddleston
Hey Alan, I think you missed my comment about adding -Werror=attributes for the $GCC case. Could you please add that as well (gcc doesn't default to -Werror=attributes with -Werror). On May 1, 2011, at 10:36, Alan Coopersmith wrote: > Still only adds it to CWARNFLAGS if --enable-strict-compil