On Tue, May 03, 2011 at 01:48:34AM +0100, Daniel Stone wrote:
> On Fri, Apr 29, 2011 at 07:34:28AM -0700, Keith Packard wrote:
> > Reviewed-by: Keith Packard
> >
> > I think that's all of them.
>
> Ta, and yes. Tree updated again (fa965fd..5bf3439).
please don't pull this one yet, it introduce
Last I saw, Daniel said he has Alan's patch in his tree, and that
supersedes this by virtue of deleting the buggy line entirely. But if
you're trying to merge this for cherry-picking to stable branches: well,
OK, I guess?
Reviewed-by: Jamey Sharp
On Wed, May 04, 2011 at 09:35:26AM +1000, Peter H
On Tue, May 03, 2011 at 05:58:18PM -0700, Jeremy Huddleston wrote:
> b4455b1..be3f41d server-1.10-branch -> server-1.10-branch
>
> What is the status of the floating/reattachment button release issue:
>
> http://bugs.freedesktop.org/show_bug.cgi?id=34182
closed, with reference to 36146
> http:
Reviewed-by: Jeremy Huddleston
On May 3, 2011, at 17:12, Peter Hutterer wrote:
> Grabbing an SD device temporary floats the device but we must not release
> the buttons. Introduced in
>
>commit 9d23459415b84606ee4f38bb2d19054c432c8552
>Author: Peter Hutterer
>Date: Fri Feb 25 11
b4455b1..be3f41d server-1.10-branch -> server-1.10-branch
What is the status of the floating/reattachment button release issue:
http://bugs.freedesktop.org/show_bug.cgi?id=34182
http://bugs.freedesktop.org/show_bug.cgi?id=36146
On May 3, 2011, at 17:22, Peter Hutterer wrote:
> A few input fixe
A few input fixes for 1.10, including the valuator alignment issue that
bothered the 1.10 series now fixed. A few passive grab fixes that affect
clients and a minor typo fix in the accel code.
The following changes since commit b4455b119cb55cc5f61add0c25863afe8cb06484:
XQuartz: BuildFix to buil
Grabbing an SD device temporary floats the device but we must not release
the buttons. Introduced in
commit 9d23459415b84606ee4f38bb2d19054c432c8552
Author: Peter Hutterer
Date: Fri Feb 25 11:08:19 2011 +1000
dix: release all buttons and keys before reattaching a device (#34182
Got inadvertantly swapped in f44d7dcb5.
Signed-off-by: Peter Hutterer
---
dix/events.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/dix/events.c b/dix/events.c
index d70d62f..3a90c50 100644
--- a/dix/events.c
+++ b/dix/events.c
@@ -4979,7 +4979,7 @@ InitEvents(void)
On Tue, 03 May 2011 14:15:30 -0700
Keith Packard wrote:
> On Tue, 3 May 2011 14:08:58 -0700, Jesse Barnes
> wrote:
>
> > Fixed version below.
>
> Reviewed-by: Keith Packard
>
> (assuming that the GLX protocol specification gets updated to match :-)
Yeah, Ian is fixing up the padding there
Updated with explicit padding.
--
Jesse Barnes, Intel Open Source Technology Center
>From 0ca3778de195a82087d0f07415a1cf8fc94f5b0a Mon Sep 17 00:00:00 2001
From: Jesse Barnes
Date: Tue, 3 May 2011 12:14:58 -0700
Subject: [PATCH] dri2proto: make DRI2 swap event match GLX spec
We only spec a 32
On Tue, 3 May 2011 14:08:58 -0700, Jesse Barnes
wrote:
> Fixed version below.
Reviewed-by: Keith Packard
(assuming that the GLX protocol specification gets updated to match :-)
--
keith.pack...@intel.com
pgpfAeQieI8MM.pgp
Description: PGP signature
On Tue, 3 May 2011 14:02:31 -0700
Jesse Barnes wrote:
> On Tue, 03 May 2011 13:54:38 -0700
> Keith Packard wrote:
>
> > On Tue, 3 May 2011 12:21:24 -0700, Jesse Barnes
> > wrote:
> >
> > > We only spec a 32 bit swap count, so drop the high sbc field.
> >
> > You're missing the explicit 16-
On Tue, 03 May 2011 13:54:38 -0700
Keith Packard wrote:
> On Tue, 3 May 2011 12:21:24 -0700, Jesse Barnes
> wrote:
>
> > We only spec a 32 bit swap count, so drop the high sbc field.
>
> You're missing the explicit 16-bit padding field after 'event_type'
>
> The documented encoding
> http:/
On Tue, 3 May 2011 12:21:24 -0700, Jesse Barnes
wrote:
> We only spec a 32 bit swap count, so drop the high sbc field.
You're missing the explicit 16-bit padding field after 'event_type'
The documented encoding
http://www.opengl.org/registry/specs/INTEL/swap_event.txt needs to be
fixed to mat
On Tue, 3 May 2011 12:21:23 -0700
Jesse Barnes wrote:
> Ian reminded me that we changed the spec to fit within an XEvent, but we
> never updated the code to match. This set of patches (much simpler than
> the last) does just that. Wrapping support can be added to Mesa if we
> really want 64 bi
We only handle a 32 bit swap count, so use the new structure definitions.
Signed-off-by: Jesse Barnes
---
configure.ac |4 ++--
src/glx/dri2.c |2 +-
src/glx/glxext.c |2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/configure.ac b/configure.ac
index 3b05ca3
After sending the GLXChangeDrawableAttributes request, we also set a
local set of attributes on the DRI drawable. But in the indirect case
this array won't be present, so skip the setting in that case to avoid a
crash.
Signed-off-by: Jesse Barnes
---
src/glx/glx_pbuffer.c |3 +++
1 files ch
We only spec a 32 bit sbc count, so drop the high bits.
Signed-off-by: Jesse Barnes
---
configure.ac |2 +-
dri2proto.h |3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/configure.ac b/configure.ac
index 5b78d6b..9505f56 100644
--- a/configure.ac
+++ b/configure.ac
We only spec a 32 bit swap count, so drop the high sbc field.
Signed-off-by: Jesse Barnes
---
configure.ac |2 +-
glxproto.h |3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/configure.ac b/configure.ac
index d88e6df..a3047e4 100644
--- a/configure.ac
+++ b/configu
Only send a 32 bit swap count out to the client.
Signed-off-by: Jesse Barnes
---
configure.ac |4 ++--
glx/glxdri2.c |5 ++---
hw/xfree86/dri2/dri2.c|2 +-
hw/xfree86/dri2/dri2.h|2 +-
hw/xfree86/dri2/dri2ext.c |5 ++---
5 files changed, 8 ins
Pass the right drawable pointer as data to the swap complete function.
Signed-off-by: Jesse Barnes
---
glx/glxdri2.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/glx/glxdri2.c b/glx/glxdri2.c
index d979717..93c5e5b 100644
--- a/glx/glxdri2.c
+++ b/glx/glxdri2.c
@@ -2
Ian reminded me that we changed the spec to fit within an XEvent, but we
never updated the code to match. This set of patches (much simpler than
the last) does just that. Wrapping support can be added to Mesa if we
really want 64 bit values, but that means checking the drawable sbc and
adding whe
On Tue, 03 May 2011 11:38:26 -0700
Ian Romanick wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> On 05/03/2011 10:59 AM, Jesse Barnes wrote:
> > Ended up moving over to generic events since the GLX type code is part
> > of the GLX namespace and larger than 8 bits.
> >
> > Apparently
On Tue, 03 May 2011 11:38:26 -0700
Ian Romanick wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> On 05/03/2011 10:59 AM, Jesse Barnes wrote:
> > Ended up moving over to generic events since the GLX type code is part
> > of the GLX namespace and larger than 8 bits.
> >
> > Apparently
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 05/03/2011 10:59 AM, Jesse Barnes wrote:
> Ended up moving over to generic events since the GLX type code is part
> of the GLX namespace and larger than 8 bits.
>
> Apparently no one had ever tried ChangeDrawableAttributes with indirect
> clients,
Jeremy Huddleston writes:
> Seems simple enough.
>
> Is pixman_disable_out_of_bounds_workaround now just a no-op, or was
> the symbol removed from pixman? Hopefully the former, but I wanted to
> make sure...
Yes, the function still exists as a no-op.
Soren
Send the new generic swap event type if the client supports it. This
means checking the client's DRI2 proto version at connect time and then
constructing a new generic event at swap complete time. To track the
client version, we need to add a new DRI2 client private type and track
it for the life
The existing swap complete event is too large to fit in an XEvent, so
use a generic event instead. New servers and clients can use this
structure to fully pass the swap count along with the media stamp
counter, swap complete type, and timestamp.
Signed-off-by: Jesse Barnes
---
configure.ac |
After sending the GLXChangeDrawableAttributes request, we also set a
local set of attributes on the DRI drawable. But in the indirect case
this array won't be present, so skip the setting in that case to avoid a
crash.
Signed-off-by: Jesse Barnes
---
src/glx/glx_pbuffer.c |3 +++
1 files ch
Send the new generic GLX swap event if supported by the client. This
means checking the client GLX version at swap complete time and
constructing a new generic swap completion event at swap complete time.
Signed-off-by: Jesse Barnes
---
configure.ac|2 +-
glx/glxdri2.c
Pass the right drawable pointer as data to the swap complete function.
Signed-off-by: Jesse Barnes
---
glx/glxdri2.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/glx/glxdri2.c b/glx/glxdri2.c
index d979717..93c5e5b 100644
--- a/glx/glxdri2.c
+++ b/glx/glxdri2.c
@@ -2
The existing swap event structure is too big to fit in an XEvent, so
support servers that send generic events instead. Do this by
advertising the GLX proto version we support when connecting and check
for generic events in the event stream. Convert any received events
into regular swap complete e
The existing event is too large for an XEvent meaning that the swap
count is never sent to clients. Create a generic event instead for use
by new clients & servers.
Signed-off-by: Jesse Barnes
---
configure.ac |2 +-
glxproto.h | 18 ++
2 files changed, 19 insertions(+),
The existing swap event structure is too large to fit in an XEvent, so new
servers will send a generic event if the client supports it. This
allows a valid swap count value to be sent along with the event type,
timestamp, and media stamp. Check for server support based on the
advertised DRI2 vers
Ended up moving over to generic events since the GLX type code is part
of the GLX namespace and larger than 8 bits.
Apparently no one had ever tried ChangeDrawableAttributes with indirect
clients, because simply going a glXSelectEvent causes a crash in that
case. So this patch set includes a fix
Seems simple enough.
Is pixman_disable_out_of_bounds_workaround now just a no-op, or was the symbol
removed from pixman? Hopefully the former, but I wanted to make sure...
Reviewed-by: Jeremy Huddleston
On May 3, 2011, at 3:36 AM, Søren Sandmann wrote:
> From: Søren Sandmann Pedersen
>
> P
Ok, then I'll just
On May 3, 2011, at 8:59 AM, Alan Coopersmith wrote:
> On 05/ 2/11 11:00 PM, Jeremy Huddleston wrote:
>>> http://people.freedesktop.org/~jeremyhu/analyzer/yuffie/20110429-1617/libXi/report-yDDyYj.html#EndPath
>>> "undefined allocation of 0 bytes" would be a server bug afaict
>>
On 05/ 2/11 11:00 PM, Jeremy Huddleston wrote:
>> http://people.freedesktop.org/~jeremyhu/analyzer/yuffie/20110429-1617/libXi/report-yDDyYj.html#EndPath
>> "undefined allocation of 0 bytes" would be a server bug afaict
>
> I dunno... is there anywhere that we guarantee that Xmalloc(0) returns NULL
On Tue, May 03, 2011 at 08:16:07AM -0700, Alan Coopersmith wrote:
> On 05/ 2/11 11:05 PM, Jeremy Huddleston wrote:
> > In fact, should we just move xorg-tls.m4 into util-macros?
>
> Are we likely to be using it in anything outside the X server?
The tls_model bit is too specialized, I think. I'd l
On Mon, May 02, 2011 at 11:29:49PM -0700, Jeremy Huddleston wrote:
> On May 2, 2011, at 11:24 PM, Peter Hutterer wrote:
> > On Mon, May 02, 2011 at 11:11:26PM -0700, Jeremy Huddleston wrote:
> >> I dislike macros. Why don't we make all those inline functions
> >> instead? That is so much cleaner.
On 05/ 2/11 11:05 PM, Jeremy Huddleston wrote:
>
> On May 2, 2011, at 10:25 PM, Peter Hutterer wrote:
>> Reviewed-by: Peter Hutterer
>> (I'd obviously prefer if this patch is held back until the macros are
>> released)
>
> Ditto on that.
Right - I had no intention of asking Keith to pull until
Actually, I did try to cc Keith et al, but I think that Thunderbird may have
been confused by the combination of NNTP (Gmane) and SMTP.
On May 2, 2011 1:20 PM, "Simon Thum" wrote:
> Hi Ian,
>
> you seem not to be used to mailing lists. You should cc all the people
> you want to read this mail, i.e
On Thu, Apr 07, 2011 at 08:50:56AM -0700, Keith Packard wrote:
> On Thu, 07 Apr 2011 12:26:56 +0200, Michel Dänzer wrote:
>
> > Anyway, you know where you can find testers for your patch.
>
> Are you willing to test and review it? I don't know of anyone else
> interested and capable.
>
> --
>
Hi,
On Mon, May 02, 2011 at 07:44:15AM -0400, Søren Sandmann wrote:
> The interface to these function was was very confusing since it gave
> the impression that they initialized the region from a list of boxes,
> which they didn't.
>
> This patch changes the interface to take just one box and fix
On Tue, May 03, 2011 at 01:50:28PM +1000, Peter Hutterer wrote:
> Reported-by: Roger Cruz
> Signed-off-by: Peter Hutterer
For the series:
Reviewed-by: Daniel Stone
Cheers,
Daniel
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.
From: Søren Sandmann Pedersen
Pixman used to have a workaround for a bug in old X servers, and this
function was used to disable that workaround in servers known to be
fixed.
In current versions of pixman, including the version the X server
depends on, the workaround doesn't exist anymore, so th
46 matches
Mail list logo
