Re: [PATCH synaptics 0/15] Predictable motion, better accel & smooth-scrolling

2011-06-13 Thread Peter Hutterer
On Thu, Jun 09, 2011 at 08:09:04PM +0100, Daniel Stone wrote: > Hi, > The attached patchset is the first part of the touchpad work we did for > ChromiumOS, which is applicable to all Synaptics touchpads. The main > thrust of this patchset is to make motion as predictable as possible: we > use hard

Re: [PATCH 15/15] Initial smooth scrolling support

2011-06-13 Thread Peter Hutterer
On Thu, Jun 09, 2011 at 08:57:36PM +0100, Daniel Stone wrote: > Post smooth-scrolling events through the new X server API when > available, rather than legacy jerky button events. > > Signed-off-by: Daniel Stone > --- > src/synaptics.c| 58 +-

Re: [PATCH 14/15] Prepare ScrollData for smooth scrolling

2011-06-13 Thread Peter Hutterer
On Thu, Jun 09, 2011 at 08:57:35PM +0100, Daniel Stone wrote: > Convert ScrollData from up/down/left/right members for button presses, > to more fine-grained x and y members. > > Signed-off-by: Daniel Stone > --- Reviewed-by: Peter Hutterer Cheers, Peter > src/synaptics.c | 119 ++

Re: [PATCH 13/15] Modify ScrollData in repeat_scrollbuttons

2011-06-13 Thread Peter Hutterer
On Thu, Jun 09, 2011 at 08:57:34PM +0100, Daniel Stone wrote: > repeat_scrollbuttons used to read the scroll repeat values and then post > button events directly. Instead, make it modify ScrollData and let > post_scroll_events take care of sending the scroll events, which > requires moving the rep

Re: [PATCH 12/15] Clarify rep_buttons assignment

2011-06-13 Thread Peter Hutterer
On Thu, Jun 09, 2011 at 08:57:33PM +0100, Daniel Stone wrote: > Instead of a combined variable declaration with two ternary expressions > using raw hex values, expand it to have two genuine if statements, > setting with a more clear bitshift. > > Signed-off-by: Daniel Stone > --- > src/synaptics

Re: [PATCH 09/15] Add four new motion filters

2011-06-13 Thread Peter Hutterer
On Thu, Jun 09, 2011 at 08:57:30PM +0100, Daniel Stone wrote: > From: Derek Foreman > > Attempt to decrease the possibility of errant motion as much as possible > by adding three new configurable filters, disabled by default: > - Synaptics Max Jerk: maximum change in acceleration before the >

Re: [PATCH 08/15] More accurate extrapolated fake motion events

2011-06-13 Thread Peter Hutterer
On Thu, Jun 09, 2011 at 08:57:29PM +0100, Daniel Stone wrote: > From: Derek Foreman > > Use better time estimates so we can provide better fake motion events. > This reduces the difference between motion with one and two fingers down > to be almost imperceptible, despite the reporting rate being

Re: [PATCH 05/28] Input: Convert ValuatorMask to double-precision internally

2011-06-13 Thread Peter Hutterer
On Fri, Jun 10, 2011 at 10:09:36PM +0200, Simon Thum wrote: > On 06/09/2011 07:17 PM, Daniel Stone wrote: > > Switch the ValuatorMask struct to using doubles instead of ints for the > > actual values. Preserve the old int API, and (attempt to) round towards > > zero for values we return. > It's ni

Re: [PATCH 07/15] Replace the motion estimator

2011-06-13 Thread Peter Hutterer
On Thu, Jun 09, 2011 at 08:57:28PM +0100, Daniel Stone wrote: > From: Derek Foreman > > Use a smarter motion estimator that attempts to draw a best-fit line > through the history where possible, including taking acceleration into > account. > > Signed-off-by: Derek Foreman > Reviewed-by: Daniel

Re: [PATCH 06/15] Use hardware time where possible

2011-06-13 Thread Peter Hutterer
On Thu, Jun 09, 2011 at 08:57:27PM +0100, Daniel Stone wrote: > From: Derek Foreman > > Rather than always setting hw->millis as the time when we received the > event in our SIGIO handler, use the time provided by the kernel if > applicable (i.e. if we're using evdev rather than PS/2 or similar).

Re: [PATCH 04/15] Introduce POLL_MS for packet frequency

2011-06-13 Thread Peter Hutterer
On Thu, Jun 09, 2011 at 08:57:25PM +0100, Daniel Stone wrote: > We expect to be receiving a steady 80 packets/sec (which gives 40 > reports/sec with more than one finger on the pad, as Advanced Gesture > Mode requires two PS/2 packets per report). Instead of a random > scattering of magic 13 and 2

Re: [PATCH 01/15] Fix pressure->motion property format

2011-06-13 Thread Peter Hutterer
On Thu, Jun 09, 2011 at 08:57:22PM +0100, Daniel Stone wrote: > From: Derek Foreman > > UINT32, not float. not that a negative value would make sense here but the driver (and your code) uses int internally so a commit message fixup would be in order. in this case we should also check for negativ

Re: [PATCH input-synaptics 5/5] Regroup the distribution makefile rules together

2011-06-13 Thread Peter Hutterer
On Mon, Jun 13, 2011 at 07:43:31PM -0400, Gaetan Nadon wrote: > Just moving statements, no change. > These rules are common to all 240 X.Org modules and are maintained > by scripts. They are at the bottom of the file. > > Signed-off-by: Gaetan Nadon > --- > Makefile.am | 14 +++--- > 1

Re: [PATCH input-synaptics 0/5] Fix a number of module configuration regressions

2011-06-13 Thread Peter Hutterer
On Mon, Jun 13, 2011 at 07:43:26PM -0400, Gaetan Nadon wrote: > Aside from one packaging error, mostly adding confusion and causing extra > work. tbh, I'd rather prefer reverting the changes and then implementing your changes on top. In your patch 4/5 we'd restore the behaviour to before 39afe69a

Re: [PATCH 3/3] dix: support the transformation matrix for relative devices.

2011-06-13 Thread Peter Hutterer
On Fri, Jun 10, 2011 at 09:00:37PM +0200, Simon Thum wrote: > On 06/09/2011 02:14 AM, Peter Hutterer wrote: > > On Wed, Jun 08, 2011 at 07:30:52PM +0200, Simon Thum wrote: > >> (I removed some text) > >> > I think "my" wiki page has a scenario for high-resolution mice, plus > some users a

Re: [PATCH fpit 0/5] Add .conf file distribution

2011-06-13 Thread Gaetan Nadon
On Tue, 2011-06-14 at 09:47 +1000, Peter Hutterer wrote: > Upstreaming from our Fedora package which ships with this file. Patches 1-4 > are just cleanup to make 5/5 not hurt too much. It distchecks, which means > this patchset has seen about as much testing as the last couple of releases. > For

[PATCH fpit 5/5] Add 50-fpit.conf default configuration file.

2011-06-13 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- Makefile.am | 10 -- conf/50-fpit.conf | 28 conf/Makefile.am |3 +++ configure.ac | 12 +++- 4 files changed, 50 insertions(+), 3 deletions(-) create mode 100644 conf/50-fpit.conf create mode 1

[PATCH fpit 2/5] Include xorg-server.h, not xorgVersion.h

2011-06-13 Thread Peter Hutterer
xorg-server is the generic server header file these days. Signed-off-by: Peter Hutterer --- src/xf86Fpit.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/xf86Fpit.c b/src/xf86Fpit.c index 592a0ec..fa4ace7 100644 --- a/src/xf86Fpit.c +++ b/src/xf86Fpit.c @@ -54,7 +5

[PATCH fpit 4/5] Remove usage of sdkdir - not used by this driver

2011-06-13 Thread Peter Hutterer
This driver doesn't install any header files. Signed-off-by: Peter Hutterer --- configure.ac |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index ea274fc..74c5858 100644 --- a/configure.ac +++ b/configure.ac @@ -57,8 +57,6 @@ XORG_DRIVER_CHE

[PATCH fpit 3/5] Reshuffle configure.ac to be more in-line with other modules

2011-06-13 Thread Peter Hutterer
Also bump required macros to 1.12. Signed-off-by: Peter Hutterer --- configure.ac | 27 --- 1 files changed, 8 insertions(+), 19 deletions(-) diff --git a/configure.ac b/configure.ac index ad66332..ea274fc 100644 --- a/configure.ac +++ b/configure.ac @@ -27,23 +27,21 @

[PATCH fpit 1/5] Bump minimum required server version to 1.10

2011-06-13 Thread Peter Hutterer
And remove manual ABI check, all 1.10 servers ship with ABI 12. Signed-off-by: Peter Hutterer --- configure.ac |4 ++-- src/xf86Fpit.c |4 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/configure.ac b/configure.ac index 9c3a9a0..ad66332 100644 --- a/configure.ac ++

[PATCH fpit 0/5] Add .conf file distribution

2011-06-13 Thread Peter Hutterer
Upstreaming from our Fedora package which ships with this file. Patches 1-4 are just cleanup to make 5/5 not hurt too much. It distchecks, which means this patchset has seen about as much testing as the last couple of releases. Cheers, Peter ___ xorg-

Synaptics: a number of issues with commit 39afe69ad7d2

2011-06-13 Thread Gaetan Nadon
Commit http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics/commit/?id=39afe69ad7d2258d4043044d1283bd6e311e48da build: collapse all Makefile.am files into a single non-recursive one. With this change, the whole of the build is done non-recursively in the top-level Makefile

[PATCH input-synaptics 5/5] Regroup the distribution makefile rules together

2011-06-13 Thread Gaetan Nadon
Just moving statements, no change. These rules are common to all 240 X.Org modules and are maintained by scripts. They are at the bottom of the file. Signed-off-by: Gaetan Nadon --- Makefile.am | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/Makefile.am b/Ma

[PATCH input-synaptics 4/5] man: restore the standard man pages makefile

2011-06-13 Thread Gaetan Nadon
The X.Org 176 man pages directories use the same coding pattern in a dedicated makefile. Also restores the copyright for the moved code. This allows scripted maintenance. Prevents makefile from being accidentally broken One can work on man pages makefiles without having to test driver One can work

[PATCH input-synaptics 3/5] man: there is no need to create the "man" source directory

2011-06-13 Thread Gaetan Nadon
This directory is created when the source code is extracted from git. There are 175 other man pages directories in X.Org and none are created from the makefile. Signed-off-by: Gaetan Nadon --- Makefile.am |7 +-- 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/Makefile.am

[PATCH input-synaptics 2/5] Do not install ChangeLog and README with documentation

2011-06-13 Thread Gaetan Nadon
The content and location of these files are governed by the GNU Build System architecture. They are expected to be found in the root directory of the package. They are included in the tarball automatically by Automake and require no explicit 'dist' action. Signed-off-by: Gaetan Nadon --- Makefil

[PATCH input-synaptics 1/5] Use appropriate Autoconf statements to check for prerequisites

2011-06-13 Thread Gaetan Nadon
Using m4 to check for macro defined by the xserver to ensure it is installed will work as long as the macro is not removed. The preferred way of checking for dependencies is to use PKG_CHECK_MODULE. The check for XORG_MACROS_VERSION was done this way because there was no pkgconfig file for the mod

[PATCH input-synaptics 0/5] Fix a number of module configuration regressions

2011-06-13 Thread Gaetan Nadon
Aside from one packaging error, mostly adding confusion and causing extra work. Gaetan Nadon (5): Use appropriate Autoconf statements to check for prerequisites Do not install ChangeLog and README with documentation man: there is no need to create the "man" source directory man: restore th

Re: [PATCH mouse] Fix wrong read Protocol and Device from xorg.conf

2011-06-13 Thread Peter Hutterer
On Tue, Jun 14, 2011 at 12:31:14AM +0600, Alexandr Shadchin wrote: > Before call xf86CollectInputOptions(): > pInfo->options - empty > > Need use pInfo->conf_idev->commonOptions instead pInfo->options thanks. Unfortunately, this won't work in servers 1.10 and later as conf_idev is gone now. I

[PATCH xkeyboard-config v2] Use XSL to generate man page from the rules XML

2011-06-13 Thread Peter Hutterer
Generate a man-page from the evdev.xml through the xslt/man.xsl stylesheet. Adds a requirement on the xorg util-macros and xsltproc. Signed-off-by: Peter Hutterer Reviewed-by: Dan Nicholson Reviewed-by: Gaetan Nadon --- Changes to v1: - more table-specific syntax to soothe the eyes ;) - remove

Re: xf86-video-intel fails make check

2011-06-13 Thread Chris Wilson
On Mon, 13 Jun 2011 11:10:49 -0700, Jeremy Huddleston wrote: > Please address this ASAP, and let me know when it is fixed, so I can remove > the kludgery that I put in place in the tinderbox. If your kludge was to exclude the extremely long running tests from make distcheck... Then I just appli

[PATCH mouse] Fix wrong read Protocol and Device from xorg.conf

2011-06-13 Thread Alexandr Shadchin
Before call xf86CollectInputOptions(): pInfo->options - empty Need use pInfo->conf_idev->commonOptions instead pInfo->options Signed-off-by: Alexandr Shadchin --- src/mouse.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mouse.c b/src/mouse.c index c3498ea.

xf86-video-intel fails make check

2011-06-13 Thread Jeremy Huddleston
Hi Chris, Your xf86-intel patch bcef98af561939aa48d9236b2dfa2c5626adf4cb seems to have causes xf86-video-intel to fail 'make check': http://tinderbox.x.org/builds/2011-06-04-0001/logs/xf86-video-intel It just starts hanging during make check. Your bcef98af patch was the only change in xf86-vi

[PATCH] xfree86: Use correct size while reallocation gamma ramp

2011-06-13 Thread Rahul Singhal
Thanks, Rahul Singhal --- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If

[PATCH xserver] Install xml versions of specs even if HAVE_XMLTO is false

2011-06-13 Thread Gaetan Nadon
DocBook/XML input source is also a usefull output format that can be viewed with an XML viewer or editor and by some O/S help system. Signed-off-by: Gaetan Nadon --- doc/dtrace/Makefile.am |2 -- docbook.am |2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a