[PATCH 2/4 v3] os/log: Add LogVHdrMessageVerb and friends

2011-08-05 Thread Daniel Kurtz
LogVHdrMessageVerb allows a custom header to be inserted in a log message, between the Log system's MessageType string, and a formatted variable message body. The custom header can itself be a formatted variable string. These functions can be used, for example, by driver abstraction layers to

[PATCH 1/4 v3] os/log: Pull LogMessageTypeVerbString out of LogVMessageVerb

2011-08-05 Thread Daniel Kurtz
Also, optimize how the type and format strings are combined. Signed-off-by: Daniel Kurtz djku...@chromium.org --- os/log.c | 105 + 1 files changed, 57 insertions(+), 48 deletions(-) diff --git a/os/log.c b/os/log.c index

[PATCH 3/4 v3] xf86Helper: use LogHdrMessageVerb in xf86VIDrvMsgVerb

2011-08-05 Thread Daniel Kurtz
LogHdrMessageVerb allows passing a parameterized header to insert in a log message between MessageType and the formatted message body string. Signed-off-by: Daniel Kurtz djku...@chromium.org Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- hw/xfree86/common/xf86Helper.c | 25

[PATCH 0/4 v3] Use static buffers to log from driver signal handlers

2011-08-05 Thread Daniel Kurtz
For Version 3: * 0001: Make cleaner and faster per Guillem Jover review comments. * 0002: Make slightly faster and fix some comments. Back in the bad old days, using xf86Msg() from a signal handler was a big no-no, as it would deadlock the system on malloc when the prefix is prepended. Thus,

[PATCH 4/4 v3] xf86Helper: use LogHdrMessageVerb in xf86VDrvMsgVerb

2011-08-05 Thread Daniel Kurtz
LogHdrMessageVerb allows passing a parameterized header to insert in a log message between MessageType and the formatted message body string. Signed-off-by: Daniel Kurtz djku...@chromium.org Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- hw/xfree86/common/xf86Helper.c | 25

Re: [PATCH 0/4 v3] Use static buffers to log from driver signal handlers

2011-08-05 Thread Mark Kettenis
From: Daniel Kurtz Date: Fri, 5 Aug 2011 15:09:57 +0800 For Version 3: * 0001: Make cleaner and faster per Guillem Jover review comments. * 0002: Make slightly faster and fix some comments. Back in the bad old days, using xf86Msg() from a signal handler was a big no-no, as it would

Re: [PATCH 1/4 v3] os/log: Pull LogMessageTypeVerbString out of LogVMessageVerb

2011-08-05 Thread Guillem Jover
Hi! On Fri, 2011-08-05 at 15:09:58 +0800, Daniel Kurtz wrote: diff --git a/os/log.c b/os/log.c index f519762..56e5b80 100644 --- a/os/log.c +++ b/os/log.c @@ -325,58 +328,64 @@ LogWrite(int verb, const char *f, ...) va_end(args); } +/* Returns the Message Type string to prepend

Re: [PATCH 2/5] Use correct swap{l,s} (or none at all for CARD8)

2011-08-05 Thread walter harms
hi matt, I am not sure if i understand the purpose of swap() really. do you generaly swap bytes ? then you may like a look at swab() (man 3 swab). On the other side when endianes is a problem ntoh() and friends may be more friendly. the macro uses sizeof((src)) != 2 perhaps you can use int16_t

[PATCH 3/4 v4] xf86Helper: use LogHdrMessageVerb in xf86VIDrvMsgVerb

2011-08-05 Thread Daniel Kurtz
LogHdrMessageVerb allows passing a parameterized header to insert in a log message between MessageType and the formatted message body string. Signed-off-by: Daniel Kurtz djku...@chromium.org Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- hw/xfree86/common/xf86Helper.c | 25

[PATCH 0/4 v4] Use static buffers to log from driver signal handlers

2011-08-05 Thread Daniel Kurtz
For Version 4: * 0001: Fix more Guillem Jover review comments... Thanks! * 0001: Reviewed-by: Guillem Jover guil...@hadrons.org Back in the bad old days, using xf86Msg() from a signal handler was a big no-no, as it would deadlock the system on malloc when the prefix is prepended. Thus, only

[PATCH 4/4 v4] xf86Helper: use LogHdrMessageVerb in xf86VDrvMsgVerb

2011-08-05 Thread Daniel Kurtz
LogHdrMessageVerb allows passing a parameterized header to insert in a log message between MessageType and the formatted message body string. Signed-off-by: Daniel Kurtz djku...@chromium.org Reviewed-by: Peter Hutterer peter.hutte...@who-t.net --- hw/xfree86/common/xf86Helper.c | 25

[PATCH 2/4 v4] os/log: Add LogVHdrMessageVerb and friends

2011-08-05 Thread Daniel Kurtz
LogVHdrMessageVerb allows a custom header to be inserted in a log message, between the Log system's MessageType string, and a formatted variable message body. The custom header can itself be a formatted variable string. These functions can be used, for example, by driver abstraction layers to

[PATCH 1/4 v4] os/log: Pull LogMessageTypeVerbString out of LogVMessageVerb

2011-08-05 Thread Daniel Kurtz
Also, optimize how the type and format strings are combined. Signed-off-by: Daniel Kurtz djku...@chromium.org Reviewed-by: Guillem Jover guil...@hadrons.org --- os/log.c | 106 ++ 1 files changed, 58 insertions(+), 48 deletions(-)

Re: [PATCH 2/5] Use correct swap{l,s} (or none at all for CARD8)

2011-08-05 Thread Daniel Stone
Hi, On Fri, Aug 05, 2011 at 04:07:13PM +0200, walter harms wrote: I am not sure if i understand the purpose of swap() really. To account for different byte ordering (rather than bit ordering) on machines of different endianness. The bit ordering is already taken care of for us by everyone

Re: [PATCH 4/4 v4] xf86Helper: use LogHdrMessageVerb in xf86VDrvMsgVerb

2011-08-05 Thread walter harms
Am 05.08.2011 16:20, schrieb Daniel Kurtz: LogHdrMessageVerb allows passing a parameterized header to insert in a log message between MessageType and the formatted message body string. Signed-off-by: Daniel Kurtz djku...@chromium.org Reviewed-by: Peter Hutterer peter.hutte...@who-t.net

Re: [PATCH 2/5] Use correct swap{l,s} (or none at all for CARD8)

2011-08-05 Thread walter harms
Am 05.08.2011 16:34, schrieb Daniel Stone: Hi, On Fri, Aug 05, 2011 at 04:07:13PM +0200, walter harms wrote: I am not sure if i understand the purpose of swap() really. To account for different byte ordering (rather than bit ordering) on machines of different endianness. The bit

Re: [PATCH 4/4 v4] xf86Helper: use LogHdrMessageVerb in xf86VDrvMsgVerb

2011-08-05 Thread Daniel Kurtz
Hi! On Fri, Aug 5, 2011 at 10:35 PM, walter harms wha...@bfs.de wrote: Am 05.08.2011 16:20, schrieb Daniel Kurtz: LogHdrMessageVerb allows passing a parameterized header to insert in a log message between MessageType and the formatted message body string. Signed-off-by: Daniel Kurtz

Re: [PATCH 2/5] Use correct swap{l,s} (or none at all for CARD8)

2011-08-05 Thread Jonathan Morton
On Fri, 2011-08-05 at 16:54 +0200, walter harms wrote: there are the htonl() etc. what do automatic the right thing. That works just fine when the wire protocol is defined in network order, ie. big-endian, which is very common for proper, grown-up Internet protocols. You still need to use the

Re: [PATCH 2/5] Use correct swap{l,s} (or none at all for CARD8)

2011-08-05 Thread Mikhail Gusarov
Twas brillig at 16:54:57 05.08.2011 UTC+02 when wha...@bfs.de did gyre and gimble: wh But is this a common problem in network programming ? In X11 client decides the byte order, and server has to deal with what comes over the wire. Most of the protocols have fixed endianess, so they might use

[PATCH libX11] credits.xml: remove toc from Acknowledgments

2011-08-05 Thread Gaetan Nadon
There should be no toc for a simple preface with only one Acknowledgments section. Use simplesect markup rather than sect1. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- specs/libX11/credits.xml | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git

Re: [PATCH libXaw3d] Add .gitignore to filter out all the compile artifacts

2011-08-05 Thread Matt Turner
On Tue, Aug 2, 2011 at 5:18 PM, Gaetan Nadon mems...@videotron.ca wrote: git://people.freedesktop.org/~mattst88/libXaw3d Signed-off-by: Gaetan Nadon mems...@videotron.ca ---  .gitignore |   78  1 files changed, 78 insertions(+),

[PATCH inputproto multitouch 7/9] Remove touch Observe grabs

2011-08-05 Thread Chase Douglas
The semantics of these grabs doesn't work for all use cases. Raw touch events will likely work better. Signed-off-by: Chase Douglas chase.doug...@canonical.com --- XI2.h |2 -- specs/XI2proto.txt | 18 +++--- 2 files changed, 3 insertions(+), 17 deletions(-) diff

[PATCH inputproto multitouch 4/9] Prettyify touch device types

2011-08-05 Thread Chase Douglas
Signed-off-by: Chase Douglas chase.doug...@canonical.com --- specs/XI2proto.txt |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/specs/XI2proto.txt b/specs/XI2proto.txt index 2fd3c45..4432035 100644 --- a/specs/XI2proto.txt +++ b/specs/XI2proto.txt @@ -343,12 +343,12 @@

[PATCH inputproto multitouch 3/9] Update device type terminology

2011-08-05 Thread Chase Douglas
Remove IndepedentTouch and SemiMultitouch devices. These may be handled in an implementation specific manner through the props array of ATOMs in the touch class information. Signed-off-by: Chase Douglas chase.doug...@canonical.com --- XI2.h |2 -- specs/XI2proto.txt | 37

[PATCH inputproto multitouch 6/9] Fix up pointer event emulation section

2011-08-05 Thread Chase Douglas
* Wording cleanups for tense and to make some sentences flow better. * Upon further review, it does seem to make more sense to deliver emulated pointer events through the same slave device rather than the master device. Thus, slave devices (including floating devices) may emit emulated

[PATCH inputproto multitouch 0/9] Another round of changes

2011-08-05 Thread Chase Douglas
I have taken the latest inputproto branch and the latest multitouch branch from Daniel and merged them. I then added these nine patches on top. My working branch is located at: http://cgit.freedesktop.org/~cndougla/inputproto/ multitouch Patches 1-6 are of the simple rewrite, cleanup, clarify,

[PATCH inputproto multitouch 1/9] Separate XI2.x into XI 2.x for readability

2011-08-05 Thread Chase Douglas
Signed-off-by: Chase Douglas chase.doug...@canonical.com --- specs/XI2proto.txt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/specs/XI2proto.txt b/specs/XI2proto.txt index 0212a4a..9763d8a 100644 --- a/specs/XI2proto.txt +++ b/specs/XI2proto.txt @@ -71,7 +71,7 @@ The

[PATCH inputproto multitouch 2/9] Yes, send TouchEnd to owner, TouchPendingEnd to other listeners

2011-08-05 Thread Chase Douglas
Signed-off-by: Chase Douglas chase.doug...@canonical.com --- specs/XI2proto.txt |9 - 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/specs/XI2proto.txt b/specs/XI2proto.txt index 9763d8a..b592cfe 100644 --- a/specs/XI2proto.txt +++ b/specs/XI2proto.txt @@ -336,15

[PATCH inputproto multitouch 5/9] Peter is right, floating devices can emit touch events

2011-08-05 Thread Chase Douglas
Signed-off-by: Chase Douglas chase.doug...@canonical.com --- specs/XI2proto.txt | 10 -- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git a/specs/XI2proto.txt b/specs/XI2proto.txt index 4432035..3452428 100644 --- a/specs/XI2proto.txt +++ b/specs/XI2proto.txt @@ -375,16

[PATCH inputproto multitouch 9/9] Specify dependent device pointer/touch handling

2011-08-05 Thread Chase Douglas
With the added rules, trackpads should be manageable no matter what occurs (button presses and pointer motion). Gesture and touch semantics during these actions are not well defined, and cancelling touches cleans up the protocol and implementation. Signed-off-by: Chase Douglas

[PATCH inputproto multitouch 8/9] Use the same valuator axes for pointer and touch events

2011-08-05 Thread Chase Douglas
Signed-off-by: Chase Douglas chase.doug...@canonical.com --- XI2proto.h | 15 --- specs/XI2proto.txt | 68 ++- 2 files changed, 14 insertions(+), 69 deletions(-) diff --git a/XI2proto.h b/XI2proto.h index a631335..6991fda 100644