Re: [PATCH xserver 1/2] Xi: Fix passive XI2 ungrabs on XIAll[Master]Devices

2011-09-01 Thread Peter Hutterer
On Wed, Aug 31, 2011 at 12:46:52AM +0200, carl...@gnome.org wrote: > From: Carlos Garnacho > > The corresponding DeviceIntPtr wasn't being gotten properly, > resulting in BadDevice from dixLookupDevice(). > > Signed-off-by: Carlos Garnacho > --- > Xi/xipassivegrab.c | 13 ++--- > 1 f

Re: [PATCH xserver 2/2] Xi: Fix passive key grabs on XIAll[Master]Devices

2011-09-01 Thread Peter Hutterer
On Wed, Aug 31, 2011 at 12:46:53AM +0200, carl...@gnome.org wrote: > From: Carlos Garnacho > > The KeyClass is not set for these DeviceIntRec, but it's only used > for XI1 grabs in order to check the XKB keycode range, and > XIAll[Master]Devices doesn't apply there. So only spare the NULL > check

[PATCH 2/2] input: switch miPointerSetPosition to expect desktop-wide coordinates.

2011-09-01 Thread Peter Hutterer
miPointerSetPosition traditionally took coordinates on a per-screen basis, triggering a screen switch when these went out-of-bounds. Change it to take desktop-coordinates instead and trigger screen switches when these coordinates are not on the current screen. This unifies the pointer behaviour of

[PATCH 1/2] Move pointOnScreen to inpututils.c

2011-09-01 Thread Peter Hutterer
We need this from other files too. Signed-off-by: Peter Hutterer --- dix/events.c | 11 ++- dix/inpututils.c |8 include/input.h |2 ++ 3 files changed, 12 insertions(+), 9 deletions(-) diff --git a/dix/events.c b/dix/events.c index 8935ad9..199d115 100644 --- a/

[PATCH 0/2] Fixing screen crossing for Zaphod

2011-09-01 Thread Peter Hutterer
Handling of multiple ScreenRecs is still an issue. We've had a problem for several years now where absolute devices get stuck on the right-most screen [1] This is basically just a scaling bug that can be fixed by extending the scaling range from 0...width to -1..width. This still gives us bad beh

Re: [PATCH libXaw] Remove include directive to

2011-09-01 Thread Yaakov (Cygwin/X)
On Thu, 2011-09-01 at 19:26 -0400, Gaetan Nadon wrote: > The -I directive to include/X11/Xaw is removed which will alert > developers not to include header files with quotes unless they are in > the /src directory. > > Currently no offending includes were found. > > Signed-off-by: Gaetan Nadon

[PATCH libXaw3d] Fix build after f28531a33d1f28bc86626b3013ef7857b564647f

2011-09-01 Thread Yaakov (Cygwin/X)
From: Yaakov Selkowitz Signed-off-by: Yaakov Selkowitz --- src/laygram.y |2 +- src/laylex.l |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/laygram.y b/src/laygram.y index 1ac05a0..3644dd4 100644 --- a/src/laygram.y +++ b/src/laygram.y @@ -10,7 +10,7 @@ #i

Re: libXaw3d: Changes to 'master'

2011-09-01 Thread Yaakov (Cygwin/X)
On Thu, 2011-09-01 at 10:52 -0700, Gaetan Nadon wrote: > New commits: > commit daaa028c111276c3ba4d60b454f0fe39bf10666e > Author: Gaetan Nadon > Date: Tue Aug 30 22:06:36 2011 -0400 > > Add missing AC_CONFIG_HEADERS > > This is a requirement for all modules. > www.gnu.org/softw

[PATCH v2 7/7] dix: NewCurrentScreen must work on pointers where possible

2011-09-01 Thread Peter Hutterer
When a screen switch is triggered by PointerKeys, the device for NewCurrentScreen is the keyboard. Submitting pointer events for this keyboard (without valuators) has no effect as GPE ignores the event. Force the dequeuing through the XTest device attached to this device. Signed-off-by: Peter Hut

[PATCH libXaw] Remove include directive to

2011-09-01 Thread Gaetan Nadon
The -I directive to include/X11/Xaw is removed which will alert developers not to include header files with quotes unless they are in the /src directory. Currently no offending includes were found. Signed-off-by: Gaetan Nadon --- src/Makefile.am |1 - 1 files changed, 0 insertions(+), 1 del

Re: [PATCH] RFCv2: video support for dri2

2011-09-01 Thread Rob Clark
On Thu, Sep 1, 2011 at 5:22 PM, Younes Manton wrote: > On Thu, Sep 1, 2011 at 4:52 PM, Rob Clark wrote: >> To allow the potential use of overlays to display video content, a few >> extra parameters are required: >> >>  + source buffer in different format (for example, various YUV formats) >>   an

X.Org Developer's Conference: content needed

2011-09-01 Thread Alan Coopersmith
Two weeks from today, we should all be satisfied that we just spent three days at a useful, fun, and well-run X.Org Developer's Conference. However, in order to make that happen, we need your help! http://www.x.org/wiki/Events/XDC2011/Program currently does not have 3 days worth of content on it

Re: [PATCH] RFCv2: video support for dri2

2011-09-01 Thread Younes Manton
On Thu, Sep 1, 2011 at 4:52 PM, Rob Clark wrote: > To allow the potential use of overlays to display video content, a few > extra parameters are required: > >  + source buffer in different format (for example, various YUV formats) >   and size as compared to destination drawable >  + multi-planar

[PATCH] RFCv2: video support for dri2

2011-09-01 Thread Rob Clark
To allow the potential use of overlays to display video content, a few extra parameters are required: + source buffer in different format (for example, various YUV formats) and size as compared to destination drawable + multi-planar formats where discontiguous buffers are used for differen

Re: [PATCH libXaw3d 0/5] Fix old-style function definitions, round three

2011-09-01 Thread Matt Turner
On Wed, Aug 31, 2011 at 10:12 PM, Yaakov (Cygwin/X) wrote: > From: Yaakov Selkowitz > > This completes my work in fixing all the old-style function definitions, > and some other warnings which these fixes exposed.  The code is *much* > cleaner now; it should be a lot easier for others to help fix

Re: [PATCH libXaw3d 0/5] Fix old-style function definitions, round three

2011-09-01 Thread Gaetan Nadon
On Wed, 2011-08-31 at 21:12 -0500, Yaakov (Cygwin/X) wrote: > Yaakov Selkowitz (5): > MultiSink: Fix old-style function definitions > MultiSrc: Fix old-style function definitions > XawIm: Fix old-style function definitions > > Acked-by: Gaetan Nadon signature.asc Description: This is a

Re: [PATCH 0/7] Fix PointerKeys crash on switching ScreenRec

2011-09-01 Thread Keith Packard
On Thu, 1 Sep 2011 20:41:23 +1000, Peter Hutterer wrote: > Either way, 7/7 is the key here, the others just make sure to avoid future > similar cases like this. This one of the issues listed in > https://bugs.freedesktop.org/show_bug.cgi?id=38313 Would it be cleaner to make NewCurrentScreen ac

[PATCH 7/7] mi: add special handling for keyboard events on switching screens.

2011-09-01 Thread Peter Hutterer
When a screen switch is triggered by PointerKeys, the device for NewCurrentScreen is the keyboard. Submitting pointer events for this keyboard (without valuators) has no effect as GPE ignores the event. Force the dequeuing through the XTest device attached to this device. Signed-off-by: Peter Hut

[PATCH 6/7] mi: move switching screen on dequeue to separate helper function

2011-09-01 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- mi/mieq.c | 47 --- 1 files changed, 28 insertions(+), 19 deletions(-) diff --git a/mi/mieq.c b/mi/mieq.c index fc3738a..3a5aaf0 100644 --- a/mi/mieq.c +++ b/mi/mieq.c @@ -347,6 +347,30 @@ CopyGetMasterEvent(DeviceIn

[PATCH 5/7] dix: warn about keyboard events with valuator masks

2011-09-01 Thread Peter Hutterer
We don't actually handle the mask correctly. They're clipped and dropped into the event but that's about it. I don't think we did since 1.4, let's warn the user if this happens. Signed-off-by: Peter Hutterer --- dix/getevents.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff

[PATCH 4/7] dix: fill out root_x/y for keyboard events

2011-09-01 Thread Peter Hutterer
Switching screens relies on rootx/y to be set to the correct value. Though we technically take a mask for GetKeyboardEvents we don't actually handle it properly anyway, so this hack is acceptable for now. This should really be shared code with GPE but not today. Signed-off-by: Peter Hutterer ---

[PATCH 3/7] dix: don't allow keyboard devices to submit motion or button events.

2011-09-01 Thread Peter Hutterer
GPE unconditionally dereferences pDev->valuator if a mask is present. This shouldn't really happen but if it does, don't crash, just ignore the events with an error. Signed-off-by: Peter Hutterer --- dix/getevents.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git

[PATCH 2/7] dix: rename cx/cy into sx/sy in GetPointerEvents.

2011-09-01 Thread Peter Hutterer
cx/cy are legacy names (core x, core y). These days, sx/sy is more descriptive and less confusing. Signed-off-by: Peter Hutterer --- dix/getevents.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/dix/getevents.c b/dix/getevents.c index 6a5ff51..511c96c 1006

[PATCH 1/7] dix: update comments for moveAbsolute and moveRelative

2011-09-01 Thread Peter Hutterer
These functions don't actually move anything, they just calculate x/y and clip into ranges Signed-off-by: Peter Hutterer --- dix/getevents.c | 15 +-- 1 files changed, 9 insertions(+), 6 deletions(-) diff --git a/dix/getevents.c b/dix/getevents.c index a12462a..6a5ff51 100644 ---

[PATCH 0/7] Fix PointerKeys crash on switching ScreenRec

2011-09-01 Thread Peter Hutterer
Test case: 1) xorg.conf for two ScreenRecs 2) enable PointerKeys, move with keypad 4/6 across screens 3) Boom one of the above is a bug, even though RandR purists will argue that both 1 and 3 are not supposed to happen.. Either way, 7/7 is the key here, the others just make sure to avoid future

Re: randr: stop immutable output properties from being deleted (v2)

2011-09-01 Thread Rami Ylimäki
On 08/24/2011 01:26 AM, Luc Verhaegen wrote: On Wed, Aug 24, 2011 at 12:19:58AM +0200, Luc Verhaegen wrote: This version of the server side patch now no longer mangles the output properties list directly. This incurs a slight bit of overhead, in what is an extremely low frequency path anyway. It