Re: [PULL] bswap cleanup and misc patches

On Fri, Sep 2, 2011 at 7:05 PM, Matt Turner wrote: > The following changes since commit 0caeef6146bee5fb1827ab25db191685dde9d4b4: > >  Version bumped to 1.11 (2011-08-26 16:46:13 -0700) > > are available in the git repository at: >  git://people.freedesktop.org/~mattst88/xserver for-keith > > Matt

Re: drivers to de-support (was: [PATCH 2/3] xorg-server.pc.in: Remove libpciaccess and pixman-1 from Requires)

On Sat, Sep 17, 2011 at 8:55 PM, Michael wrote: > Hello, > > On Sat, 17 Sep 2011 11:59:29 -0400 > Matt Turner wrote: > >> Where's the SGI O2's video driver? It's still not hosted on FDO. I >> thought that was one reason you were getting commit access. > > cvs://anoncvs.netbsd.org/xsrc/external/mi

Re: [PATCH] Assign ids to more tags in Xserver-Dtrace.xml

Hi Alan, In the IDs attributes for funcdef, sect and chapter, I was keeping the id attributes matching the . (I've got a series of patches coming any day now(TM) to that effect,) Probes and their arguments would be: Probes and their arguments Is that appropriate here for consistency?

Re: [PATCH libXi multitouch 3/4] Define macros for unstable protocol development

On Sat, 2011-09-17 at 09:54 -0700, Chase Douglas wrote: > On 09/17/2011 06:53 AM, Gaetan Nadon wrote: > > On Sat, 2011-09-17 at 06:52 +1000, Peter Hutterer wrote: > >> On Wed, Sep 14, 2011 at 10:33:56PM -0700, Chase Douglas wrote: > >> > Signed-off-by: Chase Douglas >> >

Re: [PATCH:libXcursor] Set Xcursor.h version numbers from configure.ac

On Fri, 2011-09-16 at 21:45 -0700, Alan Coopersmith wrote: > ased on similar commit dac73a519816 to libXft > > Signed-off-by: Alan Coopersmith > --- > configure.ac | 19 ++- > include/X11/Xcursor/Xcursor.h| 500 > -- > include/X11/X

Re: [PATCH:libXi] Make shadow man pages generated by asciidoc work with Solaris man

On Fri, 2011-09-16 at 21:00 -0700, Alan Coopersmith wrote: > Solaris man requires .so entries in man pages include the man section > directory, not just the man page filename, even when it's in the same > directory, so use sed to add it in. > > Signed-off-by: Alan Coopersmith > --- > man/Makefi

Re: Xserver driver merging pros & cons

Do distro's share testing? I've seen comments on how testing diff versions of drivers against diff versions of the X server and having to deal with problems there. Can some of that be offloaded from the distros into Shuang He's auto-regression testing setup? I realize how that will grow in co

Re: [PATCH:xfs] Remove dependency on libFS, the client-side library

On Fri, 2011-09-16 at 19:26 -0700, Alan Coopersmith wrote: > xfs doesn't include nor call any functions from the > library, which is not surprising, as that's the library containing the > client-side code for connecting to a font server such as xfs. > > Signed-off-by: Alan Coopersmith > --- >

Re: [PATCH] Assign ids to more tags in Xserver-Dtrace.xml

On Fri, 2011-09-16 at 17:17 -0700, Alan Coopersmith wrote: > Keeps xsltproc from adding random-number id tags to html output so that > it's easier to see real changes vs. different random numbers. > > Signed-off-by: Alan Coopersmith > --- > doc/dtrace/Xserver-DTrace.xml | 14 +++--- >

[PATCH libXaw3d 2/2] Fix a couple of unused variable warnings

Signed-off-by: Matt Turner --- src/ThreeD.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/ThreeD.c b/src/ThreeD.c index 754b6e2..586242d 100644 --- a/src/ThreeD.c +++ b/src/ThreeD.c @@ -346,7 +346,6 @@ AllocTopShadowPixel (Widget new) XColor set_c; ThreeD

[PATCH libXaw3d 1/2] Fix a couple unused function warnings

Functions were only called inside ifdef blocks, but were defined outside. Signed-off-by: Matt Turner --- src/TextAction.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/src/TextAction.c b/src/TextAction.c index 7d1afcb..8d8fe00 100644 --- a/src/TextAction.c +++ b/src

Re: Xserver driver merging pros & cons

On Sat, 17 Sep 2011 13:04:13 +0200, Matthieu Herrb wrote: >3) makes it harder to maintain out of tree drivers, since API > breaks are not going to be documented anymore. > If old pre-kms code start to be removed, the people still > depending on them will need a forked X xs

Re: [PATCH xserver/hw/xfree86/modes/xf86Crtc.c] trivial memory leak

On Sat, Sep 17, 2011 at 12:55 PM, wrote: > Anyone willing to review this triviality ? The code is included below. > > This patch fixes a memory leak in xf86CrtcCreate().  It frees the > crtc->gamma_red buffer when a quit on error occurs. > > xf86CrtcPtr > xf86CrtcCreate (ScrnInfoPtr             s

Re: [PATCH 7/9] xnest: Delete unused nClipRects GC-private field.

On 09/17/11 01:22, Jamey Sharp wrote: This field was never read at any time in the git history. Signed-off-by: Jamey Sharp --- hw/xnest/GC.c |3 --- hw/xnest/XNGC.h |1 - 2 files changed, 0 insertions(+), 4 deletions(-) Reviewed-by: Alan Coopersmith -- -Alan Coopersmith

[PATCH xserver/hw/xfree86/parser/scan.c] potential buffer overrun

This patch fixes a potential buffer overrun in xf86addComment(). The overrun occurs if the comment string to add doesn't start with a leading '#'. The bug can be seen from the code assuming curlen > 0 && eol_seen == 0 && iscomment == 0 : char * xf86addComment(char *cur, char *add) <...>

Re: [PATCH 3/9] XineramaInitData ignores its argument. Quit passing one.

On 09/17/11 01:22, Jamey Sharp wrote: Also fix up XineramaInitData's caller, XineramaReinitData. Commit by Jamey Sharp and Josh Triplett. Signed-off-by: Jamey Sharp Signed-off-by: Josh Triplett --- Xext/panoramiX.c | 12 ++-- Xext/panoramiXsrv.h |2 +- hw/dmx/dmxextensi

[PATCH xserver/hw/xfree86/modes/xf86Crtc.c] trivial memory leak

Anyone willing to review this triviality ? The code is included below. This patch fixes a memory leak in xf86CrtcCreate(). It frees the crtc->gamma_red buffer when a quit on error occurs. xf86CrtcPtr xf86CrtcCreate (ScrnInfoPtr scrn, const xf86CrtcFuncsRec *funcs) <

Re: [PATCH libXi multitouch 3/4] Define macros for unstable protocol development

On 09/17/2011 06:53 AM, Gaetan Nadon wrote: > On Sat, 2011-09-17 at 06:52 +1000, Peter Hutterer wrote: >> On Wed, Sep 14, 2011 at 10:33:56PM -0700, Chase Douglas wrote: >> > Signed-off-by: Chase Douglas > > > >> > --- >> > configure.ac |3 +++ >> > 1 files c

Re: [PATCH 1/9] dmx: Fix a non-constant printf format string warning.

On 09/17/11 08:55, Matt Turner wrote: I suppose that change is OK, but I seem to remember a conversation on this list that concluded that those non-const printf format warnings are quite often bogus. In this case, the code looks obviously correct, the only problem is that stupid warning. It's r

Re: [PATCH 1/9] dmx: Fix a non-constant printf format string warning.

On 09/17/11 01:22, Jamey Sharp wrote: Signed-off-by: Jamey Sharp --- hw/dmx/input/lnx-keyboard.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/dmx/input/lnx-keyboard.c b/hw/dmx/input/lnx-keyboard.c index 5bfb881..5b92f3b 100644 --- a/hw/dmx/input/lnx-keyboard.c

Re: [PATCH 2/9] dmx: Fix some "no previous prototype" warnings by making functions static.

On Sat, Sep 17, 2011 at 4:22 AM, Jamey Sharp wrote: > Signed-off-by: Jamey Sharp > --- >  hw/dmx/glxProxy/glxcmds.c     |   41 > ++--- >  hw/dmx/glxProxy/glxscreens.c  |   39 --- >  hw/dmx/glxProxy/render2swap.c |    2 +- >

Re: drivers to de-support (was: [PATCH 2/3] xorg-server.pc.in: Remove libpciaccess and pixman-1 from Requires)

On Fri, Sep 16, 2011 at 9:36 PM, Michael wrote: > Hello, > > On Fri, 16 Sep 2011 21:13:10 -0400 > Matt Turner wrote: > >> > Which goes back to another question raised at XDC - is it time to start >> > dropping support for video drivers the way we have for input drivers? >> > >> > rendition is one

Re: [PATCH] savage: Avoid unnecessary float calculation in video display

On Sat, Sep 17, 2011 at 5:58 AM, Tormod Volden wrote: > From: Tormod Volden > > There is no reason to do the division using floats as long as > the result is an integer and there is no risk of intermediate > overflow. > > This is in the code for "Old" chipsets. Integer division was already > used

Re: [PATCH] savage: Fix Xv scaling on non-native resolutions

On Sat, Sep 17, 2011 at 11:52 AM, Matt Turner wrote: > I'm wondering why the added lines don't have (float) casts when the > x1, y1 lines do? If they're not necessary, perhaps a follow-on patch > would be nice. And now I see the other email you already sent. __

Re: [PATCH 1/9] dmx: Fix a non-constant printf format string warning.

On Sat, Sep 17, 2011 at 4:22 AM, Jamey Sharp wrote: > Signed-off-by: Jamey Sharp > --- >  hw/dmx/input/lnx-keyboard.c |    4 ++-- >  1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/dmx/input/lnx-keyboard.c b/hw/dmx/input/lnx-keyboard.c > index 5bfb881..5b92f3b 100644 > --- a/

Re: drivers to de-support (was: [PATCH 2/3] xorg-server.pc.in: Remove libpciaccess and pixman-1 from Requires)

Hi, On 17 September 2011 02:36, Michael wrote: > On Fri, 16 Sep 2011 21:13:10 -0400 > Matt Turner wrote: >> I think we should simply maintain the drivers we care about. I'll try >> to keep -glint going. For other drivers without any sort of >> maintainer, I don't think anything really changes fro

Re: [PATCH] savage: Fix Xv scaling on non-native resolutions

On Sat, Sep 17, 2011 at 5:22 AM, Tormod Volden wrote: > From: Hans-Juergen Mauser > > If I set the resolution to 800x600 for example (to be able to use the > TV output in full screen mode), I only can see 800/1024 = 0,78 of the > real video width, no matter if the video is displayed in a small pl

Re: [PATCH:libXaw3d 2/2] Add LayYYWrap() prototype to LayYY.h

On Sat, Sep 17, 2011 at 3:57 AM, Alan Coopersmith wrote: > Fixes gcc warning: > laygram.y:259:5: warning: no previous prototype for 'LayYYwrap' > > Signed-off-by: Alan Coopersmith > --- >  src/LayYY.h |    1 + >  1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/src/LayYY.h b/src/

Re: [PATCH:libXaw3d 1/2] Fix several unused variable warnings

On Sat, Sep 17, 2011 at 3:57 AM, Alan Coopersmith wrote: > All but one are due to variables defined outside #ifdef's but only > used inside #ifdef'ed code blocks. > > Signed-off-by: Alan Coopersmith > --- >  src/Label.c      |    2 ++ >  src/SmeBSB.c     |    2 +- >  src/Text.c       |    2 +- >

Re: drivers to de-support (was: [PATCH 2/3] xorg-server.pc.in: Remove libpciaccess and pixman-1 from Requires)

Hello, On Fri, 16 Sep 2011 21:13:10 -0400 Matt Turner wrote: > > Which goes back to another question raised at XDC - is it time to start > > dropping support for video drivers the way we have for input drivers? > > > > rendition is one of my favorite examples there - it's so old that > > Windows

Re: [PATCH libXi multitouch 3/4] Define macros for unstable protocol development

On Sat, 2011-09-17 at 06:52 +1000, Peter Hutterer wrote: > On Wed, Sep 14, 2011 at 10:33:56PM -0700, Chase Douglas wrote: > > Signed-off-by: Chase Douglas > > --- > > configure.ac |3 +++ > > 1 files changed, 3 insertions(+), 0 deletions(-) > > > > diff --git a/configure.ac b/configure.ac >

Re: Xserver driver merging pros & cons

Hi, On 17 September 2011 12:04, Matthieu Herrb wrote: > On Thu, Sep 15, 2011 at 10:45:17AM -0500, Jesse Barnes wrote: >> Cons: >>  [...] > >   3) makes it harder to maintain out of tree drivers, since API >      breaks are not going to be documented anymore. >      If old pre-kms code start to be

Re: Xserver driver merging pros & cons

2011/9/15 Arkadiusz Miśkiewicz : > From distro package maintainer point of view I _love_ split drivers. It's so > much easier to packages these, rebuild when needed (one faulty, not building, > driver doesn't stop whole build process), easier to patch and backport fixes. As a mandriva/mageia packa

Re: [PATCH xserver 1/8] bsd: Remove unused macros KBD_FD

On Sat, Sep 17, 2011 at 01:29:58PM +0200, Matthieu Herrb wrote: > On Thu, Sep 15, 2011 at 11:20:21PM +0600, Alexandr Shadchin wrote: > > Signed-off-by: Alexandr Shadchin > > For the serie: > > Tested-by: Matthieu Herrb > > (On OpenBSD/i386 and amd64 only, but the changes for other platforms >

Re: [PATCH xserver 8/8] Remove unused vtSysreq

On Fri, Sep 16, 2011 at 04:03:44PM -0500, Jamey Sharp wrote: > On Thu, Sep 15, 2011 at 09:13:09PM -0700, Alan Coopersmith wrote: > > On 09/15/11 20:51, Jamey Sharp wrote: > > >On Thu, Sep 15, 2011 at 06:42:59PM -0700, Alan Coopersmith wrote: > > >>On 09/15/11 13:07, Jamey Sharp wrote: > > >>>It loo

Re: [PATCH xserver 1/8] bsd: Remove unused macros KBD_FD

On Thu, Sep 15, 2011 at 11:20:21PM +0600, Alexandr Shadchin wrote: > Signed-off-by: Alexandr Shadchin For the serie: Tested-by: Matthieu Herrb (On OpenBSD/i386 and amd64 only, but the changes for other platforms look ok too). -- Matthieu Herrb ___ x

Re: [PATCH] savage: Avoid unnecessary float calculation in video display

On Sat, Sep 17, 2011 at 1:03 PM, walter harms wrote: >>      if (S3_MOBILE_TWISTER_SERIES(psav->Chipset) >> -        && psav->FPExpansion) { >> -        drw_w = (((float)(drw_w * psav->XExp1)/(float)psav->XExp2)+1); >> -        drw_h = (float)(drw_h * psav->YExp1)/(float)psav->YExp2+1; >> -        

Re: Xserver driver merging pros & cons

On Thu, Sep 15, 2011 at 10:45:17AM -0500, Jesse Barnes wrote: > At XDC this week we discussed merging drivers back into the server > tree. One thing I found frustrating about the discussion was that we > didn't have a whiteboard nor a list of the pros & cons of such a > change. So I'd like to cap

Re: [PATCH] savage: Avoid unnecessary float calculation in video display

Am 17.09.2011 11:58, schrieb Tormod Volden: > From: Tormod Volden > > There is no reason to do the division using floats as long as > the result is an integer and there is no risk of intermediate > overflow. > > This is in the code for "Old" chipsets. Integer division was already > used in the

Re: [PATCH 1/9] dmx: Fix a non-constant printf format string warning.

Am 17.09.2011 10:22, schrieb Jamey Sharp: > Signed-off-by: Jamey Sharp > --- > hw/dmx/input/lnx-keyboard.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/dmx/input/lnx-keyboard.c b/hw/dmx/input/lnx-keyboard.c > index 5bfb881..5b92f3b 100644 > --- a/hw/dmx/i

[PATCH] savage: Avoid unnecessary float calculation in video display

From: Tormod Volden There is no reason to do the division using floats as long as the result is an integer and there is no risk of intermediate overflow. This is in the code for "Old" chipsets. Integer division was already used in the parallel code for "New" chipsets. Also fixed up the whitespa

[PATCH] savage: Fix Xv scaling on non-native resolutions

From: Hans-Juergen Mauser If I set the resolution to 800x600 for example (to be able to use the TV output in full screen mode), I only can see 800/1024 = 0,78 of the real video width, no matter if the video is displayed in a small player window or enlarged to full screen. On the right of the vide

[PATCH 9/9] Make GC clientClip always be a region.

Nothing ever set clientClip to anything but a region or NULL, so delete the clientClipType field and change clientClip from (pointer) to (RegionPtr). Signed-off-by: Jamey Sharp --- dix/gc.c | 51 +-- exa/exa_accel.c| 18 ++

[PATCH 8/9] Quit wrapping ChangeClip, CopyClip, and DestroyClip in GCFuncs.

Use the mi implementation of these functions instead, moving them to dix/gc.c. Signed-off-by: Jamey Sharp --- Xext/panoramiX.c | 32 -- dix/gc.c | 87 +-- doc/Xserver-spec.xml | 74 +- exa/exa

[PATCH 7/9] xnest: Delete unused nClipRects GC-private field.

This field was never read at any time in the git history. Signed-off-by: Jamey Sharp --- hw/xnest/GC.c |3 --- hw/xnest/XNGC.h |1 - 2 files changed, 0 insertions(+), 4 deletions(-) diff --git a/hw/xnest/GC.c b/hw/xnest/GC.c index 7968b4f..48fe4dc 100644 --- a/hw/xnest/GC.c +++ b/hw/x

[PATCH 6/9] Eliminate MAXSCREENS-sized CursorScreenKey array.

Use new per-screen privates API instead. Commit by Jamey Sharp and Josh Triplett. Signed-off-by: Jamey Sharp Signed-off-by: Josh Triplett --- dix/cursor.c |2 +- dix/dispatch.c |2 +- hw/dmx/dmxcursor.h |4 ++-- hw/xfree86/modes/xf86Cur

[PATCH 4/9] Fix pixmap double-frees on error paths.

Commit by Jamey Sharp and Josh Triplett. Signed-off-by: Jamey Sharp Signed-off-by: Josh Triplett --- Xext/shm.c |6 +- dix/dispatch.c |1 - 2 files changed, 1 insertions(+), 6 deletions(-) diff --git a/Xext/shm.c b/Xext/shm.c index b08af82..4141a8f 100644 --- a/Xext/shm.c +++ b

[PATCH 3/9] XineramaInitData ignores its argument. Quit passing one.

Also fix up XineramaInitData's caller, XineramaReinitData. Commit by Jamey Sharp and Josh Triplett. Signed-off-by: Jamey Sharp Signed-off-by: Josh Triplett --- Xext/panoramiX.c | 12 ++-- Xext/panoramiXsrv.h |2 +- hw/dmx/dmxextension.c |2 +- 3 files changed, 8 insert

[PATCH 2/9] dmx: Fix some "no previous prototype" warnings by making functions static.

Signed-off-by: Jamey Sharp --- hw/dmx/glxProxy/glxcmds.c | 41 ++--- hw/dmx/glxProxy/glxscreens.c | 39 --- hw/dmx/glxProxy/render2swap.c |2 +- 3 files changed, 39 insertions(+), 43 deletions(-) diff --git a/hw

misc cleanups

The following patches should be independent, except that the last three won't apply cleanly in another order. I think they're mostly pretty obvious, so I hope they get reviewed. I didn't manage to get them reviewed around XDS last year, although I don't think I even managed to send out the patches

[PATCH 1/9] dmx: Fix a non-constant printf format string warning.

Signed-off-by: Jamey Sharp --- hw/dmx/input/lnx-keyboard.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/dmx/input/lnx-keyboard.c b/hw/dmx/input/lnx-keyboard.c index 5bfb881..5b92f3b 100644 --- a/hw/dmx/input/lnx-keyboard.c +++ b/hw/dmx/input/lnx-keyboard.c @@ -42

[PATCH 5/9] Revert "Bug #6924: Restore the ABI for DrawableRec and ColormapRec to the state"

This reverts commit bc0c56c407117d1545e20d21f7d30eb3472d618b since we're breaking ABI anyway. Conflicts: ChangeLog dix/colormap.c dix/pixmap.c dix/window.c include/pixmapstr.h Signed-off-by: Jamey Sharp --- dix/colormap.c |7 --- include/co

[PATCH:xfs 4/4] Add _X_NORETURN to declarations of functions that exit

While you might think FatalError() also should have _X_NORETURN, if you add it, you will find that gcc warns you that it does indeed return when built with syslog support. Why syslog makes all fatal errors become non-fatal is an excellent question to ponder... Signed-off-by: Alan Coopersmith --

[PATCH:xfs 3/4] Fix warnings about mismatched printf arg types

Mostly from types defined as long or unsigned long which we tried to print as normal ints. difs/cache.c: In function `CacheFreeMemory': difs/cache.c:371: warning: int format, different type arg (arg 2) difs/resource.c: In function `AddResource': difs/resource.c:304: warning: unsigned int format,

[PATCH:xfs 2/4] Add _X_ATTRIBUTE_PRINTF to error reporting functions

Signed-off-by: Alan Coopersmith --- include/os.h |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/include/os.h b/include/os.h index 58238ec..e07d4e0 100644 --- a/include/os.h +++ b/include/os.h @@ -53,6 +53,7 @@ typedef struct _alt_server *AlternateServerPtr; typede

[PATCH:xfs 1/4] Fix gcc -Wwrite-strings warnings for initialization with string literals

Many warnings of the form: os/config.c:92:5: warning: initialization discards qualifiers from pointer target type Signed-off-by: Alan Coopersmith --- difs/difsutils.c| 10 +- include/difsutils.h |2 +- include/os.h| 10 +- os/config.c |4 ++-- os/

[PATCH:libXaw3d 2/2] Add LayYYWrap() prototype to LayYY.h

Fixes gcc warning: laygram.y:259:5: warning: no previous prototype for 'LayYYwrap' Signed-off-by: Alan Coopersmith --- src/LayYY.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/LayYY.h b/src/LayYY.h index 7d0c1cd..1406ef6 100644 --- a/src/LayYY.h +++ b/src/LayYY.h

[PATCH:libXaw3d 1/2] Fix several unused variable warnings

All but one are due to variables defined outside #ifdef's but only used inside #ifdef'ed code blocks. Signed-off-by: Alan Coopersmith --- src/Label.c |2 ++ src/SmeBSB.c |2 +- src/Text.c |2 +- src/TextAction.c | 10 ++ 4 files changed, 10 insertions(+), 6 d