Re: Xserver driver merging pros cons

2011-09-19 Thread Peter Hutterer
On Sat, Sep 17, 2011 at 01:23:27PM +0100, Daniel Stone wrote: Hi, On 17 September 2011 12:04, Matthieu Herrb matthieu.he...@laas.fr wrote: On Thu, Sep 15, 2011 at 10:45:17AM -0500, Jesse Barnes wrote: Cons:  [...]   3) makes it harder to maintain out of tree drivers, since API      

Re: Xserver driver merging pros cons

2011-09-19 Thread Keith Packard
On Mon, 19 Sep 2011 16:44:17 +1000, Peter Hutterer peter.hutte...@who-t.net wrote: If we're really concerned about the numbers changing in an unpredictable manner and the difficulty of associating the server with a specific ABI, we should consider switching to a date-based ABI major. 2019

Re: Xserver driver merging pros cons

2011-09-19 Thread Peter Hutterer
On Fri, Sep 16, 2011 at 09:46:29PM -0700, Jeremy Huddleston wrote: On Sep 16, 2011, at 13:10, Stéphane Marchesin wrote: 2011/9/16 Jeremy Huddleston jerem...@apple.com: On Sep 16, 2011, at 12:45 PM, Stéphane Marchesin wrote: Well, the issue is not separate. Driver repos are

[RFC] Bugzilla Cleanup

2011-09-19 Thread Jeremy Huddleston
So, one of the things talked about at XDC was just how icky bugzilla has become. There are a ton of open bugs which haven't been touched in ages and either don't apply any more or don't have sufficient information to act upon. I would like to spend some effort cleaning these up, but before I

Re: Xserver driver merging pros cons

2011-09-19 Thread Jeremy Huddleston
On Sep 19, 2011, at 00:00, Peter Hutterer wrote: If the reason the model doesn't work is because people don't review, then some how getting people to step up and give reviews would fix the model. I think the one thing we don't cover right now are patches that cannot really be reviewed by

Re: [RFC] Bugzilla Cleanup

2011-09-19 Thread walter harms
hi, You actions are understandable but i warn to be careful. I did a quick look some time ago and found some bugs that where still open and valid and even contained patches but where is the wrong section so no one found them. Is it an option to have a open bugs marked as OLD BUG when age 2 ?

Re: [PATCH libXi multitouch 3/4] Define macros for unstable protocol development

2011-09-19 Thread Gaetan Nadon
On Sun, 2011-09-18 at 09:28 -0700, Chase Douglas wrote: On 09/17/2011 03:31 PM, Gaetan Nadon wrote: On Sat, 2011-09-17 at 09:54 -0700, Chase Douglas wrote: On 09/17/2011 06:53 AM, Gaetan Nadon wrote: On Sat, 2011-09-17 at 06:52 +1000, Peter Hutterer wrote: On Wed, Sep 14, 2011 at

[PATCH] Add a 'wscons' autoconf mechanism to configure input devices on BSD.

2011-09-19 Thread Matthieu Herrb
This does not really handle hotplug (it's handled inside the kernel, by the 'mux' devices), but uses the wscons console driver configuration to figure out the keyboard layout and the list of pointing devices found by the kernel. Signed-off-by: Matthieu Herrb matthieu.he...@laas.fr ---

Re: Xserver driver merging pros cons

2011-09-19 Thread Michel Dänzer
On Fre, 2011-09-16 at 23:36 +1000, Peter Hutterer wrote: On Fri, Sep 16, 2011 at 10:50:45AM +0200, Michel Dänzer wrote: Speaking as a radeon driver developer, merging the driver into the server tree would be unworkable at this point because since the new development model has been in

[PATCH v3] Add a 'wscons' autoconf mechanism to configure input devices on BSD.

2011-09-19 Thread Matthieu Herrb
This does not really handle hotplug (it's handled inside the kernel, by the 'mux' devices), but uses the wscons console driver configuration to figure out the keyboard layout and the list of pointing devices found by the kernel. Signed-off-by: Matthieu Herrb matthieu.he...@laas.fr ---

Re: Xserver driver merging pros cons

2011-09-19 Thread Luc Verhaegen
I just rejoined the land of the living after returning from Chicago just yesterday, hence the lack of response earlier. On Thu, Sep 15, 2011 at 10:45:17AM -0500, Jesse Barnes wrote: At XDC this week we discussed merging drivers back into the server tree. One thing I found frustrating about

Re: [PATCH] Replace XmuSnprintf with snprintf.

2011-09-19 Thread Alan Coopersmith
On 09/18/11 18:57, Jamey Sharp wrote: Alan Coopersmith explains: XmuSnprintf() can be replaced by snprintf() now. (It was a implementation X provided for it's libraries to use in the days before all platforms we cared about had snprintf in libc.) Reported-by: walter

Re: [RFC] Bugzilla Cleanup

2011-09-19 Thread Alan Coopersmith
On 09/19/11 00:17, Jeremy Huddleston wrote: So, one of the things talked about at XDC was just how icky bugzilla has become. There are a ton of open bugs which haven't been touched in ages and either don't apply any more or don't have sufficient information to act upon. I would like to

[PATCH v4] Add a 'wscons' autoconf mechanism to configure input devices on BSD.

2011-09-19 Thread Matthieu Herrb
This does not really handle hotplug (it's handled inside the kernel, by the 'mux' devices), but uses the wscons console driver configuration to figure out the keyboard layout and the list of pointing devices found by the kernel. Signed-off-by: Matthieu Herrb matthieu.he...@laas.fr ---

Re: [PATCH:libXi] Make shadow man pages generated by asciidoc work with Solaris man

2011-09-19 Thread Alan Coopersmith
On 09/17/11 13:59, Gaetan Nadon wrote: On Fri, 2011-09-16 at 21:00 -0700, Alan Coopersmith wrote: Solaris man requires .so entries in man pages include the man section directory, not just the man page filename, even when it's in the same directory, so use sed to add it in. Signed-off-by: Alan

Re: [PATCH:libXi] Make shadow man pages generated by asciidoc work with Solaris man

2011-09-19 Thread Gaetan Nadon
On Mon, 2011-09-19 at 13:12 -0700, Alan Coopersmith wrote: On 09/17/11 13:59, Gaetan Nadon wrote: On Fri, 2011-09-16 at 21:00 -0700, Alan Coopersmith wrote: Solaris man requires .so entries in man pages include the man section directory, not just the man page filename, even when it's in

Re: [PATCH libXaw3d 1/2] Fix a couple unused function warnings

2011-09-19 Thread Alan Coopersmith
On 09/17/11 11:22, Matt Turner wrote: Functions were only called inside ifdef blocks, but were defined outside. Signed-off-by: Matt Turnermatts...@gmail.com Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com -- -Alan Coopersmith-alan.coopersm...@oracle.com

Re: [PATCH libXaw3d 2/2] Fix a couple of unused variable warnings

2011-09-19 Thread Alan Coopersmith
On 09/17/11 11:22, Matt Turner wrote: Signed-off-by: Matt Turnermatts...@gmail.com --- src/ThreeD.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/ThreeD.c b/src/ThreeD.c index 754b6e2..586242d 100644 --- a/src/ThreeD.c +++ b/src/ThreeD.c @@ -346,7 +346,6 @@

Re: [PATCH] Assign ids to more tags in Xserver-Dtrace.xml

2011-09-19 Thread Alan Coopersmith
On 09/17/11 16:37, Matt Dew wrote: Hi Alan, In the IDs attributes for funcdef, sect and chapter, I was keeping the id attributes matching the title. (I've got a series of patches coming any day now(TM) to that effect,) table id=probe-table titleProbes and their arguments/title would be: table

[PATCH 1/2] Add some intramodule dependencies

2011-09-19 Thread Alan Coopersmith
libshadow depends on libfb for fbGetWinPrivateKey libvbe depends on libint10 for xf86Int10AllocPages, xf86Int10FreePages, xf86ExecX86int10, xf86ExtendedInitInt10, xf86FreeInt10, xf86int10Addr Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- hw/xfree86/dixmods/Makefile.am |1 +

[PATCH 2/2] Don't fallback to wsfb or fbdev on Solaris

2011-09-19 Thread Alan Coopersmith
We don't ship either one, so don't waste time and make confusing log entries trying to load them. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- hw/xfree86/common/xf86AutoConfig.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git

Re: [PATCH 1/2] Add some intramodule dependencies

2011-09-19 Thread Aaron Plattner
On Mon, Sep 19, 2011 at 02:51:07PM -0700, Alan Coopersmith wrote: libshadow depends on libfb for fbGetWinPrivateKey libvbe depends on libint10 for xf86Int10AllocPages, xf86Int10FreePages, xf86ExecX86int10, xf86ExtendedInitInt10, xf86FreeInt10, xf86int10Addr Signed-off-by: Alan Coopersmith

Re: [PATCH:libXi] Make shadow man pages generated by asciidoc work with Solaris man

2011-09-19 Thread Peter Hutterer
On Mon, Sep 19, 2011 at 04:43:48PM -0400, Gaetan Nadon wrote: On Mon, 2011-09-19 at 13:12 -0700, Alan Coopersmith wrote: On 09/17/11 13:59, Gaetan Nadon wrote: On Fri, 2011-09-16 at 21:00 -0700, Alan Coopersmith wrote: Solaris man requires .so entries in man pages include the man

Re: [PATCH] XGrabKey manual page fix

2011-09-19 Thread Alan Coopersmith
On 09/17/11 09:54, Alexander Polakov wrote: I guess it's meant to be like this diff --git a/man/XGrabKey.man b/man/XGrabKey.man index 66e85e0..8b31dd1 100644 --- a/man/XGrabKey.man +++ b/man/XGrabKey.man @@ -290,7 +290,7 @@ alternatives can generate this error. .ZN BadWindow A value for a

[PATCH dri2proto] Remove extra DRI2SwapBuffers

2011-09-19 Thread Rob Clark
From: Rob Clark r...@ti.com Remove duplicate DRI2SwapBuffers from 'A.2 Protocol Requests' section. --- I believe this to be a typo.. either that or I am confused and missing some subtle point (in which case a comment might be useful). dri2proto.txt | 21 - 1 files changed,

Re: [PATCH 1/2] Add some intramodule dependencies

2011-09-19 Thread Alan Coopersmith
On 09/19/11 15:12, Aaron Plattner wrote: On Mon, Sep 19, 2011 at 02:51:07PM -0700, Alan Coopersmith wrote: libshadow depends on libfb for fbGetWinPrivateKey libvbe depends on libint10 for xf86Int10AllocPages, xf86Int10FreePages, xf86ExecX86int10, xf86ExtendedInitInt10, xf86FreeInt10,

Re: [PATCH libXi] Use AM_CPPFLAGS to use in tree headers before installed headers

2011-09-19 Thread Julien Cristau
On Sun, Sep 18, 2011 at 01:01:58 -0700, Jeremy Huddleston wrote: This addresses a build failure found by the tinderbox. Signed-off-by: Jeremy Huddleston jerem...@apple.com --- See: http://tinderbox.x.org/builds/2011-09-17-/logs/libXi src/Makefile.am |9 + 1 files

Re: [PATCH libXi] Use AM_CPPFLAGS to use in tree headers before installed headers

2011-09-19 Thread Jeremy Huddleston
On Sep 19, 2011, at 4:00 PM, Julien Cristau wrote: On Sun, Sep 18, 2011 at 01:01:58 -0700, Jeremy Huddleston wrote: This addresses a build failure found by the tinderbox. Signed-off-by: Jeremy Huddleston jerem...@apple.com --- See:

[PATCH:modular] build.sh: Handle xcb-util module split

2011-09-19 Thread Alan Coopersmith
Mostly straightforward addition of new xcb/util-* submodules, but util-common-m4 needs special handling since it doesn't have the usual autoconfery, just needs to be found in the aclocal path when autoconfing the other xcb/util* modules. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com

[PATCH libXi] 1UL may be 4 bytes, force to 1ULL

2011-09-19 Thread Peter Hutterer
Reported-by: Jeremy Huddleston jerem...@apple.com Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- something like this good enough? src/XExtInt.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/XExtInt.c b/src/XExtInt.c index d74a8d4..4009285 100644 ---

Re: [PATCH libXi] 1UL may be 4 bytes, force to 1ULL

2011-09-19 Thread Jamey Sharp
I'm a bit skeptical... Would ldexp(frac, -32) work for you? Otherwise I'd argue for (UINT64_C(1) 32). Jamey On Tue, Sep 20, 2011 at 10:19:54AM +1000, Peter Hutterer wrote: Reported-by: Jeremy Huddleston jerem...@apple.com Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- something

Re: [PATCH dri2proto] Remove extra DRI2SwapBuffers

2011-09-19 Thread Rob Clark
err, umm.. it looks like DRI2SwapBuffers description in sect '8. Extension Requests' also needs to be updated.. if someone can confirm that I am on the right track (and not mis-understanding something) I'll send an updated patch.. either way, you probably don't want to merge the initial version

Re: [PULL] reviewed cleanups

2011-09-19 Thread Jamey Sharp
Hi Keith! I've gotten some more reviews since my previous pull request, so I've fast-forwarded my reviewed branch to include those as well. The following changes since commit 0caeef6146bee5fb1827ab25db191685dde9d4b4: Version bumped to 1.11 (2011-08-26 16:46:13 -0700) are available in the git

Re: [PATCH libXi] 1UL may be 4 bytes, force to 1ULL

2011-09-19 Thread Jeremy Huddleston
I'm curious... why is the cls_wire-increment.frac getting cast to unsigned int? It's already typed as uint32_t. Looking at the context a bit more, I agree with Jamey that this should work (with or without explicit casts): cls_lib-increment = (double)cls_wire-increment.integral;

Re: [PATCH xserver v2] randr: Add Border property support

2011-09-19 Thread Stéphane Marchesin
On Wed, Aug 31, 2011 at 18:27, Aaron Plattner aplatt...@nvidia.com wrote: Add helpers to RandR to allow the DDX (or rather the driver loaded by the DDX, for xfree86) to specify how many dimensions of adjustments it supports.  Check for this property and adjust the CRTC raster size accordingly

input driver maintainance changes

2011-09-19 Thread Peter Hutterer
We've retired a few input drivers a while ago. The ones we still have left are in a variety of different states. The big 4 are maintained and expected to work (evdev, synaptics, mouse, keyboard) with the development version of X. Joystick is maintained, and Sascha is usually able to get the driver

[PATCH xorg-docs] MAINTAINERS: microtouch was deactivated in 2009

2011-09-19 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- realised this while typing the other email but forgot to remove it from that email. microtouch is already dead. MAINTAINERS |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index

Re: [PATCH xorg-docs] MAINTAINERS: microtouch was deactivated in 2009

2011-09-19 Thread Alan Coopersmith
On 09/19/11 20:01, Peter Hutterer wrote: Signed-off-by: Peter Huttererpeter.hutte...@who-t.net --- realised this while typing the other email but forgot to remove it from that email. microtouch is already dead. MAINTAINERS |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff

Re: input driver maintainance changes

2011-09-19 Thread Alan Coopersmith
On 09/19/11 19:46, Peter Hutterer wrote: We've retired a few input drivers a while ago. The ones we still have left are in a variety of different states. The big 4 are maintained and expected to work (evdev, synaptics, mouse, keyboard) with the development version of X. Joystick is maintained,

Re: [PATCH] xfree86: expose Option TransformationMatrix

2011-09-19 Thread Peter Hutterer
On Sat, Sep 10, 2011 at 05:19:17PM +0200, v...@picaros.org wrote: diff --git a/hw/xfree86/man/xorg.conf.man b/hw/xfree86/man/xorg.conf.man index 6774dbc..6aae650 100644 --- a/hw/xfree86/man/xorg.conf.man +++ b/hw/xfree86/man/xorg.conf.man @@ -948,6 +948,17 @@ is equivalent to

Re: input driver maintainance changes

2011-09-19 Thread Peter Hutterer
On Mon, Sep 19, 2011 at 08:13:05PM -0700, Alan Coopersmith wrote: On 09/19/11 19:46, Peter Hutterer wrote: We've retired a few input drivers a while ago. The ones we still have left are in a variety of different states. The big 4 are maintained and expected to work (evdev, synaptics, mouse,

Re: [RFC] Bugzilla Cleanup

2011-09-19 Thread Matt Turner
On Mon, Sep 19, 2011 at 3:17 AM, Jeremy Huddleston jerem...@freedesktop.org wrote: So, one of the things talked about at XDC was just how icky bugzilla has become.  There are a ton of open bugs which haven't been touched in ages and either don't apply any more or don't have sufficient

Re: [PATCH 2/2] Remove unused ClientStateAuthenticating

2011-09-19 Thread Alan Coopersmith
On 08/27/11 08:39, Alan Coopersmith wrote: On 08/27/11 03:32, Julien Cristau wrote: On Fri, Aug 26, 2011 at 19:25:02 -0700, Alan Coopersmith wrote: Appears to be leftover from the Kerberos code deleted in 2007 (commit dfbe32b5b828cc4e3da36a0e2e6ad641164eaa5e). Nothing left ever set

Re: [PATCH 5/9] Revert Bug #6924: Restore the ABI for DrawableRec and ColormapRec to the state

2011-09-19 Thread Aaron Plattner
Sure, why not? This is the first ABI break since server-1.11 that I've seen go out to the list, I think, but it seems naive to assume there won't be more. Reviewed-by: Aaron Plattner aplatt...@nvidia.com On Sat, Sep 17, 2011 at 01:22:31AM -0700, Jamey Sharp wrote: This reverts commit

Re: [PATCH xserver v2] xf86cmap: Use old palette system for pseudocolour.

2011-09-19 Thread Maarten Maathuis
On Mon, Feb 14, 2011 at 1:45 PM, Mark Kettenis mark.kette...@xs4all.nl wrote: Date: Fri, 11 Feb 2011 20:27:22 +0100 From: Maarten Maathuis madman2...@gmail.com On Fri, Feb 11, 2011 at 8:02 PM, Keith Packard kei...@keithp.com wrote: On Fri, 11 Feb 2011 20:00:13 +0100, Maarten Maathuis

Re: [PATCH 4/9] Fix pixmap double-frees on error paths.

2011-09-19 Thread Peter Hutterer
On Sat, Sep 17, 2011 at 03:22:30AM -0500, Jamey Sharp wrote: Commit by Jamey Sharp and Josh Triplett. Signed-off-by: Jamey Sharp ja...@minilop.net Signed-off-by: Josh Triplett j...@joshtriplett.org --- Xext/shm.c |6 +- dix/dispatch.c |1 - 2 files changed, 1

Re: [PATCH 6/9] Eliminate MAXSCREENS-sized CursorScreenKey array.

2011-09-19 Thread Peter Hutterer
On Sat, Sep 17, 2011 at 03:22:32AM -0500, Jamey Sharp wrote: Use new per-screen privates API instead. Commit by Jamey Sharp and Josh Triplett. Signed-off-by: Jamey Sharp ja...@minilop.net Signed-off-by: Josh Triplett j...@joshtriplett.org --- dix/cursor.c |2 +-

Re: [PATCH 5/9] Revert Bug #6924: Restore the ABI for DrawableRec and ColormapRec to the state

2011-09-19 Thread Jamey Sharp
On Mon, Sep 19, 2011 at 10:12:48PM -0700, Aaron Plattner wrote: Sure, why not? This is the first ABI break since server-1.11 that I've seen go out to the list, I think, but it seems naive to assume there won't be more. Oh, right--I wrote the commit message when I thought it would be merged

Re: [PATCH 4/9] Fix pixmap double-frees on error paths.

2011-09-19 Thread Keith Packard
On Tue, 20 Sep 2011 15:29:01 +1000, Peter Hutterer peter.hutte...@who-t.net wrote: if we create the pixmap but it cannot be added to the resource (and return BadAlloc), shouldn't we destroy it? AddResource frees the object if it fails -- keith.pack...@intel.com pgp6MDLHFU9JU.pgp

Re: [PATCH 4/9] Fix pixmap double-frees on error paths.

2011-09-19 Thread Peter Hutterer
On Mon, Sep 19, 2011 at 10:43:25PM -0700, Keith Packard wrote: On Tue, 20 Sep 2011 15:29:01 +1000, Peter Hutterer peter.hutte...@who-t.net wrote: if we create the pixmap but it cannot be added to the resource (and return BadAlloc), shouldn't we destroy it? AddResource frees the object

Re: [PATCH 6/9] Eliminate MAXSCREENS-sized CursorScreenKey array.

2011-09-19 Thread Jamey Sharp
On Tue, Sep 20, 2011 at 03:30:31PM +1000, Peter Hutterer wrote: i'd remove the space before '(' but otherwise Are you talking about this hunk? On Sat, Sep 17, 2011 at 03:22:32AM -0500, Jamey Sharp wrote: -extern _X_EXPORT DevPrivateKeyRec cursorScreenDevPriv[MAXSCREENS]; -#define