Re: [PATCH:xfs 4/4] Use config.h for autoconf output now that there's no conflict

2011-11-12 Thread Josh Triplett
Mark Kettenis wrote: > > From: Alan Coopersmith > > Date: Fri, 11 Nov 2011 22:49:10 -0800 > > > > Now that os/config.h is gone, no reason to special case and have > > xfs-config.h for the autoconf generated header. > > Ah, *there* is your reason for getting rid of the config.h file. > Makes more

Re: xf86-video-cyrix

2011-11-12 Thread Jeremy Huddleston
On Nov 12, 2011, at 11:39, Martin-Éric Racine wrote: > I do. However, it hasn't built succesfully since about version 1.5 of > xserver. That's why most distributions haven't shipped it in ages. cyrix_driver.c:164:1: error: unknown type name 'IsaChipsets' cyrix_driver.c:1297:15: error: 'miBankInf

Re: [PATCH:xfs 3/4] Move os/config.h into os/config.c

2011-11-12 Thread Jeremy Huddleston
If someone wants to tune that in the future, they can make a configure option for it, so it can live in autoconf's config.h ... On Nov 12, 2011, at 02:25, Mark Kettenis wrote: >> From: Alan Coopersmith >> Date: Fri, 11 Nov 2011 22:49:09 -0800 >> >> The only file that needed the only remaining

Re: [PATCH libXi v2] Fix duplicate sizeof in copy_classes

2011-11-12 Thread Jeremy Huddleston
Yep, that looks right (re-rev-by me). On Nov 11, 2011, at 23:43, Peter Hutterer wrote: > sizeof(bla * sizeof()) is'nt right. > > Plus add some () to the next_block call too to emphasise that *nclasses is > the multiplicator. > > Signed-off-by: Peter Hutterer > Reviewed-by: Jeremy Huddleston >

Re: [PATCH:xfs 1/4] Make CONFIG_ERR_* values be strings instead of indexes in ConfigErrors array

2011-11-12 Thread Jeremy Huddleston
Series: Reviewed-by: Jeremy Huddleston On Nov 11, 2011, at 22:49, Alan Coopersmith wrote: > Allows gcc to check printf format strings instead of just giving warnings. > Since these #defines are only used in config.c, define them directly there, > instead of in the config.h header that no one els

Re: [PATCH:libxkbfile] Add const attributes to fix gcc -Wwrite-strings warnings

2011-11-12 Thread Jeremy Huddleston
Reviewed-by: Jeremy Huddleston On Nov 11, 2011, at 21:58, Alan Coopersmith wrote: > Does not fix all of them, as some affect the API and thus need more analysis. > > Signed-off-by: Alan Coopersmith > --- > include/X11/extensions/XKBfile.h |4 ++-- > src/maprules.c |2 +

Re: [PATCH:xmodmap 1/3] Fix gcc -Wwrite-strings warnings

2011-11-12 Thread Jeremy Huddleston
Series: Reviewed-by: Jeremy Huddleston On Nov 11, 2011, at 21:27, Alan Coopersmith wrote: > Signed-off-by: Alan Coopersmith > --- > exec.c|2 +- > handle.c |6 +++--- > pf.c | 18 ++ > wq.h |2 +- > xmodmap.c |2 +- > xmodmap.h |3 ++- > 6 files ch

Re: [PATCH xserver] docs: spell "X Server Version" consistently in titles. Add where missing.

2011-11-12 Thread Jeremy Huddleston
Reviewed-by: Jeremy Huddleston On Nov 11, 2011, at 17:44, Gaetan Nadon wrote: > Reviewed-by: Alan Coopersmith > Signed-off-by: Gaetan Nadon > --- > doc/Xinput.xml|2 +- > doc/Xserver-spec.xml |2 +- > doc/dtrace/Xserver-DTrace.xml |2 +- > hw/dmx/doc/dmx.xml

Re: [PATCH xdm] Re-introduce the ability of staticcally linking the greeter.

2011-11-12 Thread Gaetan Nadon
On Fri, 2011-11-11 at 19:37 -0800, Alan Coopersmith wrote: > On 11/07/11 11:57, Matthieu Herrb wrote: > > This logically reverts 7e223d3ac6c0d549a7d6e4dcc86a053e19594028. > > There are still cases (in particular OpenBSD) where the shared greeter > > is not desired. > > As discussed elsewhere in t

Re: [PATCH:xfs 4/4] Use config.h for autoconf output now that there's no conflict

2011-11-12 Thread Mark Kettenis
> From: Alan Coopersmith > Date: Fri, 11 Nov 2011 22:49:10 -0800 > > Now that os/config.h is gone, no reason to special case and have > xfs-config.h for the autoconf generated header. Ah, *there* is your reason for getting rid of the config.h file. Makes more sense now. Did I ever say how much

Re: [PATCH:xfs 1/4] Make CONFIG_ERR_* values be strings instead of indexes in ConfigErrors array

2011-11-12 Thread Mark Kettenis
> From: Alan Coopersmith > Date: Fri, 11 Nov 2011 22:49:07 -0800 > > Allows gcc to check printf format strings instead of just giving warnings. > Since these #defines are only used in config.c, define them directly there, > instead of in the config.h header that no one else includes. > > Signed-

Re: [PATCH:libFS 2/2] Mark pattern argument to FSListFonts* as const char *

2011-11-12 Thread Mark Kettenis
> From: Alan Coopersmith > Date: Fri, 11 Nov 2011 21:43:05 -0800 > > Needed to fix gcc -Wwrite-strings warnings in clients such as fslsfonts > > diff --git a/src/FSlibInt.c b/src/FSlibInt.c > index 5a33b64..eea9840 100644 > --- a/src/FSlibInt.c > +++ b/src/FSlibInt.c > @@ -536,7 +536,7 @@ _FSRea

Re: [PATCH:xfs 3/4] Move os/config.h into os/config.c

2011-11-12 Thread Mark Kettenis
> From: Alan Coopersmith > Date: Fri, 11 Nov 2011 22:49:09 -0800 > > The only file that needed the only remaining definition was config.c, > so there's no point keeping a header file around for a single #define Dunno, there is a school of thought that says that (potentially) tunable #defines lik

Re: [PATCH:libFS 1/2] Change FSOpenServer and FSServerName to take const char * args.

2011-11-12 Thread Mark Kettenis
> From: Alan Coopersmith > Date: Fri, 11 Nov 2011 21:43:04 -0800 > diff --git a/src/FSServName.c b/src/FSServName.c > index 022be82..a535b38 100644 > --- a/src/FSServName.c > +++ b/src/FSServName.c > @@ -59,12 +59,12 @@ in this Software without prior written authorization from > The Open Group.

Re: [PATCH:xmodmap 3/3] Replace chk_malloc + sprintf with asprintf

2011-11-12 Thread walter harms
Am 12.11.2011 06:27, schrieb Alan Coopersmith: > Includes local private copy of asprintf for OS'es without it in libc. > Removes chk_malloc as no callers remain anymore. > > Signed-off-by: Alan Coopersmith > --- > configure.ac |2 +- > xmodmap.c| 69 ++