[PATCH] xf86: add rgb ordering helper

2012-01-26 Thread Dave Airlie
From: Dave Airlie At least the intel, nouveau and radeon driver contain this chunk of code. We should move it into the server just for the sake of stopping further cut-n-paste. Drivers can be adapted to use it later. Signed-off-by: Dave Airlie --- hw/xfree86/common/xf86.h |1 + hw

Re: [PATCH 04/11] glx: Add tracking for GLX_ARB_create_context and GLX_ARB_create_context_profile

2012-01-26 Thread Dave Airlie
On Fri, Dec 23, 2011 at 11:18 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick Reviewed-by: Dave Airlie ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.or

Re: [PATCH 06/11] glx: Implement GLX SetClientInfoARB protocol

2012-01-26 Thread Dave Airlie
On Fri, Dec 23, 2011 at 11:18 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick Reviewed-by: Dave Airlie ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.or

Re: [PATCH 10/11] glx: Make several functions available outside the glxcmds.c compilation unit

2012-01-26 Thread Dave Airlie
On Fri, Dec 23, 2011 at 11:18 PM, Ian Romanick wrote: > From: Ian Romanick > > validGlxScreen, validGlxFBConfig, validGlxContext, and > __glXdirectContextCreate will soon be used by createcontext.c. > > Signed-off-by: Ian Romanick Reviewed-by: Dave Airlie __

Re: [PATCH 11/11] glx: Implement protocol for glXCreateContextAttribsARB

2012-01-26 Thread Dave Airlie
On Fri, Dec 23, 2011 at 11:18 PM, Ian Romanick wrote: > From: Ian Romanick > > Signed-off-by: Ian Romanick Reviewed-by: Dave Airlie ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.or

[PATCH] configure.ac: bump GL requirements

2012-01-26 Thread Dave Airlie
From: Dave Airlie Once Ian's GLX changes are commited for GL3.0 support, then we need to bump the minimum requirements for glproto and gl (from Mesa). Signed-off-by: Dave Airlie --- configure.ac |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configur

Re: [PATCH] configure.ac: bump GL requirements

2012-01-26 Thread Luc Verhaegen
On Thu, Jan 26, 2012 at 03:44:58PM +, Dave Airlie wrote: > From: Dave Airlie > > Once Ian's GLX changes are commited for GL3.0 support, then we > need to bump the minimum requirements for glproto and gl (from Mesa). > > Signed-off-by: Dave Airlie > --- > configure.ac |4 ++-- > 1 files

[PULL] hw/xwin fixes + a warning fix

2012-01-26 Thread Jon TURNEY
Hi Keith, Please consider pulling into master. Thanks. The following changes since commit 02775efb8930291cc62fc84086c97da75b912a55: int10: Fix unmapping of the BIOS scratch area (2012-01-25 09:26:23 -0800) are available in the git repository at: git://people.freedesktop.org/~jturney/xserv

[PATCH modular] Format cleanup of help output

2012-01-26 Thread Trevor Woerner
From: Trevor Woerner Miscellaneous cleanups of the help text that is printed. Signed-off-by: Trevor Woerner --- build.sh | 31 +++ 1 files changed, 19 insertions(+), 12 deletions(-) diff --git a/build.sh b/build.sh index 5878ef1..9068f29 100755 --- a/build.sh +++

Re: Slow XQueryPointer?

2012-01-26 Thread Adam Jackson
On Thu, 2012-01-26 at 17:51 +0200, Lauri Kasanen wrote: > For this particular call, my app called XQueryPointer at > 1327592221.398620 and reported the call took 12177 usec. The relevant > portion of the strace is attached. > > I'm not fully confident in my ability to grok strace, but to me it >

Re: [PATCH] configure.ac: bump GL requirements

2012-01-26 Thread Dave Airlie
On Thu, Jan 26, 2012 at 3:53 PM, Luc Verhaegen wrote: > On Thu, Jan 26, 2012 at 03:44:58PM +, Dave Airlie wrote: >> From: Dave Airlie >> >> Once Ian's GLX changes are commited for GL3.0 support, then we >> need to bump the minimum requirements for glproto and gl (from Mesa). >> >> Signed-off-

Re: [PULL] hw/xwin fixes + a warning fix

2012-01-26 Thread Keith Packard
On Thu, 26 Jan 2012 16:13:59 +, Jon TURNEY wrote: > hw/xwin: Fix winEnqueueMotion() for change in miPointerSetPosition() This looks like it's missing x = dx; y = dy; Without that, you'll miss any changes to position made by miPointerSetPosition. -- keith.

Re: Slow XQueryPointer?

2012-01-26 Thread Adam Jackson
On Thu, 2012-01-26 at 11:58 -0500, Adam Jackson wrote: > I think a more complete solution would involve changing the main loop's > logic slightly: if we get to the end of requests for a single client > within a single timeslice, start pulling requests from any other clients > that have pending req

Re: Slow XQueryPointer?

2012-01-26 Thread Adam Jackson
On Thu, 2012-01-26 at 19:34 +0200, Lauri Kasanen wrote: > Hi ajax > > Thanks for taking the time to look into this. > > Trying -schedInterval 5 had slight improvement - the skips weren't as > high, the highest was 7ms. But the skips still happen about just as > often. That's about what I'd expec

Re: [PULL] hw/xwin fixes + a warning fix

2012-01-26 Thread Colin Harrison
Hi, > This looks like it's missing > x = dx; > y = dy; With this in I get no mouse events (on the left monitor) when the main display is not leftmost with multiple monitors. The casting is probably messing up negative x's on Windows? As in the [PULL] I can't detect any position errors

Re: [PATCH] xf86: add rgb ordering helper

2012-01-26 Thread Aaron Plattner
On 01/26/2012 03:36 AM, Dave Airlie wrote: From: Dave Airlie At least the intel, nouveau and radeon driver contain this chunk of code. vesa, nv, and tegra do too. They explicitly check for pScrn->bitsPerPixel > 8, but I don't see why any of the visuals would match the (visual->class | Dynam

Re: [PULL] hw/xwin fixes + a warning fix

2012-01-26 Thread Keith Packard
On Thu, 26 Jan 2012 19:27:42 -, "Colin Harrison" wrote: > > This looks like it's missing > > x = dx; > > y = dy; > > With this in I get no mouse events (on the left monitor) when the main > display is not leftmost with multiple monitors. I don't understand how that can happen -

Re: [PATCH] render: don't bother with animated cursors on floating slaves (#39989)

2012-01-26 Thread Colin Harrison
Hi, On my Windows build this patch... diff --git a/render/animcur.c b/render/animcur.c index 4cf1fdf..0f174fd 100644 --- a/render/animcur.c +++ b/render/animcur.c @@ -208,6 +208,9 @@ AnimCurDisplayCursor (DeviceIntPtr pDev, AnimCurScreenPtras = GetAnimCurScreen(pScreen); Bool

Re: [PATCH] xf86: add rgb ordering helper

2012-01-26 Thread Daniel Stone
On 26 January 2012 22:36, Dave Airlie wrote: > From: Dave Airlie > > At least the intel, nouveau and radeon driver contain this chunk of code. > > We should move it into the server just for the sake of stopping further > cut-n-paste. > > Drivers can be adapted to use it later. > > Signed-off-by:

Re: [PATCH] xf86: add rgb ordering helper

2012-01-26 Thread Keith Packard
On Thu, 26 Jan 2012 11:36:47 +, Dave Airlie wrote: > +void xf86FixupRGBOrdering(ScrnInfoPtr scrn, ScreenPtr screen) This name is very misleading; it's filling out visual pixel format information, not somehow 'fixing' RGB ordering. Otherwise, sure, sharing code is always nice. -- keith.pac

Re: [PATCH modular] Format cleanup of help output

2012-01-26 Thread Peter Hutterer
On Thu, Jan 26, 2012 at 11:29:46AM -0500, Trevor Woerner wrote: > From: Trevor Woerner > > Miscellaneous cleanups of the help text that is printed. > > Signed-off-by: Trevor Woerner Reviewed-by: Peter Hutterer > --- > build.sh | 31 +++ > 1 files changed, 19 in

Re: [PATCH] xf86: add rgb ordering helper

2012-01-26 Thread Aaron Plattner
On 01/26/2012 01:46 PM, Daniel Stone wrote: On 26 January 2012 22:36, Dave Airlie wrote: From: Dave Airlie At least the intel, nouveau and radeon driver contain this chunk of code. We should move it into the server just for the sake of stopping further cut-n-paste. Drivers can be adapted to

Re: [PATCH] xf86: add rgb ordering helper

2012-01-26 Thread Daniel Stone
Hi, On 27 January 2012 09:28, Aaron Plattner wrote: > On 01/26/2012 01:46 PM, Daniel Stone wrote: >> Can you not drop the ScreenPtr argument and just say that the function >> relies on ScrnInfoPtr::pScreen being valid? > > It would presumably be typically called from ScreenInit, where > pScrn->pS

Re: Slow XQueryPointer?

2012-01-26 Thread Lauri Kasanen
Hi ajax Thanks for taking the time to look into this. Trying -schedInterval 5 had slight improvement - the skips weren't as high, the highest was 7ms. But the skips still happen about just as often. > I think a more complete solution would involve changing the main loop's > logic slightly: if

Re: [PULL] hw/xwin fixes + a warning fix

2012-01-26 Thread Colin Harrison
Hi, Looking into it further the code at the end of miPointerSetPosition() maybe the cause of this... /* In the event we actually change screen or we get confined, we just * drop the float component on the floor * FIXME: only drop remainder for ConstrainCursorHarder, not for screen

Re: [PULL] hw/xwin fixes + a warning fix

2012-01-26 Thread Daniel Stone
Hi, On 27 January 2012 10:22, Colin Harrison wrote: > If I revert those traps and then call the function... > > void winEnqueueMotion(int x, int y) > { >  int valuators[2]; >  ValuatorMask mask; >  double dx = (double)x; >  double dy = (double)y; > >  miPointerSetPosition(g_pwinPointer, POINTER_R

Re: [PATCH xf86-input-synaptics 6/6] Switch X and Y axis labels to "Abs {X,Y}"

2012-01-26 Thread Peter Hutterer
On Wed, Jan 25, 2012 at 10:20:29PM -0800, Chase Douglas wrote: > On 01/25/2012 10:07 PM, Peter Hutterer wrote: > > On Thu, Jan 19, 2012 at 01:05:51PM -0800, Chase Douglas wrote: > >> Non-raw X core and XI events are provided in absolute coordinates. If > >> you really care, you can look at the XI a

Re: [PULL] hw/xwin fixes + a warning fix

2012-01-26 Thread Colin Harrison
Hi, Daniel wrote: > > Why are you actually calling miPointerSetPosition at all? Someone had to be daft enough to use it. As in "if it isn't defined static then it must be useful" And if it is then "I want to access it anyway" :) It's late...more coffee is required to wash away the dust! Thank

Re: [PULL] hw/xwin fixes + a warning fix

2012-01-26 Thread Peter Hutterer
On Thu, Jan 26, 2012 at 01:10:53PM -0800, Keith Packard wrote: > On Thu, 26 Jan 2012 19:27:42 -, "Colin Harrison" > wrote: > > > > This looks like it's missing > > > x = dx; > > > y = dy; > > > > With this in I get no mouse events (on the left monitor) when the main > > display

[RFC PATCH v2] fixesproto v6: Pointer barrier improvements.

2012-01-26 Thread christopher . halse . rogers
From: Christopher James Halse Rogers Adds a velocity-gated pointer barrier, events to notify a client when barriers are hit, and a mechanism for clients to temporarily allow movement through a barrier. Signed-off-by: Christopher James Halse Rogers --- After further prototyping with DX it beca

[PATCH RFC inputproto] specs: Don't allow for early acceptance/rejection

2012-01-26 Thread Peter Hutterer
Definition of early acceptance/rejection: If supported, a client may accept or reject a touch sequence before it becomes the current owner of the sequence. In some cases, this can speed up touch processing as it removes one ore more clients from the listeners and thus reduce the number of events to

Re: [PATCH app-transset] COPYING: make the content reflect the copyright statements in source code

2012-01-26 Thread Gaetan Nadon
On 12-01-25 09:21 PM, Arnaud Fontaine wrote: > Alan Coopersmith writes: > >> On 01/25/12 05:33 PM, Arnaud Fontaine wrote: >>> Gaetan Nadon writes: >>> No "Copyright © 2003 Keith Packard" could be found in source code. >>> There is only one copyright header in the source code, and this is >

Re: [PATCH modular] Format cleanup of help output

2012-01-26 Thread Gaetan Nadon
On 12-01-26 11:29 AM, Trevor Woerner wrote: > From: Trevor Woerner > > Miscellaneous cleanups of the help text that is printed. > > Signed-off-by: Trevor Woerner > --- > build.sh | 31 +++ > 1 files changed, 19 insertions(+), 12 deletions(-) > > diff --git a/build.s

Re: [PATCH app-transset] COPYING: make the content reflect the copyright statements in source code

2012-01-26 Thread Arnaud Fontaine
Hello, Gaetan Nadon writes: > The author of the code should submit a patch to clarify his rights > over the code. The X.Org preferred license can be found here: > http://www.x.org/releases/X11R7.6/doc/xorg-docs/License.html#id2521948 That would be great indeed. > The role of the

Re: [PULL] hw/xwin fixes + a warning fix

2012-01-26 Thread Keith Packard
On Fri, 27 Jan 2012 10:28:40 +1000, Peter Hutterer wrote: > Jon confirmed on IRC that just removing miSetPointerPosition() fixes it > anyways, so let's do that. Makes a lot more sense to me anyways... -- keith.pack...@intel.com pgpX9OtWdnRR5.pgp Description: PGP signature __

Re: [RFC PATCH v2] fixesproto v6: Pointer barrier improvements.

2012-01-26 Thread Christopher James Halse Rogers
Here are some patches for a quick, prototype implementation of this protocol. They're what we've been using to test the protocol is sufficiently useful. These are provided for people who'd like to test the behaviour; they are in no way intended to be applied as-is. Chris diff --git a/include/pro

[PATCH] Removal of early acceptance and grab_window

2012-01-26 Thread Peter Hutterer
These two features were still marked with a "FIXME" in the server, both unimplemented (early acceptance responded with a BadAccess, the window argument was ignored completely). Drop them from XI 2.2, they're a nice feature to have but it's unlikely that they will get implemented in time and so far

[PATCH inputproto 1/3] Unbreak protocol ABI for XIAllowEvents.

2012-01-26 Thread Peter Hutterer
XIAllowEvents was extended with touchid and grab_window in 2ea2f99f4fe1dcd3b8e539ca41c482fc40a0533d. This extended the size of the request from 12 to 20 but also broke the ABI. Older server match the request size exactly, so compiling libXi 1.5 against inputproto 2.2 and then running it against a p

[PATCH inputproto 2/3] Drop grab_window from XIAllowEvents

2012-01-26 Thread Peter Hutterer
With the drop of early acceptance/rejection the grab_window argument is not as necessary anymore as it would be with early acceptance/rejection. Right now, it is unlikely that the grab_window handling will be implemented in time for XI 2.2, so drop it from the protocol - let's not pretend we can ac

[PATCH inputproto 3/3] inputproto 2.1.99.6

2012-01-26 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index abd8355..028538b 100644 --- a/configure.ac +++ b/configure.ac @@ -1,5 +1,5 @@ AC_PREREQ([2.60]) -AC_INIT([InputProto], [2.1.99.5], [https://

[PATCH libXi 1/3] Handle new XIAllowEvent request size

2012-01-26 Thread Peter Hutterer
inputproto 2.1.99.6 restored the previous request for ABI compatibility reasons, plus it dropped the grab_window argument. Handle that by inverting the current logic and sending touchid down the wire as extra data. Signed-off-by: Peter Hutterer --- configure.ac|2 +- src/XIAllowEven

[PATCH libXi 2/3] Drop grab_window from XIAllowTouch()

2012-01-26 Thread Peter Hutterer
grab_window was removed from the protocol, drop it from the public facing API. This argument was sent to the server but always ignored, clients can be fixed easily without seeing changed behaviour. Signed-off-by: Peter Hutterer --- include/X11/extensions/XInput2.h |1 - src/XIAllowEvents.c

[PATCH libXi 3/3] libXi 1.5.99.3

2012-01-26 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 46f2fb8..77341da 100644 --- a/configure.ac +++ b/configure.ac @@ -1,7 +1,7 @@ # Initialize Autoconf AC_PREREQ([2.60]) -AC_INIT([libXi], [1

[PATCH xserver 1/3] Xi: handle new XIAllowEvents request in inputproto 2.1.99.6

2012-01-26 Thread Peter Hutterer
grab_window was dropped completely, touchid was removed from the struct for ABI compatibility reasons, we need to pull that in manually now. Signed-off-by: Peter Hutterer --- Xi/xiallowev.c |9 - configure.ac |2 +- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a

[PATCH xserver 2/3] Xi: check request size for xXIAllowEvents based on client version

2012-01-26 Thread Peter Hutterer
This request got 4 bytes added in XI 2.2. Signed-off-by: Peter Hutterer --- Xi/xiallowev.c | 19 ++- 1 files changed, 18 insertions(+), 1 deletions(-) diff --git a/Xi/xiallowev.c b/Xi/xiallowev.c index 5d3116d..aadcf62 100644 --- a/Xi/xiallowev.c +++ b/Xi/xiallowev.c @@ -41,6

[PATCH xserver 3/3] Xi: swap touchid for xXIAllowEventsReq

2012-01-26 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- Xi/xiallowev.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/Xi/xiallowev.c b/Xi/xiallowev.c index aadcf62..95eef40 100644 --- a/Xi/xiallowev.c +++ b/Xi/xiallowev.c @@ -52,7 +52,12 @@ SProcXIAllowEvents(ClientPtr client) swap

[PATCH inputproto] specs: explain touch behaviour for dependent devices

2012-01-26 Thread Peter Hutterer
Dependent devices don't send touch events until the interaction is a true touch interaction (i.e. doesn't just serve to move the pointer). Once that happens, all touchpoints send touch events exclusively. Pointer movement restarts once we're down to one touch that controls the pointer again. For c

[RFC PATCH v3] fixesproto v6: Pointer barrier improvements.

2012-01-26 Thread christopher . halse . rogers
From: Christopher James Halse Rogers Adds a velocity-gated pointer barrier, events to notify a client when barriers are hit, and a mechanism for clients to temporarily allow movement through a barrier. Signed-off-by: Christopher James Halse Rogers --- Whoops. git-fail. Here's the *actual*

Re: [PATCH] xf86: add rgb ordering helper

2012-01-26 Thread Dave Airlie
On Thu, Jan 26, 2012 at 10:32 PM, Daniel Stone wrote: > Hi, > > On 27 January 2012 09:28, Aaron Plattner wrote: >> On 01/26/2012 01:46 PM, Daniel Stone wrote: >>> Can you not drop the ScreenPtr argument and just say that the function >>> relies on ScrnInfoPtr::pScreen being valid? >> >> It would

Re: [PATCH] xf86: add rgb ordering helper

2012-01-26 Thread Dave Airlie
On Thu, Jan 26, 2012 at 9:57 PM, Keith Packard wrote: > On Thu, 26 Jan 2012 11:36:47 +, Dave Airlie wrote: > >> +void xf86FixupRGBOrdering(ScrnInfoPtr scrn, ScreenPtr screen) > > This name is very misleading; it's filling out visual pixel format > information, not somehow 'fixing' RGB orderin

Re: [PATCH] xf86: add rgb ordering helper

2012-01-26 Thread Aaron Plattner
On 01/26/2012 01:57 PM, Keith Packard wrote: * PGP Signed by an unknown key On Thu, 26 Jan 2012 11:36:47 +, Dave Airlie wrote: +void xf86FixupRGBOrdering(ScrnInfoPtr scrn, ScreenPtr screen) This name is very misleading; it's filling out visual pixel format information, not somehow 'fixi