Re: [PATCH xorg-gtest 1/3] Separate XSERVER deps from X11 deps

2012-02-29 Thread Chase Douglas
On 02/27/2012 08:04 AM, Gaetan Nadon wrote: The previous commits fixed a compile error as there were no -I for Xlib.h but at the same time introduced a link error for the example subdir. The X server published C flags introduce -fvisibility=hidden. The X server is not a build dependency for the

[PATCH libXaw3d] Fix parameters of FloatInRange

2012-02-29 Thread Matt Turner
Introduced in f6cd786d1. Reported-by: Jean-Pierre Demailly jean-pierre.demai...@ujf-grenoble.fr Signed-off-by: Matt Turner matts...@gmail.com --- src/Scrollbar.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/Scrollbar.c b/src/Scrollbar.c index be74ed3..5667327

[PATCH macros 1/2] Make XORG_TESTSET_CFLAG work for multiple languages

2012-02-29 Thread Chase Douglas
Signed-off-by: Chase Douglas chase.doug...@canonical.com --- xorg-macros.m4.in | 53 - 1 files changed, 32 insertions(+), 21 deletions(-) diff --git a/xorg-macros.m4.in b/xorg-macros.m4.in index 8550ca0..9041542 100644 --- a/xorg-macros.m4.in

[PATCH macros 2/2] Define BASE_CXXFLAGS when C++ is the chosen language

2012-02-29 Thread Chase Douglas
Set the language to C++ before calling XORG_DEFAULT_OPTIONS. This can be done by calling AC_LANG(C++). Signed-off-by: Chase Douglas chase.doug...@canonical.com --- xorg-macros.m4.in | 166 ++-- 1 files changed, 96 insertions(+), 70 deletions(-)

[PATCH xorg-gtest] Remove xorg-server pkgconfig check

2012-02-29 Thread Chase Douglas
xorg-server flags are not needed. Including them also causes -fvisibility=hidden to be used, which breaks the build output. Signed-off-by: Chase Douglas chase.doug...@canonical.com --- configure.ac |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac

Re: [PATCH xorg-gtest 2/3] distcheck fails: cannot open linker script file libxorg-gtest.ver

2012-02-29 Thread Chase Douglas
On 02/27/2012 08:04 AM, Gaetan Nadon wrote: The $(top_srcdir) path is needed to locate the source as it is not in the same dir as the generated files. Signed-off-by: Gaetan Nadonmems...@videotron.ca --- src/Makefile.am |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH xorg-gtest 3/3] distcheck: cannot create directory `xorg-gtest-0.1.1': Permission denied

2012-02-29 Thread Chase Douglas
On 02/27/2012 08:04 AM, Gaetan Nadon wrote: Use the util-macros implementation to generate the ChangeLog and the INSTALL file. Signed-off-by: Gaetan Nadonmems...@videotron.ca --- Makefile.am |6 +++--- configure.ac |6 ++ 2 files changed, 9 insertions(+), 3 deletions(-)

Re: [PATCH] Xi: prohibit multiple XIQueryVersion requests with different versions

2012-02-29 Thread Chase Douglas
On 02/26/2012 06:58 PM, Peter Hutterer wrote: Return BadValue if major or minor differs on the second call. Signed-off-by: Peter Huttererpeter.hutte...@who-t.net Makes sense. Reviewed-by: Chase Douglas chase.doug...@canonical.com ___

Re: [PATCH] dix: when rescaling from master, rescale from desktop dimensions (#46657)

2012-02-29 Thread Chase Douglas
On 02/26/2012 04:18 PM, Peter Hutterer wrote: master-last.valuators[] is in desktop dimensions, so use those as rescale axis ranges, not the screen. Otherwise, a rescale on any screen not the top-left will cause out-of-bounds coordinates which will always map to the bottom-right screen, causing

Re: [PATCH xorg-gtest 1/3] Separate XSERVER deps from X11 deps

2012-02-29 Thread Gaetan Nadon
On 12-02-29 01:57 PM, Chase Douglas wrote: On 02/27/2012 08:04 AM, Gaetan Nadon wrote: The previous commits fixed a compile error as there were no -I for Xlib.h but at the same time introduced a link error for the example subdir. The X server published C flags introduce -fvisibility=hidden.

Re: [PATCH xorg-gtest 1/3] Separate XSERVER deps from X11 deps

2012-02-29 Thread Chase Douglas
On 02/29/2012 12:57 PM, Gaetan Nadon wrote: On 12-02-29 01:57 PM, Chase Douglas wrote: On 02/27/2012 08:04 AM, Gaetan Nadon wrote: The previous commits fixed a compile error as there were no -I for Xlib.h but at the same time introduced a link error for the example subdir. The X server

Re: [PATCH macros 2/2] Define BASE_CXXFLAGS when C++ is the chosen language

2012-02-29 Thread Gaetan Nadon
On 12-02-29 03:24 PM, Chase Douglas wrote: Set the language to C++ before calling XORG_DEFAULT_OPTIONS. This can be done by calling AC_LANG(C++). Is this sentence a recommendation of what to do in a module or does it describe what the patch does? I am a little confused. Signed-off-by: Chase

Re: [PATCH xorg-gtest] Remove xorg-server pkgconfig check

2012-02-29 Thread Gaetan Nadon
On 12-02-29 03:28 PM, Chase Douglas wrote: xorg-server flags are not needed. Including them also causes -fvisibility=hidden to be used, which breaks the build output. Signed-off-by: Chase Douglas chase.doug...@canonical.com --- configure.ac |2 +- 1 files changed, 1 insertions(+), 1

[PATCH xorg-gtest 2/2] config: do not initialize libtool twice

2012-02-29 Thread Gaetan Nadon
AC_PROG_LIBTOOL initializes libtool, contrary to what the name may suggest. It has been renamed to LT_INIT in libtool v2. However X.Org has a requirement to support libtool v1.5. Signed-off-by: Gaetan Nadon mems...@videotron.ca --- configure.ac |2 -- 1 files changed, 0 insertions(+), 2

Re: [PATCH macros 2/2] Define BASE_CXXFLAGS when C++ is the chosen language

2012-02-29 Thread Chase Douglas
On 02/29/2012 02:58 PM, Gaetan Nadon wrote: On 12-02-29 03:24 PM, Chase Douglas wrote: Set the language to C++ before calling XORG_DEFAULT_OPTIONS. This can be done by calling AC_LANG(C++). Is this sentence a recommendation of what to do in a module or does it describe what the patch does? I

Re: [PATCH xorg-gtest] Remove xorg-server pkgconfig check

2012-02-29 Thread Chase Douglas
On 02/29/2012 03:15 PM, Gaetan Nadon wrote: On 12-02-29 03:28 PM, Chase Douglas wrote: xorg-server flags are not needed. Including them also causes -fvisibility=hidden to be used, which breaks the build output. Signed-off-by: Chase Douglaschase.doug...@canonical.com --- configure.ac |2

Re: [PATCH xorg-gtest 1/2] config: no need to m4_include gtest.m4

2012-02-29 Thread Chase Douglas
On 02/29/2012 03:23 PM, Gaetan Nadon wrote: This is done when autoconf runs aclocal. Signed-off-by: Gaetan Nadonmems...@videotron.ca --- configure.ac |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index ae254be..d15eac6 100644 ---

Re: [PATCH xorg-gtest 2/2] config: do not initialize libtool twice

2012-02-29 Thread Chase Douglas
On 02/29/2012 03:23 PM, Gaetan Nadon wrote: AC_PROG_LIBTOOL initializes libtool, contrary to what the name may suggest. It has been renamed to LT_INIT in libtool v2. However X.Org has a requirement to support libtool v1.5. Signed-off-by: Gaetan Nadonmems...@videotron.ca --- configure.ac |