Re: Review compose key sequence patches January 3rd and 6th

2012-03-02 Thread Pander
On 2012-02-22 17:32, Pander wrote: > On 2012-02-22 16:31, Alan Coopersmith wrote: >> On 02/22/12 03:12 AM, Pander wrote: >>> On 2012-02-22 01:26, James Cloos wrote: [Did I already send a review?] >>> >>> No not yet. Thanks for following up on this. >>> Some initial thoughts: >>>

Re: Review compose key sequence patches January 3rd and 6th

2012-03-02 Thread Alan Coopersmith
On 03/ 2/12 07:52 AM, Pander wrote: A new patch for final review has been submitted here: https://bugs.freedesktop.org/show_bug.cgi?id=18751 While we're not always speedy at review on xorg-devel, patches mailed to the list tend to get reviewed and applied months or years faster than those st

Re: [PATCH 01/10] dri2: Fix can_exchange() to allow page-flipping on more mesa versions.

2012-03-02 Thread Mario Kleiner
On Mar 1, 2012, at 9:37 PM, Daniel Stone wrote: Hi, On 1 March 2012 18:11, Mario Kleiner wrote: can_exchange() returns false and thereby prevents page flipping on some drawables where page flipping would work fine. This due to non-matching drawable depths values between front buffer pixmap

[PATCH:xfs] Require libXfont >= 1.4.5 to avoid prototype mismatch errors for MakeAtom

2012-03-02 Thread Alan Coopersmith
Signed-off-by: Alan Coopersmith --- configure.ac |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index c2ab820..f9400d7 100644 --- a/configure.ac +++ b/configure.ac @@ -130,7 +130,8 @@ AC_CHECK_FUNCS([daemon]) # Checks for pkg-config packa

[PATCH xf86-input-synaptics v4 00/10] ClickPad support

2012-03-02 Thread Chase Douglas
Change since v3: * Disable ClickPad support unless a physical right button is present. This ensures we don't disable click action support, which many people rely on. Hopefully we can revert this change once we figure out a way to enable ClickPad and click action support at the same time. * W

[PATCH xf86-input-synaptics v4 01/10] Add clickpad device property

2012-03-02 Thread Chase Douglas
Add it as a writable device property. We may not know how to probe some clickpads so allow the user to override it. It is currently not hooked up to anything yet. Signed-off-by: Chase Douglas --- include/synaptics-properties.h |3 +++ man/synaptics.man | 10 ++ src/pro

[PATCH xf86-input-synaptics v4 02/10] Check for clickpad property

2012-03-02 Thread Chase Douglas
However, only enable it by default if a right button is physically present. Clickpad support conflicts with click action support, so the user would be left without right button support if there is no physical right button. Signed-off-by: Chase Douglas --- src/eventcomm.c |7 +++ src/syna

[PATCH xf86-input-synaptics v4 03/10] Disable click action functionality for clickpads by default

2012-03-02 Thread Chase Douglas
Clickpad press-and-drag with two fingers will break click actions. Disable them for these devices by default until a good solution is found for letting both functionalities co-exist. Signed-off-by: Chase Douglas --- src/properties.c | 14 ++ src/synaptics.c | 11 +++ 2 f

[PATCH xf86-input-synaptics v4 04/10] Add cumulative_d{x, y} to SynapticsHwState

2012-03-02 Thread Chase Douglas
These values will be used for clickpad press and drag with two fingers. While the clickpad button is not pressed, cumulative_d{x,y} will match x and y values. Once the clickpad button is pressed, cumulative_d{x,y} will be updated with the relative motion of each active touch on the touchpad. This

[PATCH xf86-input-synaptics v4 05/10] Enable clickpad click and drag with two fingers

2012-03-02 Thread Chase Douglas
Use cumulative relative touch motion when the clickpad is pressed. If more than one touch is active, assume one of the touches is designated solely for pressing the clickpad button. Thus, decrement the number of reported touches. Signed-off-by: Chase Douglas --- src/synaptics.c| 34 +++

[PATCH xf86-input-synaptics v4 06/10] Disable scrolling when beginning a clickpad press

2012-03-02 Thread Chase Douglas
There really isn't a point to scrolling while a clickpad is pressed. In particular, the clickpad button areas and the horizontal edge scrolling areas overlap, so horizontal edge scrolling must be disabled. Also, performing two finger scrolling while a third finger presses the button would require u

[PATCH xf86-input-synaptics v4 07/10] Calculate touch data for semi-mt devices, but don't send touch events

2012-03-02 Thread Chase Douglas
Previously, all touch data from semi-mt devices was ignored because the X server doesn't support them. However, the touch data must be used for proper clickpad handling. Instead of ignoring semi-mt device touch events, mark the device as being semi-mt and allow initialization of the touch state. T

[PATCH xf86-input-synaptics v4 08/10] Add soft button areas property

2012-03-02 Thread Chase Douglas
Some clickpad devices have button areas painted on them. Set this property to the area of the right and middle buttons to enable proper click actions when clicking in the areas. Signed-off-by: Chase Douglas --- include/synaptics-properties.h |3 + man/synaptics.man | 22 +

[PATCH xf86-input-synaptics v4 09/10] Don't use linear regression when calculating touchpad motion deltas

2012-03-02 Thread Chase Douglas
The results depend on the data rate of the device. A device with a higher data rate, and thus lower individual deltas, will behave differently with the regression calculation. This can be verified on Synaptics semi-mt clickpads. The data rate is halved when two or more touches are on the device. W

[PATCH xf86-input-synaptics v4 10/10] Ignore motion during touch count changes on semi-mt devices

2012-03-02 Thread Chase Douglas
Semi-mt devices do not track touches. The locations of touches are unknown, we only have the bounding box of two of them. We the number of fingers changes, the bounding box coordinates may change as well, but the cumulative relative motion updates at that instant are invalid. To work around this,

Re: [PATCH synaptics] Implement a workaround for Elantech touchpads

2012-03-02 Thread Chase Douglas
On 03/01/2012 05:21 PM, Peter Hutterer wrote: From: Peter Zotov All Elantech touchpads report the number of fingers explicitly, and at least the v3 version of the hardware can report any pressure values down to zero. This interferes with the tap detection hysteresis, which is required for dumb t

[PATCH:xhost] Rework si:type:value code to remove need for shadowed namelen variable

2012-03-02 Thread Alan Coopersmith
Fixes gcc warning: xhost.c:453:6: warning: declaration of ‘namelen’ shadows a previous local xhost.c:339:9: warning: shadowed declaration is here Also removes unnecessary malloc and memcpy by just using the string pointers we already have, since XAddHost & XRemoveHost will copy the specified lengt