[PATCH synaptics 9/9] Remove leftover HAVE_SMOOTH_SCROLL typedef

2012-05-30 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- src/synapticsstr.h |4 1 file changed, 4 deletions(-) diff --git a/src/synapticsstr.h b/src/synapticsstr.h index f9057b8..ef7b4f4 100644 --- a/src/synapticsstr.h +++ b/src/synapticsstr.h @@ -35,10 +35,6 @@ #define DBG(verb, msg, ...) /* */ #endif

[PATCH synaptics 8/9] Move properties header to where it's needed

2012-05-30 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- src/eventcomm.c|1 + src/synapticsstr.h |1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/src/eventcomm.c b/src/eventcomm.c index 0dd789a..f253205 100644 --- a/src/eventcomm.c +++ b/src/eventcomm.c @@ -30,6 +30,7 @@ #endif #includ

[PATCH synaptics 7/9] ps2comm: use ErrorF from PS2DBG directly

2012-05-30 Thread Peter Hutterer
And switch a few current DBG messages to PS2DBG to have one ps/2 debugging output command. Signed-off-by: Peter Hutterer --- src/ps2comm.c | 83 +++-- 1 file changed, 40 insertions(+), 43 deletions(-) diff --git a/src/ps2comm.c b/src/ps2comm

[PATCH synaptics 6/9] Fix indentation for the synaptics protocol ops

2012-05-30 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- src/synaptics.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/src/synaptics.c b/src/synaptics.c index 1b65918..2a79a6d 100644 --- a/src/synaptics.c +++ b/src/synaptics.c @@ -147,20 +147,16 @@ const static struct { struc

[PATCH synaptics 5/9] check for HAVE_CONFIG_H before including config.h

2012-05-30 Thread Peter Hutterer
No real effect, just for correctness. Plus, move the include directive up to be the first include. Signed-off-by: Peter Hutterer --- src/synproto.h |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/synproto.h b/src/synproto.h index cf0034c..f164393 100644 --- a/src

[PATCH synaptics 4/9] Un-typedef model_lookup_t

2012-05-30 Thread Peter Hutterer
Long-term, structs will be structs without typedef. This one is the easiest one to convert, the rest follows later. Signed-off-by: Peter Hutterer --- src/eventcomm.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/eventcomm.c b/src/eventcomm.c index 6cfbcc7.

[PATCH synaptics 3/9] tools: un-typedef TouchpadState

2012-05-30 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- tools/syndaemon.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/syndaemon.c b/tools/syndaemon.c index d24f09c..50b7435 100644 --- a/tools/syndaemon.c +++ b/tools/syndaemon.c @@ -47,11 +47,11 @@ #include "synaptics-propert

[PATCH synaptics 2/9] Remove typedefs from all enums

2012-05-30 Thread Peter Hutterer
We currently mix non-typedef'd and typedef'd enums in the code. Stop this mixing, remove typedefs to make the code more obvious. Signed-off-by: Peter Hutterer --- src/synaptics.c| 22 +++--- src/synapticsstr.h |8 2 files changed, 15 insertions(+), 15 deletions

[PATCH synaptics 1/9] Remove an unused define for 1/sqrt(2)

2012-05-30 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- src/synaptics.c |4 1 file changed, 4 deletions(-) diff --git a/src/synaptics.c b/src/synaptics.c index e16718a..3a88b54 100644 --- a/src/synaptics.c +++ b/src/synaptics.c @@ -114,10 +114,6 @@ typedef enum { #define M_PI 3.14159265358979323846 #endif

[PATCH synaptics 0/9] cleanup patches

2012-05-30 Thread Peter Hutterer
These patches don't do much, the mostly shift things around and clean up a bit. They're from a bigger work set here: git://people.freedesktop.org/~whot/xf86-input-synaptics.git abstract-x-interface which aims to separate the core of the driver from the rest. Two reasons: unit-testing becomes easie

Re: Use pixman glyph API

2012-05-30 Thread Søren Sandmann
Keith Packard writes: > Are you duplicating the glyph image data in pixman? Or just saving the > pointer? I'm duplicating the glyph image data. It's similar in concept to how hardware drivers duplicate the image data in textures. It could perhaps be interesting to share the data between X and

Re: [PATCH] Use new pixman_glyph_cache_t API that will be in pixman 0.28.0

2012-05-30 Thread Søren Sandmann
Alan Coopersmith writes: > I note the pixman patches use a custom hash function instead of the standard > SHA1 hash the X server currently uses (and currently tries to find an > accelerated version of) - any idea if this factors into the performance at > all? Well, the hashes serve two differen

Re: Use pixman glyph API

2012-05-30 Thread Keith Packard
Søren Sandmann writes: > Yeah, in the commit message for the patch itself. I wrote too soon; the commit hadn't landed in my inbox yet. Nice speedups! Are you duplicating the glyph image data in pixman? Or just saving the pointer? -- keith.pack...@intel.com pgptsJnbSVohD.pgp Description: PGP

Re: [PATCH] Use new pixman_glyph_cache_t API that will be in pixman 0.28.0

2012-05-30 Thread Alan Coopersmith
On 05/30/12 05:27 PM, Søren Sandmann wrote: > From: Søren Sandmann Pedersen > > This new API allows glyphs to be cached in a data structure in pixman, > and entire glyph strings to be composited in one go. > > Results from the cairo peformance test suite running against Xvfb with > a screen size

Re: Use pixman glyph API

2012-05-30 Thread Søren Sandmann
Keith Packard writes: > Søren Sandmann writes: > >> I verified that the cairo test suite has the number of failures as >> without the patch. > > Any performance comparisons? Yeah, in the commit message for the patch itself. Soren ___ xorg-devel@list

[PATCH] Use new pixman_glyph_cache_t API that will be in pixman 0.28.0

2012-05-30 Thread Søren Sandmann
From: Søren Sandmann Pedersen This new API allows glyphs to be cached in a data structure in pixman, and entire glyph strings to be composited in one go. Results from the cairo peformance test suite running against Xvfb with a screen size of 1680x1050@32bpp: Speedups xlib fir

Re: Use pixman glyph API

2012-05-30 Thread Keith Packard
Søren Sandmann writes: > I verified that the cairo test suite has the number of failures as > without the patch. Any performance comparisons? -- keith.pack...@intel.com pgpsuCDB3FGn7.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org

Use pixman glyph API

2012-05-30 Thread Søren Sandmann
The following patch ports fb over to use a proposed new glyph cache API for pixman 0.28.0. That API is described in this thread: http://lists.freedesktop.org/archives/pixman/2012-May/002009.html and is available as a git repository here: http://cgit.freedesktop.org/~sandmann/pixman/log/?h=

Re: [PATCH] dri2: Add DRI2GetParam request (v2)

2012-05-30 Thread Keith Packard
Chad Versace writes: > v2: If driver doesn't define ds->GetParam, dont' crash. Fall back to > default behavior, per keithp. Looks good to me. Reviewed-by: Keith Packard -- keith.pack...@intel.com pgp5I7EwSfwfx.pgp Description: PGP signature _

[PATCH] dri2: Add DRI2GetParam request (v2)

2012-05-30 Thread Chad Versace
Bump dri2proto dependency to 2.7. Bump DRI2INFOREC_VERSION to 7. This new protocol request effectively allows clients to perform feature detection on the DDX. The request was added in DRI2 protocol 1.4. If I had DRI2GetParam in June 2011, when I was implementing support in the Intel DDX and Mesa

Re: don't pull yet, but read: pull request for abi/api changes

2012-05-30 Thread Keith Packard
Dave Airlie writes: (the fact that this change ends with a net loss of code is a definite bonus...) > xf86: change EnterVT/LeaveVT to take a ScrnInfoPtr (ABI/API break) > xf86: modify FreeScreen callback to take pScrn instead of index. > (ABI/API) > xf86: move AdjustFrame to p

Re: [PATCH] [rfc] push don't render sw cursor/sigio avoidance hack down

2012-05-30 Thread Keith Packard
> -static void > +static Bool > xf86CursorMoveCursor(DeviceIntPtr pDev, ScreenPtr pScreen, int x, int y) > { > xf86CursorScreenPtr ScreenPriv = > (xf86CursorScreenPtr) dixLookupPrivate(&pScreen->devPrivates, > xf86CursorScreenKey); >

Re: [PATCH] xf86/modes: Defang stale pointers when copying modes

2012-05-30 Thread Keith Packard
Chris Wilson writes: > +extern _X_EXPORT void > +xf86InternMode(DisplayModePtr intern, const DisplayModeRec * pMode); The name doesn't seem very descriptive to me -- what is 'Intern' supposed to mean? > /** > + * Fills in a copy of mode, removing all stale pointer references. > + */ > +void >

Re: [PATCH 0/4] os/log: fixes for timestamps and malicious devices

2012-05-30 Thread Daniel Kurtz
On Mon, May 28, 2012 at 4:10 AM, Julien Cristau wrote: > > On Wed, Apr 18, 2012 at 17:51:49 +0800, Daniel Kurtz wrote: > > > Input drivers like to prepend the device name to logging messages using > > LogVHdrMessageVerb().  The current implementation of this function used the > > output of a snpri

Re: [PATCH] dix/render: consolidate window format matching code.

2012-05-30 Thread Keith Packard
Dave Airlie writes: > From: Dave Airlie > > There was 3 copies of this code, make one. The code looks fine. This commit message must be some kind of Irish comedy though? Reviewed-by: Keith Packard -- keith.pack...@intel.com pgpoqXLhIAEcH.pgp Description: PGP signature

Re: [PATCH] Change memcpy to memmove in fbBlt

2012-05-30 Thread Matt Turner
On Wed, May 30, 2012 at 10:23 AM, Michal Srb wrote: > In case of horizontal blitting of less than width of blitted area, > memcpy is used on overlapping areas which is not allowed. The behavior > is undefined in such case, probably leading to graphical artifact when > blitting in specific directio

[PATCH:app/bitmap] Fix pixmap leak in error paths of BWGetUnzoomedPixmap

2012-05-30 Thread Alan Coopersmith
Found by Parfait 0.5.0.1 bug checking tool: Leaked X Resource pix at line 393 of Bitmap.c in function 'BWGetUnzoomedPixmap'. pix initialized at line 388 with XCreatePixmap(...). at line 414 of Bitmap.c in function 'BWGetUnzoomedPixmap'. pix initialized at line

[PATCH] Change memcpy to memmove in fbBlt

2012-05-30 Thread Michal Srb
In case of horizontal blitting of less than width of blitted area, memcpy is used on overlapping areas which is not allowed. The behavior is undefined in such case, probably leading to graphical artifact when blitting in specific direction. --- fb/fb.h| 14 ++ fb/fbblt.c |4 +

Re: [PATCH xf86-video-intel] Include config.h in intel_options.c

2012-05-30 Thread Chris Wilson
On Mon, 28 May 2012 18:28:28 -0400, Nick Bowler wrote: > Commit 8a9a585341e2 ("Only create a single instance of the intel_options > array") moved the definition of intel_options into a separate .c file. > Several of the defined options are #ifdef'd based on the configuration, > but since config.h