On Jun 15, 2012, at 4:27 PM, Keith Packard wrote:
> Jeremy Huddleston writes:
>
>
>> Can you please put the XQuartz mutex lock inside of the
>> inProcessInputEvents grab/release. I know the number of instructions
>> is small, but there's no reason to hold the lock when checking or
>> setting
Andy Ritger writes:
> Also, remove the unnecessary static qualifier on mieqProcessInputEvents()'s
> 'event' local variable.
following the 'each patch does one thing' rule, this should probably be
split out. In any case, I reviewed where this code came from, and a
static qualifier is not necessar
Peter Hutterer writes:
> An alternative change would be to add this to os/osinit.c but iirc the
> xfree86 ddx is the only one that actually needs SIGIO, right?
Oh. Ick. OsBlockSignals and xf86BlockSIGIO both mess with
sigprocmask. Surely that can't be a good thing.
(Note that kdrive *also* has
Jeremy Huddleston writes:
> Can you please put the XQuartz mutex lock inside of the
> inProcessInputEvents grab/release. I know the number of instructions
> is small, but there's no reason to hold the lock when checking or
> setting inProcessInputEvents. It's a mutex on miEventQueue.
Uh. That
Alan Coopersmith writes:
> Signed-off-by: Alan Coopersmith
Reviewed-by: Keith Packard
--
keith.pack...@intel.com
pgpKOsrgjKBQh.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg
Alan Coopersmith writes:
> Now that FatalError is marked as _X_NORETURN, the compilers know we
> can't get here, and the return statement added to make them happy in
> the past now makes them unhappy.
>
> Signed-off-by: Alan Coopersmith
> ---
> dix/events.c |1 -
> 1 file changed, 1 deletio
Peter Hutterer writes:
> The current tests need to be run as root to work, they require uinput
> devices to be created. If not run as root, the tests will succeed anyway
> (with a messsage) so make check won't just error out all the time.
These tests need the evdev driver installed, along with c
Jeremy Huddleston writes:
> Should RRTellChanged be calling UpdateCurrentTimeIf() instead of
> UpdateCurrentTime()?
Probably.
> Is there a way we can make this API more robust rather than just
> adding assertions to the implementation? For example, why does
> UpdateCurrentTime need to Process
On Fri, Jun 15, 2012 at 5:56 PM, Robert Hooker wrote:
> Fixes multiple instances of these warnings on x86_64:
> ../../src/vmware.h:180:5: warning: implicit declaration of function
> 'xf86ScreenToScrn' [-Wimplicit-function-declaration]
> ../../src/vmware.h:180:5: warning: nested extern declaration
Fixes multiple instances of these warnings on x86_64:
../../src/vmware.h:180:5: warning: implicit declaration of function
'xf86ScreenToScrn' [-Wimplicit-function-declaration]
../../src/vmware.h:180:5: warning: nested extern declaration of
'xf86ScreenToScrn' [-Wnested-externs]
../../src/vmware.h:1
Note: [v2] patch fixes indentation
This patch was created using xorg-server-1.12.0 source.
When using Fedora 17 with xorg-server-1.12.0 and SELinux is enabled
('setsebool xserver_object_manager on') the xserver will not load. The X
log file has a seg fault pointing to XACE/SELinux. Bug 50641 was
On Fri, 2012-06-15 at 21:54 +1000, Christopher James Halse Rogers wrote:
> On Fri, 2012-06-15 at 12:35 +0200, Michel Dänzer wrote:
> > On Fre, 2012-06-15 at 19:01 +1000, Christopher James Halse Rogers
> > wrote:
> > > xwayland drivers need access to their screen private data to authenticate.
> > >
On Fri, 2012-06-15 at 12:35 +0200, Michel Dänzer wrote:
> On Fre, 2012-06-15 at 19:01 +1000, Christopher James Halse Rogers
> wrote:
> > xwayland drivers need access to their screen private data to authenticate.
> > Now that drivers no longer have direct access to the global screen arrays,
> > thi
On Fre, 2012-06-15 at 19:01 +1000, Christopher James Halse Rogers
wrote:
> xwayland drivers need access to their screen private data to authenticate.
> Now that drivers no longer have direct access to the global screen arrays,
> this needs to be passed in as function context. The way it was workin
Jeremy Huddleston has asked me to send the patch I submitted for the
bug report in the subject to this list for review.
My bug report was:
Compilation of sessreg-1.0.7 on NetBSD-6.99.7/amd64 fails with:
--- sessreg.o ---
CC sessreg.o
sessreg.c:257:16: error: use of undeclared identifier 'WTM
xwayland drivers need access to their screen private data to authenticate.
Now that drivers no longer have direct access to the global screen arrays,
this needs to be passed in as function context. The way it was working
was ugly, anyway.
Signed-off-by: Christopher James Halse Rogers
---
This c
Can you please put the XQuartz mutex lock inside of the inProcessInputEvents
grab/release. I know the number of instructions is small, but there's no
reason to hold the lock when checking or setting inProcessInputEvents. It's a
mutex on miEventQueue.
Thanks,
Jeremy
On Jun 14, 2012, at 9:15 A
Ok, I failed to actually notice the patch was already on the list in my deluge
of unread messages. Seeing as how this is exactly what I just described in my
previous email,
Reviewed-by: Jeremy Huddleston
Thanks,
Jeremy
On Jun 14, 2012, at 9:15 AM, Andy Ritger wrote:
> Call UpdateCurrentTim
On Jun 12, 2012, at 5:48 PM, Peter Hutterer wrote:
> On Tue, Jun 12, 2012 at 05:11:49PM -0700, Andy Ritger wrote:
>> ...
>> Making the 'event' variable in mieqProcessInputEvents() non-static
>> avoids the FatalError() in FixKeyState(), but is it problematic to
>> have the re-entered instance of
Well, I guess that means the !SHM path was tested as working now =)
Thanks,
Jeremy
a438098..ad48dc6 master -> master
On Jun 13, 2012, at 12:40 AM, Daniel Martin wrote:
> Hi,
>
> here's a small patch, just one character ...
>
> greetings, Daniel
>
> ---8<---
>
> XShmQueryExtension retur
20 matches
Mail list logo
