[PATCH] xkb: fill in keycode and event type for slow keys enablement

eventType is set for the type that triggered a XkbControlsNotify event. Technically, SlowKeys is triggered by a timer which doesn't have a matching core event type. So we used to use 0 here. Practically, the timer is triggered by a key press + hold and cancelled when the key is released before the

Re: [PATCH xev] Add a -event parameter to control the event mask

On Fri, Jun 22, 2012 at 01:45:47PM -0700, Aaron Plattner wrote: > It's annoying to have to sift through a lot of unrelated events if all you > care > about is one specific class of events (e.g. RandR events). Add a -event > parameter that can be used to tune which events to select. When not > s

Re: [PATCH 19/19] ephyrGLXQueryServerString: Stop making an unused copy of server_string

i took a look (read: not compile tested) and it look good to me. re, wh Am 24.06.2012 19:25, schrieb Alan Coopersmith: > ephyrGLXQueryServerString() carefully allocated a buffer padded to the > word-aligned string length for sending to the client, copied the string > to it, and then forgot to us

[PATCH 19/19] ephyrGLXQueryServerString: Stop making an unused copy of server_string

ephyrGLXQueryServerString() carefully allocated a buffer padded to the word-aligned string length for sending to the client, copied the string to it, and then forgot to use it, potentially reading a few bytes of garbage past the end of the server_string buffer. Since WriteToClient already handles

[PATCH 16/19] Use C99 designated initializers in dix registry

Signed-off-by: Alan Coopersmith --- dix/registry.c |9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/dix/registry.c b/dix/registry.c index e9c19b0..bb60865 100644 --- a/dix/registry.c +++ b/dix/registry.c @@ -286,8 +286,6 @@ LookupResourceName(RESTYPE resource) void

[PATCH 15/19] Use C99 designated initializers in extension Events

Signed-off-by: Alan Coopersmith --- Xext/saver.c | 23 +++--- Xext/security.c |8 +- Xext/shape.c | 21 ++--- Xext/shm.c| 16 ++-- Xext/sync.c | 46 ++-

[PATCH 18/19] Initialize padding bits to 0 in ErrorConnMax()

Signed-off-by: Alan Coopersmith --- os/connection.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/os/connection.c b/os/connection.c index 039942f..e9be03b 100644 --- a/os/connection.c +++ b/os/connection.c @@ -891,7 +891,7 @@ ErrorConnMax(XtransConnInfo trans_conn) {

[PATCH 17/19] Set padding bytes to 0 in WriteToClient

Clear them out when needed instead of leaving whatever values were present in previously sent messages. Signed-off-by: Alan Coopersmith --- os/io.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/os/io.c b/os/io.c index b67a5f3..f71ef56 100644 --- a/os/io

[PATCH 14/19] Use C99 designated initializers in dix Events

Signed-off-by: Alan Coopersmith --- dix/colormap.c | 34 dix/devices.c| 34 dix/enterleave.c | 14 ++-- dix/events.c | 148 +- dix/inpututils.c | 13 +-- dix/property.c | 13 ++- dix/selection.c | 48 +-- dix/swap

[PATCH 13/19] Use C99 designated initializers in xf86 extension Replies

Signed-off-by: Alan Coopersmith --- hw/xfree86/dixmods/extmod/xf86dga2.c | 176 ++ hw/xfree86/dixmods/extmod/xf86vmode.c | 318 ++--- hw/xfree86/dri/xf86dri.c | 202 +++-- hw/xfree86/dri2/dri2ext.c | 149 +++

[PATCH 12/19] Use C99 designated initializers in Xephyr Replies

Signed-off-by: Alan Coopersmith --- hw/kdrive/ephyr/ephyrdriext.c | 297 + hw/kdrive/ephyr/ephyrglxext.c | 240 + 2 files changed, 280 insertions(+), 257 deletions(-) diff --git a/hw/kdrive/ephyr/ephyrdriext.c b/hw/kdrive/

[PATCH 10/19] Use C99 designated initializers in randr Replies

Signed-off-by: Alan Coopersmith --- randr/rrcrtc.c | 141 - randr/rrdispatch.c |9 +- randr/rrmode.c | 31 +++ randr/rroutput.c | 86 +- randr/rrproperty.c | 66 -- randr/rrscreen.c | 254 +

[PATCH 11/19] Use C99 designated initializers in dmx Replies

Signed-off-by: Alan Coopersmith --- hw/dmx/dmx.c | 546 ++--- hw/dmx/glxProxy/glxcmds.c | 271 ++-- hw/dmx/glxProxy/glxcmdsswap.c | 29 ++- hw/dmx/glxProxy/glxsingle.c | 97 4 files changed, 496 insertions(+

[PATCH 07/19] Use C99 designated initializers in various extension Replies

Signed-off-by: Alan Coopersmith --- composite/compext.c | 63 ++--- damageext/damageext.c | 10 dbe/dbe.c | 51 --- record/record.c | 48 - rend

[PATCH 09/19] Use C99 designated initializers in xkb Replies

Signed-off-by: Alan Coopersmith --- xkb/xkb.c | 525 +++-- 1 file changed, 265 insertions(+), 260 deletions(-) diff --git a/xkb/xkb.c b/xkb/xkb.c index b21815c..03bd69e 100644 --- a/xkb/xkb.c +++ b/xkb/xkb.c @@ -157,7 +157,6 @@ int ProcXk

[PATCH 08/19] Use C99 designated initializers in glx Replies

Signed-off-by: Alan Coopersmith --- glx/glxcmds.c | 352 +++-- glx/single2.c | 28 +++-- glx/single2swap.c | 38 +++--- 3 files changed, 217 insertions(+), 201 deletions(-) diff --git a/glx/glxcmds.c b/glx/glxcmds.c index 0a26a3b..397e

[PATCH 04/19] Use C99 designated initializers in dix Replies

Signed-off-by: Alan Coopersmith --- dix/devices.c | 200 --- dix/dispatch.c | 279 +-- dix/dixfonts.c | 27 +++--- dix/events.c| 94 +++ dix/extension.c | 29 +++--- dix/propert

[PATCH 06/19] Use C99 designated initializers in Xinput Replies

Signed-off-by: Alan Coopersmith --- Xi/chgdctl.c| 12 ++--- Xi/getbmap.c| 25 +-- Xi/getdctl.c| 12 ++--- Xi/getfctl.c| 14 +++--- Xi/getfocus.c | 12 ++--- Xi/getkmap.c| 18 Xi/getmmap.c

[PATCH 03/19] Use C99 designated initializers in SendErrorToClient

Let the compiler worry about 0-filling the rest of the fields, instead of memsetting the whole struct and then going back to overwrite some of the fields. Signed-off-by: Alan Coopersmith --- dix/dispatch.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/dix/

[PATCH 02/19] Use calloc to zero fill buffers being allocated for replies & events

Ensures padding bytes are zero-filled Signed-off-by: Alan Coopersmith --- Xext/sync.c |2 +- mi/miexpose.c |2 +- randr/rrcrtc.c |2 +- render/render.c |4 ++-- xfixes/cursor.c |7 --- xfixes/region.c |3 ++- 6 files changed, 11 insertions(+), 9 deletions(-) d

[PATCH 00/19] Reworking initializion of data sent to clients

This is one of those patch series that started out as noticing one little nit, and then when you pull on the thread the whole server unravels in your lap and you have to spend time off and on for months knitting it back together before you're happy again. In this case, it was noticing garbage in

Re: [PATCH 1/4] shadowfb calls GetGlyphs() so list libXfont as a dependency

On 06/23/12 09:20 PM, Yaakov (Cygwin/X) wrote: > On 2012-06-22 23:59, Alan Coopersmith wrote: >> Blargh. On Solaris you have to link libXfont just right to avoid the weak >> symbols being linked wrong and overriding the symbols from Xorg, which leaves >> Xorg unable to start because it can't even