Re: [PATCH] unload input modules when they are no longer used

2012-07-10 Thread Peter Hutterer
On Mon, Jul 02, 2012 at 03:30:02PM +0200, Michal Suchanek wrote: > Hello > > On 22 June 2012 03:55, Peter Hutterer wrote: > > On Fri, Jun 08, 2012 at 04:19:17PM +0200, Michal Suchanek wrote: > >> Hello, > >> > >> sending the patch witch should fix issue with unloading sibling > >> modules along w

Re: [PATCH v2] uload unused input modules

2012-07-10 Thread Peter Hutterer
On Tue, Jul 03, 2012 at 12:45:21PM +0200, Michal Suchanek wrote: > Hello, > > since the patches got lost somewhere without even generating an error > sending as plain email. > > Changes since v1: > > - split out module 'query' functions > - rename some variables > - fix some whitespace and br

Re: [PATCH (resend) 0/2] Initialisation fixups

2012-07-10 Thread Keith Packard
Daniel Stone writes: > Hi, > Without these two patches, initialisation is broken for me, and the > server asserts (without the XKB patch) or segfaults (without the Sync > patch). I'm not really sure how it's working for others, and looking > at these in context they seem correct, so ... Merged.

[PATCH] xfree86: When xf86CrtcCloseScreen is called, the randr CRTCs are gone

2012-07-10 Thread Keith Packard
The RandR CRTC structures are freed when their resource IDs are destroyed during server shut down, which is before the screen is closed. Calling back into RandR with stale pointers just segfaults the server. Signed-off-by: Keith Packard Cc: Daniel Stone --- hw/xfree86/modes/xf86Crtc.c |3 --

Re: [PATCH] ProcGetPointerMapping uses rep.nElts before it is initialized

2012-07-10 Thread Keith Packard
Keith Packard writes: > Fixed by creating a local nElts variable and using that. Merged. 44bd27c..34cf559 master -> master -- keith.pack...@intel.com pgpmzMBK1AHqc.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Ar

Re: [PATCH 2/2] AllocDevicePair: Ensure XKB privates are initialised

2012-07-10 Thread Peter Hutterer
On Tue, Jul 10, 2012 at 09:10:22AM +0100, Daniel Stone wrote: > Since we call directly into XKB and may be doing so before the extension > has been initialised, make sure its privates are set up first. XTest > had a hack to do this itself, but seems cleaner to just make sure we do > it in AllocDev

[PATCH xorg-gtest v2 8/8] xserver: update documentation

2012-07-10 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- Changes to v1: - remove try/catch include/xorg/gtest/xorg-gtest-xserver.h | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/include/xorg/gtest/xorg-gtest-xserver.h b/include/xorg/gtest/xorg-gtest-xserver.h index 5eb402e..dc9

[PATCH xorg-gtest v2 7/8] environment: remove default settings

2012-07-10 Thread Peter Hutterer
Keep those in the server only, not the environment. And only override the build-in ones when they've been set by main. Signed-off-by: Peter Hutterer --- Changes to v1: - uses SetDisplayNumber/GetDisplayString() now src/environment.cpp | 20 1 file changed, 8 insertions(+)

[PATCH xorg-gtest v2 6/8] xserver: move Terminate and Kill handling here

2012-07-10 Thread Peter Hutterer
Rename to TerminateAndCheck/KillAndCheck to signal that we're waiting for the process to shut down instead of just sending the respective signals Signed-off-by: Peter Hutterer --- Changes to v1: - rename to *AndCheck include/xorg/gtest/xorg-gtest-xserver.h | 13 src/environment.c

[PATCH xorg-gtest v2 5/8] xserver: move testing startup to the XServer object

2012-07-10 Thread Peter Hutterer
No real functional changes, TestStartup() is called by XServer::Start() before the process is started, so from the Environment's POV, everything stays the same. Signed-off-by: Peter Hutterer --- No real hanges that I can recall include/xorg/gtest/xorg-gtest-xserver.h |2 ++ src/environment.

[PATCH xorg-gtest v2 4/8] xserver: move starting the process into the XServer object

2012-07-10 Thread Peter Hutterer
Changes from hardcoded vararg call to requiring the caller to set up options for logfile, config, etc. beforehand. The display string is automatically added to the command line. If no binary is given by the caller, the previously set binary path is used. Signed-off-by: Peter Hutterer --- Changes

[PATCH xorg-gtest v2 3/8] xserver: add WaitForConnections()

2012-07-10 Thread Peter Hutterer
Moved from Environment to XServer class Signed-off-by: Peter Hutterer --- No changes to v1 include/xorg/gtest/xorg-gtest-xserver.h |5 + src/environment.cpp | 33 + src/xserver.cpp | 35 +

[PATCH xorg-gtest v2 2/8] xserver: store config, logfile, binary paths in the XServer object

2012-07-10 Thread Peter Hutterer
And provide a SetOption call for the various commandline options that the server may take. Signed-off-by: Peter Hutterer --- Changes to v1: - drop separate SetConfigPath(), SetLogfilePath() include/xorg/gtest/xorg-gtest-xserver.h | 16 src/environment.cpp

[PATCH xorg-gtest v2 1/8] Add a new class representing the X server

2012-07-10 Thread Peter Hutterer
This class is a Process, so it's a drop-in replacement for the current Environment, but it provides a few methods to talk to the server being started. SetDisplayNumber() is called, but currently unused by the server. Signed-off-by: Peter Hutterer --- Changes to v1: - squashed a few minor patches

[PATCH xorg-gtest v2 0/8] Add XServer class

2012-07-10 Thread Peter Hutterer
Less messy than the first series so some of these v2 patches are patches squashed together from the first version. Functionality is largely the same as in the first set of patches, but the APIs have been cleaned up Cheers, Peter ___ xorg-devel@lists.x

Re: [PATCH xorg-gtest 06/16] xserver: move Terminate and Kill handling here

2012-07-10 Thread Peter Hutterer
On Mon, Jul 09, 2012 at 04:59:02PM -0700, Chase Douglas wrote: > On 07/09/2012 04:26 PM, Peter Hutterer wrote: > >On Mon, Jul 09, 2012 at 10:19:50AM -0700, Chase Douglas wrote: > >>On 07/08/2012 06:50 PM, Peter Hutterer wrote: > >>>On Fri, Jul 06, 2012 at 11:08:13AM -0700, Chase Douglas wrote: > >>

[PATCH xorg-gtest 4/4] process: add Start(program, vector)

2012-07-10 Thread Peter Hutterer
Same thing as the va_list but takes a std::vector of arguments instead. Signed-off-by: Peter Hutterer --- include/xorg/gtest/xorg-gtest-process.h | 16 src/process.cpp | 25 +++-- 2 files changed, 35 insertions(+), 6 deletions(-)

[PATCH xorg-gtest 3/4] Add Device::GetDeviceNode() to return device node path from an evemu device

2012-07-10 Thread Peter Hutterer
evemu doesn't export this information and even evemu-device just trawls through the file system to print this info. So do the same here, noting the time before evemu_create() and the ctime of the new device file. If the latter is later than the former and the device names match, we can assume this

[PATCH xorg-gtest 2/4] test: add SetDisplayString()

2012-07-10 Thread Peter Hutterer
Don't rely on the environment alone, take the display string if it's been set. Signed-off-by: Peter Hutterer --- include/xorg/gtest/xorg-gtest-test.h | 10 ++ src/test.cpp | 12 +++- 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/includ

[PATCH xorg-gtest 1/4] environment: provide Get/SetFoobar wrappers for all set/get_foobar

2012-07-10 Thread Peter Hutterer
The google coding style endorses set_foo and get_foo for setters/getters, but DoSomething style for anything else. Let's not do that, stick to one CamelCase coding style only since most of the functions we'll call will likely be CamelCase. Having a separate style for getters/setters gets ambiguous

[PATCH xorg-gtest 0/4] misc helper functions

2012-07-10 Thread Peter Hutterer
Adding a few helper functions that are needed to add some more functionality to the tests. 3/4 should eventually move into evemu, and we can ifdef this code out if evemu's shipped version supports this functionality. 4/4 still feels clumsy, but I have to find a better approach to this yet. Chee

Re: [PATCH]new driver for siliconmotion

2012-07-10 Thread Matt Turner
I applaud the effort and am thankful that Silicon Motion is contributing to the driver. I actually own a 712, so I feel like I should at least take a look at this patch. Unfortunately, after a quick glance, I'm not very impressed. Generally, I wonder why you haven't been working on the upstream d

Re: [PATCH] ProcGetPointerMapping uses rep.nElts before it is initialized

2012-07-10 Thread Alan Coopersmith
On 07/10/12 04:03 PM, Keith Packard wrote: > In: > > commit d792ac125a0462a04a930af543cbc732f8cdab7d > Author: Alan Coopersmith > Date: Mon Jul 9 19:12:43 2012 -0700 > > Use C99 designated initializers in dix Replies > > the initializer for the .length element of t

[PATCH] ProcGetPointerMapping uses rep.nElts before it is initialized

2012-07-10 Thread Keith Packard
In: commit d792ac125a0462a04a930af543cbc732f8cdab7d Author: Alan Coopersmith Date: Mon Jul 9 19:12:43 2012 -0700 Use C99 designated initializers in dix Replies the initializer for the .length element of the xGetPointerMappingReply structure uses the value o

Re: Integrating NetBSD patches?

2012-07-10 Thread Keith Packard
Thomas Klausner writes: > Are you interested in merging them? Of course; portability fixes are always a good thing. > If yes, please let me know which > way to do that so the effort on both sides is not too high and we can > make progress on this topic. They'd need to be rebased on top of the

Re: [PATCH 1/2] Sync: Always initialise system counter list

2012-07-10 Thread Alan Coopersmith
On 07/10/12 01:10 AM, Daniel Stone wrote: > Sync is designed to let you add system counters before the extension has > been initialised, which means the system counter list may well be full > of bees. Make sure it's initialised before we add to it, to avoid the > risk of fatal injury. > > Signed-

Re: [PATCH 02/54] Don't make failure to -nolisten fatal

2012-07-10 Thread Michal Suchanek
On 10 July 2012 14:34, Daniel Stone wrote: > Hi, > > On 10 July 2012 12:43, Michal Suchanek wrote: >> On 10 July 2012 03:02, Daniel Stone wrote: >>> If failing to disable a protocol specified by -nolisten failed, we'd >>> throw a FatalError and bomb startup entirely. From poking at xtrans, it >

Re: [PATCH:randrproto 0/3] 1.4 spec nits/omissions

2012-07-10 Thread Alex Deucher
On Tue, Jul 10, 2012 at 1:18 AM, Alan Coopersmith wrote: > Some oversights & typos I noticed in the randr 1.4 spec while working on > updating xscope to support 1.4. (Not done with that yet, so more may come > later, but since I saw a call for a 1.4 release soon, figured I'd send what > I have n

Re: [PATCH 02/54] Don't make failure to -nolisten fatal

2012-07-10 Thread Daniel Stone
Hi, On 10 July 2012 12:43, Michal Suchanek wrote: > On 10 July 2012 03:02, Daniel Stone wrote: >> If failing to disable a protocol specified by -nolisten failed, we'd >> throw a FatalError and bomb startup entirely. From poking at xtrans, it >> looks like the only way we can get a failure here

Integrating NetBSD patches?

2012-07-10 Thread Thomas Klausner
Hi! I'm currently looking at migrating the changes NetBSD has in its copy of xorg in the NetBSD CVS tree into pkgsrc. (Just to get an overview if I'll manage to do that or if it's too much effort). This means extracting all the local patches. I guess that most of these haven't been fed upstream t

Re: [PATCH 00/54] extmod, again (and XAA)

2012-07-10 Thread Michel Dänzer
On Die, 2012-07-10 at 12:49 +0200, Michel Dänzer wrote: > > [...] the weird module loading / initialization ordering requirement > of the current solution, which no longer works at all with current > xserver master, and didn't work for me for GLX indirect rendering > before either. Actually, I t

Re: [PATCH 02/54] Don't make failure to -nolisten fatal

2012-07-10 Thread Michal Suchanek
On 10 July 2012 03:02, Daniel Stone wrote: > If failing to disable a protocol specified by -nolisten failed, we'd > throw a FatalError and bomb startup entirely. From poking at xtrans, it > looks like the only way we can get a failure here is because we've > specified a protocol name which doesn'

Re: [PATCH 00/54] extmod, again (and XAA)

2012-07-10 Thread Michel Dänzer
On Die, 2012-07-10 at 18:29 +0800, Zhigang Gong wrote: > > -Original Message- > > From: xorg-devel-bounces+zhigang.gong=linux.intel@lists.x.org > > [mailto:xorg-devel-bounces+zhigang.gong=linux.intel@lists.x.org] On > > Behalf Of Michel D?nzer > > Sent: Tuesday, July 10, 2012 4:30

RE: [PATCH 00/54] extmod, again (and XAA)

2012-07-10 Thread Zhigang Gong
> -Original Message- > From: xorg-devel-bounces+zhigang.gong=linux.intel@lists.x.org > [mailto:xorg-devel-bounces+zhigang.gong=linux.intel@lists.x.org] On > Behalf Of Michel D?nzer > Sent: Tuesday, July 10, 2012 4:30 PM > To: Keith Packard > Cc: xorg-devel@lists.x.org; Daniel Stone;

Re: [PATCH 00/54] extmod, again (and XAA)

2012-07-10 Thread Michel Dänzer
On Die, 2012-07-10 at 01:04 -0700, Keith Packard wrote: > Daniel Stone writes: > > > This should hopefully be the very totally final version of the extmod > > patches. These have all had to be rebased, and some have had to have > > minor tweaks, so I've sent them out again. > > Wow. Ok, fixed

[PATCH] dri2: Pass AsyncSwap [swap_interval=0] requests to the drivers

2012-07-10 Thread Chris Wilson
Currently, the midlayer dri2 code intercepts swap_interval=0 (ala vblank_mode=0) SwapBuffers and converts it to a CopyRegion request. This prevents the backend from doing anything meaningful in this case and typically ends up being vsync'ed since the drivers cannot distinguish it from a regular Cop

Re: A short set of server cleanups before the freeze

2012-07-10 Thread Michel Dänzer
On Die, 2012-07-10 at 01:05 -0700, Keith Packard wrote: > Keith Packard writes: > > > Here's a few cleanups I made while trying to test the current server > > bits. Please comment today if you like, otherwise I'll plan on pushing > > these to > > master in a few hours. > > So, no love for the

[PATCH (resend) 0/2] Initialisation fixups

2012-07-10 Thread Daniel Stone
Hi, Without these two patches, initialisation is broken for me, and the server asserts (without the XKB patch) or segfaults (without the Sync patch). I'm not really sure how it's working for others, and looking at these in context they seem correct, so ... Cheers, Daniel

[PATCH 2/2] AllocDevicePair: Ensure XKB privates are initialised

2012-07-10 Thread Daniel Stone
Since we call directly into XKB and may be doing so before the extension has been initialised, make sure its privates are set up first. XTest had a hack to do this itself, but seems cleaner to just make sure we do it in AllocDevicePair. Signed-off-by: Daniel Stone --- dix/devices.c |2 ++ t

[PATCH 1/2] Sync: Always initialise system counter list

2012-07-10 Thread Daniel Stone
Sync is designed to let you add system counters before the extension has been initialised, which means the system counter list may well be full of bees. Make sure it's initialised before we add to it, to avoid the risk of fatal injury. Signed-off-by: Daniel Stone --- Xext/sync.c |4 ++-- 1

Re: A short set of server cleanups before the freeze

2012-07-10 Thread Keith Packard
Keith Packard writes: > Here's a few cleanups I made while trying to test the current server > bits. Please comment today if you like, otherwise I'll plan on pushing these > to > master in a few hours. So, no love for these patches. As one of them is needed to let hotplug work, I'm just going

Re: [PATCH 00/54] extmod, again (and XAA)

2012-07-10 Thread Keith Packard
Daniel Stone writes: > Hi, > This should hopefully be the very totally final version of the extmod > patches. These have all had to be rebased, and some have had to have > minor tweaks, so I've sent them out again. Wow. Ok, fixed up for alanc's changes and merged to master. ad4092c..532fbc2

Re: [PATCH 03/54] Sync: Always initialise system counter list

2012-07-10 Thread Daniel Stone
Hi, On 10 July 2012 05:03, Alan Coopersmith wrote: > Should the xorg_list_init in SyncExtensionInit be moved inside its > if (RTCounter == 0) check then, so it doesn't reset the list back to > empty after you've done this? Yes, definitely. I'll fix that up - thanks! Cheers, Daniel