Re: [PATCH 9/9] glx/dri2: Enable GLX_ARB_create_context_robustness

2012-07-11 Thread Matt Turner
On Wed, Jul 4, 2012 at 3:21 PM, Ian Romanick wrote: > From: Ian Romanick > > If the driver supports __DRI2_ROBUSTNESS, then enable > GLX_ARB_create_cotnext_robustness as well. If robustness values are > passed to glXCreateContextAttribsARB and the driver doesn't support > __DRI2_ROBUSTNESS, exis

Re: [PATCH xorg-gtest] device: add PlayOne() for single event replaying

2012-07-11 Thread Chase Douglas
On 07/11/2012 09:59 PM, Peter Hutterer wrote: Signed-off-by: Peter Hutterer --- include/xorg/gtest/evemu/xorg-gtest-device.h | 14 ++ src/device.cpp | 20 2 files changed, 34 insertions(+) device->PlayOne(EV_KEY, KEY_Q, 1) i

[PATCH xorg-gtest] device: add PlayOne() for single event replaying

2012-07-11 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- include/xorg/gtest/evemu/xorg-gtest-device.h | 14 ++ src/device.cpp | 20 2 files changed, 34 insertions(+) device->PlayOne(EV_KEY, KEY_Q, 1) is much nicer than having recordings for this. diff

Re: A problem about config touchscreen in xorg

2012-07-11 Thread Peter Hutterer
On Wed, Jul 11, 2012 at 06:53:02PM +0800, David Yu wrote: > Hi everyone: > I have a xubuntu filesystem of arm s3c6410 and I can enter the > system desktop, but s3cXX touchscreen can't work. The filesystem does not > have "xorg.conf" and "xorg.conf.d/" in "/etc/X11", then I have created

Re: [PATCH xorg-gtest 2/2] process: add a timeout wait to Kill and Terminate

2012-07-11 Thread Chase Douglas
On 07/11/2012 05:25 PM, Peter Hutterer wrote: Default of 0 has the same behaviour, but for any other timeout, we wait up to that timeout and then return. Signed-off-by: Peter Hutterer --- I think this is the better implementation over having a separate function call that the caller needs to inv

Re: [PATCH xorg-gtest 1/2] process: Terminate/Kill can use a common helper function

2012-07-11 Thread Chase Douglas
On 07/11/2012 05:24 PM, Peter Hutterer wrote: The only difference is the signal and the message, and we can probably live without the message differentiation (since it throws an exception anyways). Signed-off-by: Peter Hutterer --- We could also just reduce this into one Kill(signal) function a

Re: [PATCH xorg-gtest v2 7/8] environment: remove default settings

2012-07-11 Thread Chase Douglas
On 07/11/2012 06:12 PM, Peter Hutterer wrote: On Wed, Jul 11, 2012 at 05:47:23PM -0700, Chase Douglas wrote: On 07/11/2012 04:26 PM, Peter Hutterer wrote: On Wed, Jul 11, 2012 at 12:24:18PM -0700, Chase Douglas wrote: On 07/10/2012 08:28 PM, Peter Hutterer wrote: Keep those in the server only

Re: [PATCH xorg-gtest v2 7/8] environment: remove default settings

2012-07-11 Thread Peter Hutterer
On Wed, Jul 11, 2012 at 05:47:23PM -0700, Chase Douglas wrote: > On 07/11/2012 04:26 PM, Peter Hutterer wrote: > >On Wed, Jul 11, 2012 at 12:24:18PM -0700, Chase Douglas wrote: > >>On 07/10/2012 08:28 PM, Peter Hutterer wrote: > >>>Keep those in the server only, not the environment. And only overri

Re: [PATCH] Do not unconditionally define DEBUG.

2012-07-11 Thread Alan Coopersmith
On 07/11/12 04:30 AM, Thomas Klausner wrote: > --- > lisp/re/re.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lisp/re/re.c b/lisp/re/re.c > index fca7e28..f4c1246 100644 > --- a/lisp/re/re.c > +++ b/lisp/re/re.c > @@ -31,7 +31,7 @@ > > #include > #include "rep.h"

Re: [PATCH xorg-gtest v2 7/8] environment: remove default settings

2012-07-11 Thread Chase Douglas
On 07/11/2012 04:26 PM, Peter Hutterer wrote: On Wed, Jul 11, 2012 at 12:24:18PM -0700, Chase Douglas wrote: On 07/10/2012 08:28 PM, Peter Hutterer wrote: Keep those in the server only, not the environment. And only override the build-in ones when they've been set by main. I'm a little confus

Re: [PATCH xorg-gtest v2 4/8] xserver: move starting the process into the XServer object

2012-07-11 Thread Chase Douglas
On 07/11/2012 04:07 PM, Peter Hutterer wrote: On Wed, Jul 11, 2012 at 11:57:50AM -0700, Chase Douglas wrote: On 07/10/2012 08:28 PM, Peter Hutterer wrote: Changes from hardcoded vararg call to requiring the caller to set up options for logfile, config, etc. beforehand. The display string is aut

Re: [PATCH xorg-gtest v2 1/8] Add a new class representing the X server

2012-07-11 Thread Chase Douglas
On 07/11/2012 03:16 PM, Peter Hutterer wrote: On Wed, Jul 11, 2012 at 11:35:47AM -0700, Chase Douglas wrote: On 07/10/2012 08:28 PM, Peter Hutterer wrote: This class is a Process, so it's a drop-in replacement for the current Environment, but it provides a few methods to talk to the server bein

[PATCH xorg-gtest 2/2] process: add a timeout wait to Kill and Terminate

2012-07-11 Thread Peter Hutterer
Default of 0 has the same behaviour, but for any other timeout, we wait up to that timeout and then return. Signed-off-by: Peter Hutterer --- I think this is the better implementation over having a separate function call that the caller needs to invoke. Just calling Kill(1000) to wait a second fo

[PATCH xorg-gtest 1/2] process: Terminate/Kill can use a common helper function

2012-07-11 Thread Peter Hutterer
The only difference is the signal and the message, and we can probably live without the message differentiation (since it throws an exception anyways). Signed-off-by: Peter Hutterer --- We could also just reduce this into one Kill(signal) function and just ask the caller to provide SIGTERM/SIGKIL

Re: [PATCH xorg-gtest v2 7/8] environment: remove default settings

2012-07-11 Thread Peter Hutterer
On Wed, Jul 11, 2012 at 12:24:18PM -0700, Chase Douglas wrote: > On 07/10/2012 08:28 PM, Peter Hutterer wrote: > >Keep those in the server only, not the environment. And only override the > >build-in ones when they've been set by main. > > I'm a little confused by this patch. When I read "Keep tho

Re: [PATCH] sdksyms: Fix build with --disable-xv

2012-07-11 Thread Keith Packard
Daniel Stone writes: > I hate this [redacted] script. > > Signed-off-by: Daniel Stone Tested-by: Keith Packard -- keith.pack...@intel.com pgpHF4Gd2WxQY.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://

Re: [PATCH xorg-gtest v2 4/8] xserver: move starting the process into the XServer object

2012-07-11 Thread Peter Hutterer
On Wed, Jul 11, 2012 at 11:57:50AM -0700, Chase Douglas wrote: > On 07/10/2012 08:28 PM, Peter Hutterer wrote: > >Changes from hardcoded vararg call to requiring the caller to set up options > >for logfile, config, etc. beforehand. The display string is automatically > >added to the command line. >

Re: [resend with fixed changelog entry PATCH] xfree86: Strip dangling pointers from desiredMode

2012-07-11 Thread Keith Packard
Maarten Lankhorst writes: > Based on the original patch by Chris Wilson, which was a better fix than mine. > > We stash a copy of the desiredMode on the crtc so that we can restore it > after a vt switch. This copy is a simple memcpy and so also stashes a > references to the pointers contained wi

Re: [PATCH] rrproviderproperty.c: free newly allocated prop in more error paths

2012-07-11 Thread Keith Packard
Alan Coopersmith writes: > Reported by parfait 1.0: > > Error: Memory leak (CWE 401) >Memory leak of pointer 'prop' allocated with > RRCreateProviderProperty(property) > at line 221 of randr/rrproviderproperty.c in function > 'RRChangeProviderProperty'. > 'prop' allocated

Re: [PATCH xorg-gtest v2 2/8] xserver: store config, logfile, binary paths in the XServer object

2012-07-11 Thread Peter Hutterer
On Wed, Jul 11, 2012 at 11:45:59AM -0700, Chase Douglas wrote: > On 07/10/2012 08:28 PM, Peter Hutterer wrote: > >And provide a SetOption call for the various commandline options that the > >server may take. > > > >Signed-off-by: Peter Hutterer > >--- > >Changes to v1: > >- drop separate SetConfig

[PATCH xf86-video-nested 3/3] Resize client (XSetWMNormalHints()) on mode switch

2012-07-11 Thread Daniel Martin
If the user switched the mode, call XSetWMNormalHints() accordingly. --- src/client.h | 4 src/driver.c | 4 src/xlibclient.c | 33 ++--- 3 files changed, 34 insertions(+), 7 deletions(-) diff --git a/src/client.h b/src/client.h index 4c73b3c..dd811

[PATCH xf86-video-nested 2/3] Fix segmentation fault when no modes specified

2012-07-11 Thread Daniel Martin
The test if a mode was specified in the Display SubSection was wrong. ... pScrn->display->modes vs. pScrn->display->modes[0] --- src/driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/driver.c b/src/driver.c index b38e492..2cae14e 100644 --- a/src/driver.c +++ b/src/d

[PATCH xf86-video-nested 1/3] Avoid casts, use union members

2012-07-11 Thread Daniel Martin
Just beautification. --- src/xlibclient.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/xlibclient.c b/src/xlibclient.c index 1aa3590..1f0d3b7 100644 --- a/src/xlibclient.c +++ b/src/xlibclient.c @@ -309,12 +309,12 @@ NestedClientCheckEvents(NestedClient

[PATCH xf86-video-nested 0/3] small commit series with the request for comments

2012-07-11 Thread consume . noise
Hi everyone, I just spend some more time on the nested driver and prepared 3 patches, any comments are appreciated - I'm a newbie. The patches are numbered, but don't depend on each other. [PATCH xf86-video-nested 1/3] Avoid casts, use union members * No commit message, just beautification [PATC

Re: [PATCH xorg-gtest v2 1/8] Add a new class representing the X server

2012-07-11 Thread Peter Hutterer
On Wed, Jul 11, 2012 at 11:35:47AM -0700, Chase Douglas wrote: > On 07/10/2012 08:28 PM, Peter Hutterer wrote: > >This class is a Process, so it's a drop-in replacement for the current > >Environment, but it provides a few methods to talk to the server being > >started. > > > >SetDisplayNumber() is

Re: [PATCH xorg-gtest 2/4] test: add SetDisplayString()

2012-07-11 Thread Peter Hutterer
On Wed, Jul 11, 2012 at 12:38:27PM -0700, Chase Douglas wrote: > On 07/10/2012 06:51 PM, Peter Hutterer wrote: > >Don't rely on the environment alone, take the display string if it's been > >set. > > > >Signed-off-by: Peter Hutterer > >--- > > include/xorg/gtest/xorg-gtest-test.h | 10 +

Re: [PATCH] xfree86: When xf86CrtcCloseScreen is called, the randr CRTCs are gone

2012-07-11 Thread Dave Airlie
On Wed, Jul 11, 2012 at 7:09 AM, Keith Packard wrote: > The RandR CRTC structures are freed when their resource IDs are > destroyed during server shut down, which is before the screen is > closed. Calling back into RandR with stale pointers just segfaults the > server. > > Signed-off-by: Keith Pac

Re: [PATCH] Change autogen.sh scripts to respect NOCONFIGURE

2012-07-11 Thread Colin Walters
(Sorry for taking up people's time with the autogen.sh trivia, I know many of you have more important stuff to do, but once this lands I can use the fact that both GNOME and X.org do the same thing as leverage on smaller projects, and that helps me get much closer to my ideal of having a large

Re: [PATCH xorg-gtest 3/4] Add Device::GetDeviceNode() to return device node path from an evemu device

2012-07-11 Thread Chase Douglas
On 07/10/2012 06:51 PM, Peter Hutterer wrote: evemu doesn't export this information and even evemu-device just trawls through the file system to print this info. So do the same here, noting the time before evemu_create() and the ctime of the new device file. If the latter is later than the former

Re: [PATCH xorg-gtest 1/4] environment: provide Get/SetFoobar wrappers for all set/get_foobar

2012-07-11 Thread Chase Douglas
On 07/10/2012 06:51 PM, Peter Hutterer wrote: The google coding style endorses set_foo and get_foo for setters/getters, but DoSomething style for anything else. Let's not do that, stick to one CamelCase coding style only since most of the functions we'll call will likely be CamelCase. Having a s

Re: [PATCH xorg-gtest 2/4] test: add SetDisplayString()

2012-07-11 Thread Chase Douglas
On 07/10/2012 06:51 PM, Peter Hutterer wrote: Don't rely on the environment alone, take the display string if it's been set. Signed-off-by: Peter Hutterer --- include/xorg/gtest/xorg-gtest-test.h | 10 ++ src/test.cpp | 12 +++- 2 files changed, 2

Re: [PATCH xorg-gtest 3/4] Add Device::GetDeviceNode() to return device node path from an evemu device

2012-07-11 Thread Chase Douglas
On 07/10/2012 06:51 PM, Peter Hutterer wrote: evemu doesn't export this information and even evemu-device just trawls through the file system to print this info. So do the same here, noting the time before evemu_create() and the ctime of the new device file. If the latter is later than the former

Re: [PATCH xorg-gtest 4/4] process: add Start(program, vector)

2012-07-11 Thread Chase Douglas
On 07/10/2012 06:51 PM, Peter Hutterer wrote: Same thing as the va_list but takes a std::vector of arguments instead. Signed-off-by: Peter Hutterer --- include/xorg/gtest/xorg-gtest-process.h | 16 src/process.cpp | 25 +++--

Re: [PATCH xorg-gtest v2 8/8] xserver: update documentation

2012-07-11 Thread Chase Douglas
On 07/10/2012 08:28 PM, Peter Hutterer wrote: Signed-off-by: Peter Hutterer --- Changes to v1: - remove try/catch include/xorg/gtest/xorg-gtest-xserver.h | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/include/xorg/gtest/xorg-gtest-xserver.h b/include/

Re: [PATCH xorg-gtest v2 7/8] environment: remove default settings

2012-07-11 Thread Chase Douglas
On 07/10/2012 08:28 PM, Peter Hutterer wrote: Keep those in the server only, not the environment. And only override the build-in ones when they've been set by main. I'm a little confused by this patch. When I read "Keep those in the server only, not the environment," I expect that the members

Re: [PATCH xorg-gtest v2 6/8] xserver: move Terminate and Kill handling here

2012-07-11 Thread Chase Douglas
On 07/10/2012 08:28 PM, Peter Hutterer wrote: Rename to TerminateAndCheck/KillAndCheck to signal that we're waiting for the process to shut down instead of just sending the respective signals I realized that perhaps we really should compose the functionalities rather than combine them into new

Re: [PATCH] xfree86: When xf86CrtcCloseScreen is called, the randr CRTCs are gone

2012-07-11 Thread Keith Packard
Keith Packard writes: > The RandR CRTC structures are freed when their resource IDs are > destroyed during server shut down, which is before the screen is > closed. Calling back into RandR with stale pointers just segfaults the > server. Sorry Daniel -- this was meant to be sent to Dave instead.

A problem about config touchscreen in xorg

2012-07-11 Thread David Yu
Hi everyone: I have a xubuntu filesystem of arm s3c6410 and I can enter the system desktop, but s3cXX touchscreen can't work. The filesystem does not have "xorg.conf" and "xorg.conf.d/" in "/etc/X11", then I have created a xorg.conf, As follows: Section "InputDevice" Identifie

Re: [PATCH xorg-gtest v2 5/8] xserver: move testing startup to the XServer object

2012-07-11 Thread Chase Douglas
On 07/10/2012 08:28 PM, Peter Hutterer wrote: No real functional changes, TestStartup() is called by XServer::Start() before the process is started, so from the Environment's POV, everything stays the same. This is much easier to understand now, in comparison to how these changes were split ac

Re: [PATCH xorg-gtest v2 4/8] xserver: move starting the process into the XServer object

2012-07-11 Thread Chase Douglas
On 07/10/2012 08:28 PM, Peter Hutterer wrote: Changes from hardcoded vararg call to requiring the caller to set up options for logfile, config, etc. beforehand. The display string is automatically added to the command line. If no binary is given by the caller, the previously set binary path is u

Re: [PATCH xorg-gtest v2 3/8] xserver: add WaitForConnections()

2012-07-11 Thread Chase Douglas
On 07/10/2012 08:28 PM, Peter Hutterer wrote: Moved from Environment to XServer class Signed-off-by: Peter Hutterer --- No changes to v1 include/xorg/gtest/xorg-gtest-xserver.h |5 + src/environment.cpp | 33 + src/xserver.cpp

Re: [PATCH xorg-gtest v2 2/8] xserver: store config, logfile, binary paths in the XServer object

2012-07-11 Thread Chase Douglas
On 07/10/2012 08:28 PM, Peter Hutterer wrote: And provide a SetOption call for the various commandline options that the server may take. Signed-off-by: Peter Hutterer --- Changes to v1: - drop separate SetConfigPath(), SetLogfilePath() include/xorg/gtest/xorg-gtest-xserver.h | 16 +

Re: [PATCH xorg-gtest v2 1/8] Add a new class representing the X server

2012-07-11 Thread Chase Douglas
On 07/10/2012 08:28 PM, Peter Hutterer wrote: This class is a Process, so it's a drop-in replacement for the current Environment, but it provides a few methods to talk to the server being started. SetDisplayNumber() is called, but currently unused by the server. Signed-off-by: Peter Hutterer -

Re: [PATCH] Make pixman-mmx.c compile on x86-32 without optimization

2012-07-11 Thread Matt Turner
On Mon, Jul 9, 2012 at 10:19 PM, Matt Turner wrote: > Works for me. On second glance, did I just make a mistake in b87cd1f and write ifdef instead of ifndef? ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel

Re: [PATCH] Do not unconditionally define DEBUG.

2012-07-11 Thread Matt Turner
On Wed, Jul 11, 2012 at 7:30 AM, Thomas Klausner wrote: The subject of patches to anything but the X server sent to this list should be [PATCH ]. E.g., [PATCH xedit] ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xor

Re: [PATCH]new driver for siliconmotion

2012-07-11 Thread Matt Turner
On Tue, Jul 10, 2012 at 8:24 PM, Matt Turner wrote: > 64 Megabytes in bytes is too large for a signed int. This code cannot > work. It's clear that someone thought about this, since there's a > more-correct commented-out function signature above it. Math fail. Ignore this hunk. The commented-out

[PATCH] sdksyms: Fix build with --disable-xv

2012-07-11 Thread Daniel Stone
I hate this [redacted] script. Signed-off-by: Daniel Stone --- hw/xfree86/sdksyms.sh |2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/xfree86/sdksyms.sh b/hw/xfree86/sdksyms.sh index c0398da..07372ad 100755 --- a/hw/xfree86/sdksyms.sh +++ b/hw/xfree86/sdksyms.sh @@ -46,8 +46,10 @@ cat

Re: [PATCH] Add EXA support

2012-07-11 Thread Michel Dänzer
On Mon, 2012-07-09 at 16:44 -0700, Connor Behan wrote: > On 06/07/12 03:52 AM, Michel Dänzer wrote: > > On Don, 2012-07-05 at 17:51 -0700, Connor Behan wrote: > >> For real this time. This allows the r128 driver to continue having 2D > > That this patch is for the r128 driver should be mentioned o

[resend with fixed changelog entry PATCH] xfree86: Strip dangling pointers from desiredMode

2012-07-11 Thread Maarten Lankhorst
Based on the original patch by Chris Wilson, which was a better fix than mine. We stash a copy of the desiredMode on the crtc so that we can restore it after a vt switch. This copy is a simple memcpy and so also stashes a references to the pointers contained within the desiredMode. Those pointers

Patches from NetBSD's xsrc

2012-07-11 Thread Thomas Klausner
The simplest patch I could find first, for xedit: [PATCH] Do not unconditionally define DEBUG. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH] Do not unconditionally define DEBUG.

2012-07-11 Thread Thomas Klausner
--- lisp/re/re.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/re/re.c b/lisp/re/re.c index fca7e28..f4c1246 100644 --- a/lisp/re/re.c +++ b/lisp/re/re.c @@ -31,7 +31,7 @@ #include #include "rep.h" -#define DEBUG + /* * Types */ -- 1.7.11.1 __

Re: Integrating NetBSD patches?

2012-07-11 Thread Thomas Klausner
On Tue, Jul 10, 2012 at 01:22:26PM -0700, Keith Packard wrote: > They'd need to be rebased on top of the current development branches of > each repository. That can vary from trivial to a huge amount of > work. Starting with simple fixes to learn where the pitfalls are is > probably a good idea. O

RE: [PATCH 00/54] extmod, again (and XAA)

2012-07-11 Thread Zhigang Gong
> -Original Message- > From: xorg-devel-bounces+zhigang.gong=linux.intel@lists.x.org > [mailto:xorg-devel-bounces+zhigang.gong=linux.intel@lists.x.org] On > Behalf Of Michel D?nzer > Sent: Tuesday, July 10, 2012 6:49 PM > To: Zhigang Gong > Cc: xorg-devel@lists.x.org; 'Daniel Stone'

[PATCH] rrproviderproperty.c: free newly allocated prop in more error paths

2012-07-11 Thread Alan Coopersmith
Reported by parfait 1.0: Error: Memory leak (CWE 401) Memory leak of pointer 'prop' allocated with RRCreateProviderProperty(property) at line 221 of randr/rrproviderproperty.c in function 'RRChangeProviderProperty'. 'prop' allocated at line 155 with RRCreateProviderProperty(