[PATCH xinput] Add rotation support

2012-07-12 Thread Peter Hutterer
Rotating the device simply sets the Coordinate Transformation Matrix to the rotation matrix, it does not handle screen mapping or offsets. Signed-off-by: Peter Hutterer --- configure.ac|3 +++ man/xinput.man |6 ++ src/Makefile.am |4 ++-- src/property.c | 44

Re: [PATCH v2 2/2] Populate touch emulated button state separately

2012-07-12 Thread Peter Hutterer
On Thu, Jul 12, 2012 at 01:24:18PM -0700, Chase Douglas wrote: > On 07/11/2012 11:34 PM, Peter Hutterer wrote: > >On Mon, Jul 09, 2012 at 05:12:44PM -0700, Chase Douglas wrote: > >>When a touch begin is pointer emulated, do not include touch state when > >>calculating the button state for the initi

Re: [PATCH] Cache xkbcomp output

2012-07-12 Thread Keith Packard
Colin Walters writes: > It'd be nicer if X shipped a binary to run which did whatever is > necessary to ensure the cache is valid, and update it. That keeps the > implementation details of the caching contained where it should be, and > not duplicated around in the various rpm/deb/other postinst

Re: [PATCH v2] Add regression test for button event state for touch emulation

2012-07-12 Thread Peter Hutterer
On Thu, Jul 12, 2012 at 01:17:33PM -0700, Chase Douglas wrote: > On 07/11/2012 11:26 PM, Peter Hutterer wrote: > >On Mon, Jul 09, 2012 at 05:13:15PM -0700, Chase Douglas wrote: > >>When a touch begin is pointer emulated, the initial motion and button > >>press events should not have the first butto

Re: [PATCH] Cache xkbcomp output

2012-07-12 Thread Colin Walters
On Thu, 2012-07-12 at 15:27 -0700, Keith Packard wrote: > My plan is to simply put that work on the package installer loading new > files into the xkb directories. A simple post-install hook that removed > all of the files in the server's cache directory should make that work It'd be nicer if X s

Re: git pull: glx + build fix

2012-07-12 Thread Keith Packard
Dave Airlie writes: > Bartosz Brachaczek (1): > glx: Fix checking GL version > > Dave Airlie (6): > glx: pass screen into the convert function > glx/dri2: fix typo in the notification reset for robustness. > glx/dri2: fix incorrect == vs = > glx/dri2: use correct def

git pull: glx + build fix

2012-07-12 Thread Dave Airlie
Hi Keith, the GLX fixes are all for building against mesa master, the platform bus fix is unreviewed, but please smash an r-b on it, its trivial, but Fedora won't build the server with implicit declarations. Dave. The following changes since commit ea74e381ae91f45ec195a5505262e2e5a3c0e1c9: xt

Re: [PATCH] Cache xkbcomp output

2012-07-12 Thread Keith Packard
Daniel Stone writes: > Ugh, please don't do that. I already get people (validly) complaining > that XKB is unintuitive enough ... Yeah, but I don't want to stat 324 files and 26 directories. That seems like a worse plan. > You could just do everything under the data root directory, although I

Re: [PATCH] Cache xkbcomp output

2012-07-12 Thread Daniel Stone
Hi, On 12 July 2012 23:27, Keith Packard wrote: > Daniel Stone writes: > >> You need to do at least some rudimentary stat() work so that you'll >> rebuild the keymap if the files it uses changes. > > My plan is to simply put that work on the package installer loading new > files into the xkb dir

Re: [PATCH] Cache xkbcomp output

2012-07-12 Thread Keith Packard
Daniel Stone writes: > You need to do at least some rudimentary stat() work so that you'll > rebuild the keymap if the files it uses changes. My plan is to simply put that work on the package installer loading new files into the xkb directories. A simple post-install hook that removed all of the

Re: [PATCH] xtest: add extinit.h for SyncExtensionInit

2012-07-12 Thread Keith Packard
Dave Airlie writes: > This adds the decl for SyncExtenionInit. Tested-by: Keith Packard master -- keith.pack...@intel.com pgp0zVBO6KWGU.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archi

Re: [PATCH] Cache xkbcomp output

2012-07-12 Thread Daniel Stone
Hi, On 12 July 2012 23:07, Keith Packard wrote: > Construct a unique filename based on the display name and the RMLVO > values. If that file contains valid contents, use it. Otherwise, > compile the keymap to that file and don't unlink it so that it will be > re-used the next time the server runs

Re: [PULL] XWin fixes for extmod removal changes fallout

2012-07-12 Thread Keith Packard
Jon TURNEY writes: > Jon TURNEY (3): > Revert bogus GlxPushProvider() in commit a1d41e3 > Restore extern to the declaration of __glXDRISWRastProvider > Restore GLX extension to XWin Merged. a2d0829..746193a master -> master -- keith.pack...@intel.com pgp7GuYp7qa1V.pgp D

Re: [PATCH xserver 0/2] glx/dri2: Fix bug #50019.

2012-07-12 Thread Keith Packard
Michel Dänzer writes: > [PATCH 1/2] dri2: Add DRI2CreateDrawable2. > [PATCH 2/2] glx: Free DRI2 drawable reference to destroyed GLX Merged. 656e5fe..a2d0829 master -> master -- keith.pack...@intel.com pgpvdimyUbuFg.pgp Description: PGP signature __

[PATCH] Cache xkbcomp output

2012-07-12 Thread Keith Packard
Construct a unique filename based on the display name and the RMLVO values. If that file contains valid contents, use it. Otherwise, compile the keymap to that file and don't unlink it so that it will be re-used the next time the server runs. Signed-off-by: Keith Packard --- include/xkbsrv.h |

Re: [PATCH] Add EXA support

2012-07-12 Thread Connor Behan
On 11/07/12 08:13 AM, Michel Dänzer wrote: > On Mon, 2012-07-09 at 16:44 -0700, Connor Behan wrote: >> On 06/07/12 03:52 AM, Michel Dänzer wrote: >>> On Don, 2012-07-05 at 17:51 -0700, Connor Behan wrote: For real this time. This allows the r128 driver to continue having 2D >>> That this patc

Re: [PATCH v2 2/2] Populate touch emulated button state separately

2012-07-12 Thread Chase Douglas
On 07/11/2012 11:34 PM, Peter Hutterer wrote: On Mon, Jul 09, 2012 at 05:12:44PM -0700, Chase Douglas wrote: When a touch begin is pointer emulated, do not include touch state when calculating the button state for the initial motion and button press events. This change ensures the logical state

Re: [PATCH v2] Add regression test for button event state for touch emulation

2012-07-12 Thread Chase Douglas
On 07/11/2012 11:26 PM, Peter Hutterer wrote: On Mon, Jul 09, 2012 at 05:13:15PM -0700, Chase Douglas wrote: When a touch begin is pointer emulated, the initial motion and button press events should not have the first button set in the button mask. The button mask represents the state of the but

Re: [Nouveau] [PATCH 9/9] dri2: Fix corner case crash for swaplimit > 1

2012-07-12 Thread Anssi Hannula
Hi! On 16.02.2012 02:45, Mario Kleiner wrote: If a swaplimit > 1 is set on a server which supports the swaplimit api (XOrg 1.12.0+), the following can happen: 1. Client calls glXSwapBuffersMscOML() with a swap target > 1 vblank in the future, or a client calls glXSwapbuffers() while the s

Re: [PATCH libFS] Fix a prototype error

2012-07-12 Thread Julien Cristau
On Thu, Jul 12, 2012 at 14:39:26 +0200, Thomas Klausner wrote: > Per NetBSD PR 41899 from Henning Petersen. > > Signed-off-by: Thomas Klausner > --- > src/FSlibInt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/FSlibInt.c b/src/FSlibInt.c > index db9cc47..a04d3c

Re: [PATCH 1/2] dri2: Add DRI2CreateDrawable2.

2012-07-12 Thread Keith Packard
Michel Dänzer writes: > On Don, 2012-07-12 at 09:30 -0700, Keith Packard wrote: >> Michel Dänzer writes: >> >> > From: Michel Dänzer >> > >> > Same as DRI2CreateDrawable, except it can return the DRI2 specific XID of >> > the >> > DRI2 drawable reference to the base drawable. >> >> Any reas

Re: [PATCH] Rename PIC to XMAN_PIC to avoid problems with "-DPIC" compilations.

2012-07-12 Thread Thomas Klausner
On Thu, Jul 12, 2012 at 07:00:52PM +0200, walter harms wrote: > I see, to be fair i do not know the code but the names are roff/nroff > precompiler therefore i would > expect a name like roff_pic. Fine with me, I've just resent the patch with the change as suggested. Pick either, I don't really c

[PATCH] Rename PIC to ROFF_PIC to avoid problems with "-DPIC" compilations. From Christos Zoulas .

2012-07-12 Thread Thomas Klausner
Signed-off-by: Thomas Klausner --- misc.c | 2 +- vendor.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/misc.c b/misc.c index 8818aa8..abe410e 100644 --- a/misc.c +++ b/misc.c @@ -764,7 +764,7 @@ ConstructCommand(cmdbuf, path, filename, tempfile) filter =

[PATCH xman] Changed patch after suggestion by Walter Harms

2012-07-12 Thread Thomas Klausner
The same patch as before, but with s/XMAN/ROFF/ -- pick either version :) [PATCH] Rename PIC to ROFF_PIC to avoid problems with "-DPIC" ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org

Re: [PATCH 1/5] glx: pass screen into the convert function

2012-07-12 Thread Ian Romanick
On 07/12/2012 02:12 AM, Dave Airlie wrote: when robustness is enabled, this is required. Cc: Ian Romanick Signed-off-by: Dave Airlie Series is Reviewed-by: Ian Romanick --- glx/glxdri2.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/glx/glxdri2.c b/glx/gl

Re: [PATCH 3/5] glx/dri2: fix incorrect == vs =

2012-07-12 Thread Ian Romanick
On 07/12/2012 02:12 AM, Dave Airlie wrote: glxdri2.c:486: warning: statement with no effect Signed-off-by: Dave Airlie Cc: Ian Romanick This also needs the 'glx: Fix checking GL version' posted by Bartosz Brachaczek back on 7/5. --- glx/glxdri2.c |2 +- 1 file changed, 1 insertion

Re: [PATCH 9/9] glx/dri2: Enable GLX_ARB_create_context_robustness

2012-07-12 Thread Matt Turner
On Thu, Jul 12, 2012 at 10:33 AM, Ian Romanick wrote: > No, it should have been __DRI_CTX_ATTRIB_RESET_STRATEGY. :( I making > changes across multiple repos across multiple sets of review comments. I'll > change the name in Mesa back to __DRI_CTX_ATTRIB_RESET_NOTIFICATION. Okay. Dave has '[PATCH

Re: [PATCH 9/9] glx/dri2: Enable GLX_ARB_create_context_robustness

2012-07-12 Thread Ian Romanick
On 07/11/2012 10:37 PM, Matt Turner wrote: On Wed, Jul 4, 2012 at 3:21 PM, Ian Romanick wrote: From: Ian Romanick If the driver supports __DRI2_ROBUSTNESS, then enable GLX_ARB_create_cotnext_robustness as well. If robustness values are passed to glXCreateContextAttribsARB and the driver does

Re: [PATCH 1/2] dri2: Add DRI2CreateDrawable2.

2012-07-12 Thread Michel Dänzer
On Don, 2012-07-12 at 09:30 -0700, Keith Packard wrote: > Michel Dänzer writes: > > > From: Michel Dänzer > > > > Same as DRI2CreateDrawable, except it can return the DRI2 specific XID of > > the > > DRI2 drawable reference to the base drawable. > > Any reason to keep the old function around?

Re: [PATCH 2/5] glx/dri2: fix typo in the notification reset for robustness.

2012-07-12 Thread Matt Turner
On Thu, Jul 12, 2012 at 2:12 AM, Dave Airlie wrote: > Cc: Ian Romanick > Signed-off-by: Dave Airlie > --- Patches 2-5 are R-b me. No idea about patch 1. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Inf

[PULL] XWin fixes for extmod removal changes fallout

2012-07-12 Thread Jon TURNEY
Hi Keith, Please consider pulling into master. Thanks. The following changes since commit deb08658e2a6b1647a7213a316c6f3019bcdce48: xfree86: Strip dangling pointers from desiredMode (2012-07-11 15:55:22 -0700) are available in the git repository at: git://people.freedesktop.org/~jturney/x

Re: [PATCH] Rename PIC to XMAN_PIC to avoid problems with "-DPIC" compilations.

2012-07-12 Thread walter harms
Am 12.07.2012 14:55, schrieb Thomas Klausner: > Signed-off-by: Thomas Klausner > --- > misc.c | 2 +- > vendor.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/misc.c b/misc.c > index 8818aa8..7592996 100644 > --- a/misc.c > +++ b/misc.c > @@ -764,7 +764,7 @@ Con

Re: [PATCH 1/2] dri2: Add DRI2CreateDrawable2.

2012-07-12 Thread Keith Packard
Michel Dänzer writes: > From: Michel Dänzer > > Same as DRI2CreateDrawable, except it can return the DRI2 specific XID of the > DRI2 drawable reference to the base drawable. Any reason to keep the old function around? It doesn't appear to be used outside of the X server. -- keith.pack...@inte

Re: [PULL] XQuartz build fixes for ext changes fallout

2012-07-12 Thread Keith Packard
Jeremy Huddleston Sequoia writes: > Jeremy Huddleston (3): > XQuartz: Silence an unused-variable warning > XQuartz: Fix build failure due to incorrect PseudoramiXExtensionInit > prototype > XQuartz: Re-add prototype for DRIExtensionInit 8b820f2..656e5fe master -> master -

Re: [PATCH] sdksyms: Fix build with --disable-xv

2012-07-12 Thread Keith Packard
Daniel Stone writes: > I hate this [redacted] script. > > Signed-off-by: Daniel Stone Merged. deb0865..8b820f2 master -> master -- keith.pack...@intel.com pgpq3JJDF6hRx.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org developme

Re: [PATCH] Do not unconditionally define DEBUG.

2012-07-12 Thread Thomas Klausner
On Wed, Jul 11, 2012 at 05:56:45PM -0700, Alan Coopersmith wrote: > Works for me. Applied & pushed to git master: > To ssh://git.freedesktop.org/git/xorg/app/xedit >33dacad..ce36f7b master -> master Thank you! > As Matt noted, please include the module name in the [PATCH module] header > f

Re: [PATCH 0/3] extmod changes fallout

2012-07-12 Thread Colin Harrison
Hi, All Jon's series works OK for me: Reviewed-by: Colin Harrison Tested-by: Colin Harrison Thanks, Colin Harrison ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinf

Re: [PATCH xserver 0/2] glx/dri2: Fix bug #50019.

2012-07-12 Thread Kristian Høgsberg
On Thu, Jul 12, 2012 at 7:16 AM, Michel Dänzer wrote: > As suggested by Kristian Høgsberg, explicitly call FreeResource for the DRI2 > drawable reference. > > [PATCH 1/2] dri2: Add DRI2CreateDrawable2. > [PATCH 2/2] glx: Free DRI2 drawable reference to destroyed GLX Thanks, Michel. For the serie

[PATCH] xtest: add extinit.h for SyncExtensionInit

2012-07-12 Thread Dave Airlie
This adds the decl for SyncExtenionInit. Signed-off-by: Dave Airlie --- test/xtest.c |1 + 1 file changed, 1 insertion(+) diff --git a/test/xtest.c b/test/xtest.c index 402d9ce..e5e5241 100644 --- a/test/xtest.c +++ b/test/xtest.c @@ -30,6 +30,7 @@ #include "inputstr.h" #include "scrnints

Re: [xkbdata] colemak support

2012-07-12 Thread Thomas Klausner
On Thu, Jul 12, 2012 at 06:51:04AM -0700, Alan Coopersmith wrote: > xkbdata is long dead - xkeyboard-config replaced it shortly after the > X11R7.0 release. Thanks for the info. Upon checking further, NetBSD has already switched to xkeyboard-config (in 2009 or so) but just didn't remove xkbdata (y

[PATCH] xf86: include xf86platformBus.h in xf86AutoConfig.c

2012-07-12 Thread Dave Airlie
This fixes an implicit declaration, xf86AutoConfig.c:202:5: error: implicit declaration of function 'xf86PlatformMatchDriver' [-Werror=implicit-function-declaration] xf86AutoConfig.c:202:5: warning: nested extern declaration of 'xf86PlatformMatchDriver' [-Wnested-externs] Signed-off-by: Dave Air

Re: [xkbdata] colemak support

2012-07-12 Thread Alan Coopersmith
On 07/12/12 05:25 AM, Thomas Klausner wrote: > Another patch to NetBSD xsrc adds Colemak data to xkbdata. > > The files are marked: > "2006-01-01 Shai Coleman, http://colemak.com/ . Public domain." > so they should be safe to include. > > I didn't find an anongit repository for xkbdata, so the tw

Re: Cannot compile xorg-server-git with current mesa

2012-07-12 Thread Dave Airlie
On Thu, Jul 12, 2012 at 6:54 PM, wrote: > Hi. I have got the following error: > Making all in glx > make[1]: Enter to folder `/usr/src/xorg-server-git/src/xserver/glx' > CC glxdri2.lo > glxdri2.c: In function '__glXDRIscreenDestroy': > glxdri2.c:385:18: warning: cast discards '__attribute

Cannot compile xorg-server-git with current mesa

2012-07-12 Thread son_of_the_osiris
Hi. I have got the following error: Making all in glx make[1]: Enter to folder `/usr/src/xorg-server-git/src/xserver/glx' CC glxdri2.lo glxdri2.c: In function '__glXDRIscreenDestroy': glxdri2.c:385:18: warning: cast discards '__attribute__((const))' qualifier from pointer target type [-Wc

[PATCH] Rename PIC to XMAN_PIC to avoid problems with "-DPIC" compilations.

2012-07-12 Thread Thomas Klausner
Signed-off-by: Thomas Klausner --- misc.c | 2 +- vendor.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/misc.c b/misc.c index 8818aa8..7592996 100644 --- a/misc.c +++ b/misc.c @@ -764,7 +764,7 @@ ConstructCommand(cmdbuf, path, filename, tempfile) filter =

[PATCH xman] avoid PIC macro

2012-07-12 Thread Thomas Klausner
Lots of compiler setting recommendations include "-DPIC -fPIC" for compiling position-independent code. This patch avoids a problem with that in xman. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: htt

Re: [PATCH 3/3] Restore GLX extension to XWin

2012-07-12 Thread Daniel Stone
Hi, On 12 July 2012 13:30, Jon TURNEY wrote: > #ifdef XWIN_GLX_WINDOWS > -if (g_fNativeGl) { > +if ((g_fNativeGl) && (serverGeneration == 1)) { > /* install the native GL provider */ > glxWinPushNativeProvider(); > } > #endif You might instead want to create a wr

[PATCH libFS] Fix a prototype error

2012-07-12 Thread Thomas Klausner
Per NetBSD PR 41899 from Henning Petersen. Signed-off-by: Thomas Klausner --- src/FSlibInt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/FSlibInt.c b/src/FSlibInt.c index db9cc47..a04d3cd 100644 --- a/src/FSlibInt.c +++ b/src/FSlibInt.c @@ -1194,7 +1194,7 @@ doData16(

[PATCH libFS] Fix a prototype error

2012-07-12 Thread Thomas Klausner
Another simple fix, this time for libFS -- a broken prototype. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH 3/3] Restore GLX extension to XWin

2012-07-12 Thread Jon TURNEY
- Add an XwinExtensionInit(), similar in spirit to QuartzExtensionInit() and xf86ExtensionInit() - Load the GLX extension (I'm guessing XQuartz needs this adding somewhere as well) - Also, since we now have an proper place to install the native GL provider where it will take priority over the the s

[PATCH 2/3] Restore extern to the declaration of __glXDRISWRastProvider

2012-07-12 Thread Jon TURNEY
b86aa74 dropped the 'extern' from the declaration of __glXDRISWRastProvider This turns out to be important to me, as without it, the final link only gets the tentative definition of __glXDRISWRastProvider implied by the declaration, and not the proper one from glxdriswrast.c, presumably because no

[PATCH 1/3] Revert bogus GlxPushProvider() in commit a1d41e3

2012-07-12 Thread Jon TURNEY
a1d41e3 "Move extension initialisation prototypes into extinit.h" also includes a change to GlxExtensionInit to install the swrast GLX provider. Since b86aa74 "GLX: Insert swrast provider from GlxExtensionInit" already does this (correctly, by installing the swrast provider at the end of the chain

[PATCH 0/3] extmod changes fallout

2012-07-12 Thread Jon TURNEY
Jon TURNEY (3): Revert bogus GlxPushProvider() in commit a1d41e3 Restore extern to the declaration of __glXDRISWRastProvider Restore GLX extension to XWin glx/glxext.c |3 --- glx/glxserver.h |2 +- hw/xwin/InitOutput.c | 23 --- 3 files changed, 2

[xkbdata] colemak support

2012-07-12 Thread Thomas Klausner
Another patch to NetBSD xsrc adds Colemak data to xkbdata. The files are marked: "2006-01-01 Shai Coleman, http://colemak.com/ . Public domain." so they should be safe to include. I didn't find an anongit repository for xkbdata, so the two files are added as attachment with corresponding Makefile

[xinit] XSLASHGLOB

2012-07-12 Thread Thomas Klausner
Hi! While looking at NetBSD xsrc patches I found one for xinit. Index: xinit/dist/xinitrc.cpp === RCS file: /cvsroot/xsrc/external/mit/xinit/dist/xinitrc.cpp,v retrieving revision 1.1.1.3 retrieving revision 1.2 diff -u -r1.1.1.3 -r1

[PATCH 1/2] dri2: Add DRI2CreateDrawable2.

2012-07-12 Thread Michel Dänzer
From: Michel Dänzer Same as DRI2CreateDrawable, except it can return the DRI2 specific XID of the DRI2 drawable reference to the base drawable. Signed-off-by: Michel Dänzer --- hw/xfree86/dri2/dri2.c | 15 +-- hw/xfree86/dri2/dri2.h |7 +++ 2 files changed, 20 insertions(

[PATCH xserver 0/2] glx/dri2: Fix bug #50019.

2012-07-12 Thread Michel Dänzer
As suggested by Kristian Høgsberg, explicitly call FreeResource for the DRI2 drawable reference. [PATCH 1/2] dri2: Add DRI2CreateDrawable2. [PATCH 2/2] glx: Free DRI2 drawable reference to destroyed GLX ___ xorg-devel@lists.x.org: X.Org development Arch

[PATCH 2/2] glx: Free DRI2 drawable reference to destroyed GLX drawable.

2012-07-12 Thread Michel Dänzer
From: Michel Dänzer Otherwise the reference can lead to use after free in __glXDRIinvalidateBuffers(). Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=50019 Signed-off-by: Michel Dänzer --- glx/glxdri2.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/glx

Re: 答复: [PATCH]new driver for siliconmotion

2012-07-12 Thread Tiago Vignatti
On 07/12/2012 05:17 AM, Aaron.Chen 陈俊杰 wrote: Hi Matt, Thank you for your review. We really appreciate that you've pick out so many issues we need to improve. It seems that we still have a lot of work to do to match the quality which can be accepted by X.Org. We will fix the issue you've rep

[PATCH 5/5] glx/dri2: don't return NULL in a function with no return.

2012-07-12 Thread Dave Airlie
Reported by gcc. Signed-off-by: Dave Airlie Cc: Ian Romanick --- glx/glxdri2.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/glx/glxdri2.c b/glx/glxdri2.c index ddbcf69..b8261d4 100644 --- a/glx/glxdri2.c +++ b/glx/glxdri2.c @@ -518,7 +518,7 @@ create_driver_context(__G

[PATCH 4/5] glx/dri2: use correct define from dri attribs.

2012-07-12 Thread Dave Airlie
Looks like idr renamed this and pushed the wrong one. Signed-off-by: Dave Airlie Cc: Ian Romanick --- glx/glxdri2.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/glx/glxdri2.c b/glx/glxdri2.c index a35e39c..ddbcf69 100644 --- a/glx/glxdri2.c +++ b/glx/glxdri2.c @@ -537,

[PATCH 3/5] glx/dri2: fix incorrect == vs =

2012-07-12 Thread Dave Airlie
glxdri2.c:486: warning: statement with no effect Signed-off-by: Dave Airlie Cc: Ian Romanick --- glx/glxdri2.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/glx/glxdri2.c b/glx/glxdri2.c index 6b389ab..a35e39c 100644 --- a/glx/glxdri2.c +++ b/glx/glxdri2.c @@ -484,7 +48

[PATCH 2/5] glx/dri2: fix typo in the notification reset for robustness.

2012-07-12 Thread Dave Airlie
Cc: Ian Romanick Signed-off-by: Dave Airlie --- glx/glxdri2.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/glx/glxdri2.c b/glx/glxdri2.c index 608cc17..6b389ab 100644 --- a/glx/glxdri2.c +++ b/glx/glxdri2.c @@ -535,7 +535,7 @@ create_driver_context(__GLXDRIcontext * con

[PATCH 1/5] glx: pass screen into the convert function

2012-07-12 Thread Dave Airlie
when robustness is enabled, this is required. Cc: Ian Romanick Signed-off-by: Dave Airlie --- glx/glxdri2.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/glx/glxdri2.c b/glx/glxdri2.c index 909de70..608cc17 100644 --- a/glx/glxdri2.c +++ b/glx/glxdri2.c @@ -390,7 +

Re: [PATCH:randrproto 0/3] 1.4 spec nits/omissions

2012-07-12 Thread Dave Airlie
On Tue, Jul 10, 2012 at 10:45 PM, Alex Deucher wrote: > On Tue, Jul 10, 2012 at 1:18 AM, Alan Coopersmith > wrote: >> Some oversights & typos I noticed in the randr 1.4 spec while working on >> updating xscope to support 1.4. (Not done with that yet, so more may come >> later, but since I saw a

[PULL] XQuartz build fixes for ext changes fallout

2012-07-12 Thread Jeremy Huddleston Sequoia
The following changes since commit deb08658e2a6b1647a7213a316c6f3019bcdce48: xfree86: Strip dangling pointers from desiredMode (2012-07-11 15:55:22 -0700) are available in the git repository at: git://people.freedesktop.org/~jeremyhu/xserver master for you to fetch changes up to 1720cd9badf

Re: [PATCH v2 2/2] Populate touch emulated button state separately

2012-07-12 Thread Peter Hutterer
On Mon, Jul 09, 2012 at 05:12:44PM -0700, Chase Douglas wrote: > When a touch begin is pointer emulated, do not include touch state when > calculating the button state for the initial motion and button press > events. This change ensures the logical state of the buttons prior to the > events is set

Re: [PATCH v2] Add regression test for button event state for touch emulation

2012-07-12 Thread Peter Hutterer
On Mon, Jul 09, 2012 at 05:13:15PM -0700, Chase Douglas wrote: > When a touch begin is pointer emulated, the initial motion and button > press events should not have the first button set in the button mask. > The button mask represents the state of the buttons *before* the event. > > Signed-off-by

答复: [PATCH]new driver for siliconmotion

2012-07-12 Thread Aaron . Chen 陈俊杰
Hi Matt, Thank you for your review. We really appreciate that you've pick out so many issues we need to improve. It seems that we still have a lot of work to do to match the quality which can be accepted by X.Org. We will fix the issue you've reported before next submission. One more question: