Re: [PATCH lib/libXfont] If Socket is getting interrupted with signal EINTR, after re attempts we are closing socket connection, which is wrong.

2012-08-25 Thread Alan Coopersmith
On 08/23/12 03:45 AM, Arvind Umrao wrote: Code changes are integrated in Solaris and now I am trying to give back to community. If Socket is getting interrupted with signal EINTR, we should keep socket in progress state. I have borrowed following code from Socket Write _fs_flush():line274 .

Re: xwininfo: const in iconv

2012-08-25 Thread Thomas Klausner
On Fri, Aug 24, 2012 at 06:14:20PM -0700, Alan Coopersmith wrote: I think that's already taken care of via the AM_ICONV autoconf macro that checks for the constness of the pointer and sets ICONV_CONST appropriately, but we don't seem to have released a tarball with that fix (commit

Re: [PATCH:intel-gpu-tools 0/4] Fix build on Solaris

2012-08-25 Thread Daniel Vetter
On Fri, Aug 24, 2012 at 02:02:00PM -0700, Alan Coopersmith wrote: With these patches, the current head of git master builds completely on Solaris 11 with gcc 4.5, and all but intel_l3_parity.c builds fine with Solaris Studio 12.3. (The __attribute__ ((__packed__)) in that file triggers an

Re: [PATCH:intel-gpu-tools 2/4] Rename NOPID to NO_PID to avoid conflict with Solaris NOPID

2012-08-25 Thread Daniel Vetter
On Fri, Aug 24, 2012 at 02:52:19PM -0700, Alan Coopersmith wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/24/12 02:50 PM, Eric Anholt wrote: Alan Coopersmith alan.coopersm...@oracle.com writes: Solaris sys/types.h already has #define NOPID (pid_t)(-1) Signed-off-by:

Re: xwininfo: const in iconv

2012-08-25 Thread Alan Coopersmith
On 08/25/12 02:24 AM, Thomas Klausner wrote: With master, I don't see any warning about the iconv line. Many other warnings though :) Yeah, generating configure scripts using the latest Xorg macros with all the additional -W flags will do that. xwininfo.c: In function ‘scale_init’:

[PATCH:imake 2/2] Ensure inFile is always closed on error in cppit()

2012-08-25 Thread Alan Coopersmith
Another instance of the can-return-in-rare-cases nature of LogFatal() raising red flags in static analysis. Resolves warning from Parfait 1.0.1: Error: File Leak File Leak: Leaked File inFile at line 1719 of imake.c in function 'cppit'. inFile initialized at line 1699 with

[PATCH:imake 1/2] Avoid closing inFile twice in CheckImakefileC if LogFatal returns

2012-08-25 Thread Alan Coopersmith
Imake's LogFatal() checks if it's being re-entered and if so, returns, so we can't mark it NORETURN, leading to static analyzers believing it can return even in call paths it shouldn't. Resolves warning from Parfait 1.0.1: Error: File Invalid File not Initialized: The value inFile is not

Re: An attempt at fixing a bug involving DGA and mouse buttons

2012-08-25 Thread Steven Elliott
On Fri, 2012-08-24 at 12:29 +1000, Peter Hutterer wrote: On Sat, 2012-08-18 at 20:46 -0500, Steven Elliott wrote: I have not yet been successful in writing a standalone test program to recreate the problem (to recreate it without MCEdit), but I can try things and report back. you need to

[PATCH:xwininfo] Get rid of a number of warnings. Signed-off-by: Thomas Klausner w...@netbsd.org

2012-08-25 Thread Thomas Klausner
--- xwininfo.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/xwininfo.c b/xwininfo.c index f1126e6..a9f1e96 100644 --- a/xwininfo.c +++ b/xwininfo.c @@ -251,7 +251,7 @@ static Bool window_id_format_dec = False; static iconv_t

Re: xwininfo: const in iconv

2012-08-25 Thread Thomas Klausner
On Sat, Aug 25, 2012 at 10:51:10AM -0700, Alan Coopersmith wrote: These are the lines: xwininfo.c:static xcb_screen_t *screen; xwininfo.c:scale_init (xcb_screen_t *screen) Patch attached. Looks good to me. xwininfo.c: In function ‘wm_size_hints_reply’: xwininfo.c:707:40:

Re: New keyboard config files for some Sharp hardware

2012-08-25 Thread Thomas Klausner
On Thu, Aug 23, 2012 at 08:05:44AM -0700, Alan Coopersmith wrote: On 08/23/12 08:00 AM, Thomas Klausner wrote: Keyboard config files for 5 Sharp machines, from Nonaka Kimihiro non...@netbsd.org. xkeyboard-config has it's own mailing list for patch submission:

Re: xwininfo: const in iconv

2012-08-25 Thread Alan Coopersmith
On 08/25/12 03:11 PM, Thomas Klausner wrote: I've just sent a patch to the mailing list which fixes all but two of them. xwininfo.c: In function ‘usage’: xwininfo.c:282:1: warning: function might be possible candidate for attribute ‘noreturn’ I'm not sure how to portably specify this

[PATCH 0/5] dix: Remove more backing store leftovers

2012-08-25 Thread Daniel Martin
These patches remove some more backing store leftovers. Basicly dead snippets since Nov 2010 (commit: c4c4676). Daniel Martin (5): dix: Delete mibstore.c dix: Remove #includes of mibstore.h dix: Remove refs to mi backing store from docs dix: Add warning about deprecation in mibstore.h

[PATCH 1/5] dix: Delete mibstore.c

2012-08-25 Thread Daniel Martin
The only reference to mibstore.c was removed with commit c4c4676. Remove the file itself too. --- mi/mibstore.c | 43 --- 1 file changed, 43 deletions(-) delete mode 100644 mi/mibstore.c diff --git a/mi/mibstore.c b/mi/mibstore.c deleted file mode 100644

[PATCH 2/5] dix: Remove #includes of mibstore.h

2012-08-25 Thread Daniel Martin
Remove more backing store leftovers. --- exa/exa_priv.h | 1 - fb/fb.h| 1 - hw/kdrive/src/kdrive.h | 1 - hw/vfb/InitInput.c | 1 - hw/vfb/InitOutput.c| 1 - hw/xfree86/sdksyms.sh | 1 - hw/xnest/Screen.c | 1 - hw/xnest/Visual.c | 1 -

[PATCH 3/5] dix: Remove refs to mi backing store from docs

2012-08-25 Thread Daniel Martin
Remove any reference to mibstore.h and miInitializeBackingStore() from the documentation. --- hw/dmx/doc/dmx.xml | 12 ++-- hw/xfree86/doc/ddxDesign.xml | 20 2 files changed, 2 insertions(+), 30 deletions(-) diff --git a/hw/dmx/doc/dmx.xml

[PATCH 4/5] dix: Add warning about deprecation in mibstore.h

2012-08-25 Thread Daniel Martin
Add a #warning compiler directive that mibstore.h is deprecated. --- mi/mibstore.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mi/mibstore.h b/mi/mibstore.h index f8ed444..3439e48 100644 --- a/mi/mibstore.h +++ b/mi/mibstore.h @@ -16,6 +16,8 @@ #ifndef _MIBSTORE_H #define _MIBSTORE_H

[PATCH 5/5] dix: Remove mibstore.h from source file list

2012-08-25 Thread Daniel Martin
Remove mibstore.h from the source file list. But, keep it in the list of sdk headers to install it for backward compatibility. --- mi/Makefile.am | 1 - 1 file changed, 1 deletion(-) diff --git a/mi/Makefile.am b/mi/Makefile.am index 96ceeaa..cc1a4f1 100644 --- a/mi/Makefile.am +++

Re: [PATCH:xwininfo] Get rid of a number of warnings. Signed-off-by: Thomas Klausner w...@netbsd.org

2012-08-25 Thread Alan Coopersmith
On 08/25/12 03:07 PM, Thomas Klausner wrote: --- xwininfo.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) Looks good to me - pushed to git master - thanks. To ssh://git.freedesktop.org/git/xorg/app/xwininfo 1279ed6..53564df

[PATCH:xwininfo 2/2] Mark usage() as not returning.

2012-08-25 Thread Thomas Klausner
Signed-off-by: Thomas Klausner w...@netbsd.org --- xwininfo.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xwininfo.c b/xwininfo.c index a9f1e96..34d7702 100644 --- a/xwininfo.c +++ b/xwininfo.c @@ -278,6 +278,7 @@ static size_t strlcat (char *dst, const char *src, size_t dstsize) /* *

Re: xwininfo: const in iconv

2012-08-25 Thread Thomas Klausner
On Sat, Aug 25, 2012 at 04:29:48PM -0700, Alan Coopersmith wrote: On 08/25/12 03:11 PM, Thomas Klausner wrote: I've just sent a patch to the mailing list which fixes all but two of them. xwininfo.c: In function ‘usage’: xwininfo.c:282:1: warning: function might be possible candidate for