Re: [PATCH:libXt 4/6] Fix char vs. unsigned char warnings.

2013-06-27 Thread Thomas Klausner
On Wed, Jun 26, 2013 at 08:55:35PM -0400, Thomas E. Dickey wrote: > On Tue, Jun 25, 2013 at 11:02:48PM +0200, Thomas Klausner wrote: > > --- > > src/ResConfig.c | 4 ++-- > > src/TMparse.c | 4 ++-- > > 2 files changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/src/ResConfig.c b/src/

Re: xorg-server-1.14.1.902 - build error

2013-06-27 Thread Chris Clayton
On 06/21/13 21:14, Keith Packard wrote: Matt Dew writes: Thanks Chris. Keith, I can't just apply patches in the stable branch though right? You can, but as this code is also broken on master, it's best to have it committed to master and then cherry-picked to the stable branch. I'll

[PATCH] [RFC] socket activation code for xserver

2013-06-27 Thread Łukasz Stelmach
Hello All. These are patches for libxtrans[1] and xserver[2]. The first, for libxtrans implements the "client" side of socket passing as implemented in systemd[3]. With this code in libxtrans it is possible to configre systemd to open X sockets, listen for incomming connection and start xserver as

[PATCH] [RFC] Enable systemd socket activation

2013-06-27 Thread Łukasz Stelmach
Receive file descriptors of open sockets from systemd instead of creating them. Signed-off-by: Łukasz Stelmach --- Xtrans.c | 50 ++ 1 file changed, 50 insertions(+) diff --git a/Xtrans.c b/Xtrans.c index 0799f04..a96e901 100644 --- a/Xtrans.c +

[PATCH] [RFC] configure.ac: enable systemd socket activation in libxtrans

2013-06-27 Thread Łukasz Stelmach
Signed-off-by: Łukasz Stelmach --- configure.ac | 32 1 file changed, 32 insertions(+) diff --git a/configure.ac b/configure.ac index 53335b1..a58cde6 100644 --- a/configure.ac +++ b/configure.ac @@ -825,6 +825,38 @@ AC_SUBST(SDK_REQUIRED_MODULES) REQUIRED_M

Re: [PATCH:libXt 4/6] Fix char vs. unsigned char warnings.

2013-06-27 Thread Thomas Dickey
On Thu, Jun 27, 2013 at 08:33:02AM +0200, Thomas Klausner wrote: > On Wed, Jun 26, 2013 at 08:55:35PM -0400, Thomas E. Dickey wrote: > > On Tue, Jun 25, 2013 at 11:02:48PM +0200, Thomas Klausner wrote: > > > --- > > > src/ResConfig.c | 4 ++-- > > > src/TMparse.c | 4 ++-- > > > 2 files changed,

Re: [PATCH:libXt 4/6] Fix char vs. unsigned char warnings.

2013-06-27 Thread walter harms
Am 27.06.2013 08:33, schrieb Thomas Klausner: > On Wed, Jun 26, 2013 at 08:55:35PM -0400, Thomas E. Dickey wrote: >> On Tue, Jun 25, 2013 at 11:02:48PM +0200, Thomas Klausner wrote: >>> --- >>> src/ResConfig.c | 4 ++-- >>> src/TMparse.c | 4 ++-- >>> 2 files changed, 4 insertions(+), 4 deleti

Re: [PATCH:libXt 4/6] Fix char vs. unsigned char warnings.

2013-06-27 Thread Thomas Klausner
On Thu, Jun 27, 2013 at 04:23:06AM -0400, Thomas E. Dickey wrote: > On Thu, Jun 27, 2013 at 08:33:02AM +0200, Thomas Klausner wrote: > > On Wed, Jun 26, 2013 at 08:55:35PM -0400, Thomas E. Dickey wrote: > > > On Tue, Jun 25, 2013 at 11:02:48PM +0200, Thomas Klausner wrote: > > > > --- > > > > src/

libXi warning fix for clang-3.4

2013-06-27 Thread Thomas Klausner
I'm just guessing at a fix, please check if this is correct before merging it. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH:libXi] Fix size comparison.

2013-06-27 Thread Thomas Klausner
This addresses the following clang-3.4 warning: XGetFCtl.c:129:32: warning: comparison of constant 268435455 with expression of type 'CARD16' (aka 'unsigned short') is always false [-Wtautological-constant-out-of-range-compare] if (strf->num_syms_supported >= (INT_MAX / sizeo

Re: [PATCH:libXi] Fix size comparison.

2013-06-27 Thread Alan Coopersmith
On 06/27/13 05:55 AM, Thomas Klausner wrote: This addresses the following clang-3.4 warning: XGetFCtl.c:129:32: warning: comparison of constant 268435455 with expression of type 'CARD16' (aka 'unsigned short') is always false [-Wtautological-constant-out-of-range-compare]

Re: [PATCH:libXi] Fix size comparison.

2013-06-27 Thread Thomas Klausner
On Thu, Jun 27, 2013 at 07:11:44AM -0700, Alan Coopersmith wrote: > On 06/27/13 05:55 AM, Thomas Klausner wrote: > >This addresses the following clang-3.4 warning: > >XGetFCtl.c:129:32: warning: comparison of constant 268435455 with expression > >of type 'CARD16' (aka 'unsigned short') is always f

[PATCH:libXi] Remove check that can never be true.

2013-06-27 Thread Thomas Klausner
clang warns: warning: comparison of constant 268435455 with expression of type 'CARD16' (aka 'unsigned short') is always false --- src/XGetFCtl.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/XGetFCtl.c b/src/XGetFCtl.c index bb50bf3..2d71fab 100644 --- a/src/XGetFCtl.c +++ b/src/XGetF

Re: [PATCH:libXi] Remove check that can never be true.

2013-06-27 Thread Alan Coopersmith
On 06/27/13 08:16 AM, Thomas Klausner wrote: clang warns: warning: comparison of constant 268435455 with expression of type 'CARD16' (aka 'unsigned short') is always false --- src/XGetFCtl.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/XGetFCtl.c b/src/XGetFCtl.c index bb50bf3..2d

Re: [PATCH:libXi] Remove check that can never be true.

2013-06-27 Thread Peter Hutterer
On Thu, Jun 27, 2013 at 09:24:29AM -0700, Alan Coopersmith wrote: > On 06/27/13 08:16 AM, Thomas Klausner wrote: > >clang warns: > >warning: comparison of constant 268435455 with expression of type > >'CARD16' (aka 'unsigned short') is always false > >--- > > src/XGetFCtl.c | 3 --- > > 1 file cha

Re: [PATCH xts v2] XI/ChangePointerDevice: Fix double-free

2013-06-27 Thread Peter Hutterer
On Tue, Jun 11, 2013 at 01:42:36PM -0400, Peter Harris wrote: > XCloseDevice frees the device parameter, even if it references an > invalid device. Therefore, the device parameter must not be on the stack. > > Since xts5/XI does not clean up the devices created by > Setup_Extension_DeviceInfo, it

Re: [PATCH] [RFC] Enable systemd socket activation

2013-06-27 Thread Peter Hutterer
On Wed, Jun 26, 2013 at 06:18:04PM +0200, Łukasz Stelmach wrote: > Receive file descriptors of open sockets from systemd instead of > creating them. > > Signed-off-by: Łukasz Stelmach > --- > Xtrans.c | 50 ++ > 1 file changed, 50 insertions(+) >