Re: [PATCH:libXt 5/6] Silence compiler clang warnings.

2013-07-09 Thread Alan Coopersmith
On 06/25/13 02:02 PM, Thomas Klausner wrote: Fixes: warning: cast from function call of type 'char *' to non-matching type 'XtArgVal' (aka 'long') [-Wbad-function-cast] --- src/Resources.c | 2 +- src/Varargs.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Res

Re: [PATCH:libXt 2/6] Avoid shadowing variables.

2013-07-09 Thread Alan Coopersmith
On 06/25/13 02:02 PM, Thomas Klausner wrote: --- src/Composite.c | 10 +- src/Convert.c | 2 +- src/Geometry.c | 8 src/Intrinsic.c | 6 +++--- src/NextEvent.c | 1 - src/Object.c| 16 src/Selection.c | 1 - src/TMaction.c | 10 +-

Re: [PATCH libxtrans xserver v2 0/5] systemd socket activation code for xserver

2013-07-09 Thread Peter Hutterer
On Tue, Jul 09, 2013 at 04:24:42PM +0200, Łukasz Stelmach wrote: > Hi All. > > I've fixed the problems reported for the previous release and those I had > found myself. > > Let me describe each patch. > > 1. Add const qualifier to unix_nolisten. > >Without const I got a warning and tcp_nol

Re: [PATCH xserver v2 5/5] Do not define ErrorF in xstrans.c, libxtrans handles it.

2013-07-09 Thread Peter Hutterer
On Tue, Jul 09, 2013 at 04:24:47PM +0200, Łukasz Stelmach wrote: > Signed-off-by: Łukasz Stelmach > Cc: Kyungmin Park > Cc: MyungJoo Ham > Cc: Piort Bereza > Cc: Karol Lewandowski > Cc: Lennart Poettering > Cc: Zbigniew Jędrzejewski-Szmek > Cc: Peter Hutterer > Cc: walter harms > --- > os

Re: [PATCH xserver v2 4/5] configure.ac: enable systemd socket activation in libxtrans

2013-07-09 Thread Peter Hutterer
On Tue, Jul 09, 2013 at 04:24:46PM +0200, Łukasz Stelmach wrote: --- > configure.ac | 32 > 1 file changed, 32 insertions(+) > > diff --git a/configure.ac b/configure.ac > index 89a7a9d..ab9dc0d 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -832,6 +832,

Re: [PATCH xsetroot] Improve manpage and -help option.

2013-07-09 Thread Alan Coopersmith
On 07/ 7/13 02:23 PM, Stéphane Aulery wrote: Signed-off-by: Stéphane Aulery --- man/xsetroot.man | 44 ++-- xsetroot.c | 32 2 files changed, 42 insertions(+), 34 deletions(-) Thanks - Reviewed-by: Alan Coop

Re: [PATCH 1/7] os: Remove any old logfile before trying to write to it

2013-07-09 Thread Peter Hutterer
On Tue, Jul 09, 2013 at 12:59:26PM +0100, Jon TURNEY wrote: > On 08/11/2012 13:41, Jon TURNEY wrote: > > If we are not backing up logfiles, remove the old logfile before trying to > > write > > a new logfile, as otherwise the operation may fail if the previous logfile > > was > > created by a dif

Re: [PATCH xsetmode] Remove dead code the-l option

2013-07-09 Thread Peter Hutterer
On Tue, Jul 09, 2013 at 10:41:42AM +0200, Thomas Klausner wrote: > On Mon, Jul 08, 2013 at 11:53:56PM -0700, Alan Coopersmith wrote: > > On 07/ 8/13 03:55 PM, Stéphane Aulery wrote: > > >Remove dead code the-l option that seems copied from another utility > > >(xsetpointer) but never executed. > >

[PATCH] dix: when ungrabbing an active grab, accept pointer grabs (#66720)

2013-07-09 Thread Peter Hutterer
Ungrabbing a device during an active touch grab rejects the grab. Ungrabbing a device during an active pointer grab accepts the grab. Rejection is not really an option for a pointer-emulated grab, if a client has a button mask on the window it would get a ButtonPress emulated after UngrabDevice. T

Re: [PATCH xsetmode] Remove dead code the-l option

2013-07-09 Thread Alan Coopersmith
On 07/ 9/13 01:41 AM, Thomas Klausner wrote: On Mon, Jul 08, 2013 at 11:53:56PM -0700, Alan Coopersmith wrote: On 07/ 8/13 03:55 PM, Stéphane Aulery wrote: Remove dead code the-l option that seems copied from another utility (xsetpointer) but never executed. Signed-off-by: Stéphane Aulery ---

[PATCH xserver v2 4/5] configure.ac: enable systemd socket activation in libxtrans

2013-07-09 Thread Łukasz Stelmach
Signed-off-by: Łukasz Stelmach Cc: Kyungmin Park Cc: MyungJoo Ham Cc: Piort Bereza Cc: Karol Lewandowski Cc: Lennart Poettering Cc: Zbigniew Jędrzejewski-Szmek Cc: Peter Hutterer Cc: walter harms --- configure.ac | 32 1 file changed, 32 insertions(+) d

[PATCH libxtrans v2 2/3] Define TRANS_RECEIVED flag for transports

2013-07-09 Thread Łukasz Stelmach
The flag is to be used to mark transports related to sockets received from systemd. Signed-off-by: Łukasz Stelmach Cc: Kyungmin Park Cc: MyungJoo Ham Cc: Piort Bereza Cc: Karol Lewandowski Cc: Lennart Poettering Cc: Zbigniew Jędrzejewski-Szmek Cc: Peter Hutterer Cc: walter harms --- Xtra

[PATCH xserver v2 5/5] Do not define ErrorF in xstrans.c, libxtrans handles it.

2013-07-09 Thread Łukasz Stelmach
Signed-off-by: Łukasz Stelmach Cc: Kyungmin Park Cc: MyungJoo Ham Cc: Piort Bereza Cc: Karol Lewandowski Cc: Lennart Poettering Cc: Zbigniew Jędrzejewski-Szmek Cc: Peter Hutterer Cc: walter harms --- os/xstrans.c |5 - 1 file changed, 5 deletions(-) diff --git a/os/xstrans.c b/os

[PATCH libxtrans v2 3/3] Enable systemd socket activation

2013-07-09 Thread Łukasz Stelmach
Receive file descriptors of open sockets from systemd instead of creating them. Signed-off-by: Łukasz Stelmach Cc: Kyungmin Park Cc: MyungJoo Ham Cc: Piort Bereza Cc: Karol Lewandowski Cc: Lennart Poettering Cc: Zbigniew Jędrzejewski-Szmek Cc: Peter Hutterer Cc: walter harms --- Xtrans.c

[PATCH libxtrans v2 1/3] Add const qualifier to unix_nolisten

2013-07-09 Thread Łukasz Stelmach
Signed-off-by: Łukasz Stelmach Cc: Kyungmin Park Cc: MyungJoo Ham Cc: Piort Bereza Cc: Karol Lewandowski Cc: Lennart Poettering Cc: Zbigniew Jędrzejewski-Szmek Cc: Peter Hutterer Cc: walter harms --- Xtranssock.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Xtran

[PATCH libxtrans xserver v2 0/5] systemd socket activation code for xserver

2013-07-09 Thread Łukasz Stelmach
Hi All. I've fixed the problems reported for the previous release and those I had found myself. Let me describe each patch. 1. Add const qualifier to unix_nolisten. Without const I got a warning and tcp_nolisten is marked as const too. 2. Define TRANS_RECEIVED flag for transports The p

Re: [PATCH 1/7] os: Remove any old logfile before trying to write to it

2013-07-09 Thread Jon TURNEY
On 08/11/2012 13:41, Jon TURNEY wrote: > If we are not backing up logfiles, remove the old logfile before trying to > write > a new logfile, as otherwise the operation may fail if the previous logfile was > created by a different user. > > This change is useful when: > - The DDX doesn't use the l

Re: [PATCH xsetmode] Remove dead code the-l option

2013-07-09 Thread Thomas Klausner
On Mon, Jul 08, 2013 at 11:53:56PM -0700, Alan Coopersmith wrote: > On 07/ 8/13 03:55 PM, Stéphane Aulery wrote: > >Remove dead code the-l option that seems copied from another utility > >(xsetpointer) but never executed. > > > >Signed-off-by: Stéphane Aulery > >--- > > xsetmode.c | 14 ++--

Re: [PATCH xsetmode] Remove dead code the-l option

2013-07-09 Thread Stéphane Aulery
>De: Alan Coopersmith >Envoyé: Tue, 09 Jul 2013 08:53:56 +0200 (CEST) > >On 07/ 8/13 03:55 PM, Stéphane Aulery wrote: >> >> Signed-off-by: Stéphane Aulery >> --- >> xsetmode.c | 14 ++ >> 1 file changed, 2 insertions(+), 12 deletions(-) > > Dead code in a dead program. Pushed,