[PATCH] config/udev: do not remove devices on add udev events

2013-11-26 Thread Maarten Lankhorst
"udevadm trigger --action=add" can cause devices to be unloaded, which breaks when X.org is already started during early init. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=72021 Signed-off-by: Maarten Lankhorst --- diff --git a/config/udev.c b/config/udev.c index 454838f..74ac998 100644 --

[PATCH v2 xf86-video-modesetting 2/2] Properly identify DSI outputs

2013-11-26 Thread Thierry Reding
Newer Linux kernels support DSI outputs. To be able to identify them properly, add DSI to the list of output names. Reviewed-by: Aaron Plattner Signed-off-by: Thierry Reding --- src/drmmode_display.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/drmmode_display.c b/src/drmmode_display

[PATCH v2 xf86-video-modesetting 1/2] Staticise output names

2013-11-26 Thread Thierry Reding
This array isn't used anywhere outside this file, so it can be made static. Signed-off-by: Thierry Reding --- Changes in v2: - make output_names array static const char * const src/drmmode_display.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff -

[PATCH v3 xf86-video-modesetting 1/2] Staticise and constify output names

2013-11-26 Thread Thierry Reding
This array isn't used anywhere outside this file, so it can be made static. While at it, make the array const as well. Signed-off-by: Thierry Reding --- Changes in v3: - update commit message to reflect prior change Changes in v2: - make output_names array static const char * const src/drmmode

[PATCH v3 xf86-video-modesetting 2/2] Properly identify DSI outputs

2013-11-26 Thread Thierry Reding
Newer Linux kernels support DSI outputs. To be able to identify them properly, add DSI to the list of output names. Reviewed-by: Aaron Plattner Signed-off-by: Thierry Reding --- src/drmmode_display.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/drmmode_display.c b/src/drmmode_display

Re: [PATCH v2 xf86-video-modesetting 1/2] Staticise output names

2013-11-26 Thread Thierry Reding
On Tue, Nov 26, 2013 at 05:05:31PM +0100, Thierry Reding wrote: > This array isn't used anywhere outside this file, so it can be made > static. > > Signed-off-by: Thierry Reding > --- > Changes in v2: > - make output_names array static const char * const Ugh... forgot to update the commit messag

Re: [PATCH xf86-video-modesetting 1/2] Staticise output names

2013-11-26 Thread Thierry Reding
On Mon, Nov 25, 2013 at 09:05:18AM -0800, Aaron Plattner wrote: > On 11/25/13 03:49, Thierry Reding wrote: > >This array isn't used anywhere outside this file, so it can be made > >static. > > > >Signed-off-by: Thierry Reding > >--- > > src/drmmode_display.c | 32

Re: [PATCH 0/4] xf86-video-intel DRI3 and Present patch series

2013-11-26 Thread Keith Packard
Chris Wilson writes: >> [PATCH 1/4] Support 64-bit MSC values. Handle kernel vageries about > > Some spurious assignments that appear to intentially drop the error code > could be clarified, I can't find any dropped error codes in this patch to add comments to, please provide patch excerpts for

Re: [PATCH v3 xf86-video-modesetting 1/2] Staticise and constify output names

2013-11-26 Thread Aaron Plattner
Reviewed-by: Aaron Plattner On 11/26/13 08:08, Thierry Reding wrote: This array isn't used anywhere outside this file, so it can be made static. While at it, make the array const as well. Signed-off-by: Thierry Reding --- Changes in v3: - update commit message to reflect prior change Changes

Re: [PATCH 2/8] -pendantic is too pendantic

2013-11-26 Thread Ran Benita
On Wed, Nov 06, 2013 at 07:45:39PM -0800, Keith Packard wrote: > Many system headers have warnings when compiled with this flag. This was already committed, but how about changing to AC_CC_C99 instead? pedantic _can_ be useful for XCB imo, e.g. the "enum too big for an int" thing. Also, the code a

Re: [PATCH 2/8] -pendantic is too pendantic

2013-11-26 Thread Gaetan Nadon
On 13-11-26 06:33 PM, Ran Benita wrote: > This was already committed, but how about changing to AC_CC_C99 instead? Pardon me as I am out of context. The xserver module is configured with AC_PROG_CC_C99 that gets pulled in by XORG_DEFAULTS from util-macros. It's not obvious, but it saves from copyin

[PATCH:xcmsdb 1/6] Combine usage message strings

2013-11-26 Thread Alan Coopersmith
Signed-off-by: Alan Coopersmith --- xcmsdb.c | 22 +++--- 1 file changed, 7 insertions(+), 15 deletions(-) diff --git a/xcmsdb.c b/xcmsdb.c index 255b449..548c9b3 100644 --- a/xcmsdb.c +++ b/xcmsdb.c @@ -59,25 +59,17 @@ static void Syntax (void) { fprintf (stderr, -

[PATCH:xcmsdb 3/6] Add -version option to print program version

2013-11-26 Thread Alan Coopersmith
Adds both -version and previously undocumented -help to man page Signed-off-by: Alan Coopersmith --- man/xcmsdb.man |7 +++ xcmsdb.c |8 2 files changed, 15 insertions(+) diff --git a/man/xcmsdb.man b/man/xcmsdb.man index f08604f..48ce6e1 100644 --- a/man/xcmsdb.man +

[PATCH:xcmsdb 6/6] config: Add missing AC_CONFIG_SRCDIR

2013-11-26 Thread Alan Coopersmith
Regroup AC statements under the Autoconf initialization section. Regroup AM statements under the Automake initialization section. Signed-off-by: Alan Coopersmith --- configure.ac |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 54c4

[PATCH:xcmsdb 2/6] Print which option was in error along with usage message

2013-11-26 Thread Alan Coopersmith
Signed-off-by: Alan Coopersmith --- xcmsdb.c | 27 --- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/xcmsdb.c b/xcmsdb.c index 548c9b3..21255e2 100644 --- a/xcmsdb.c +++ b/xcmsdb.c @@ -56,7 +56,7 @@ static int _XcmsGetProperty(Display *pDpy, Window w, At

[PATCH:xcmsdb 4/6] Fix const char * warnings

2013-11-26 Thread Alan Coopersmith
Signed-off-by: Alan Coopersmith --- SCCDFile.h |2 +- loadData.c | 15 --- xcmsdb.c |6 +++--- 3 files changed, 12 insertions(+), 11 deletions(-) diff --git a/SCCDFile.h b/SCCDFile.h index a9a7722..41a51bf 100644 --- a/SCCDFile.h +++ b/SCCDFile.h @@ -139,7 +139,7 @@ typed

[PATCH:xcmsdb 5/6] Remove break statements immediately after return statements

2013-11-26 Thread Alan Coopersmith
Silences clang -Wunreachable-code warnings Signed-off-by: Alan Coopersmith --- loadData.c |7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/loadData.c b/loadData.c index 170d9e0..defcb40 100644 --- a/loadData.c +++ b/loadData.c @@ -485,7 +485,6 @@ ProcessColorimetric(F

Re: [PATCH 1/3] configure.ac: Add whitespace near PCI configuration

2013-11-26 Thread Keith Packard
Adam Jackson writes: > On Fri, 2013-11-15 at 17:00 -0800, Connor Behan wrote: >> Signed-off-by: Connor Behan > > Series: > > Reviewed-by: Adam Jackson Merged. 8048126..bd70def master -> master -- keith.pack...@intel.com pgp8emQgpEVST.pgp Description: PGP signature _

[PATCH:xdpyinfo 1/2] Print which option was in error along with usage message

2013-11-26 Thread Alan Coopersmith
Signed-off-by: Alan Coopersmith --- xdpyinfo.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/xdpyinfo.c b/xdpyinfo.c index f161a97..84d5b2a 100644 --- a/xdpyinfo.c +++ b/xdpyinfo.c @@ -1466,18 +1466,29 @@ main(int argc, char *argv[]) size_t len =

[PATCH:xdpyinfo 2/2] Sprinkle consts in StrCmp to quiet cast warnings

2013-11-26 Thread Alan Coopersmith
Makes gcc stop saying: xdpyinfo.c: In function ‘StrCmp’: xdpyinfo.c:162:20: warning: cast discards ‘__attribute__((const))’ qualifier from pointer target type [-Wcast-qual] xdpyinfo.c:162:39: warning: cast discards ‘__attribute__((const))’ qualifier from pointer target type [-Wcast-qual] Signed-

Re: [PATCH] Xdmx: Initialize DMX extension even if not built with GLX support

2013-11-26 Thread Keith Packard
Alan Coopersmith writes: > dmxAddExtensions takes an argument to determine if it should just > initialize the DMX extension, or both DMX & GLX, but if GLX wasn't > compiled in, the entire call was #ifdef'ed out, leaving the DMX > extension unavailable. > > Signed-off-by: Alan Coopersmith > Revie

Re: [PATCH 2/8] -pendantic is too pendantic

2013-11-26 Thread Ran Benita
Hi Gaetan, On Tue, Nov 26, 2013 at 07:02:23PM -0500, Gaetan Nadon wrote: > On 13-11-26 06:33 PM, Ran Benita wrote: > > This was already committed, but how about changing to AC_CC_C99 instead? > Pardon me as I am out of context. The xserver module is configured with > AC_PROG_CC_C99 that gets pulle

Re: [RFC] GLX dispatch rewrite

2013-11-26 Thread Jeremy Huddleston Sequoia
So what's the story on this? How should we solve this for xquartz and xwin? Should we pull the old code into hw/xquartz/GL and hw/xwin/GL? That seems redundant. So should we restore it in some other way? I'd really like to get master working for OS X (at-least XQuartz, but hopefully Xorg as