[PATCH 1/1] randr: make RROutputChanged change the main protocol screen not the gpu screen

2013-12-08 Thread Alberto Milone
We only set changes on the main protocol screen as, for example in RRSetChanged() and RRTellChanged(), therefore we should follow the same logic when reporting that an output changed in RROutputChanged(). This means that RRTellChanged() will then update the relevant timestamps also when events com

Re: [PATCH 1/1] randr: make RROutputChanged change the main protocol screen not the gpu screen

2013-12-08 Thread Alberto Milone
On 08/12/13 12:08, Alberto Milone wrote: > We only set changes on the main protocol screen as, for example > in RRSetChanged() and RRTellChanged(), therefore we should follow > the same logic when reporting that an output changed in > RROutputChanged(). > > This means that RRTellChanged() will the

[PATCH 2/5] ephyr: Fix compilation when ./configure'd with --enable-debug

2013-12-08 Thread Jon TURNEY
/jhbuild/checkout/xorg/xserver/hw/kdrive/ephyr/ephyr.c: In function ‘ephyrProcessMouseMotion’: /jhbuild/checkout/xorg/xserver/hw/kdrive/ephyr/ephyr.c:946:188: error: ‘ephyrCurScreen’ undeclared (first use in this function) /jhbuild/checkout/xorg/xserver/hw/kdrive/ephyr/ephyr.c: In function ‘ephy

[PATCH 0/5] hw/xwin fixes and more (v2)

2013-12-08 Thread Jon TURNEY
[3/5] depends on ajax's "Attempt to fix GLX for OSX" series [4/5] is unneeded if those tokens are added to gltokens.h in glproto instead [5/5] is another, perhaps better, attempt at updating XWin for the conversion to GL direct dispatch Jon TURNEY (5): configure.ac: Link XWin with present exten

[PATCH 5/5] hw/xwin/glx: Rewrite WGL wrappers after Xserver conversion to direct GL dispatch

2013-12-08 Thread Jon TURNEY
v1: Rewrite by Marc Haesen of the WGL wrapper function generation script to use Khronos group XML. v2: Remove -dispatchheader option, since dispatch.h doesn't exist anymore, use the private glapi interface to construct the GL dispatch table for the native WGL thunks. v3: Rewrite to generate shims

[PATCH 3/5] glx: Consistently use ARB-suffixed names for ARB_multitexture functions

2013-12-08 Thread Jon TURNEY
At the moment we have a mix of ARB and non-ARB suffixed forms for ARB_multitexture functions e.g. glMultiTexCoord1fvARB and glMultiTexCoord1dv Consistently use the ARB-suffixed form, assuming that is present in all libGL which provide the OpenGL 1.2.1 ABI we expect to be able to directly link wit

[PATCH 1/5] configure.ac: Link XWin with present extension if we are building with it enabled

2013-12-08 Thread Jon TURNEY
Signed-off-by: Jon TURNEY --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 11a3e11..5030923 100644 --- a/configure.ac +++ b/configure.ac @@ -2108,7 +2108,7 @@ if test "x$XWIN" = xyes; then ;; esa

[PATCH 4/5] hw/xwin/glx: Fix compilation of hw/xwin/glx/indirect.c

2013-12-08 Thread Jon TURNEY
/jhbuild/checkout/xorg/xserver/hw/xwin/glx/indirect.c: In function 'fbConfigsDump': /jhbuild/checkout/xorg/xserver/hw/xwin/glx/indirect.c:390:34: error: 'GLX_RGBA_FLOAT_BIT_ARB' undeclared (first use in this function) /jhbuild/checkout/xorg/xserver/hw/xwin/glx/indirect.c:391:20: error: 'GLX_RGBA

Re: [PATCH 2/5] xfree86/linux: cleanup Makefile.am

2013-12-08 Thread walter harms
is there no shortcut for $(srcdir)/../shared/ ? re, wh Am 07.12.2013 16:48, schrieb Daniel Martin: > Indent source filenames with one tab and sort them. > > Signed-off-by: Daniel Martin > --- > hw/xfree86/os-support/linux/Makefile.am | 29 + > 1 file changed, 17 in

Re: [PATCH 3/5] ephyr: Fix compilation when ./configure'd with --enable-debug

2013-12-08 Thread Jon TURNEY
On 05/12/2013 18:39, Keith Packard wrote: > Jon TURNEY writes: > >> xcb_button_press_event_t *button = (xcb_button_press_event_t *)xev; >> +KdScreenInfo *screen = screen_from_window(button->event); > > I suspect you won't want a local variable here -- when debug isn't > enabled, this var

[PATCH:libXScrnSaver] Copy root field from wire event into root, not window, of Xlib event

2013-12-08 Thread Alan Coopersmith
Fixes cppcheck warning: [src/XScrnSaver.c:104] -> [src/XScrnSaver.c:105]: (performance, inconclusive) Variable 'window' is reassigned a value before the old one has been used if variable is no semaphore variable. Error seems to date back to revision 1.1 in X Consortium RCS, dated 1992-02-13, by

[PATCH:libXScrnSaver] Copy root field from wire event into root, not window, of Xlib event

2013-12-08 Thread Alan Coopersmith
Fixes cppcheck warning: [src/XScrnSaver.c:104] -> [src/XScrnSaver.c:105]: (performance, inconclusive) Variable 'window' is reassigned a value before the old one has been used if variable is no semaphore variable. Error seems to date back to revision 1.1 in X Consortium RCS, dated 1992-02-13, by

[PATCH:libXfont] Don't leak old allocation if realloc fails to enlarge it

2013-12-08 Thread Alan Coopersmith
In ftfuncs.c, since the buffer being reallocated is a function local buffer, used to accumulate data for a single run of the function and then freed at the end of the function, we just free the old buffer if realloc fails. In atom.c however, the ReverseMap is a static buffer, so we operate in temp

Re: [PATCH 0/5] hw/xwin fixes and more (v2)

2013-12-08 Thread Colin Harrison
Hi, I'm happy with Jon making code changes in xwin to try and sort this glx-dispatch mess out (i.e. xwin is currently broken in xserver git master!) but am unable to spare much time mangling changes at the moment. Thanks Colin Harrison ___ xorg-devel

[PATCH:libdmx] Replace malloc(size); memset(...,0,size) with calloc

2013-12-08 Thread Alan Coopersmith
Signed-off-by: Alan Coopersmith --- src/dmx.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/dmx.c b/src/dmx.c index 5ef0ed4..7e1f953 100644 --- a/src/dmx.c +++ b/src/dmx.c @@ -440,8 +440,7 @@ Bool DMXAddScreen(Display *dpy, const char *displayName, unsigned int

[PATCH:iceauth] Free old argv array if realloc fails to enlarge it

2013-12-08 Thread Alan Coopersmith
Found by cppcheck: [app/iceauth/process.c:302]: (error) Common realloc mistake: 'argv' nulled but not freed upon failure Signed-off-by: Alan Coopersmith --- process.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/process.c b/process.c index 09cb7ef..6f7396d 100644

[PATCH:xkbutils] XkbQueryExtension returns a Bool, don't use > 0 to check it

2013-12-08 Thread Alan Coopersmith
We just want to know if XkbQueryExtension returned false, so ! is enough, don't need > 0 as well. Reported by cppcheck: [app/xkbutils/xkbbell.c:205]: (warning) Comparison of a boolean value using relational operator (<, >, <= or >=). Signed-off-by: Alan Coopersmith --- xkbbell.c |2 +- 1 f

Re: [PATCH:xkbutils] XkbQueryExtension returns a Bool, don't use > 0 to check it

2013-12-08 Thread Peter Hutterer
On Sun, Dec 08, 2013 at 01:10:26PM -0800, Alan Coopersmith wrote: > We just want to know if XkbQueryExtension returned false, so ! is enough, > don't need > 0 as well. > > Reported by cppcheck: > [app/xkbutils/xkbbell.c:205]: (warning) Comparison of a boolean value > using relational operator (<,

Re: [PATCH:iceauth] Free old argv array if realloc fails to enlarge it

2013-12-08 Thread Peter Hutterer
On Sun, Dec 08, 2013 at 12:55:57PM -0800, Alan Coopersmith wrote: > Found by cppcheck: > [app/iceauth/process.c:302]: (error) Common realloc mistake: > 'argv' nulled but not freed upon failure > > Signed-off-by: Alan Coopersmith Reviewed-by: Peter Hutterer Cheers, Peter > --- > process.c

Re: [PATCH:libdmx] Replace malloc(size); memset(...,0,size) with calloc

2013-12-08 Thread Peter Hutterer
On Sun, Dec 08, 2013 at 12:30:47PM -0800, Alan Coopersmith wrote: > Signed-off-by: Alan Coopersmith Reviewed-by: Peter Hutterer Cheers, Peter > --- > src/dmx.c |6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/src/dmx.c b/src/dmx.c > index 5ef0ed4..7e1f953

Re: [PATCH:libXfont] Don't leak old allocation if realloc fails to enlarge it

2013-12-08 Thread Peter Hutterer
On Sun, Dec 08, 2013 at 10:40:15AM -0800, Alan Coopersmith wrote: > In ftfuncs.c, since the buffer being reallocated is a function local > buffer, used to accumulate data for a single run of the function and > then freed at the end of the function, we just free the old buffer if > realloc fails. >

Re: [PATCH:libXScrnSaver] Copy root field from wire event into root, not window, of Xlib event

2013-12-08 Thread Peter Hutterer
On Sun, Dec 08, 2013 at 10:04:15AM -0800, Alan Coopersmith wrote: > Fixes cppcheck warning: > [src/XScrnSaver.c:104] -> [src/XScrnSaver.c:105]: (performance, inconclusive) > Variable 'window' is reassigned a value before the old one has been > used if variable is no semaphore variable. > > Error

Re: [RFC] Add MatchDMI support in InputClass sections

2013-12-08 Thread Peter Hutterer
On Sat, Dec 07, 2013 at 04:48:45PM +0100, Daniel Martin wrote: > Hi, > > this series adds support to match on DMI identifiers in InputClass > sections. Its main purpose is to be able to workaround the shortcomings > of synaptics touch- and clickpads. > > In their latest (Haswell) laptop models Le

Re: [PATCH 1/5] misc: add xrtrim() - right-trim a string

2013-12-08 Thread Peter Hutterer
On Sat, Dec 07, 2013 at 04:48:46PM +0100, Daniel Martin wrote: > Signed-off-by: Daniel Martin > --- > include/misc.h | 1 + > os/utils.c | 16 > 2 files changed, 17 insertions(+) > > diff --git a/include/misc.h b/include/misc.h > index 17de710..aab556a 100644 > --- a/includ

Re: [PATCH 2/5] xfree86/linux: cleanup Makefile.am

2013-12-08 Thread Peter Hutterer
On Sat, Dec 07, 2013 at 04:48:47PM +0100, Daniel Martin wrote: > Indent source filenames with one tab and sort them. > > Signed-off-by: Daniel Martin Reviewed-by: Peter Hutterer Cheers, Peter > --- > hw/xfree86/os-support/linux/Makefile.am | 29 + > 1 file chan

Re: [PATCH 3/5] xfree86/os: add xf86DMI stubs

2013-12-08 Thread Peter Hutterer
On Sat, Dec 07, 2013 at 04:48:48PM +0100, Daniel Martin wrote: > Add stubs for DMI identifier initialization, cleanup, add and matching. > > Signed-off-by: Daniel Martin > --- [...] > + > +/* > + * Add a DMI id value for specific key to the key value mapping. > + */ > +void > +xf86DMIAdd(const

Re: [PATCH 4/5] xfree86/linux: implement xf86DMIInit

2013-12-08 Thread Peter Hutterer
On Sat, Dec 07, 2013 at 04:48:49PM +0100, Daniel Martin wrote: > Read DMI identifiers from sysfs (/sys/devices/virtual/dmi/id). > > Signed-off-by: Daniel Martin > --- > hw/xfree86/os-support/linux/Makefile.am | 2 +- > hw/xfree86/os-support/linux/lnx_dmi.c | 136 > ++

Re: [PATCH 1/1] randr: make RROutputChanged change the main protocol screen not the gpu screen

2013-12-08 Thread Dave Airlie
On Sun, Dec 8, 2013 at 9:08 PM, Alberto Milone wrote: > We only set changes on the main protocol screen as, for example > in RRSetChanged() and RRTellChanged(), therefore we should follow > the same logic when reporting that an output changed in > RROutputChanged(). > > This means that RRTellChang