Re: [PATCH:xmessage] Stop leaking temporary buffer when realloc fails to enlarge it

2013-12-10 Thread walter harms
Am 10.12.2013 06:30, schrieb Alan Coopersmith: Fixes cppcheck error: [readfile.c:108]: (error) Common realloc mistake: 'cp' nulled but not freed upon failure Reviewed-by: wharms wha...@bfs.de Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- readfile.c |2 ++ 1

Re: [PATCH 0/5] hw/xwin fixes and more (v2)

2013-12-10 Thread Keith Packard
Adam Jackson a...@nwnk.net writes: On Sun, 2013-12-08 at 16:57 +, Jon TURNEY wrote: [3/5] depends on ajax's Attempt to fix GLX for OSX series [4/5] is unneeded if those tokens are added to gltokens.h in glproto instead [5/5] is another, perhaps better, attempt at updating XWin for the

Re: [PATCH 6/8] dri2: wire up GetProcAddress

2013-12-10 Thread Keith Packard
Adam Jackson a...@redhat.com writes: +__glXsetGetProcAddress(glXGetProcAddressARB); + I'm confused -- how did this ever work before? Seems like _get_proc_address was uninitialized and that calls to the thunked functions in glxstubs.c would have crashed? -- keith.pack...@intel.com

Negative Selection devPrivates refcount?

2013-12-10 Thread Andrew Eikum
Hello, I ran into an X server crash triggered by an X module I'm writing, and eventually tracked the crash down to 'global_keys[PRIVATE_SELECTION].created' underflowing in _dixFiniPrivates. What seems to happen is: 1) The module registers a new private key with

Re: [PATCH 0/8] Attempt to fix GLX for OSX

2013-12-10 Thread Keith Packard
Adam Jackson a...@redhat.com writes: This fixes up the indirect glx code to only call-by-name those symbols present in the Linux OpenGL ABI, which corresponds to OpenGL 1.2.1. Since that was available even on OSX 10.0 this should be sufficient for xquartz as well. Merely proven correct, not

Re: [PATCH 0/5] hw/xwin fixes and more (v2)

2013-12-10 Thread Jon TURNEY
On 10/12/2013 15:02, Keith Packard wrote: Adam Jackson writes: On Sun, 2013-12-08 at 16:57 +, Jon TURNEY wrote: [3/5] depends on ajax's Attempt to fix GLX for OSX series [4/5] is unneeded if those tokens are added to gltokens.h in glproto instead [5/5] is another, perhaps better, attempt

Re: [PATCH 0/5] hw/xwin fixes and more (v2)

2013-12-10 Thread Keith Packard
Jon TURNEY jon.tur...@dronecode.org.uk writes: Jon TURNEY (4): configure.ac: Link XWin with present extension if we are building with it enabled ephyr: Fix compilation when ./configure'd with --enable-debug glx: Consistently use ARB-suffixed names for ARB_multitexture

[PATCH] glx: Add null pointer protection to __glGetProcAddress

2013-12-10 Thread Adam Jackson
This can't happen when GLX is the backing window system, but can elsewhere. We may as well protect against it at a high level. Signed-off-by: Adam Jackson a...@redhat.com --- glx/glxext.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/glx/glxext.c b/glx/glxext.c index

[PATCH] present: recursively set window pixmaps on flip

2013-12-10 Thread Keith Packard
Newly created windows inherit the pixmap of their parent, similarly, reparenting a tree inherits the pixmap of the destination tree. Making present preserve the invariant that unredirected windows always have the same pixmap as their parent ensures that the above cases work correctly.

Re: [PATCH] present: recursively set window pixmaps on flip

2013-12-10 Thread Adam Jackson
On Tue, 2013-12-10 at 11:32 -0800, Keith Packard wrote: Newly created windows inherit the pixmap of their parent, similarly, reparenting a tree inherits the pixmap of the destination tree. Making present preserve the invariant that unredirected windows always have the same pixmap as their

Re: [PATCH] present: recursively set window pixmaps on flip

2013-12-10 Thread Keith Packard
Adam Jackson a...@nwnk.net writes: On Tue, 2013-12-10 at 11:32 -0800, Keith Packard wrote: Newly created windows inherit the pixmap of their parent, similarly, reparenting a tree inherits the pixmap of the destination tree. Making present preserve the invariant that unredirected windows

Re: [PATCH] glx: Add null pointer protection to __glGetProcAddress

2013-12-10 Thread Eric Anholt
Adam Jackson a...@redhat.com writes: This can't happen when GLX is the backing window system, but can elsewhere. We may as well protect against it at a high level. (where elsewhere is both egl and wgl, each with different sets of functions that will return NULL. What a delightful API) An

[PULL] passive grab fixes

2013-12-10 Thread Peter Hutterer
Fixes some pointer-emulated touch hangs that are apparently quite easy to trigger with xmonad. The following changes since commit b3533d0b212b6747a8f9a01931253d6bdb648ee2: Bump version to 1.14.99.904 (1.15 RC4) (2013-12-10 10:29:11 -0800) are available in the git repository at: