Re: [PULL] MatchSeat, logind patch, two invalid memory access

2014-05-08 Thread Keith Packard
Laércio de Sousa writes: > These warnings are all related to a malformed FIND_SUITABLE macro > expansion. I can fix it tomorrow. Thanks. -- keith.pack...@intel.com pgpeTDe1BBR9h.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org devel

Re: [PATCH] glamor: Stop disabling asserts by default.

2014-05-08 Thread Michel Dänzer
On 09.05.2014 00:45, Eric Anholt wrote: > Disabling asserts is something the user gets to manage. > > Signed-off-by: Eric Anholt > --- > glamor/glamor_priv.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/glamor/glamor_priv.h b/glamor/glamor_priv.h > index 96635be..c56c559 100644 >

Re: [PATCH 02/13] glamor: Add glamor_program based copy acceleration

2014-05-08 Thread Michel Dänzer
On 09.05.2014 10:56, Zhigang Gong wrote: > On Thu, May 08, 2014 at 12:02:50PM -0700, Eric Anholt wrote: >> Keith Packard writes: >> >>> Michel Dänzer writes: >>> On 06.05.2014 07:02, Keith Packard wrote: > > +static Bool > +glamor_copy_gl(DrawablePtr src, > + Dr

Re: [PATCH 02/13] glamor: Add glamor_program based copy acceleration

2014-05-08 Thread Zhigang Gong
On Thu, May 08, 2014 at 12:02:50PM -0700, Eric Anholt wrote: > Keith Packard writes: > > > Michel Dänzer writes: > > > >> On 06.05.2014 07:02, Keith Packard wrote: > >>> > >>> +static Bool > >>> +glamor_copy_gl(DrawablePtr src, > >>> + DrawablePtr dst, > >>> + GCPtr

[PATCH] Fix openchrome build on Hurd

2014-05-08 Thread Gabriele Giacone
Hello, as suggested on irc, forwarding patch by Pino Toscano (CC'ed) that fixes openchrome driver build on Hurd. Already attached to bug #69621 months ago. Just added Fixes tag. Thanks. Pino Toscano (1): Do not require libdrm as base pkg-config module configure.ac | 2 +- 1 file changed, 1

[PATCH] Do not require libdrm as base pkg-config module

2014-05-08 Thread Gabriele Giacone
From: Pino Toscano Remove libdrm from the list of mandatory Xorg modules, as it is an optional component whose presence is checked later. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=69621 --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b

Re: [PULL] MatchSeat, logind patch, two invalid memory access

2014-05-08 Thread Laércio de Sousa
Em 08/05/2014 17:03, "Keith Packard" escreveu: > > Peter Hutterer writes: > > > The last two aren't rev-by. If you want to add the tag, feel free to add the > > tag after merging. > > I've reviewed both of these; feel free to add as you please, or send > along and I'll add that when I merge. Howe

Re: [PATCH xfs 2/2] Delete unused CopyISOLatin1Lowered function

2014-05-08 Thread Alan Coopersmith
I think it may have been needed for platforms without weak symbols before libXfont commit daa7af2bb2326de363, but that's in 1.4.0 and we already require newer, so seems fine to drop now. (Why that was ever weak and overridable in the first place, I can't imagine. It's not like different program

Re: [PATCH xfs 1/2] Use the register_fpe_functions() function from libXfont

2014-05-08 Thread Alan Coopersmith
On 05/ 8/14 10:28 AM, Julien Cristau wrote: Instead of individually registering support for font files and font servers, use the libXfont-provided register_fpe_functions() which will do the right thing (as of 1.4.2) depending how libXfont was configured. I was going to ask if pkg-config needed

Re: [PULL] MatchSeat, logind patch, two invalid memory access

2014-05-08 Thread Keith Packard
Peter Hutterer writes: > The last two aren't rev-by. If you want to add the tag, feel free to add the > tag after merging. I've reviewed both of these; feel free to add as you please, or send along and I'll add that when I merge. However, I'm getting a bunch of new warnings now and those will ne

Re: [PATCH 02/13] glamor: Add glamor_program based copy acceleration

2014-05-08 Thread Keith Packard
Eric Anholt writes: > That said, why do GLAMOR_DRM_ONLY pixmaps even exist? From a quick tour > of the glamor_egl.c paths that set_pixmap_type(pixmap, GLAMOR_DRM_ONLY) > and the associated radeon code, it looks like a DRM_ONLY pixmap should > be immediately getting thrown away to use a normal pi

Re: [PATCH 02/13] glamor: Add glamor_program based copy acceleration

2014-05-08 Thread Eric Anholt
Keith Packard writes: > Michel Dänzer writes: > >> On 06.05.2014 07:02, Keith Packard wrote: >>> >>> +static Bool >>> +glamor_copy_gl(DrawablePtr src, >>> + DrawablePtr dst, >>> + GCPtr gc, >>> + BoxPtr box, >>> + int nbox, >>> +

Re: [PULL] MatchSeat, logind patch, two invalid memory access

2014-05-08 Thread Laércio de Sousa
Sorry for the insistence. Any problem with this pull-req? CANTATE DOMINO CANTICUM NOVUM QUIA MIRABILIA FECIT Laércio 2014-05-04 18:37 GMT-03:00 Peter Hutterer : > The last two aren't rev-by. If you want to add the tag, feel free to add > the > tag after merging. > > The following changes since

Re: [PATCH 12/13] mi: Fill all spans for PolyFillArc at once

2014-05-08 Thread Keith Packard
Eric Anholt writes: > Can you give me some justification of what prevents integer overflow > here? Here's a replacement which limits the number of spans allocated to 4M. It's still a net -12 lines of code, so I don't feel *too* bad about making it more complicated. No performance impact as we ne

[PATCH xfs 1/2] Use the register_fpe_functions() function from libXfont

2014-05-08 Thread Julien Cristau
Instead of individually registering support for font files and font servers, use the libXfont-provided register_fpe_functions() which will do the right thing (as of 1.4.2) depending how libXfont was configured. This should let xfs run against a libXfont configured with --disable-fc. --- Makefile.

[PATCH xfs 2/2] Delete unused CopyISOLatin1Lowered function

2014-05-08 Thread Julien Cristau
--- difs/difsutils.c | 20 1 file changed, 20 deletions(-) diff --git a/difs/difsutils.c b/difs/difsutils.c index 0dd99b5..7e350c6 100644 --- a/difs/difsutils.c +++ b/difs/difsutils.c @@ -189,26 +189,6 @@ XpClientIsPrintClient(ClientPtr client, FontPathElementPtr fpe) r

Re: [PATCH v2] mi: start calculating the sprite trace from the first child of root

2014-05-08 Thread Keith Packard
Peter Hutterer writes: > Introduced in > 73698d41e41ce76bef2d9a90b46ac0c24ae148dd "Make XYToWindow a screen function" > > Moving the code into miwindow.c changed the start of the loop from > RootWindow()->firstChild to DeepestSpriteWindow(). This function is only > supposed to be called from miXY

Re: [PATCH 02/13] glamor: Add glamor_program based copy acceleration

2014-05-08 Thread Keith Packard
Michel Dänzer writes: > On 06.05.2014 07:02, Keith Packard wrote: >> >> +static Bool >> +glamor_copy_gl(DrawablePtr src, >> + DrawablePtr dst, >> + GCPtr gc, >> + BoxPtr box, >> + int nbox, >> + int dx, >> + int

[PATCH] glamor: Stop disabling asserts by default.

2014-05-08 Thread Eric Anholt
Disabling asserts is something the user gets to manage. Signed-off-by: Eric Anholt --- glamor/glamor_priv.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/glamor/glamor_priv.h b/glamor/glamor_priv.h index 96635be..c56c559 100644 --- a/glamor/glamor_priv.h +++ b/glamor/glamor_priv.h @@ -30

Re: [PATCH 02/13] glamor: Add glamor_program based copy acceleration

2014-05-08 Thread Michel Dänzer
On 06.05.2014 07:02, Keith Packard wrote: > > +static Bool > +glamor_copy_gl(DrawablePtr src, > + DrawablePtr dst, > + GCPtr gc, > + BoxPtr box, > + int nbox, > + int dx, > + int dy, > + Bool reverse,

Re: [PATCH keyboard] Init LEDs to zero before querying the value

2014-05-08 Thread Peter Hutterer
On 8/05/2014 16:57 , Samuel Thibault wrote: Peter Hutterer, le Thu 08 May 2014 13:01:03 +1000, a écrit : This way if the ioctl fails we don't set any unintended LEDs, but really this patch is more to silence valgrind: ==7129== Conditional jump or move depends on uninitialised value(s) ==7129==