[PATCH] LibX11: rm redundant null checks

2014-06-07 Thread walter harms
remove more redundant NULL checks note that _XkbFree() is realy Xfree() Signed-off-by: Harms wharms@bfs,de --- src/GetHints.c | 2 +- src/xkb/XKBAlloc.c | 3 +- src/xkb/XKBExtDev.c | 6 ++-- src/xkb/XKBGeom.c | 11 +++--- src/xkb/XKBMAlloc.c | 99

Re: [PATCH V2] libx11:lcDefConv.c fix use before check

2014-06-07 Thread walter harms
Hi Allen, please try this one, it is a simple diff between my current version and the current tar Since i have no clue what my caused the problem, let alone how to use git to fix it. i went back to a less sophisticated way. Signed-off-by: Harms wharms@bfs,de ---

[PATCH] libX11: rm redundante NULL checks

2014-06-07 Thread walter harms
This patch removes the last remaining NULL checks for Xfree() Signed-off-by: Harms wharms@bfs,de --- src/GetWMProto.c| 2 +- src/xkb/XKBGAlloc.c | 6 ++ src/xlibi18n/ICWrap.c | 10 +- src/xlibi18n/XDefaultOMIF.c | 36 ++--

[PATCH] libX11: do not shadow variables

2014-06-07 Thread walter harms
unshadow a few variables that fixes: imCallbk.c:627:15: warning: symbol 'len' shadows an earlier one imCallbk.c:627:8: warning: declaration of 'len' shadows a parameter [-Wshadow] imCallbk.c:597:9: warning: shadowed declaration is here [-Wshadow] imLcLkup.c:64:18: warning: symbol 'mb' shadows an

Re: [PATCH util/modular] Add gpg signing to release.sh

2014-06-07 Thread Stephen Kitt
Hi, On Thu, 5 Jun 2014 10:05:15 +1000, Peter Hutterer peter.hutte...@who-t.net wrote: shouldn't we fail here if creating the detached sig fails? I'm attaching a new version which fails if gpg fails to sign for any reason. Regards, Stephen From 283b89da292ad8a5743222baf33393d964cff54b Mon Sep