Re: [PATCH 0/2] Replace OdevAttributes API

2014-07-16 Thread Hans de Goede
Hi, On 07/16/2014 02:31 AM, Keith Packard wrote: > Here's a 'real' version of the proposed OdevAttributes API > change. This one provides a patch which adds a backward compatible API > for drivers. I made that API perform compile-time checks on the > attribute and default values provided to make s

Re: [PATCH:libXaw] Fix abs() usage.

2014-07-16 Thread Thomas Klausner
Review please! Thanks, Thomas On Wed, Mar 19, 2014 at 08:52:46AM +0100, Thomas Klausner wrote: > From: Jörg Sonnenberger > > For long arguments, use labs(). > > Signed-off-by: Thomas Klausner > --- > src/Text.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/Te

Re: [PATCH] gcc 4.2 doesn't accept 2 typedef declarations of the same type.

2014-07-16 Thread Keith Packard
Matthieu Herrb writes: > Protect them with a macro to avoid the duplication. We can just remove the one from xf86Xinput.h; xf86.h will always have been included already. -- keith.pack...@intel.com pgpC55UGar2tR.pgp Description: PGP signature ___ xo

Re: [PATCH:libXaw] Fix abs() usage.

2014-07-16 Thread Matt Turner
On Wed, Jul 16, 2014 at 9:44 AM, Thomas Klausner wrote: > Review please! > > Thanks, > Thomas Reviewed-by: Matt Turner Please apply to libXaw3d as well. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel In

Re: [PATCH] Revert "glamor: Fix coordinates handling for composite source/mask pictures"

2014-07-16 Thread Keith Packard
Michel Dänzer writes: > After several complaints about this revert from users of other DEs > (because it broke their systray icons again), I tried to reproduce the > kwin problem shown on > http://markus.members.selfnet.de/xorg/glamor_kwin.png without the revert > again, but couldn't. Markus, can

Re: [PATCH] gcc 4.2 doesn't accept 2 typedef declarations of the same type.

2014-07-16 Thread Matthieu Herrb
On Wed, Jul 16, 2014 at 11:21:33AM -0700, Keith Packard wrote: > Matthieu Herrb writes: > > > Protect them with a macro to avoid the duplication. > > We can just remove the one from xf86Xinput.h; xf86.h will always have > been included already. It's currenlty not true at least for xf86-input sy

Re: [PATCH] gcc 4.2 doesn't accept 2 typedef declarations of the same type.

2014-07-16 Thread Keith Packard
Matthieu Herrb writes: > It's currenlty not true at least for xf86-input synaptics. But if > Peter is willing to fix that, I'm ok with that solution (it was the > first I used, until I also built the synaptics driver). Alternatively, just #include xf86.h from xf86Xinput.h; that'll solve the prob