Re: [PATCH v2 evdev] Make the slot-state per slot

2014-08-15 Thread walter harms
thx for taking me serious much better to read now. It is to see that SLOTSTATE_UPDATE is not covered by any case. I assume that is intentional ? re, wh revieded-by wharms Am 15.08.2014 05:57, schrieb Peter Hutterer: > The previous approach only had the slot state for the current slot. If we >

Re: [PATCH] render: Don't generate invalid pixman format when using a 24bpp framebuffer with a 32bit depth visual.

2014-08-15 Thread Takashi Iwai
At Tue, 12 Aug 2014 16:03:54 -0700, Keith Packard wrote: > > Robert Ancell writes: > > > When using the fb backend at 24bpp it allows a visual with 32 bit > > depth. > > That's not valid; depth must never be larger than bits per pixel. Can we put some assert to catch such a bug? > Please > fi

Re: [PATCH] render: Don't generate invalid pixman format when using a 24bpp framebuffer with a 32bit depth visual.

2014-08-15 Thread Takashi Iwai
At Fri, 15 Aug 2014 12:01:53 +0200, Takashi Iwai wrote: > > At Tue, 12 Aug 2014 16:03:54 -0700, > Keith Packard wrote: > > > > Robert Ancell writes: > > > > > When using the fb backend at 24bpp it allows a visual with 32 bit > > > depth. > > > > That's not valid; depth must never be larger tha

Re: [PATCH] linux: Automatically ShareVTs if the VT are already in graphics mode

2014-08-15 Thread Daniel Vetter
On Thu, Aug 14, 2014 at 11:36:11AM +0100, Chris Wilson wrote: > On Wed, Aug 13, 2014 at 10:58:54AM +0100, Chris Wilson wrote: > > If the VT we are using is already in KD_GRAPHICS mode, calling SETACTIVE > > will silently fail. This leads to an indefinite hang as WAITACTIVE never > > returns causing

[PATCH synaptics] Use cumulative relative touch movements while scrolling

2014-08-15 Thread Gabriele Mazzotta
Signed-off-by: Gabriele Mazzotta --- src/eventcomm.c | 8 +--- src/synaptics.c | 8 +--- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/src/eventcomm.c b/src/eventcomm.c index 1f440b8..54421bb 100644 --- a/src/eventcomm.c +++ b/src/eventcomm.c @@ -665,9 +665,11 @@ EventRe

[PATCH renderproto] Add floating point transforms

2014-08-15 Thread Keith Packard
Fixed point coordinates don't provide reasonable precision for transformation operations; the resulting transforms are often off by several pixels. Allow clients to represent the transformation using either fixed point or floating point. Signed-off-by: Keith Packard --- configure.ac| 2 +-

Re: [PATCH v4 0/3] new approach for Xephyr window placement (for multiseat purposes) (v4)

2014-08-15 Thread Keith Packard
LaƩrcio de Sousa writes: > This is the v4 of patch series for providing window placement support > for Xephyr. > > Previous version of this series was already reviewed by Keith Packard, > but not yet merged into xserver git master branch. > > Meanwhile, we've made some minor changes, as suggested

Re: [PATCH 2/2] Update .pc file Requires lines to express full dependencies

2014-08-15 Thread Keith Packard
Alan Coopersmith writes: > See points #2 & #3 of > http://people.freedesktop.org/~dbn/pkg-config-guide.html#faq > and Tollef's post at http://err.no/personal/blog/2008/Mar/25 . > > Requires.privates are used for both header files & static linking, > Requires are for the rare cases where callers n

Re: [PATCH][V3][xserver] configure.ac: add option for xshmfence

2014-08-15 Thread Keith Packard
Ross Burton writes: > xshmfence is usable outside of DRI3, and is currently autodetected which isn't > good for distributions where deterministic builds are desired. > > Signed-off-by: Ross Burton Seems like this should work; Reviewed-by: Keith Packard -- keith.pack...@intel.com pgp1J07cS

Re: [PATCH][V3][xserver] configure.ac: add option for xshmfence

2014-08-15 Thread Matt Turner
On Fri, Aug 15, 2014 at 8:16 AM, Keith Packard wrote: > Ross Burton writes: > >> xshmfence is usable outside of DRI3, and is currently autodetected which >> isn't >> good for distributions where deterministic builds are desired. >> >> Signed-off-by: Ross Burton > > Seems like this should work;

[PATCH] xrandr: Fix bug in calling crtc_set_transform()

2014-08-15 Thread Nikhil Mahale
Compare pending transformation with currently pending transformation on server, instead of comparing it with current transformation on server. Signed-off-by: Nikhil Mahale --- xrandr.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/xrandr.c b/xrandr.c index 36