[PATCH 1/4] glamor: Fix use-after-free in glamor_destroy_textured_pixmap

2014-12-10 Thread Michel Dänzer
From: Michel Dänzer ==25551== Invalid read of size 8 ==25551==at 0x85D5F2C: glamor_egl_destroy_pixmap_image (glamor_egl.c:527) ==25551==by 0x85D7750: glamor_destroy_pixmap (glamor.c:235) ==25551==by 0xC1BDD9B: radeon_glamor_destroy_pixmap (radeon_glamor.c:278) ==25551==by 0x5098F6

[PATCH 2/4] glamor: Make glamor_set_pixmap_private not crash if the pixmap has no fbo

2014-12-10 Thread Michel Dänzer
From: Michel Dänzer Signed-off-by: Michel Dänzer --- glamor/glamor.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/glamor/glamor.c b/glamor/glamor.c index c4f3f3a..cbd0e02 100644 --- a/glamor/glamor.c +++ b/glamor/glamor.c @@ -563,8 +563,11 @@ glamor_set_pixmap_priv

[PATCH 3/4] glamor: Make glamor_destroy_textured_pixmap idempotent

2014-12-10 Thread Michel Dänzer
From: Michel Dänzer For robustness against drivers which may call both glamor_(egl_)destroy_textured_pixmap and glamor_destroy_pixmap. Signed-off-by: Michel Dänzer --- glamor/glamor.c | 1 + glamor/glamor_fbo.c | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/glamor/gl

[PATCH 4/4] glamor: Make sure glamor_egl_close_screen wraps glamor_close_screen

2014-12-10 Thread Michel Dänzer
From: Michel Dänzer The other way around fails to destroy the screen pixmap EGL image: ==1782== 80 (32 direct, 48 indirect) bytes in 1 blocks are definitely lost in loss record 981 of 2,171 ==1782==at 0x4C28C20: malloc (vg_replace_malloc.c:296) ==1782==by 0xF9D4BD2: dri2_create_image_fr

Re: [PULL] GLX and Xephyr fixes

2014-12-10 Thread Keith Packard
Adam Jackson writes: > Adam Jackson (2): > glx: Dynamically compute attribute slot in GetDrawableAttributes > glx: Add hack for GLX-1.2-style naked windows to GetDrawableAttributes This one is a bug fix, but the other two look like new features? Do you think I should merge them all f

Re: [PATCH] glamor: Reinstate glamor_(egl_)destroy_textured_pixmap

2014-12-10 Thread Keith Packard
Michel Dänzer writes: > From: Michel Dänzer > > They are part of the ABI. Sorry for breaking the ABI. No biscuit for me today. Reviewed-by: Keith Packard Merged. c1455f7..91651e7 master -> master We should revert this after 1.17 as there's no reason to expose this API at this point. Jus

Re: [PATCH] glamor: Reinstate glamor_(egl_)destroy_textured_pixmap

2014-12-10 Thread Michel Dänzer
On 10.12.2014 16:21, Michel Dänzer wrote: > From: Michel Dänzer > > They are part of the ABI. This probably fixes https://bugs.freedesktop.org/show_bug.cgi?id=87198 . -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast |

xinitrc empty variables (xterm/xclock/twm) on config file

2014-12-10 Thread Victor Rodriguez
HI I am very new on Xorg and X11 technology, but I think there is a problem with the xinit system, here is the story : When I compiled the xinit from the source code with these options on the configure: ./configure --without-twm --without-xclock --without-xterm Everything works fine , but

[PATCH] dix: offset touch root coordinates by ScreenRec origins (#86655)

2014-12-10 Thread Peter Hutterer
For two ScreenRecs abs pointer positioning was working fine, but touch events stuck to the lower/right edge on any screen but the one with a 0/0 origin. Cause is a missing offset by the screen coordinates, causing the root coordinates in the event to desktop-wide, not screen-wide. Offset properly,

Re: DRI3/Present fixes for XServers 1.16 and 1.17rc - reviewed

2014-12-10 Thread Julien Cristau
On Sat, Dec 6, 2014 at 05:40:06 +0100, Mario Kleiner wrote: > Ok, the final patchset. I made the changes Eric Anholt proposed, > retested, and got them reviewed by him. With those on top of > XServer 1.16.2, DRI3/Present works for me on all drivers and > backends (intel sna, uxa and nouveau exa,

Re: [PATCH 8/8] modesetting: Add output hotplug support

2014-12-10 Thread Aaron Plattner
On 12/10/2014 10:17 AM, Keith Packard wrote: Aaron Plattner writes: How is a client expected to deal with outputs going away? XSync() and wire up an error handler around all of its RandR calls? If so, that sucks. Like any client deals with any resource which may disappear. Xlib's error han

Re: [PATCH 8/8] modesetting: Add output hotplug support

2014-12-10 Thread Keith Packard
Aaron Plattner writes: > How is a client expected to deal with outputs going away? XSync() and > wire up an error handler around all of its RandR calls? If so, that > sucks. Like any client deals with any resource which may disappear. Xlib's error handling is pretty painful, but it can be mad

Re: [PATCH 8/8] modesetting: Add output hotplug support

2014-12-10 Thread Aaron Plattner
On 12/10/2014 09:29 AM, Keith Packard wrote: Daniel Martin writes: Hmm, the awesome Xlib error handling ... Keith, what do you think, should I change the patch to keep the outputs? In case, I have to admin, that I can't manage to do this during this week. No, we don't need to work around cl

Re: [PATCH 8/8] modesetting: Add output hotplug support

2014-12-10 Thread Keith Packard
Daniel Martin writes: > Hmm, the awesome Xlib error handling ... > > Keith, what do you think, should I change the patch to keep the outputs? > In case, I have to admin, that I can't manage to do this during this > week. No, we don't need to work around client bugs like that. -- keith.pack...@

Re: [PATCH 8/8] modesetting: Add output hotplug support

2014-12-10 Thread Alex Deucher
On Wed, Dec 10, 2014 at 3:03 AM, Daniel Martin wrote: > On 9 December 2014 at 08:14, Aaron Plattner wrote: >> On 12/08/2014 01:01 AM, Daniel Martin wrote: >>> >>> On 5 December 2014 at 17:45, Keith Packard wrote: Daniel Martin writes: > From: Daniel Martin > > When r

Re: [PATCH] saa: Adapt to GC client clip changes in xserver 1.17

2014-12-10 Thread Thomas Hellstrom
Hi, Sorry for the late response. Best is to send to linux-graphics-maintai...@vmware.com as listed in the xorg maintainer info. The change looks good to me. I just need to run it through our compile-testing-tool Thanks! /Thomas On 12/10/2014 05:05 PM, Adam Jackson wrote: > On Thu, 2014-12-04

[PULL] GLX and Xephyr fixes

2014-12-10 Thread Adam Jackson
The following changes since commit c1455f76c6b1aa4ecaacb2221a687244285aa44b: glx: Add implementation of __GLXContext->loseCurrent for direct ctxts (2014-12-09 14:15:55 -0800) are available in the git repository at: ssh://people.freedesktop.org/~ajax/xserver.git xserver-next for you to fetc

Re: [PATCH] saa: Adapt to GC client clip changes in xserver 1.17

2014-12-10 Thread Adam Jackson
On Thu, 2014-12-04 at 10:35 -0500, Adam Jackson wrote: > 1.17 always stores the client clip as a region, so there's no longer a > clientClipType member to look at. Change the code to just inspect > whether the clientClip is non-null, since that works both before and > after 1.17. Ping? This is r

Re: [PATCH 8/8] modesetting: Add output hotplug support

2014-12-10 Thread Daniel Martin
On 9 December 2014 at 08:14, Aaron Plattner wrote: > On 12/08/2014 01:01 AM, Daniel Martin wrote: >> >> On 5 December 2014 at 17:45, Keith Packard wrote: >>> >>> Daniel Martin writes: >>> From: Daniel Martin When receiving a hotplug uevent, check if we have to add or remove