Re: [PATCH 2/7] glamor: glObjectLabel is not defined in GLES2

2015-01-12 Thread Maarten Lankhorst
Hey, On 13-01-15 03:40, Eric Anholt wrote: > Maarten Lankhorst writes: > >> Signed-off-by: Maarten Lankhorst >> --- >> glamor/glamor_core.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/glamor/glamor_core.c b/glamor/glamor_core.c >> index 737b274..4eaf8ac 100644

Re: synaptics - double taps are ignored in some applications

2015-01-12 Thread Peter Hutterer
On Mon, Jan 12, 2015 at 09:32:13PM +0100, Gabriele Mazzotta wrote: > Hi, > > I have some problems with double taps in some applications. > These applications, e.g. Firefox, often (if not always) ignores double > taps. This never happens with double clicks and it happens only with > the same applic

Re: [PATCH 1/7] glamor: only use (un)pack_subimage when available

2015-01-12 Thread Matt Turner
On Mon, Jan 12, 2015 at 6:29 AM, Maarten Lankhorst wrote: > Signed-off-by: Maarten Lankhorst > --- > glamor/glamor.c | 7 ++ > glamor/glamor_priv.h | 2 ++ > glamor/glamor_transfer.c | 55 > +++- > 3 files changed, 45 insertions(+),

Re: [PATCH 7/7] XXX glamor: Only use supported tex formats

2015-01-12 Thread Eric Anholt
Maarten Lankhorst writes: > Some GLES2 implementations don't support GL_UNSIGNED__REV and only > guarantee less fancy things to work. > > I'm only certain it fixes the GLES2 errors, but is this a sane way to handle > things? Or am I just shutting up the errors? I always find the GL format ar

Re: [PATCH 6/7] glamor: Re-enable a8 textures for GLES2

2015-01-12 Thread Eric Anholt
Maarten Lankhorst writes: > This will probably break PVR, but fixes other implementations. GL ES 2.0.25 spec says: "Formats not listed in table 4.5, including compressed internal formats. are not color-, depth-, or stencil-renderable, no matter which components they contain." where table 4.5 ha

Re: [PATCH 4/7] glamor: Use GL_FRAMEBUFFER instead of GL_READ_FRAMEBUFFER

2015-01-12 Thread Eric Anholt
Maarten Lankhorst writes: > The latter might not be available on GLES2. > > Signed-off-by: Maarten Lankhorst Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.or

Re: [PATCH 5/7] glamor: GL_TEXTURE_MAX_LEVEL is not available on GLES2

2015-01-12 Thread Eric Anholt
Maarten Lankhorst writes: > Signed-off-by: Maarten Lankhorst I'd rather just delete the MAX_LEVEL setting, since it's unnecessary, and setting the filtering is a sufficient hint to the driver about texture mipmap allocation. signature.asc Description: PGP signature ___

Re: [PATCH 3/7] glamor: swallow gl errors before compiling programs

2015-01-12 Thread Eric Anholt
Maarten Lankhorst writes: > In case the glamor implementation is buggy a error might be set > before compiling, which causes glamor_build_program to enter > the failure path even though shader compilation succeeded. > Eat all errors before running glamor_build_program. I'd rather delete the glGe

Re: [PATCH 2/7] glamor: glObjectLabel is not defined in GLES2

2015-01-12 Thread Eric Anholt
Maarten Lankhorst writes: > Signed-off-by: Maarten Lankhorst > --- > glamor/glamor_core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/glamor/glamor_core.c b/glamor/glamor_core.c > index 737b274..4eaf8ac 100644 > --- a/glamor/glamor_core.c > +++ b/glamor/glamor_cor

Re: xproto: _X_NONNULL uses GNU extension

2015-01-12 Thread Alan Coopersmith
On 01/10/15 03:41 PM, Thomas Klausner wrote: On Fri, Jan 09, 2015 at 03:26:24PM -0800, Alan Coopersmith wrote: On 01/ 9/15 02:53 PM, Thomas Klausner wrote: Hi! When compiling slock with clang, one sees: /scratch/x11/slock/work/.buildlink/include/X11/Xfuncproto.h:157:24: warning: named variad

Re: [PATCH 2/3] glamor: Don't use PACK/UNPACK_SKIP_ROWS/PIXELS.

2015-01-12 Thread Eric Anholt
Maarten Lankhorst writes: > Hey, > Op 30-12-14 om 23:54 schreef Eric Anholt: >> It's not available in GLES2 (though it's in GLES3). It's trivial to >> do the math, and avoids going through more switch statements in the GL >> on desktop. >> >> Signed-off-by: Eric Anholt >> --- > > Doesn't fix it

[PATCH 4/7] glamor: Use GL_FRAMEBUFFER instead of GL_READ_FRAMEBUFFER

2015-01-12 Thread Maarten Lankhorst
The latter might not be available on GLES2. Signed-off-by: Maarten Lankhorst --- glamor/glamor_spans.c| 2 +- glamor/glamor_transfer.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/glamor/glamor_spans.c b/glamor/glamor_spans.c index 582d11d..6ebb12e 100644 --- a/glam

[PATCH 2/7] glamor: glObjectLabel is not defined in GLES2

2015-01-12 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- glamor/glamor_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/glamor/glamor_core.c b/glamor/glamor_core.c index 737b274..4eaf8ac 100644 --- a/glamor/glamor_core.c +++ b/glamor/glamor_core.c @@ -102,7 +102,8 @@ glamor_link_glsl_prog

[PATCH 1/7] glamor: only use (un)pack_subimage when available

2015-01-12 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- glamor/glamor.c | 7 ++ glamor/glamor_priv.h | 2 ++ glamor/glamor_transfer.c | 55 +++- 3 files changed, 45 insertions(+), 19 deletions(-) diff --git a/glamor/glamor.c b/glamor/glamor.c index e6e

synaptics - double taps are ignored in some applications

2015-01-12 Thread Gabriele Mazzotta
Hi, I have some problems with double taps in some applications. These applications, e.g. Firefox, often (if not always) ignores double taps. This never happens with double clicks and it happens only with the same applications. After some tests I found that the problem is that there's no delay bet

[PATCH 6/7] glamor: Re-enable a8 textures for GLES2

2015-01-12 Thread Maarten Lankhorst
This will probably break PVR, but fixes other implementations. Signed-off-by: Maarten Lankhorst --- glamor/glamor_pixmap.c | 10 ++ glamor/glamor_utils.h | 6 +- 2 files changed, 3 insertions(+), 13 deletions(-) diff --git a/glamor/glamor_pixmap.c b/glamor/glamor_pixmap.c index 1c

[PATCH 0/7] glamor fixes with GLES2

2015-01-12 Thread Maarten Lankhorst
I've tested glamor against other GLES2 drivers and found that some behavior is different from the desktop. The below plus the patch "glamor: Just set the logic op to what we want at the start of all rendering." created by Eric Anholt squashes most GLES2 errors I've hit. Maarten Lankhorst (7): gl

[PATCH 7/7] XXX glamor: Only use supported tex formats

2015-01-12 Thread Maarten Lankhorst
Some GLES2 implementations don't support GL_UNSIGNED__REV and only guarantee less fancy things to work. I'm only certain it fixes the GLES2 errors, but is this a sane way to handle things? Or am I just shutting up the errors? --- glamor/glamor_transfer.c | 8 1 file changed, 4 insert

[PATCH xserver V2] use xcb struct in render

2015-01-12 Thread Jaya Tiwari
Replacing manually written proto headers for render extension with xcb generated structs Have changed simple requests without list/switch and replies Signed-off-by: Jaya Tiwari --- render/render.c | 153 1 file changed, 77 insertions(+), 7

[PATCH 5/7] glamor: GL_TEXTURE_MAX_LEVEL is not available on GLES2

2015-01-12 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- glamor/glamor_fbo.c| 3 ++- glamor/glamor_font.c | 3 ++- glamor/glamor_pixmap.c | 3 ++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/glamor/glamor_fbo.c b/glamor/glamor_fbo.c index d2aabb2..30f8342 100644 --- a/glamor/glamor_fbo.c +++

Re: [PATCH 3/3] glx/dri3: Request non-vsynced Present for swapinterval zero.

2015-01-12 Thread Mathias Fröhlich
Hi, On Sunday, January 04, 2015 20:53:59 Emil Velikov wrote: > Adding Mathias and Frank Binns to the Cc list. > > So taking into account the discussion so far, including Mathias's input > that the official nvidia driver does the same/similar form of cheating: > - Should we revert on master unti

Re: [Mesa-dev] [PATCH 3/3] glx/dri3: Request non-vsynced Present for swapinterval zero.

2015-01-12 Thread Mathias Fröhlich
Hi Aaron, On Monday, December 29, 2014 08:01:53 Aaron Plattner wrote: > Really? Do you have a link to a report of this, or some description of > how this happened? I could see it happen if you're running a composite > manager, but that's only because the application can render to its > redir

[PATCH 3/7] glamor: swallow gl errors before compiling programs

2015-01-12 Thread Maarten Lankhorst
In case the glamor implementation is buggy a error might be set before compiling, which causes glamor_build_program to enter the failure path even though shader compilation succeeded. Eat all errors before running glamor_build_program. Signed-off-by: Maarten Lankhorst --- glamor/glamor_program.c

[PATCH v2] backtrace.c: Fix word cast to a pointer

2015-01-12 Thread Vicente Olivert Riera
backtrace.c uses a word size provided by libunwind. In some architectures like MIPS, libunwind makes that word size 64-bit for all variants of the architecture. In the lines #90 and #98, backtrace.c tries to do a cast to a pointer, which fails in all MIPS variants with 32-bit pointers, like MIPS32

Re: [PATCH x11perf] remove srand(1) call as nothing calls any rand like functions in x11perf

2015-01-12 Thread Thomas Klausner
On Mon, Jan 12, 2015 at 11:28:32AM +0100, Matthieu Herrb wrote: > On Sun, Jan 11, 2015 at 11:40:32AM +0100, Thomas Klausner wrote: > > LGTM > > Hi Thomas, > > Can I interpret that as a Reviewed-by: header? Yes, sorry for not being more explicit. Thomas > > > > On Sat, Jan 10, 2015 at 10:51:1

Re: [PATCH x11perf] remove srand(1) call as nothing calls any rand like functions in x11perf

2015-01-12 Thread Matthieu Herrb
On Sun, Jan 11, 2015 at 11:40:32AM +0100, Thomas Klausner wrote: > LGTM Hi Thomas, Can I interpret that as a Reviewed-by: header? > > On Sat, Jan 10, 2015 at 10:51:12AM +0100, Matthieu Herrb wrote: > > Signed-off-by: Matthieu Herrb > > --- > > x11perf.c | 1 - > > 1 file changed, 1 deletion(-

Re: [PATCH 2/3] glamor: Don't use PACK/UNPACK_SKIP_ROWS/PIXELS.

2015-01-12 Thread Maarten Lankhorst
Hey, Op 30-12-14 om 23:54 schreef Eric Anholt: > It's not available in GLES2 (though it's in GLES3). It's trivial to > do the math, and avoids going through more switch statements in the GL > on desktop. > > Signed-off-by: Eric Anholt > --- Doesn't fix it, below patch should.. Can I steal your c