[PATCH] RandR: Remove sensless checks for xf86RandR12Key

When xf86RandR12Key is not set we will not get to the places where these tests are done as the functions in question are not called. In most cases we would have crashed before these checks anyway. Signed-off-by: Egbert Eich --- hw/xfree86/modes/xf86RandR12.c | 13 - 1 file changed, 4

[PATCH 1/2] xserver: add xorg.conf support for gpu devices.

From: Dave Airlie This allows gpu devices to be specified in xorg.conf Screen sections. Section "Device" Driver "intel" Identifier "intel0" Option "AccelMethod" "uxa" EndSection Section "Device" Driver "modesetting" Identifier "usb0" EndSection Section "

[PATCH 2/2] xfree86: attempt to autoconfig gpu slave devices

From: Dave Airlie This allows us to skip the screen section, the first Device section will get assigned to the screen, any remaining ones will get assigned to the GPUDevice sections for the screen. Signed-off-by: Dave Airlie --- hw/xfree86/common/xf86Config.c | 31 ++---

xorg.conf support for gpu devices

This is something I meant to do ages ago and failed, it adds a GPUDevice to the Screen section for specifying GPU devices to be attached to the screen. There is a second patch to try and autoconfigure things a bit better. Dave. ___ xorg-devel@lists.x.or

[PATCH 0/5] Xephyr: Numerous issues

These are fixes for issues I ran into when looking into an issue with Xephyr on IBM z-Series. Actually only the last one is related to be->le. The others however were unveiled by this special use case. Egbert Eich (5): Xephyr: Don't crash when no command line argument is specified Xephyr: Prin

[PATCH 5/5] Xephyr: Fix broken image when endianess of client machine and host-Xserver differ

The image is created in the native byte order of the machine Xephyr is rendered on however drawn in the image byte order of the Xephyr server. Correct byte order in the xcb_image_t structure and convert to native before updating the window. If depths of Xephyr and host server differ this is already

[PATCH 2/5] Xephyr: Print default server display number if none is specified

Signed-off-by: Egbert Eich --- hw/kdrive/ephyr/hostx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/kdrive/ephyr/hostx.c b/hw/kdrive/ephyr/hostx.c index c67ff60..a516c20 100644 --- a/hw/kdrive/ephyr/hostx.c +++ b/hw/kdrive/ephyr/hostx.c @@ -177,7 +177,7 @@ hostx_set_win_

[PATCH 1/5] Xephyr: Don't crash when no command line argument is specified

From: Egbert Eich The DDX specific command line parsing function only gets called if command line arguments are present. Therefore this function is not suitable to initialize mandatory global variables. Replace main() instead. Signed-off-by: Egbert Eich --- configure.ac| 4 +++

[PATCH 4/5] Xephyr: Fix screen image draw for the non-Glamor & non-XHSM case

xcb_image_put() prints the entire image, therefore don't use an offset. Signed-off-by: Egbert Eich --- hw/kdrive/ephyr/hostx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/kdrive/ephyr/hostx.c b/hw/kdrive/ephyr/hostx.c index bdffba9..99b7716 100644 --- a/hw/kdrive/ephyr

[PATCH 3/5] Xephyr: Fix compile when debugging is enabled

Signed-off-by: Egbert Eich --- hw/kdrive/ephyr/hostx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/kdrive/ephyr/hostx.c b/hw/kdrive/ephyr/hostx.c index a516c20..bdffba9 100644 --- a/hw/kdrive/ephyr/hostx.c +++ b/hw/kdrive/ephyr/hostx.c @@ -798,7 +798,7 @@ hostx_screen_i

Re: [PATCH 3/3] modesetting: add tile property support (v2)

On Tue, Mar 31, 2015 at 01:47:26PM +1000, Dave Airlie wrote: > From: Dave Airlie > > This adds tiling support to the server modesetting driver, > it retrieves the tile info from the kernel and translates > it into the server format and exposes the property. > > Signed-off-by: Dave Airlie > ---

Re: [PATCH 3/3] modesetting: add tile property support (v2)

On Tue, Mar 31, 2015 at 10:07:53AM +0100, Chris Wilson wrote: > On Tue, Mar 31, 2015 at 01:47:26PM +1000, Dave Airlie wrote: > > From: Dave Airlie > > > > This adds tiling support to the server modesetting driver, > > it retrieves the tile info from the kernel and translates > > it into the serve

Re: [PATCH libX11] fix for Xlib 32-bit request number issues

Hi Christian, On 27/03/15 15:50, Olivier Fourdan wrote: On 21/03/15 15:32, Christian Linhart wrote: [...] I am not a libX11 maintainer, so it's not really a review or anything, it's just some comments :-) So I looked further into your patch (took me some time!) and came to the following idea

[PATCH] Fix XQuartz build

On 31/03/2015 01:06, Jeremy Huddleston Sequoia wrote: One additional change needed (see below). Please squash that in and then you can tag it: Reviewed-by: Jeremy Huddleston Sequoia Tested-by: Jeremy Huddleston Sequoia Hi Keith, Please apply this patch to master. Thanks From 146cec4a78

Re: [PATCH 1/2] xserver: add xorg.conf support for gpu devices.

Hi Dave, On 31/03/15 07:12, Dave Airlie wrote: > From: Dave Airlie > > This allows gpu devices to be specified in xorg.conf Screen sections. > > Section "Device" > Driver "intel" > Identifier "intel0" > Option "AccelMethod" "uxa" > EndSection > > Section "Device" >

Re: [PATCH] RandR: Remove sensless checks for xf86RandR12Key

Egbert Eich writes: > When xf86RandR12Key is not set we will not get to the places where > these tests are done as the functions in question are not called. > In most cases we would have crashed before these checks anyway. This is really hard to review, and that's almost entirely my fault... xf

Re: [PATCH] Fix XQuartz build

Jon TURNEY writes: > Subject: [PATCH] Fix XQuartz build > > Fix XQuartz build since commit e036cbfc "Make PseudoramiXExtensionInit() > prototype more generally available" Merged. 7088816..d3b9c47 master -> master -- -keith signature.asc Description: PGP signature

Re: pull request: support for randr 1.5 tile and monitors

Dave Airlie writes: > Dave Airlie (1): > xf86Crtc: add tile prop setting > > Keith Packard (2): > randr: Add Monitor support (v1.1) > randr: Use Monitor list for Xinerama Merged. d3b9c47..e608f35 master -> master -- -keith signature.asc Description: PGP signature __

[PATCH v2 0/8] Xephyr input hotplugging support and other additions for single-GPU multiseat

This is the v2 of patch series which provides some missing parts for full single-GPU multiseat support in Xephyr. This version fixes some problems found in v1, like double-free errors for some InputOption objects, and memory corruptions when a USB keyboard or mouse is unplugged and replugged severa

[PATCH v2 2/8] kdrive: fix up NewInputDeviceRequest() implementation

This patch simplifies NewInputDeviceRequest() implementation in kinput.c, making use of improved KdParseKbdOptions()/KdParsePointerOptions() and merging several "if (ki)"/"if (pi)" clauses. Signed-off-by: Laércio de Sousa --- hw/kdrive/src/kinput.c | 76 --

[PATCH v2 3/8] kdrive: set "evdev" driver for input devices automatically, if available.

If kdrive input driver "evdev" is available, no other driver was explicitly set for a given input device, and its kernel device node is /dev/input/event*, this patch will make kdrive set "evdev" driver automatically for such device. Signed-off-by: Laércio de Sousa --- hw/kdrive/src/kinput.c | 25

[PATCH v2 4/8] kdrive: introduce input hotplugging support for udev and hal backends (#33140)

This patch introduces a command-line option -input-hotplug for kdrive-based applications, which can be used to enable input hotplugging support, instead of passing explicit -keybd and/or -mouse options. It supports udev and hal backends for input hotplugging support. Another patches may be require

[PATCH v2 1/8] ephyr: allow passing explictly host X server display number and/or authorization file path

This patch introduces two command-line options for Xephyr: * -host-display: set Xephyr DISPLAY environment variable to host X server display number * -host-auth:set Xephyr XAUTHORITY environment variable to host X server authorization file path These

[PATCH v2 8/8] ephyr: move host_has_extension() implementation to hostx.c

This is a trivial patch that moves host_has_extension() implementation from ephyr.c to hostx.c so that it can be called by hostx.c internal functions. Also rename function to hostx_has_extension() for consistency. Signed-off-by: Laércio de Sousa --- hw/kdrive/ephyr/ephyr.c | 12 +--

[PATCH v2 6/8] kdrive: add options to set default XKB properties

This patch introduces convenient command-line options -xkbrules, -xkbmodel, -xkblayout, -xkbvariant, and -xkboptions, to set default values for these properties. These options can be handful in cases where corresponding values can't be taken from devices' udev properties, and compile-time default

[PATCH v2 7/8] ephyr: ignore "-sharevts" and "-layout seatXXX" command-line options

Multiseat-capable display managers commonly pass command-line options like "-sharevts" or "-layout seat" to Xorg server, but Xephyr currently refuses to start if these options are passed to it, which may break Xephyr-based single-GPU multiseat setups. Signed-off-by: Laércio de Sousa --- hw/k

[PATCH v2 5/8] kdrive: update evdev keyboard LEDs (#22302)

From: Mikhail Krivtsov When one hits {Num,Caps,Scroll}Lock key on a Xephyr's keyboard, keyboard itself works as expected but LEDs are not updated and always stay in off. Currently logical LEDs are propagated to physical keyboard LEDs for "CoreKeyboard" only. All "kdrive" keyboards are not "CoreK

Re: [PATCH 1/2] xserver: add xorg.conf support for gpu devices.

On 03/31/2015 12:12 AM, Dave Airlie wrote: From: Dave Airlie This allows gpu devices to be specified in xorg.conf Screen sections. Section "Device" Driver "intel" Identifier "intel0" Option "AccelMethod" "uxa" EndSection Section "Device" Driver "modesetting

Re: [PATCH 2/2] xfree86: attempt to autoconfig gpu slave devices

On 03/31/2015 12:12 AM, Dave Airlie wrote: From: Dave Airlie This allows us to skip the screen section, the first Device section will get assigned to the screen, any remaining ones will get assigned to the GPUDevice sections for the screen. Signed-off-by: Dave Airlie --- hw/xfree86/common/x

Re: [PATCH 1/2] xserver: add xorg.conf support for gpu devices.

> From: Dave Airlie > Date: Tue, 31 Mar 2015 17:12:28 +1000 > > This should allow for easier tweaking of driver options which > currently mess up the GPU device discovery process. Sorry, not a real review, but: > diff --git a/hw/xfree86/common/xf86Config.c b/hw/xfree86/common/xf86Config.c > ind

[PULL] Fix GPU screen handling for drivers with no normal screens

These fixes were reviewed by Maarten. The following changes since commit e608f3521eaaab972a3eea62aa04a65958351c1c: Merge remote-tracking branch 'airlied/for-keithp' (2015-03-31 09:06:08 -0700) are available in the git repository at: git://people.freedesktop.org/~aplattner/xserver for-keith

Re: [PULL] Fix GPU screen handling for drivers with no normal screens

Aaron Plattner writes: > Aaron Plattner (2): > xfree86: Fix xf86_check_platform_slot's handling of PCI > xfree86: Add GPU screens even if there are no active GDevs Merged. e608f35..e36236e master -> master -- -keith signature.asc Description: PGP signature ___

[PATCH 1/2] xserver: add xorg.conf support for gpu devices. (v2)

From: Dave Airlie This allows gpu devices to be specified in xorg.conf Screen sections. Section "Device" Driver "intel" Identifier "intel0" Option "AccelMethod" "uxa" EndSection Section "Device" Driver "modesetting" Identifier "usb0" EndSection Section "

[PATCH 2/2] xfree86: attempt to autoconfig gpu slave devices (v2)

From: Dave Airlie This allows us to skip the screen section, the first Device section will get assigned to the screen, any remaining ones will get assigned to the GPUDevice sections for the screen. v2: fix the skipping unsuitable screen logic (Aaron) Signed-off-by: Dave Airlie --- hw/xfree86/

[PATCH] xserver: add xorg.conf support for gpu devices. (v2.1)

From: Dave Airlie This allows gpu devices to be specified in xorg.conf Screen sections. Section "Device" Driver "intel" Identifier "intel0" Option "AccelMethod" "uxa" EndSection Section "Device" Driver "modesetting" Identifier "usb0" EndSection Section "

[PATCH] modesetting: add tile property support (v2.1)

From: Dave Airlie This adds tiling support to the server modesetting driver, it retrieves the tile info from the kernel and translates it into the server format and exposes the property. v2.1: fix resetting tile property (Chris) Signed-off-by: Dave Airlie --- hw/xfree86/drivers/modesetting/dr

[PATCH 04/17] Import reallocarray() from OpenBSD

Wrapper for realloc() that checks for overflow when multiplying arguments together, so we don't have to add overflow checks to every single call. For documentation on usage, see: http://www.openbsd.org/cgi-bin/man.cgi/OpenBSD-current/man3/calloc.3 Signed-off-by: Alan Coopersmith --- configure.a

[PATCH 06/17] Add no-fail equivalents of allocarray & reallocarray

Signed-off-by: Alan Coopersmith --- include/os.h |9 + os/utils.c | 10 ++ 2 files changed, 19 insertions(+) diff --git a/include/os.h b/include/os.h index 2633741..bc624a2 100644 --- a/include/os.h +++ b/include/os.h @@ -76,6 +76,8 @@ typedef struct _NewClientRec *NewCli

[PATCH 15/17] Convert hw/xnest & hw/vfb to new *allocarray functions

Signed-off-by: Alan Coopersmith --- hw/vfb/InitOutput.c |8 hw/xnest/Color.c| 17 +++-- hw/xnest/Display.c |4 ++-- hw/xnest/GC.c |5 ++--- hw/xnest/Keyboard.c |2 +- hw/xnest/Screen.c |4 ++-- 6 files changed, 18 insertions(+), 22 deletions

[PATCH 08/17] Convert dix/* to new *allocarray functions

Signed-off-by: Alan Coopersmith --- dix/atom.c |4 +-- dix/colormap.c | 71 +++--- dix/devices.c|4 +-- dix/dispatch.c |4 +-- dix/dixfonts.c | 18 ++ dix/enterleave.c |2 +- dix/events.c |4 +-

[PATCH 05/17] Add xallocarray() helper macro

Uses reallocarray to perform integer overflow detection when allocating an array, using NULL as the previous pointer to force a new allocation. Signed-off-by: Alan Coopersmith --- include/os.h |2 ++ 1 file changed, 2 insertions(+) diff --git a/include/os.h b/include/os.h index ffa5f39..263

[PATCH 01/17] Remove remaining doc references to Xalloc, Xrealloc, and Xfree

Functions were removed in commit cad9b053d52f62432 Signed-off-by: Alan Coopersmith --- doc/Xserver-spec.xml |9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/doc/Xserver-spec.xml b/doc/Xserver-spec.xml index 4c34419..72a544b 100644 --- a/doc/Xserver-spec.xml +++ b/d

[PATCH 12/17] Convert mi & miext to new *allocarray functions

Signed-off-by: Alan Coopersmith --- mi/miarc.c | 25 +++ mi/mibitblt.c | 16 +++ mi/micmap.c |8 mi/micopy.c |4 ++-- mi/miexpose.c |2 +- mi/m

[PATCH 02/17] Let calloc handle multiplication

It's going to multiply anyway, so if we have non-constant values, might as well let it do the multiplication instead of adding another multiply, and good versions of calloc will check for & avoid overflow in the process. Signed-off-by: Alan Coopersmith --- Xext/panoramiXprocs.c |

[PATCH 09/17] Convert top level extensions to new *allocarray functions

Signed-off-by: Alan Coopersmith --- Xext/hashtable.c |4 ++-- Xext/panoramiX.c | 10 +- Xext/panoramiXprocs.c | 19 +-- Xext/saver.c |2 +- Xext/shape.c |2 +- Xext/sync.c|4 ++-- Xext

[PATCH 14/17] Convert hw/xfree86 to new *allocarray functions

Signed-off-by: Alan Coopersmith --- hw/xfree86/common/xf86AutoConfig.c |2 +- hw/xfree86/common/xf86Bus.c | 21 ++-- hw/xfree86/common/xf86Config.c | 20 +-- hw/xfree86/common/xf86Configure.c |2 +- hw/xfree86/common/xf86

[PATCH 07/17] Convert os/* to new *allocarray functions

Signed-off-by: Alan Coopersmith --- os/connection.c | 13 +++-- os/utils.c |2 +- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/os/connection.c b/os/connection.c index 7ff44e1..5dec02f 100644 --- a/os/connection.c +++ b/os/connection.c @@ -309,7 +309,7 @@ InitC

[PATCH 00/17] Improved overflow checking for memory allocations

This series of patches borrows the reallocarray() interface from OpenBSD, improves our xcalloc interfaces, and generally cleans up our array memory allocation code to check calculations for memory allocations do not have integer overflows in several more places than we previously checked. Most of

[PATCH 17/17] Convert hw/dmx to new *allocarray functions

Signed-off-by: Alan Coopersmith --- hw/dmx/config/dmxconfig.c| 10 +- hw/dmx/dmx.c | 10 +- hw/dmx/dmxcmap.c |2 +- hw/dmx/dmxcursor.c |2 +- hw/dmx/dmxextension.c|4 ++-- hw/dmx/dmxfont.c |6 +++---

[PATCH 03/17] Add XNFcallocarray() to allow xnfcalloc() to check for overflow

The xnfcalloc() macro took two arguments but simply multiplied them together without checking for overflow and defeating any overflow checking that calloc() might have done. Let's not do that. The original XNFcalloc() function is left for now to preserve driver ABI, but is marked as deprecated so

[PATCH 11/17] Convert exa & fb to new *allocarray functions

Signed-off-by: Alan Coopersmith --- exa/exa_accel.c |8 exa/exa_glyphs.c |4 ++-- exa/exa_migration_mixed.c |4 ++-- fb/fbcopy.c |2 +- fb/fbpict.c |2 +- 5 files changed, 10 insertions(+), 10 deletions(-) diff --git a/e

[PATCH 10/17] Convert XKB to new *allocarray functions

Signed-off-by: Alan Coopersmith --- xkb/XKBAlloc.c | 14 +- xkb/XKBGAlloc.c |2 +- xkb/XKBMAlloc.c | 47 - xkb/maprules.c | 12 - xkb/xkb.c| 32 +++ xkb/xkbActions.c |4 +-- xkb/xkbUtils.c | 76 +

[PATCH 16/17] Convert hw/kdrive to new *allocarray functions

Signed-off-by: Alan Coopersmith --- hw/kdrive/ephyr/ephyrdriext.c |4 ++-- hw/kdrive/ephyr/hostx.c | 14 +++--- hw/kdrive/fake/fake.c |2 +- hw/kdrive/fbdev/fbdev.c |2 +- hw/kdrive/src/kshadow.c |2 +- hw/kdrive/src/kxv.c |4 ++--

[PATCH 13/17] Convert glamor & glx to new *allocarray functions

Signed-off-by: Alan Coopersmith --- glamor/glamor_compositerects.c |2 +- glamor/glamor_glyphs.c |2 +- glamor/glamor_gradient.c |8 glamor/glamor_pixmap.c |4 ++-- glamor/glamor_prepare.c|4 ++-- glamor/glamor_utils.c |2 +-

[PATCH] xfree86: attempt to autoconfig gpu slave devices (v3)

From: Dave Airlie This allows us to skip the screen section, the first Device section will get assigned to the screen, any remaining ones will get assigned to the GPUDevice sections for the screen. v2: fix the skipping unsuitable screen logic (Aaron) v3: fix segfault if not conf file (me, 5s aft

Re: [PATCH 11/17] Convert exa & fb to new *allocarray functions

On 01.04.2015 09:50, Alan Coopersmith wrote: > @@ -667,7 +667,7 @@ exaPolylines(DrawablePtr pDrawable, GCPtr pGC, int mode, > int npt, > return; > } > > -prect = malloc(sizeof(xRectangle) * (npt - 1)); > +prect = xallocarray(npt -1, sizeof(xRectangle)); 'npt - 1' > @@ -1

Re: [PATCH 13/17] Convert glamor & glx to new *allocarray functions

On 01.04.2015 09:50, Alan Coopersmith wrote: > diff --git a/glamor/glamor_utils.c b/glamor/glamor_utils.c > index f068960..1c32cab 100644 > --- a/glamor/glamor_utils.c > +++ b/glamor/glamor_utils.c > @@ -31,7 +31,7 @@ glamor_solid_boxes(PixmapPtr pixmap, > xRectangle *rect; > int n; > >

Re: [PATCH 06/17] Add no-fail equivalents of allocarray & reallocarray

On Tue, Mar 31, 2015 at 5:50 PM, Alan Coopersmith wrote: > Signed-off-by: Alan Coopersmith > --- > include/os.h |9 + > os/utils.c | 10 ++ > 2 files changed, 19 insertions(+) > > diff --git a/include/os.h b/include/os.h > index 2633741..bc624a2 100644 > --- a/include/os.

Re: [PATCH 07/17] Convert os/* to new *allocarray functions

On Tue, Mar 31, 2015 at 5:50 PM, Alan Coopersmith wrote: > Signed-off-by: Alan Coopersmith > --- > os/connection.c | 13 +++-- > os/utils.c |2 +- > 2 files changed, 8 insertions(+), 7 deletions(-) > > diff --git a/os/connection.c b/os/connection.c > index 7ff44e1..5dec02f 100

Re: [PATCH 08/17] Convert dix/* to new *allocarray functions

On Tue, Mar 31, 2015 at 5:50 PM, Alan Coopersmith wrote: > Signed-off-by: Alan Coopersmith > --- > dix/atom.c |4 +-- > dix/colormap.c | 71 > +++--- > dix/devices.c|4 +-- > dix/dispatch.c |4 +-- > dix/dixfonts.c |

Re: [PATCH 12/17] Convert mi & miext to new *allocarray functions

On Tue, Mar 31, 2015 at 5:50 PM, Alan Coopersmith wrote: > Signed-off-by: Alan Coopersmith > --- > mi/miarc.c | 25 +++ > mi/mibitblt.c | 16 +++ > mi/micmap.c |8 > mi/micopy.c

Re: [PATCH 00/17] Improved overflow checking for memory allocations

On Tue, Mar 31, 2015 at 5:50 PM, Alan Coopersmith wrote: > This series of patches borrows the reallocarray() interface from OpenBSD, > improves our xcalloc interfaces, and generally cleans up our array memory > allocation code to check calculations for memory allocations do not have > integer over

Re: [PATCH 00/17] Improved overflow checking for memory allocations

On 03/31/15 08:23 PM, Matt Turner wrote: I suspect you did most of this with Coccinelle, That would have been smart, one of these days I should install Coccinelle and learn to use it. Fortunately, this wasn't an overwhelming number to change by hand. but I definitely noticed an attention to

[PATCH 2/3] xf86Crtc: setup tiled monitors correctly in right of

From: Dave Airlie This puts the tiles of the monitor in the right place at X server startup. Signed-off-by: Dave Airlie --- hw/xfree86/modes/xf86Crtc.c | 62 + 1 file changed, 62 insertions(+) diff --git a/hw/xfree86/modes/xf86Crtc.c b/hw/xfree86/mo

[PATCH 1/3] xf86Crtc: right-of placement by default.

From: Adam Jackson Change the X server default to do right-of placement at startup. This gives an option to allow drivers to override this placement, which has been used for server drivers where both heads are not in the same physical place. Been in Fedora for a few years, but for tiled monitors

[PATCH 3/3] xf86Crtc/monitors: create initial monitors for tiled outputs

From: Dave Airlie This creates an automatic monitor for a tiled monitor at startup. Signed-off-by: Dave Airlie --- hw/xfree86/modes/xf86RandR12.c | 66 ++ randr/randrstr.h | 9 ++ randr/rrmonitor.c | 6 ++-- 3 files chang