When xf86RandR12Key is not set we will not get to the places where
these tests are done as the functions in question are not called.
In most cases we would have crashed before these checks anyway.
Signed-off-by: Egbert Eich
---
hw/xfree86/modes/xf86RandR12.c | 13 -
1 file changed, 4
From: Dave Airlie
This allows gpu devices to be specified in xorg.conf Screen sections.
Section "Device"
Driver "intel"
Identifier "intel0"
Option "AccelMethod" "uxa"
EndSection
Section "Device"
Driver "modesetting"
Identifier "usb0"
EndSection
Section "
From: Dave Airlie
This allows us to skip the screen section, the first
Device section will get assigned to the screen,
any remaining ones will get assigned to the GPUDevice
sections for the screen.
Signed-off-by: Dave Airlie
---
hw/xfree86/common/xf86Config.c | 31 ++---
This is something I meant to do ages ago and failed,
it adds a GPUDevice to the Screen section for specifying GPU
devices to be attached to the screen.
There is a second patch to try and autoconfigure things a bit
better.
Dave.
___
xorg-devel@lists.x.or
These are fixes for issues I ran into when looking into an
issue with Xephyr on IBM z-Series.
Actually only the last one is related to be->le. The others
however were unveiled by this special use case.
Egbert Eich (5):
Xephyr: Don't crash when no command line argument is specified
Xephyr: Prin
The image is created in the native byte order of the machine Xephyr is
rendered on however drawn in the image byte order of the Xephyr server.
Correct byte order in the xcb_image_t structure and convert to native
before updating the window.
If depths of Xephyr and host server differ this is already
Signed-off-by: Egbert Eich
---
hw/kdrive/ephyr/hostx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/kdrive/ephyr/hostx.c b/hw/kdrive/ephyr/hostx.c
index c67ff60..a516c20 100644
--- a/hw/kdrive/ephyr/hostx.c
+++ b/hw/kdrive/ephyr/hostx.c
@@ -177,7 +177,7 @@ hostx_set_win_
From: Egbert Eich
The DDX specific command line parsing function only gets called
if command line arguments are present. Therefore this function
is not suitable to initialize mandatory global variables.
Replace main() instead.
Signed-off-by: Egbert Eich
---
configure.ac| 4 +++
xcb_image_put() prints the entire image, therefore don't use an offset.
Signed-off-by: Egbert Eich
---
hw/kdrive/ephyr/hostx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/kdrive/ephyr/hostx.c b/hw/kdrive/ephyr/hostx.c
index bdffba9..99b7716 100644
--- a/hw/kdrive/ephyr
Signed-off-by: Egbert Eich
---
hw/kdrive/ephyr/hostx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/kdrive/ephyr/hostx.c b/hw/kdrive/ephyr/hostx.c
index a516c20..bdffba9 100644
--- a/hw/kdrive/ephyr/hostx.c
+++ b/hw/kdrive/ephyr/hostx.c
@@ -798,7 +798,7 @@ hostx_screen_i
On Tue, Mar 31, 2015 at 01:47:26PM +1000, Dave Airlie wrote:
> From: Dave Airlie
>
> This adds tiling support to the server modesetting driver,
> it retrieves the tile info from the kernel and translates
> it into the server format and exposes the property.
>
> Signed-off-by: Dave Airlie
> ---
On Tue, Mar 31, 2015 at 10:07:53AM +0100, Chris Wilson wrote:
> On Tue, Mar 31, 2015 at 01:47:26PM +1000, Dave Airlie wrote:
> > From: Dave Airlie
> >
> > This adds tiling support to the server modesetting driver,
> > it retrieves the tile info from the kernel and translates
> > it into the serve
Hi Christian,
On 27/03/15 15:50, Olivier Fourdan wrote:
On 21/03/15 15:32, Christian Linhart wrote:
[...]
I am not a libX11 maintainer, so it's not really a review or anything,
it's just some comments :-)
So I looked further into your patch (took me some time!) and came to the
following idea
On 31/03/2015 01:06, Jeremy Huddleston Sequoia wrote:
One additional change needed (see below). Please squash that in and then you
can tag it:
Reviewed-by: Jeremy Huddleston Sequoia
Tested-by: Jeremy Huddleston Sequoia
Hi Keith,
Please apply this patch to master.
Thanks
From 146cec4a78
Hi Dave,
On 31/03/15 07:12, Dave Airlie wrote:
> From: Dave Airlie
>
> This allows gpu devices to be specified in xorg.conf Screen sections.
>
> Section "Device"
> Driver "intel"
> Identifier "intel0"
> Option "AccelMethod" "uxa"
> EndSection
>
> Section "Device"
>
Egbert Eich writes:
> When xf86RandR12Key is not set we will not get to the places where
> these tests are done as the functions in question are not called.
> In most cases we would have crashed before these checks anyway.
This is really hard to review, and that's almost entirely my fault...
xf
Jon TURNEY writes:
> Subject: [PATCH] Fix XQuartz build
>
> Fix XQuartz build since commit e036cbfc "Make PseudoramiXExtensionInit()
> prototype more generally available"
Merged.
7088816..d3b9c47 master -> master
--
-keith
signature.asc
Description: PGP signature
Dave Airlie writes:
> Dave Airlie (1):
> xf86Crtc: add tile prop setting
>
> Keith Packard (2):
> randr: Add Monitor support (v1.1)
> randr: Use Monitor list for Xinerama
Merged.
d3b9c47..e608f35 master -> master
--
-keith
signature.asc
Description: PGP signature
__
This is the v2 of patch series which provides some missing parts
for full single-GPU multiseat support in Xephyr. This version fixes
some problems found in v1, like double-free errors for some InputOption
objects, and memory corruptions when a USB keyboard or mouse is unplugged
and replugged severa
This patch simplifies NewInputDeviceRequest() implementation
in kinput.c, making use of improved KdParseKbdOptions()/KdParsePointerOptions()
and merging several "if (ki)"/"if (pi)" clauses.
Signed-off-by: Laércio de Sousa
---
hw/kdrive/src/kinput.c | 76 --
If kdrive input driver "evdev" is available, no other driver was explicitly
set for a given input device, and its kernel device node is /dev/input/event*,
this patch will make kdrive set "evdev" driver automatically for such device.
Signed-off-by: Laércio de Sousa
---
hw/kdrive/src/kinput.c | 25
This patch introduces a command-line option -input-hotplug for kdrive-based
applications, which can be used to enable input hotplugging support, instead
of passing explicit -keybd and/or -mouse options.
It supports udev and hal backends for input hotplugging support.
Another patches may be require
This patch introduces two command-line options for Xephyr:
* -host-display: set Xephyr DISPLAY environment variable
to host X server display number
* -host-auth:set Xephyr XAUTHORITY environment variable
to host X server authorization file path
These
This is a trivial patch that moves host_has_extension() implementation
from ephyr.c to hostx.c so that it can be called by hostx.c internal
functions. Also rename function to hostx_has_extension() for consistency.
Signed-off-by: Laércio de Sousa
---
hw/kdrive/ephyr/ephyr.c | 12 +--
This patch introduces convenient command-line options -xkbrules,
-xkbmodel, -xkblayout, -xkbvariant, and -xkboptions, to set default
values for these properties.
These options can be handful in cases where corresponding values can't
be taken from devices' udev properties, and compile-time default
Multiseat-capable display managers commonly pass command-line options
like "-sharevts" or "-layout seat" to Xorg server, but Xephyr
currently refuses to start if these options are passed to it,
which may break Xephyr-based single-GPU multiseat setups.
Signed-off-by: Laércio de Sousa
---
hw/k
From: Mikhail Krivtsov
When one hits {Num,Caps,Scroll}Lock key on a Xephyr's keyboard,
keyboard itself works as expected but LEDs are not updated
and always stay in off.
Currently logical LEDs are propagated to physical keyboard LEDs
for "CoreKeyboard" only. All "kdrive" keyboards are not
"CoreK
On 03/31/2015 12:12 AM, Dave Airlie wrote:
From: Dave Airlie
This allows gpu devices to be specified in xorg.conf Screen sections.
Section "Device"
Driver "intel"
Identifier "intel0"
Option "AccelMethod" "uxa"
EndSection
Section "Device"
Driver "modesetting
On 03/31/2015 12:12 AM, Dave Airlie wrote:
From: Dave Airlie
This allows us to skip the screen section, the first
Device section will get assigned to the screen,
any remaining ones will get assigned to the GPUDevice
sections for the screen.
Signed-off-by: Dave Airlie
---
hw/xfree86/common/x
> From: Dave Airlie
> Date: Tue, 31 Mar 2015 17:12:28 +1000
>
> This should allow for easier tweaking of driver options which
> currently mess up the GPU device discovery process.
Sorry, not a real review, but:
> diff --git a/hw/xfree86/common/xf86Config.c b/hw/xfree86/common/xf86Config.c
> ind
These fixes were reviewed by Maarten.
The following changes since commit e608f3521eaaab972a3eea62aa04a65958351c1c:
Merge remote-tracking branch 'airlied/for-keithp' (2015-03-31 09:06:08 -0700)
are available in the git repository at:
git://people.freedesktop.org/~aplattner/xserver for-keith
Aaron Plattner writes:
> Aaron Plattner (2):
> xfree86: Fix xf86_check_platform_slot's handling of PCI
> xfree86: Add GPU screens even if there are no active GDevs
Merged.
e608f35..e36236e master -> master
--
-keith
signature.asc
Description: PGP signature
___
From: Dave Airlie
This allows gpu devices to be specified in xorg.conf Screen sections.
Section "Device"
Driver "intel"
Identifier "intel0"
Option "AccelMethod" "uxa"
EndSection
Section "Device"
Driver "modesetting"
Identifier "usb0"
EndSection
Section "
From: Dave Airlie
This allows us to skip the screen section, the first
Device section will get assigned to the screen,
any remaining ones will get assigned to the GPUDevice
sections for the screen.
v2: fix the skipping unsuitable screen logic (Aaron)
Signed-off-by: Dave Airlie
---
hw/xfree86/
From: Dave Airlie
This allows gpu devices to be specified in xorg.conf Screen sections.
Section "Device"
Driver "intel"
Identifier "intel0"
Option "AccelMethod" "uxa"
EndSection
Section "Device"
Driver "modesetting"
Identifier "usb0"
EndSection
Section "
From: Dave Airlie
This adds tiling support to the server modesetting driver,
it retrieves the tile info from the kernel and translates
it into the server format and exposes the property.
v2.1: fix resetting tile property (Chris)
Signed-off-by: Dave Airlie
---
hw/xfree86/drivers/modesetting/dr
Wrapper for realloc() that checks for overflow when multiplying
arguments together, so we don't have to add overflow checks to
every single call. For documentation on usage, see:
http://www.openbsd.org/cgi-bin/man.cgi/OpenBSD-current/man3/calloc.3
Signed-off-by: Alan Coopersmith
---
configure.a
Signed-off-by: Alan Coopersmith
---
include/os.h |9 +
os/utils.c | 10 ++
2 files changed, 19 insertions(+)
diff --git a/include/os.h b/include/os.h
index 2633741..bc624a2 100644
--- a/include/os.h
+++ b/include/os.h
@@ -76,6 +76,8 @@ typedef struct _NewClientRec *NewCli
Signed-off-by: Alan Coopersmith
---
hw/vfb/InitOutput.c |8
hw/xnest/Color.c| 17 +++--
hw/xnest/Display.c |4 ++--
hw/xnest/GC.c |5 ++---
hw/xnest/Keyboard.c |2 +-
hw/xnest/Screen.c |4 ++--
6 files changed, 18 insertions(+), 22 deletions
Signed-off-by: Alan Coopersmith
---
dix/atom.c |4 +--
dix/colormap.c | 71 +++---
dix/devices.c|4 +--
dix/dispatch.c |4 +--
dix/dixfonts.c | 18 ++
dix/enterleave.c |2 +-
dix/events.c |4 +-
Uses reallocarray to perform integer overflow detection when allocating
an array, using NULL as the previous pointer to force a new allocation.
Signed-off-by: Alan Coopersmith
---
include/os.h |2 ++
1 file changed, 2 insertions(+)
diff --git a/include/os.h b/include/os.h
index ffa5f39..263
Functions were removed in commit cad9b053d52f62432
Signed-off-by: Alan Coopersmith
---
doc/Xserver-spec.xml |9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/doc/Xserver-spec.xml b/doc/Xserver-spec.xml
index 4c34419..72a544b 100644
--- a/doc/Xserver-spec.xml
+++ b/d
Signed-off-by: Alan Coopersmith
---
mi/miarc.c | 25 +++
mi/mibitblt.c | 16 +++
mi/micmap.c |8
mi/micopy.c |4 ++--
mi/miexpose.c |2 +-
mi/m
It's going to multiply anyway, so if we have non-constant values, might
as well let it do the multiplication instead of adding another multiply,
and good versions of calloc will check for & avoid overflow in the process.
Signed-off-by: Alan Coopersmith
---
Xext/panoramiXprocs.c |
Signed-off-by: Alan Coopersmith
---
Xext/hashtable.c |4 ++--
Xext/panoramiX.c | 10 +-
Xext/panoramiXprocs.c | 19 +--
Xext/saver.c |2 +-
Xext/shape.c |2 +-
Xext/sync.c|4 ++--
Xext
Signed-off-by: Alan Coopersmith
---
hw/xfree86/common/xf86AutoConfig.c |2 +-
hw/xfree86/common/xf86Bus.c | 21 ++--
hw/xfree86/common/xf86Config.c | 20 +--
hw/xfree86/common/xf86Configure.c |2 +-
hw/xfree86/common/xf86
Signed-off-by: Alan Coopersmith
---
os/connection.c | 13 +++--
os/utils.c |2 +-
2 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/os/connection.c b/os/connection.c
index 7ff44e1..5dec02f 100644
--- a/os/connection.c
+++ b/os/connection.c
@@ -309,7 +309,7 @@ InitC
This series of patches borrows the reallocarray() interface from OpenBSD,
improves our xcalloc interfaces, and generally cleans up our array memory
allocation code to check calculations for memory allocations do not have
integer overflows in several more places than we previously checked.
Most of
Signed-off-by: Alan Coopersmith
---
hw/dmx/config/dmxconfig.c| 10 +-
hw/dmx/dmx.c | 10 +-
hw/dmx/dmxcmap.c |2 +-
hw/dmx/dmxcursor.c |2 +-
hw/dmx/dmxextension.c|4 ++--
hw/dmx/dmxfont.c |6 +++---
The xnfcalloc() macro took two arguments but simply multiplied them
together without checking for overflow and defeating any overflow
checking that calloc() might have done. Let's not do that.
The original XNFcalloc() function is left for now to preserve driver
ABI, but is marked as deprecated so
Signed-off-by: Alan Coopersmith
---
exa/exa_accel.c |8
exa/exa_glyphs.c |4 ++--
exa/exa_migration_mixed.c |4 ++--
fb/fbcopy.c |2 +-
fb/fbpict.c |2 +-
5 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/e
Signed-off-by: Alan Coopersmith
---
xkb/XKBAlloc.c | 14 +-
xkb/XKBGAlloc.c |2 +-
xkb/XKBMAlloc.c | 47 -
xkb/maprules.c | 12 -
xkb/xkb.c| 32 +++
xkb/xkbActions.c |4 +--
xkb/xkbUtils.c | 76 +
Signed-off-by: Alan Coopersmith
---
hw/kdrive/ephyr/ephyrdriext.c |4 ++--
hw/kdrive/ephyr/hostx.c | 14 +++---
hw/kdrive/fake/fake.c |2 +-
hw/kdrive/fbdev/fbdev.c |2 +-
hw/kdrive/src/kshadow.c |2 +-
hw/kdrive/src/kxv.c |4 ++--
Signed-off-by: Alan Coopersmith
---
glamor/glamor_compositerects.c |2 +-
glamor/glamor_glyphs.c |2 +-
glamor/glamor_gradient.c |8
glamor/glamor_pixmap.c |4 ++--
glamor/glamor_prepare.c|4 ++--
glamor/glamor_utils.c |2 +-
From: Dave Airlie
This allows us to skip the screen section, the first
Device section will get assigned to the screen,
any remaining ones will get assigned to the GPUDevice
sections for the screen.
v2: fix the skipping unsuitable screen logic (Aaron)
v3: fix segfault if not conf file (me, 5s aft
On 01.04.2015 09:50, Alan Coopersmith wrote:
> @@ -667,7 +667,7 @@ exaPolylines(DrawablePtr pDrawable, GCPtr pGC, int mode,
> int npt,
> return;
> }
>
> -prect = malloc(sizeof(xRectangle) * (npt - 1));
> +prect = xallocarray(npt -1, sizeof(xRectangle));
'npt - 1'
> @@ -1
On 01.04.2015 09:50, Alan Coopersmith wrote:
> diff --git a/glamor/glamor_utils.c b/glamor/glamor_utils.c
> index f068960..1c32cab 100644
> --- a/glamor/glamor_utils.c
> +++ b/glamor/glamor_utils.c
> @@ -31,7 +31,7 @@ glamor_solid_boxes(PixmapPtr pixmap,
> xRectangle *rect;
> int n;
>
>
On Tue, Mar 31, 2015 at 5:50 PM, Alan Coopersmith
wrote:
> Signed-off-by: Alan Coopersmith
> ---
> include/os.h |9 +
> os/utils.c | 10 ++
> 2 files changed, 19 insertions(+)
>
> diff --git a/include/os.h b/include/os.h
> index 2633741..bc624a2 100644
> --- a/include/os.
On Tue, Mar 31, 2015 at 5:50 PM, Alan Coopersmith
wrote:
> Signed-off-by: Alan Coopersmith
> ---
> os/connection.c | 13 +++--
> os/utils.c |2 +-
> 2 files changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/os/connection.c b/os/connection.c
> index 7ff44e1..5dec02f 100
On Tue, Mar 31, 2015 at 5:50 PM, Alan Coopersmith
wrote:
> Signed-off-by: Alan Coopersmith
> ---
> dix/atom.c |4 +--
> dix/colormap.c | 71
> +++---
> dix/devices.c|4 +--
> dix/dispatch.c |4 +--
> dix/dixfonts.c |
On Tue, Mar 31, 2015 at 5:50 PM, Alan Coopersmith
wrote:
> Signed-off-by: Alan Coopersmith
> ---
> mi/miarc.c | 25 +++
> mi/mibitblt.c | 16 +++
> mi/micmap.c |8
> mi/micopy.c
On Tue, Mar 31, 2015 at 5:50 PM, Alan Coopersmith
wrote:
> This series of patches borrows the reallocarray() interface from OpenBSD,
> improves our xcalloc interfaces, and generally cleans up our array memory
> allocation code to check calculations for memory allocations do not have
> integer over
On 03/31/15 08:23 PM, Matt Turner wrote:
I suspect you did most of this with Coccinelle,
That would have been smart, one of these days I should install Coccinelle
and learn to use it. Fortunately, this wasn't an overwhelming number to
change by hand.
but I definitely
noticed an attention to
From: Dave Airlie
This puts the tiles of the monitor in the right place at
X server startup.
Signed-off-by: Dave Airlie
---
hw/xfree86/modes/xf86Crtc.c | 62 +
1 file changed, 62 insertions(+)
diff --git a/hw/xfree86/modes/xf86Crtc.c b/hw/xfree86/mo
From: Adam Jackson
Change the X server default to do right-of placement
at startup. This gives an option to allow drivers to
override this placement, which has been used for server
drivers where both heads are not in the same physical
place.
Been in Fedora for a few years, but for tiled monitors
From: Dave Airlie
This creates an automatic monitor for a tiled monitor at startup.
Signed-off-by: Dave Airlie
---
hw/xfree86/modes/xf86RandR12.c | 66 ++
randr/randrstr.h | 9 ++
randr/rrmonitor.c | 6 ++--
3 files chang
66 matches
Mail list logo