Re: [RESEND: PATCH 2/2] Remove empty stub of $host_cpu case statement in configure.ac

Both patches: Reviewed-by: Thomas Klausner On Thu, Apr 16, 2015 at 06:51:31PM -0700, Alan Coopersmith wrote: > Left behind when commit 5c12399b6c3a8d moved the xorg_bus_* settings > elsewhere. > > Signed-off-by: Alan Coopersmith > --- > configure.ac |5 - > 1 file changed, 5 deletions

[PATCH:lbxproxy] Ensure lbxMaxServers stays within a reasonable range

Avoid opportunity for integer overflow when allocating servers array. Signed-off-by: Alan Coopersmith --- di/utils.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/di/utils.c b/di/utils.c index 7f7aa46..752d913 100644 --- a/di/utils.c +++ b/di/utils.c @@ -392,7 +392,11 @@ proxyProc

[RESEND: PATCH 1/2] Accept x86_64 as well as i*86 for $host_cpu in Solaris on x86

Needed when using a compiler that defaults to 64-bit output when configure is checking for $host_cpu. Signed-off-by: Alan Coopersmith --- configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index a5bdbbf..3028e12 100644 --- a/configure.

[RESEND: PATCH 2/2] Remove empty stub of $host_cpu case statement in configure.ac

Left behind when commit 5c12399b6c3a8d moved the xorg_bus_* settings elsewhere. Signed-off-by: Alan Coopersmith --- configure.ac |5 - 1 file changed, 5 deletions(-) diff --git a/configure.ac b/configure.ac index 3028e12..fc15460 100644 --- a/configure.ac +++ b/configure.ac @@ -2006,11

[PATCH v2 09/17] Convert top level extensions to new *allocarray functions

v2: remove now useless parentheses Signed-off-by: Alan Coopersmith Reviewed-by: Matt Turner --- Xext/hashtable.c |4 ++-- Xext/panoramiX.c | 10 +- Xext/panoramiXprocs.c | 19 +-- Xext/saver.c |2 +- Xext/shape.c

[PATCH v2 15/17] Convert hw/xnest & hw/vfb to new *allocarray functions

Signed-off-by: Alan Coopersmith Reviewed-by: Matt Turner --- hw/vfb/InitOutput.c |8 hw/xnest/Color.c| 17 +++-- hw/xnest/Display.c |4 ++-- hw/xnest/GC.c |5 ++--- hw/xnest/Keyboard.c |2 +- hw/xnest/Screen.c |4 ++-- 6 files changed, 18 i

[PATCH v2 10/17] Convert XKB to new *allocarray functions

Signed-off-by: Alan Coopersmith Reviewed-by: Matt Turner --- xkb/XKBAlloc.c | 14 +- xkb/XKBGAlloc.c |2 +- xkb/XKBMAlloc.c | 47 - xkb/maprules.c | 12 - xkb/xkb.c| 32 +++ xkb/xkbActions.c |4 +--

[PATCH v2 17/17] Convert hw/dmx to new *allocarray functions

Signed-off-by: Alan Coopersmith Reviewed-by: Matt Turner --- hw/dmx/config/dmxconfig.c| 10 +- hw/dmx/dmx.c | 10 +- hw/dmx/dmxcmap.c |2 +- hw/dmx/dmxcursor.c |2 +- hw/dmx/dmxextension.c|4 ++-- hw/dmx/dmxfont.c

[PATCH v2 05/17] Add xallocarray() helper macro

Uses reallocarray to perform integer overflow detection when allocating an array, using NULL as the previous pointer to force a new allocation. Signed-off-by: Alan Coopersmith Reviewed-by: Matt Turner --- include/os.h |2 ++ 1 file changed, 2 insertions(+) diff --git a/include/os.h b/inclu

[PATCH v2 11/17] Convert exa & fb to new *allocarray functions

v2: fixup whitespace Signed-off-by: Alan Coopersmith Reviewed-by: Matt Turner Reviewed-by: Michel Dänzer --- exa/exa_accel.c |8 exa/exa_glyphs.c |4 ++-- exa/exa_migration_mixed.c |4 ++-- fb/fbcopy.c |2 +- fb/fbpict.c |

[PATCH v2 14/17] Convert hw/xfree86 to new *allocarray functions

Signed-off-by: Alan Coopersmith Reviewed-by: Matt Turner --- hw/xfree86/common/xf86AutoConfig.c |2 +- hw/xfree86/common/xf86Bus.c | 21 ++-- hw/xfree86/common/xf86Config.c | 20 +-- hw/xfree86/common/xf86Configure.c |2

[PATCH v2 13/17] Convert glamor & glx to new *allocarray functions

v2: fixup whitespace Signed-off-by: Alan Coopersmith Reviewed-by: Matt Turner Reviewed-by: Michel Dänzer --- glamor/glamor_compositerects.c |2 +- glamor/glamor_glyphs.c |2 +- glamor/glamor_gradient.c |8 glamor/glamor_pixmap.c |4 ++-- glamor/gl

[PATCH v2 07/17] Convert os/* to new *allocarray functions

v2: remove now useless parentheses Signed-off-by: Alan Coopersmith Reviewed-by: Matt Turner --- os/connection.c | 13 +++-- os/utils.c |2 +- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/os/connection.c b/os/connection.c index 7ff44e1..c36b125 100644 --- a/o

[PATCH v2 00/17] Improved overflow checking for memory allocations

v2 includes the style fixes suggested after the previous round of review. Alan Coopersmith (17): Remove remaining doc references to Xalloc, Xrealloc, and Xfree Let calloc handle multiplication Add XNFcallocarray() to allow xnfcalloc() to check for overflow Import reallocarray() from OpenBS

[PATCH v2 01/17] Remove remaining doc references to Xalloc, Xrealloc, and Xfree

Functions were removed in commit cad9b053d52f62432 Signed-off-by: Alan Coopersmith Reviewed-by: Matt Turner --- doc/Xserver-spec.xml |9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/doc/Xserver-spec.xml b/doc/Xserver-spec.xml index 4c34419..72a544b 100644 --- a/do

[PATCH v2 04/17] Import reallocarray() from OpenBSD

Wrapper for realloc() that checks for overflow when multiplying arguments together, so we don't have to add overflow checks to every single call. For documentation on usage, see: http://www.openbsd.org/cgi-bin/man.cgi/OpenBSD-current/man3/calloc.3 Signed-off-by: Alan Coopersmith Acked-by: Matt T

[PATCH v2 06/17] Add no-fail equivalents of allocarray & reallocarray

v2: Remove extra 's' from comment Signed-off-by: Alan Coopersmith Reviewed-by: Matt Turner --- include/os.h |9 + os/utils.c | 10 ++ 2 files changed, 19 insertions(+) diff --git a/include/os.h b/include/os.h index 2633741..6638c84 100644 --- a/include/os.h +++ b/includ

[PATCH v2 16/17] Convert hw/kdrive to new *allocarray functions

Signed-off-by: Alan Coopersmith Reviewed-by: Matt Turner --- hw/kdrive/ephyr/ephyrdriext.c |4 ++-- hw/kdrive/ephyr/hostx.c | 14 +++--- hw/kdrive/fake/fake.c |2 +- hw/kdrive/fbdev/fbdev.c |2 +- hw/kdrive/src/kshadow.c |2 +- hw/kdrive/src/kx

[PATCH v2 02/17] Let calloc handle multiplication

It's going to multiply anyway, so if we have non-constant values, might as well let it do the multiplication instead of adding another multiply, and good versions of calloc will check for & avoid overflow in the process. Signed-off-by: Alan Coopersmith Reviewed-by: Matt Turner --- Xext/panorami

[PATCH v2 12/17] Convert mi & miext to new *allocarray functions

v2: remove now useless parentheses Signed-off-by: Alan Coopersmith Reviewed-by: Matt Turner --- mi/miarc.c | 25 +++ mi/mibitblt.c | 16 +++ mi/micmap.c |8 mi/micopy.c

[PATCH v2 08/17] Convert dix/* to new *allocarray functions

v2: remove now useless parentheses Signed-off-by: Alan Coopersmith Reviewed-by: Matt Turner --- dix/atom.c |4 +-- dix/colormap.c | 71 +++--- dix/devices.c|4 +-- dix/dispatch.c |4 +-- dix/dixfonts.c | 18 ++--

[PATCH v2 03/17] Add XNFcallocarray() to allow xnfcalloc() to check for overflow

The xnfcalloc() macro took two arguments but simply multiplied them together without checking for overflow and defeating any overflow checking that calloc() might have done. Let's not do that. The original XNFcalloc() function is left for now to preserve driver ABI, but is marked as deprecated so

[PATCH 2/2] systemd-logind: don't second guess D-Bus default timeout

At the moment, the X server uses a non-default timeout for D-Bus messages to systemd-logind. The only timeouts normally used with D-Bus are: 1) Infinite 2) Default Anything else is just as arbitrary as Default, and so rarely makes sense to use instead of Default. Put another way, there's little

[PATCH 1/2] systemd-logind: filter out non-signal messages from message filter

It's possible to receive a message reply in the message filter if a previous message call timed out locally before the reply arrived. The message_filter function only handles signals, at the moment, and does not properly handle message replies. This commit changes the message_filter function to f

[RFC PATCH] mi: reduce missing segments on large ellipse

With larger ellipses, rounding will cause some spans close to vertical tangent to be of zero length, leading to sometimes rather large missing portion of the arc. Try to detect this case and work around it. Signed-off-by: Olivier Fourdan --- mi/miarc.c | 10 ++ 1 file changed, 10 insert

[RFC PATCH] mi: reduce missing segments on large ellipse

When using large values for width/height (> 5000) arcs, the values of inx and outx in miComputeEllipseSpans() gets so close that the spans lw and rw get down to 0, meaning that no pixel will be drawn on screen. lines 566 to 578 in mi/miarc.c from miComputeEllipseSpans() span->lx = ICEIL(x

RE: [X11] Question about TouchCancel event like ACTION_CANCEL in android

> From: Peter Hutterer [mailto:peter.hutte...@who-t.net] > Sent: Thursday, April 16, 2015 4:38 PM > Cc: xorg-devel@lists.x.org > Subject: Re: [X11] Question about TouchCancel event like ACTION_CANCEL in > android > > On Thu, Apr 16, 2015 at 03:50:41PM +0900,wrote: > > Hello, Peter Hutterer

Re: [PULL] randr cleanups et al

Humble ping ? On 9 April 2015 at 15:49, Emil Velikov wrote: > Silly me forgot to add Keith to the Cc list. > > Keith can you consider the pull request below. > > Thanks > Emil > > > On 24 March 2015 at 17:52, Emil Velikov wrote: >> Hi Keith, >> >> Various patches from me. >> >> Please consider p

Re: [X11] Question about TouchCancel event like ACTION_CANCEL in android

On Thu, Apr 16, 2015 at 03:50:41PM +0900, �� wrote: > Hello, Peter Hutterer. > > I��m planning to add a ��Event cancel��(Touch Cancel?) event in x11 > protocol. > > Like below article I want to send a event to apps for notification about > current events are canceled!. > > > > How/What I