Re: [PATCH 2/7] Add 'likely' and 'unlikely' macros

2015-05-14 Thread Alan Coopersmith
On 05/12/15 11:02 PM, Keith Packard wrote: walter harms writes: Just for my curiosity .. is there any benchmark that shows that this actually improves something Yeah, I was measuring the new text code during development and saw some (tiny) improvements -- it's got a ton of branches in an inn

Re: [PATCH] Revert "glx/dri2: Disable AIGLX if indirect GLX is disabled"

2015-05-14 Thread Keith Packard
Michel Dänzer writes: > On 15.05.2015 07:51, Keith Packard wrote: >> This reverts commit d61ae18074e53c2cdfb13cc37693b526160d6ca7. >> >> If the DRI2 provider is disabled, then we don't advertise the correct >> GLX extensions to clients, and things like GLES fail. >> >> Reviewed-by: Eric Anholt

Re: [PATCH xwayland] xwayland: do not add output into output_list multiple times

2015-05-14 Thread Dima Ryazanov
Oh wow, I was playing around with outputs, and never realized output_handle_done was being called after any geometry change, not just after the output was created. On Thu, May 14, 2015 at 2:58 AM, Marek Chalupa wrote: > output.done event can be sent even on some property change, not only > when

Re: [PATCH xwayland] xwayland: do not add output into output_list multiple times

2015-05-14 Thread Dima Ryazanov
Actually, why not just move "xorg_list_append(&xwl_output->link, &xwl_screen->output_list);" to xwl_output_create? I can't tell if there's a reason it's in xwl_output_done, or if it's just an oversight. On Thu, May 14, 2015 at 9:37 AM, Dima Ryazanov wrote: > Oh wow, I was playing around with ou

Re: [PATCH 3/4] xwayland: Keep a list of wayland globals

2015-05-14 Thread Dima Ryazanov
On Thu, May 14, 2015 at 12:57 AM, Marek Chalupa wrote: > On Tue, May 12, 2015 at 7:21 PM, Dima Ryazanov wrote: > >> The logic is pretty much copied from weston's clients/window.c. >> >> Signed-off-by: Dima Ryazanov >> --- >> hw/xwayland/xwayland.c | 25 - >> hw/xwayland

Re: [PATCH] Revert "glx/dri2: Disable AIGLX if indirect GLX is disabled"

2015-05-14 Thread Michel Dänzer
On 15.05.2015 07:51, Keith Packard wrote: > This reverts commit d61ae18074e53c2cdfb13cc37693b526160d6ca7. > > If the DRI2 provider is disabled, then we don't advertise the correct > GLX extensions to clients, and things like GLES fail. > > Reviewed-by: Eric Anholt Bugzilla: https://bugs.freedes

Re: [PATCH 1/7] render: Inline common FindGlyph case

2015-05-14 Thread Keith Packard
Eric Anholt writes: > Keith Packard writes: > >> Provide the common path for FindGlyph as an inline function, falling >> back to a function for the slow case. > > From the end of your current branch, reverting this commit gives me this > on aa10text: > Difference at 95.0% confidence > 240

Re: glamor: Replace render glyphs acceleration code

2015-05-14 Thread Keith Packard
Keith Packard writes: > [PATCH 3/7] glamor: Pass depth to glamor_pm_is_solid and > [PATCH 4/7] glamor: Remove destination drawable argument from > [PATCH 5/7] glamor: compute GLSL version from > [PATCH 6/7] glamor: Adapt glamor_program API to handle render > [PATCH 7/7] glamor: Replace Comp

Re: [PATCH 1/7] render: Inline common FindGlyph case

2015-05-14 Thread Eric Anholt
Keith Packard writes: > Provide the common path for FindGlyph as an inline function, falling > back to a function for the slow case. From the end of your current branch, reverting this commit gives me this on aa10text: x glamor-new-glyphs + revert +--

[PATCH] Revert "glx/dri2: Disable AIGLX if indirect GLX is disabled"

2015-05-14 Thread Keith Packard
This reverts commit d61ae18074e53c2cdfb13cc37693b526160d6ca7. If the DRI2 provider is disabled, then we don't advertise the correct GLX extensions to clients, and things like GLES fail. Reviewed-by: Eric Anholt --- glx/glxdri2.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/glx/glxdri2.

[PATCH xwayland] xwayland: do not add output into output_list multiple times

2015-05-14 Thread Marek Chalupa
output.done event can be sent even on some property change, not only when announcing the output. Therefore we must check if we already have it otherwise we may corrupt the list by adding it multiple times. This fixes bug when xwayland looped indefinitely in output.done handler and that can be repr

Re: [PATCH 3/4] xwayland: Keep a list of wayland globals

2015-05-14 Thread Marek Chalupa
On Tue, May 12, 2015 at 7:21 PM, Dima Ryazanov wrote: > The logic is pretty much copied from weston's clients/window.c. > > Signed-off-by: Dima Ryazanov > --- > hw/xwayland/xwayland.c | 25 - > hw/xwayland/xwayland.h | 8 > 2 files changed, 32 insertions(+), 1

Re: [PATCH 2/4] xwayland: Remove a useless out-of-memory check

2015-05-14 Thread Marek Chalupa
Checking for negative return value of snprintf is wrong, but snprintf can actually "fail". It can truncate the output. However, since sizeof name is 256 and the length of "XWAYLAND%d" is always shorter that this, it is safe here. Reviewed-by: Marek Chalupa On Tue, May 12, 2015 at 7:21 PM, Dima R