[PATCH] omGeneric: Fix NULL pointer dereferences in set_fontset_extents

2015-07-15 Thread Ismael Luceno
Signed-off-by: Ismael Luceno --- modules/om/generic/omGeneric.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/om/generic/omGeneric.c b/modules/om/generic/omGeneric.c index a835f00..f0861e8 100644 --- a/modules/om/generic/omGeneric.c +++ b/modules/om/generic/omGen

[PATCH] glamor: make current in prepare paths

2015-07-15 Thread Dave Airlie
From: Dave Airlie Lots of the accel paths only make current once they start doing someting, so a lot of them call the bail paths without make current, which means on PRIME systems for example we end up in the wrong context. Add a prepare pixmap in the prepare fallback path. Bugzilla: https://bu

Re: [PATCH] glamor: make current in prepare paths

2015-07-15 Thread Michel Dänzer
On 15.07.2015 16:56, Dave Airlie wrote: > From: Dave Airlie > > Lots of the accel paths only make current once they start > doing someting, so a lot of them call the bail paths without > make current, which means on PRIME systems for example > we end up in the wrong context. > > Add a prepare pi

Re: [PATCH] glamor: make current in prepare paths

2015-07-15 Thread Michel Dänzer
On 15.07.2015 17:06, Michel Dänzer wrote: > On 15.07.2015 16:56, Dave Airlie wrote: >> From: Dave Airlie >> >> Lots of the accel paths only make current once they start >> doing someting, so a lot of them call the bail paths without >> make current, which means on PRIME systems for example >> we e

Re: [PATCH v2 2/3] xwayland: Remove a useless out-of-memory check

2015-07-15 Thread Marek Chalupa
Reviewed-by: Marek Chalupa (http://lists.freedesktop.org/archives/wayland-devel/2015-May/021952.html) On 05/16/2015 07:38 AM, Dima Ryazanov wrote: snprintf does not allocate memory, so we can never get an out-of-memory error. (Also, the error handler would free xwl_output after it was already

Re: [PATCH v2 3/3] xwayland: Destroy xwl_output when wl_output gets removed

2015-07-15 Thread Marek Chalupa
On 05/16/2015 07:38 AM, Dima Ryazanov wrote: This makes Xwayland correctly handle a monitor getting unplugged. Signed-off-by: Dima Ryazanov --- hw/xwayland/xwayland-output.c | 1 + hw/xwayland/xwayland.c| 10 +- hw/xwayland/xwayland.h| 1 + 3 files changed, 11 i

Re: [PATCH xwayland v2] xwayland: do not add output into output_list multiple times

2015-07-15 Thread Marek Chalupa
On 05/21/2015 03:43 PM, Marek Chalupa wrote: output.done event can be sent even on some property change, not only when announcing the output. Therefore we must check if we already have it otherwise we may corrupt the list by adding it multiple times. This fixes bug when xwayland looped indefin

Re: [PATCH v2 3/3] xwayland: Destroy xwl_output when wl_output gets removed

2015-07-15 Thread Marek Chalupa
Hmm, it looks like there's new bug with this patch. I remember it worked pretty well before, but now it is not true anymore. Sometimes, after destroying the output with xterm opened on the other output, the xterm stops reacting on button press event. With xterm opened on both outputs, this does

Re: [PATCH v2 2/3] xwayland: Remove a useless out-of-memory check

2015-07-15 Thread Emil Velikov
Hello gents, On 15 July 2015 at 09:51, Marek Chalupa wrote: > Reviewed-by: Marek Chalupa > > (http://lists.freedesktop.org/archives/wayland-devel/2015-May/021952.html) > > On 05/16/2015 07:38 AM, Dima Ryazanov wrote: >> >> snprintf does not allocate memory, so we can never get an out-of-memory >

Re: [PATCH] omGeneric: Fix NULL pointer dereferences in set_fontset_extents

2015-07-15 Thread Alan Coopersmith
On 07/14/15 09:36 PM, Ismael Luceno wrote: Signed-off-by: Ismael Luceno --- modules/om/generic/omGeneric.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/om/generic/omGeneric.c b/modules/om/generic/omGeneric.c index a835f00..f0861e8 100644 --- a/modules/om/gen

Re: [PATCH] damageext: Make DamageSubtract actually work for raw-rects mode

2015-07-15 Thread Adam Jackson
On Tue, 2015-07-14 at 16:58 -0700, Eric Anholt wrote: > Adam Jackson writes: > > > I swear this has come up before, but I have no idea why this isn't > > implemented. This basically makes the raw mode unusable since you can > > never subtract damage, your only recourse is to destroy the old dama

Re: [PATCH] omGeneric: Fix NULL pointer dereferences in set_fontset_extents

2015-07-15 Thread Ismael Luceno
On Wed, 15 Jul 2015 07:24:59 -0700 Alan Coopersmith wrote: > On 07/14/15 09:36 PM, Ismael Luceno wrote: > > Signed-off-by: Ismael Luceno > > --- > > modules/om/generic/omGeneric.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/modules/om/generic/omGeneric.c

Re: [PATCH v2 2/3] xwayland: Remove a useless out-of-memory check

2015-07-15 Thread Bryce Harrington
On Wed, Jul 15, 2015 at 01:09:03PM +0100, Emil Velikov wrote: > Hello gents, > > On 15 July 2015 at 09:51, Marek Chalupa wrote: > > Reviewed-by: Marek Chalupa > > > > (http://lists.freedesktop.org/archives/wayland-devel/2015-May/021952.html) > > > > On 05/16/2015 07:38 AM, Dima Ryazanov wrote: >

Re: [PATCH v2 2/3] xwayland: Remove a useless out-of-memory check

2015-07-15 Thread Emil Velikov
On 15 July 2015 at 19:11, Bryce Harrington wrote: > On Wed, Jul 15, 2015 at 01:09:03PM +0100, Emil Velikov wrote: >> Hello gents, >> >> On 15 July 2015 at 09:51, Marek Chalupa wrote: >> > Reviewed-by: Marek Chalupa >> > >> > (http://lists.freedesktop.org/archives/wayland-devel/2015-May/021952.ht

Eric is filling in for X server maintainer until 2 August

2015-07-15 Thread Keith Packard
I'm going rafting down the grand canyon for the next two weeks, and Eric has graciously volunteered to manage the care and feeding of the X server master branch while I'm away. I'm leaving my laptop at home -- I think it's probably the first time in close to twenty years that I've been away from

[PATCH] modesetting: Use correct datatypes for return values from glamor_name_from_pixmap and glamor_fd_from_pixmap

2015-07-15 Thread Robert Ancell
glamor_name_from_pixmap and glamor_fd_from_pixmap return CARD16 and CARD32 values via pointers. The current code uses uint16_t and uint32_t which will probably be the same but it's safer to use the datatypes as specified by the function. Signed-off-by: Robert Ancell --- hw/xfree86/drivers/mode