[PATCH keyboard 1/3] Remove empty function xf86KbdUnplug

Signed-off-by: Alexandr Shadchin --- src/kbd.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/kbd.c b/src/kbd.c index 189adca..4db2e0a 100644 --- a/src/kbd.c +++ b/src/kbd.c @@ -452,11 +452,6 @@ PostKbdEvent(InputInfoPtr pInfo, unsigned int scanCode, Bool down)

[PATCH keyboard 2/3] Reorder load module stuff

Signed-off-by: Alexandr Shadchin --- src/kbd.c | 94 ++- 1 file changed, 44 insertions(+), 50 deletions(-) diff --git a/src/kbd.c b/src/kbd.c index 4db2e0a..1ce4ee6 100644 --- a/src/kbd.c +++ b/src/kbd.c @@ -66,24 +66,6 @@ static void P

[PATCH keyboard 3/3] Remove support for X input ABI < 12

Signed-off-by: Alexandr Shadchin --- configure.ac | 2 +- src/kbd.c| 83 ++-- 2 files changed, 14 insertions(+), 71 deletions(-) diff --git a/configure.ac b/configure.ac index 6fd6576..993d5a8 100644 --- a/configure.ac +++ b/configure.

Re: [PATCH xserver 01/20] Remove non-smart scheduler. Don't require setitimer.

Peter Harris writes: > Data point: > > I've got a Dell box (also Ivy Bridge) where calling GetTimeInMillis() > after each request dings noop performance by like 30% because the TSC is > unstable. That's terrible. > That said, this box is an outlier. Every other recent box I can put my > hands o

Re: [PATCH xserver 20/20] mi: Remove miPointerRec from API

Adam Jackson writes: > On Wed, 2015-11-11 at 22:02 -0800, Keith Packard wrote: >> This moves the definition of miPionterRec from mipointrst.h to >                                 > Typo. Fixed. -- -keith signature.asc Description: PGP signature ___

Re: [PATCH xserver 08/20] hw/kdrive: Use NotifyFd interface for kdrive/linux APM monitoring

Adam Jackson writes: > This tripped me up at first (here and elsewhere in the series), it > looks weird to read an fd that isn't the one passed in as an argument. I fixed this one and the kdrive/linux APM one. The other patches either already used the passed-in fd directly, or had some more com

Re: [PATCH v2 0/4] XWayland: Support key focus array correctly

On Fri, Nov 20, 2015 at 03:37:27PM +, Daniel Stone wrote: > Hi, > One year later, a follow-up to: > http://lists.x.org/archives/xorg-devel/2014-November/044627.html > > This aims to support the XWayland equivalent of KeymapNotify correctly, > in particular fixing Alt-Tab. Without this patch, w

Re: [PATCH xserver 12/20] hw/xwayland: Use NotifyFd handler to monitor wayland socket

Keith Packard writes: > Replace the block/wakeup handler with a NotifyFd callback instead. Adam noticed that this patch generated some warnings, which were cleaned up in a later patch. Let's make this one right too. From b8d837f24f23eb0199da1dad8d9f84d1a2d7c631 Mon Sep 17 00:00:00 2001 From: Ke

Re: [PATCH xserver 18/20] Remove readmask from screen block/wakeup handler

Adam Jackson writes: > This is missing hunks for: > > hw/xwin/winwakeup.c > hw/xwin/win.h > hw/xquartz/quartzCocoa.m > hw/xquartz/quartzCommon.h > doc/XInput.xml > doc/Xserver-spec.xml Fixed. > Technically 12/20 from this series introduces a warning until this > patch, possibly others.  'git re

Re: Disabling RECORD by default

Alan Coopersmith writes: > You need to make a similar update to xserver/man/Xserver.man, which > currently says: > > -tstdisables all testing extensions (e.g., XTEST, XTrap, > XTestEx- > tension1, RECORD). Changed to: .TP 8 .B \-tst disables XTEST extension. From

Deliver input events only to window owner

X allows multiple clients to select for keyboard, motion and button release events (button press events generate implicit grabs, and are only selectable by one client). This means that a client receiving an input event has no way of knowing if some other client has received the same event, allowin

Re: Disabling RECORD by default

Emil Velikov writes: > Although TEST being unconditionally set (in configure.ac) we have the > above guard and a second one in include/extinit.h. I take it that > those are just left over from the olden days ? Yes, I think so. -- -keith signature.asc Description: PGP signature __

Re: Disabling RECORD by default

Jeremy Huddleston Sequoia writes: > The XQuartz option was meant mainly for RECORD. I'll followup later > to add a preference option for RECORD in XQuartz. I'm not surprised to hear that; XTEST is quite a bit more useful and less scary. -- -keith signature.asc Description: PGP signature ___

Re: Disabling RECORD by default

On 11/23/15 03:31 PM, Keith Packard wrote: -ErrorF("-tst disable testing extensions\n"); +ErrorF("-tst disable XTEST extension\n"); You need to make a similar update to xserver/man/Xserver.man, which currently says: -tstdisables all testin

Re: Disabling RECORD by default

Hi Keith, On 23 November 2015 at 23:31, Keith Packard wrote: > --- a/mi/miinitext.c > +++ b/mi/miinitext.c > #ifdef XTEST > -{XTestExtensionInit, XTestExtensionName, &noTestExtensions}, > +{XTestExtensionInit, XTestExtensionName, &noXTestExtension}, > #endif Although TEST being uncond

Re: Disabling RECORD by default

Alan Coopersmith writes: > Do we need to actually add specific +record & -record flags instead of just > using the generic +extension RECORD and -extension RECORD flags? Probably not. From 528587382afb002e3efc8638e53fa4db77161307 Mon Sep 17 00:00:00 2001 From: Keith Packard Date: Mon, 23 Nov 2

Re: Disabling RECORD by default

The XQuartz option was meant mainly for RECORD. I'll followup later to add a preference option for RECORD in XQuartz. Reviewed-by: Jeremy Huddleston Sequoia --Jeremy > On Nov 23, 2015, at 18:13, Keith Packard wrote: > > Keith Packard writes: > > Here's a patch, which first splits out the

Re: Disabling RECORD by default

+#ifdef XRECORD +ErrorF("+recordenable RECORD extension\n"); +ErrorF("-recorddisable RECORD extension\n"); +#endif Do we need to actually add specific +record & -record flags instead of just using the generic +extension RECORD and -extension RECORD flags?

Disabling RECORD by default

Keith Packard writes: Here's a patch, which first splits out the command line and config file options for XTEST and RECORD, and then disables RECORD by default but leaves XTEST enabled by default. From 2f1872f518ca7640efc42870800536f8e45c4b23 Mon Sep 17 00:00:00 2001 From: Keith Packard Date: M

Hiding keyboard state

One of the many security holes in X is that any application can monitor the state of the keyboard device by querying the list of pressed keys on a regular basis. Here's a simple patch which makes that request report only key state which the client itself has already seen through X events. With th

Re: [PATCH xwayland 2/2] xwayland: check if creating output succeeded

Hi Marek, - Original Message - > check return values of RR.*Create calls and > check if we added any output > > Signed-off-by: Marek Chalupa > --- > hw/xwayland/xwayland-output.c | 23 +++ > hw/xwayland/xwayland.c| 10 -- > 2 files changed, 31 inserti

Re: [PATCH] [RFC] modesetting: add zaphod support (v2)

27.07.2015 02:43, Dave Airlie пишет: +modesettingEntPtr ms_ent_priv(ScrnInfoPtr scrn) +{ +DevUnion *pPriv; +modesettingPtr ms = modesettingPTR(scrn); +pPriv = xf86GetEntityPrivate(ms->pEnt->index, + ms_entity_index); +return pPriv->ptr; +} @@

Re: [PATCH xwayland 1/2] xwayland: fix memory leak

On 23/11/15 11:18, Marek Chalupa wrote: don't leak memory when realizing window fails Signed-off-by: Marek Chalupa --- hw/xwayland/xwayland.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/xwayland/xwayland.c b/hw/xwayland/xwayland.c index e31becf..56b03f6 100644 --- a/hw/xwayland/xw

Re: [PATCH] randr: return NULL instead of FALSE

> No functional change since FALSE = (0) and NULL = ((void *) 0), > but everywhere else in that function we return NULL > > Signed-off-by: Marek Chalupa > --- > randr/rrcrtc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/randr/rrcrtc.c b/randr/rrcrtc.c > index 9bc456

[PATCH] randr: return NULL instead of FALSE

No functional change since FALSE = (0) and NULL = ((void *) 0), but everywhere else in that function we return NULL Signed-off-by: Marek Chalupa --- randr/rrcrtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/randr/rrcrtc.c b/randr/rrcrtc.c index 9bc456b..c9f9254 100644 --

[PATCH xwayland 2/2] xwayland: check if creating output succeeded

check return values of RR.*Create calls and check if we added any output Signed-off-by: Marek Chalupa --- hw/xwayland/xwayland-output.c | 23 +++ hw/xwayland/xwayland.c| 10 -- 2 files changed, 31 insertions(+), 2 deletions(-) diff --git a/hw/xwayland/xwaylan

[PATCH xwayland 1/2] xwayland: fix memory leak

don't leak memory when realizing window fails Signed-off-by: Marek Chalupa --- hw/xwayland/xwayland.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/xwayland/xwayland.c b/hw/xwayland/xwayland.c index e31becf..56b03f6 100644 --- a/hw/xwayland/xwayland.c +++ b/hw/xwayland/xwayland.c @@ -23

Re: [PATCH v3] xwayland: Update screen size on output removal

Hi, looks good to me and seems working Reviewed-by: Marek Chalupa Cheers, Marek On 11/20/2015 07:05 PM, Olivier Fourdan wrote: When unplugging an output, it's still listed in xrandr and the size of the root window still includes the removed output. The RR output should be destroyed when its

Re: [PATCH v3] xwayland: Do not set root clip when rootless

Hi, the patch works for me Tested-by: Marek Chalupa Cheers, Marek On 11/23/2015 08:51 AM, Olivier Fourdan wrote: Otherwise the server may try to draw onto the root window when closing down, but when running rootless the root window has no storage thus causing a memory corruption. Thanks to

Re: [PATCH xserver] xfree86: fix minor memory leak

Hi, On 22-11-15 23:00, Peter Hutterer wrote: xf86*StrOption returns a strdup Signed-off-by: Peter Hutterer Looks good to me, thanks for fixing the leak I think I introduced :) Reviewed-by: Hans de Goede Regards, Hans --- hw/xfree86/common/xf86Xinput.c | 5 - 1 file changed, 4 i