Re: [PATCH:xserver] Fix uninitialized variable warnings reported by clang. (was Re: [PATCH:xf86-video-ati] Fix uninitialized variable warnings reported by clang.)

2016-01-05 Thread Adam Jackson
On Wed, 2015-12-16 at 08:36 +0100, Thomas Klausner wrote: > On Wed, Dec 16, 2015 at 10:24:39AM +0900, Michel Dänzer wrote: > > Yes, but the xorg_list_for_each_entry macro needs the same > > treatment. > > With that, > > > > Acked-by: Michel Dänzer > > Thanks, new version attached. remote: I: pa

Re: [PATCH:xserver] Fix uninitialized variable warnings reported by clang. (was Re: [PATCH:xf86-video-ati] Fix uninitialized variable warnings reported by clang.)

2016-01-05 Thread Adam Jackson
On Tue, 2016-01-05 at 11:31 -0500, Adam Jackson wrote: > On Wed, 2015-12-16 at 08:36 +0100, Thomas Klausner wrote: > > On Wed, Dec 16, 2015 at 10:24:39AM +0900, Michel Dänzer wrote: > > > Yes, but the xorg_list_for_each_entry macro needs the same > > > treatment. > > > With that, > > > > > > Acked

Re: [PATCH:xserver] Fix uninitialized variable warnings reported by clang. (was Re: [PATCH:xf86-video-ati] Fix uninitialized variable warnings reported by clang.)

2016-01-05 Thread Keith Packard
Adam Jackson writes: > Oops. This turns out to cause a crash on init, I've pushed a revert > until I figure out why. The patch turns one statement into two; presumably that matters somewhere. -- -keith signature.asc Description: PGP signature ___

[PATCH xserver v2] Fix uninitialized variable warnings reported by clang

2016-01-05 Thread Adam Jackson
From: Thomas Klausner v2: Move initializing pos into the first clause of the for statement. We have to keep this macro equivalent to a plain for statement from the user's perspective, otherwise callers need to {} things to keep control flow correct. [ajax] Signed-off-by: Thomas Klausner Acked-b

Re: [PATCH:xserver] modesetting should not reference gbm when it's not defined

2016-01-05 Thread Adam Jackson
On Fri, 2016-01-01 at 18:10 -0800, Alan Coopersmith wrote: > Fixes build errors of: > present.c: In function 'ms_do_pageflip': > present.c:410:17: error: 'drmmode_bo' has no member named 'gbm' >  new_front_bo.gbm = glamor_gbm_bo_from_pixmap(screen, new_front); >  ^ > present.c:4

Re: [PATCH:xserver] Use unique logfile names when starting server with -displayfd

2016-01-05 Thread Adam Jackson
On Fri, 2016-01-01 at 18:11 -0800, Alan Coopersmith wrote: > Fixes https://bugs.freedesktop.org/show_bug.cgi?id=93212 > > Previously all X servers started with -displayfd would overwrite > Xorg.0.log - now a temporary name of Xorg.pid-.log is used > until after -displayfd finds an open display - t

Re: [PATCH:libX11 1/7] Use strdup instead of Xmalloc+strcpy in _XDefaultOpenIM

2016-01-05 Thread Adam Jackson
On Fri, 2016-01-01 at 18:14 -0800, Alan Coopersmith wrote: > Signed-off-by: Alan Coopersmith Series is: Reviewed-by: Adam Jackson - ajax ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://list

Re: [PATCH] xf86-video-intel: segfault

2016-01-05 Thread Henrik /KaarPoSoft
On 04-01-2016 17:45, Henrik /KaarPoSoft wrote: On 04-01-2016 05:45, Michel Dänzer wrote: On 29.12.2015 01:39, Henrik /KaarPoSoft wrote: [...] I have fixed most of the warnings with this patch: http://sourceforge.net/p/kaarpux/code/ci/master/tree/master/packages/x/xf86-video-intel.files/kaarpux

[PATCH xdm] Missed on arc4random() conversion.

2016-01-05 Thread Matthieu Herrb
Signed-off-by: Matthieu Herrb --- xdm/genauth.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git xdm/genauth.c xdm/genauth.c index 5db7315..f50be3b 100644 --- xdm/genauth.c +++ xdm/genauth.c @@ -408,15 +408,20 @@ GenerateAuthData (char *auth, int len) static int

[PATCH v2 3/8] randr: Add ability to turn PRIME sync off

2016-01-05 Thread Alex Goins
Adds an output parameter to disable PRIME synchronization. Output parameter is created when the user calls 'xrandr --setprovideroutputsource ' to prevent polluting output parameters of non-PRIME configurations. Defaults to on, so if the user wants PRIME synchronization they don't need to do anyt

[PATCH v2 4/8] randr: Cleanup rrSetupPixmapSharing()

2016-01-05 Thread Alex Goins
protopix is completely redundant with mscreenpix. Get rid of it. We don't need rrScrPriv, so remove it. v1: Initial commit v2: Unchanged Signed-off-by: Alex Goins --- randr/rrcrtc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/randr/rrcrtc.c b/randr/rrcrtc.c index 32a17e8..a4bc65d 1006

[PATCH v2 7/8] modesetting: Fix mmap leak in scanout_pixmap_cpu

2016-01-05 Thread Alex Goins
drmmode_set_scanout_pixmap_cpu() uses drmmode_map_slave_bo(), which maps a dumb bo. However, when cleaning up scanout pixmaps, it never destroys it, leading to a leak of mapped memory. With enough modesets, this can result in an insane amount of memory being mapped. Add dumb_bo_destroy() of the bac

[PATCH v2 6/8] modesetting: Implement PRIME syncing as a sink

2016-01-05 Thread Alex Goins
Implements (Enable/Disable)SharedPixmapFlipping, the sink functions for PRIME synchronization and double buffering. Allows modesetting driver to be used as a sink with PRIME synchronization. driver.c: Add plumbing for (Enable/Disable)SharedPixmapFlipping and SharedPixmapNotifyDamage. drmm

[PATCH v2 0/8] PRIME Synchronization

2016-01-05 Thread Alex Goins
Hello all, These patches change the xserver to support setting up PRIME with double buffering, and implement double buffered PRIME sink support in the modesetting driver. In addition to these changes, I've upstreamed a couple of patches to the i915 DRM driver that mesh with these, and have impleme

[PATCH v2 5/8] modesetting: Properly clean up w/ PRIME syncing

2016-01-05 Thread Alex Goins
With PRIME synchronization, there is a second scanout buffer, scanout_pixmap_back, that needs to be cleaned up when destroying scanout pixmaps. PRIME synchronization currently shouldn't apply to reverse PRIME, so only apply to scanout_pixmap_cpu(). v1: Initial commit v2: Unchanged Signed-off-by:

[PATCH v2 8/8] modesetting: Suspend and resume flipping with DPMS

2016-01-05 Thread Alex Goins
DPMS would prevent page flip / vblank events from being raised, freezing the screen until PRIME flipping was reinitialized. To handle DPMS cleanly, suspend PRIME page flipping when DPMS mode is not on, and resume it when DPMS mode is on. v1: Initial commit v2: Moved flipping_active check from prev

[PATCH v2 1/8] xf86: Add PRIME flipping functions to ScreenRec

2016-01-05 Thread Alex Goins
Adds typdefs for (*StartFlippingPixmapTrackingProcPtr), (*PresentSharedPixmapProcPtr), (*SharedPixmapNotifyDamageProcPtr), (*RequestSharedPixmapNotifyDamageProcPtr), (*StopFlippingPixmapTrackingProcPtr), (*EnableSharedPixmapFlippingProcPtr), and (*DisableSharedPixmapFlippingProcPtr). Adds (Enable/

[PATCH v2 2/8] randr/xf86: Add PRIME Synchronization / Double Buffer

2016-01-05 Thread Alex Goins
Changes PRIME to use double buffering and synchronization if all required driver functions are available. rrcrtc.c: Changes rrSetupPixmapSharing() to use double buffering and synchronization in the case that all required driver functions are available. Otherwise, falls back to unsynchr

Re: [PATCH xdm] Missed on arc4random() conversion.

2016-01-05 Thread Alan Coopersmith
On 01/ 5/16 12:34 PM, Matthieu Herrb wrote: Signed-off-by: Matthieu Herrb --- xdm/genauth.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git xdm/genauth.c xdm/genauth.c index 5db7315..f50be3b 100644 --- xdm/genauth.c +++ xdm/genauth.c @@ -408,15 +408,20 @@ GenerateAu

[PATCH:xorg-sgml-doctools] Set generate.consistent.ids in xsl stylesheets for more repeatable builds

2016-01-05 Thread Alan Coopersmith
Causes auto-generation of id attributes to use values based on position in document, such as id="id-1.5.9.5.2", instead of based on memory address of parse tree, such as id="idm140664351287904", so that generated documents end up with the same contents across rebuilds & platforms (especially on pla

Re: Use hardware sprite plane as overlay

2016-01-05 Thread Michel Dänzer
On 30.12.2015 04:52, Jasper St. Pierre wrote: > The only currently supported mechanism for using hardware overlays is > video planes through VDPAU / VA-API. And XVideo? -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast |

Re: Use hardware sprite plane as overlay

2016-01-05 Thread Jasper St. Pierre
I thought XV was simply about color conversion, it didn't handle video display. I didn't Google it before replying, though. On Tue, Jan 5, 2016 at 6:23 PM, Michel Dänzer wrote: > On 30.12.2015 04:52, Jasper St. Pierre wrote: >> The only currently supported mechanism for using hardware overlays is

Re: [PATCH xserver v2] Fix uninitialized variable warnings reported by clang

2016-01-05 Thread Thomas Klausner
Hello Adam! > If it's not too much trouble, please use git-send-email --in-reply-to > for followup patches like this. Thanks, I didn't know about this. I'll use it in the future. And thanks for the macro fix, it looks good to me. Thomas On Tue, Jan 05, 2016 at 12:51:41PM -0500, Adam Jackson wro

Re: xserver: Branch 'master'

2016-01-05 Thread Michel Dänzer
On 06.01.2016 04:51, Adam Jackson wrote: > > commit edcb6426f20c3be5dd5f50b76a686754aef2f64e > Author: Alan Coopersmith > Date: Fri Jan 1 18:11:14 2016 -0800 > > Use unique logfile names when starting server with -displayfd This change broke make check for me, specifically the signal-logg

Re: [PATCH xdm] Missed on arc4random() conversion.

2016-01-05 Thread Matthieu Herrb
On Tue, Jan 05, 2016 at 02:49:44PM -0800, Alan Coopersmith wrote: > On 01/ 5/16 12:34 PM, Matthieu Herrb wrote: > >Signed-off-by: Matthieu Herrb > >--- > > xdm/genauth.c | 9 +++-- > > 1 file changed, 7 insertions(+), 2 deletions(-) > > > >diff --git xdm/genauth.c xdm/genauth.c > >index 5db73