Re: [PATCH xserver 2/3] present: Factor code for restoring screen pixmap out of present_unflip (v2)

2016-02-25 Thread Keith Packard
Michel Dänzer writes: > On 22.02.2016 18:16, Michel Dänzer wrote: >> From: Michel Dänzer >> >> The following fix will use the refactored function. >> >> The logic in the refactored function is slightly simplified, exploiting >> the fact that this function is only ever called with a valid flip

Re: [PATCH xserver 2/3] present: Factor code for restoring screen pixmap out of present_unflip (v2)

2016-02-25 Thread Michel Dänzer
On 22.02.2016 18:16, Michel Dänzer wrote: > From: Michel Dänzer > > The following fix will use the refactored function. > > The logic in the refactored function is slightly simplified, exploiting > the fact that this function is only ever called with a valid flip > pixmap. > > v2: Assert that f

Re: New composers for local languages in Togo

2016-02-25 Thread Mats Blakstad
Hei again Could anyone please explain me how I can flush my composer after I've made changes to it locally? Thanks in advance 2016-02-17 0:22 GMT+01:00 Mats Blakstad : > Thanks again, I've uploaded a new patch now. > > I need it to work on Ubuntu 14.04 - I guess that is a GTK application? > > I

[PATCH kdrive/ephyr v3] kdrive/ephyr: map host X server's keymap into Xephyr, if supported

2016-02-25 Thread Laércio de Sousa
Currently Xephyr doesn't inherit host X server's keymap, which may lead to keymap mismatches when using a non-US keyboard in a window inside Xephyr. This patch makes Xephyr change its keymap to match host X server's one (unless XKB support is disabled), using xcb-xkb to retrieve the needed XKB cont

Re: [PATCH kdrive/ephyr v2] kdrive/ephyr: map host X server's keymap into Xephyr, if supported

2016-02-25 Thread Laércio de Sousa
2016-02-25 16:07 GMT-03:00 Adam Jackson : > @ -1291,16 +1290,35 @@ KdPointerDriver EphyrMouseDriver = { > > static Status > > EphyrKeyboardInit(KdKeyboardInfo * ki) > > { > > +int i; > > Unused variable. > Removed. Thanks! > +if (!keySyms.minKeyCode) { > > ErrorF("Couldn't lo

Re: [PATCH kdrive/ephyr v2] kdrive/ephyr: map host X server's keymap into Xephyr, if supported

2016-02-25 Thread Adam Jackson
On Thu, 2016-02-25 at 07:10 -0300, Laércio de Sousa wrote: > diff --git a/hw/kdrive/ephyr/ephyr.c b/hw/kdrive/ephyr/ephyr.c > index a272882..fa76765 100644 > --- a/hw/kdrive/ephyr/ephyr.c > +++ b/hw/kdrive/ephyr/ephyr.c > @@ -47,7 +47,6 @@ extern Bool ephyr_glamor; >   >  KdKeyboardInfo *ephyrKbd;

Re: [PATCH xserver 3/3] present: Only requeue if target MSC is not reached after an unflip

2016-02-25 Thread Adam Jackson
On Thu, 2016-02-25 at 09:49 +, Chris Wilson wrote: > On Wed, Feb 24, 2016 at 04:52:59PM +0900, Michel Dänzer wrote: > > From: Michel Dänzer > > > > While present_pixmap decrements target_msc by 1 for present_queue_vblank, > > it leaves the original vblank->target_msc intact. So incrementing t

Re: [PATCH kdrive/ephyr] kdrive/ephyr: map host X server's keymap into Xephyr, if supported

2016-02-25 Thread Laércio de Sousa
2016-02-23 17:16 GMT-03:00 Ran Benita : > So the sentence "If host X server supports XKB extension, this patch > uses xcb-xkb to apply its keymap in Xephyr." should be adjusted to only > talk about XKB controls and not the entire keymap, I think. > What about this? "This patch makes Xephyr chang

[PATCH kdrive/ephyr] kdrive/ephyr: map host X server's keymap into Xephyr, if supported

2016-02-25 Thread Laércio de Sousa
Currently Xephyr doesn't inherit host X server's keymap, which may lead to keymap mismatches when typing in a window inside Xephyr. This patch makes Xephyr change its keymap to match host X server's one (unless XKB support is disabled), using xcb-xkb to retrieve the needed XKB controls. This implem

[PATCH kdrive/ephyr v2] kdrive/ephyr: map host X server's keymap into Xephyr, if supported

2016-02-25 Thread Laércio de Sousa
Currently Xephyr doesn't inherit host X server's keymap, which may lead to keymap mismatches when typing in a window inside Xephyr. This patch makes Xephyr change its keymap to match host X server's one (unless XKB support is disabled), using xcb-xkb to retrieve the needed XKB controls. This implem

Re: [PATCH xserver 1/3] present: Move msc_is_(equal_or_)after to the top of present.c

2016-02-25 Thread Chris Wilson
On Wed, Feb 24, 2016 at 04:52:57PM +0900, Michel Dänzer wrote: > From: Michel Dänzer > > To make them usable from any other function in the file. No functional > change. > > Signed-off-by: Michel Dänzer Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre ___

Re: [PATCH xserver 2/3] present: Requeue if flip driver hook fails and target MSC not reached

2016-02-25 Thread Chris Wilson
On Wed, Feb 24, 2016 at 04:52:58PM +0900, Michel Dänzer wrote: > From: Michel Dänzer > > For flipping, we wait for the MSC before the target MSC and then call > the driver flip hook. If the latter fails, we have to wait for the > target MSC before falling back to a copy, or else it's executed too

Re: [PATCH xserver 3/3] present: Only requeue if target MSC is not reached after an unflip

2016-02-25 Thread Chris Wilson
On Wed, Feb 24, 2016 at 04:52:59PM +0900, Michel Dänzer wrote: > From: Michel Dänzer > > While present_pixmap decrements target_msc by 1 for present_queue_vblank, > it leaves the original vblank->target_msc intact. So incrementing the > latter for requeueing resulted in the requeued presentation

[PATCH xserver 2/3] present: Requeue if flip driver hook fails and target MSC not reached

2016-02-25 Thread Michel Dänzer
From: Michel Dänzer For flipping, we wait for the MSC before the target MSC and then call the driver flip hook. If the latter fails, we have to wait for the target MSC before falling back to a copy, or else it's executed too early. Fixes glxgears running at unbounded framerate (not synchronized

[PATCH xserver 3/3] present: Only requeue if target MSC is not reached after an unflip

2016-02-25 Thread Michel Dänzer
From: Michel Dänzer While present_pixmap decrements target_msc by 1 for present_queue_vblank, it leaves the original vblank->target_msc intact. So incrementing the latter for requeueing resulted in the requeued presentation being executed too late. Also, no need to requeue if the target MSC is a

[PATCH xserver 1/3] present: Move msc_is_(equal_or_)after to the top of present.c

2016-02-25 Thread Michel Dänzer
From: Michel Dänzer To make them usable from any other function in the file. No functional change. Signed-off-by: Michel Dänzer --- present/present.c | 44 ++-- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/present/present.c b/present/p